zhijiangW commented on a change in pull request #8804:
[FLINK-12883][WIP][runtime] Add elaborated partition release logic
URL: https://github.com/apache/flink/pull/8804#discussion_r297025720
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -353,6 +354,10 @@ public InputDependencyConstraint
getInputDependencyConstraint() {
return getJobVertex().getInputDependencyConstraint();
}
+ public ExecutionVertexID getID() {
Review comment:
It seems more proper to construct the `ExecutionVertexID` in the constructor
only once, then all the other usages could get it directly. And
`DefaultFailoverTopology` does not need to create `ExecutionVertexID` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
