zhijiangW commented on a change in pull request #8804:
[FLINK-12883][WIP][runtime] Add elaborated partition release logic
URL: https://github.com/apache/flink/pull/8804#discussion_r297027480
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -247,6 +256,12 @@
/** The total number of vertices currently in the execution graph. */
private int numVerticesTotal;
+ private final PartitionReleaseStrategy.Factory
partitionReleaseStrategyFactory;
+
+ private PartitionReleaseStrategy partitionReleaseStrategy;
+
+ private SchedulingTopology schedulingTopology;
Review comment:
How about initializing `schedulingTopology` and `partitionReleaseStrategy`
in the constructor, then we could make them final, and no need to maintain
class-level `partitionReleaseStrategyFactory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
