[GitHub] [flink] JingsongLi commented on issue #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
JingsongLi commented on issue #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#issuecomment-500713151 LGTM +1 after travis green. --

[GitHub] [flink] JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292300596 ## File path: flink-table/flink-table-planner-blink/src/main/scala/or

[GitHub] [flink] JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292300596 ## File path: flink-table/flink-table-planner-blink/src/main/scala/or

[GitHub] [flink] sunjincheng121 commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-10 Thread GitBox
sunjincheng121 commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-500711150 Thanks for the update @dianfu! Currently, the PR looks pretty clean form my side. only one impro

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292298235 ## File path: flink-ml-parent/flink-ml-api/src/main/java/org/apache/flink/ml/api/misc/param/Params.java #

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292297910 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/a

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

2019-06-10 Thread GitBox
sunjincheng121 commented on a change in pull request #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#discussion_r292295720 ## File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonito

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292295619 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/a

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292290228 ## File path: flink-ml-parent/flink-ml/src/main/java/org/apache/flink/ml/params/dataproc/HasFraction.java ###

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292293350 ## File path: flink-ml-parent/pom.xml ## @@ -35,5 +35,6 @@ under the License.

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292292397 ## File path: flink-ml-parent/flink-ml/src/main/java/org/apache/flink/ml/params/statistics/SummarizerParams.ja

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292291689 ## File path: flink-ml-parent/flink-ml/pom.xml ## @@ -0,0 +1,96 @@ + + +http://maven.apache.org/POM/4

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292290647 ## File path: flink-ml-parent/flink-ml/src/main/java/org/apache/flink/ml/params/dataproc/HasFraction.java ###

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292291521 ## File path: flink-ml-parent/flink-ml/pom.xml ## @@ -0,0 +1,96 @@ + + +http://maven.apache.org/POM/4

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292285461 ## File path: flink-ml-parent/flink-ml/src/main/java/org/apache/flink/ml/params/BaseWithParam.java ##

[GitHub] [flink] c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292289854 ## File path: flink-ml-parent/flink-ml/pom.xml ## @@ -0,0 +1,96 @@ + + +http://maven.apache.org/POM/4

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292295619 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/a

[GitHub] [flink] JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292295166 ## File path: flink-table/flink-table-planner-blink/src/main/scala/or

[GitHub] [flink] JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292294961 ## File path: flink-table/flink-table-planner-blink/src/main/scala/or

[GitHub] [flink] flinkbot commented on issue #8684: [FLINK-12790] Implement KeyScope enum to distinguish the key of localKeyBy and general keyBy API

2019-06-10 Thread GitBox
flinkbot commented on issue #8684: [FLINK-12790] Implement KeyScope enum to distinguish the key of localKeyBy and general keyBy API URL: https://github.com/apache/flink/pull/8684#issuecomment-500704262 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I hel

[jira] [Updated] (FLINK-12790) Implement KeyScope enum to distinguish the key of localKeyBy and general keyBy API

2019-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12790: --- Labels: pull-request-available (was: ) > Implement KeyScope enum to distinguish the key of

[GitHub] [flink] yanghua opened a new pull request #8684: [FLINK-12790] Implement KeyScope enum to distinguish the key of localKeyBy and general keyBy API

2019-06-10 Thread GitBox
yanghua opened a new pull request #8684: [FLINK-12790] Implement KeyScope enum to distinguish the key of localKeyBy and general keyBy API URL: https://github.com/apache/flink/pull/8684 ## What is the purpose of the change *This pull request implements KeyScope enum to distinguish the

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292290064 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292290042 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292290086 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] flinkbot commented on issue #8683: [FLINK-12797][table] Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread GitBox
flinkbot commented on issue #8683: [FLINK-12797][table] Remove duplicate tests in GroupWindowTableAggregateValidationTest URL: https://github.com/apache/flink/pull/8683#issuecomment-500700213 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the comm

[GitHub] [flink] hequn8128 opened a new pull request #8683: [FLINK-12797][table] Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread GitBox
hequn8128 opened a new pull request #8683: [FLINK-12797][table] Remove duplicate tests in GroupWindowTableAggregateValidationTest URL: https://github.com/apache/flink/pull/8683 ## What is the purpose of the change This pull request remove duplicate tests in `GroupWindowTableAggr

[jira] [Updated] (FLINK-12797) Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12797: --- Labels: pull-request-available (was: ) > Remove duplicate tests in GroupWindowTableAggregat

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292288623 ## File path: flink-table/flink-table-planner-blink/src/ma

[GitHub] [flink] JingsongLi commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
JingsongLi commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292285209 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] godfreyhe commented on a change in pull request #8677: [FLINK-12795] [table-planner-blink] Extracted creation & configuration of FrameworkConfig & RelBuilder to separate class in blin

2019-06-10 Thread GitBox
godfreyhe commented on a change in pull request #8677: [FLINK-12795] [table-planner-blink] Extracted creation & configuration of FrameworkConfig & RelBuilder to separate class in blink planner URL: https://github.com/apache/flink/pull/8677#discussion_r292284191 ## File path: flink

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292283695 ## File path: flink-table/flink-table-common/src/main/java/org/apache/fl

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292283695 ## File path: flink-table/flink-table-common/src/main/java/org/apache/fl

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292283695 ## File path: flink-table/flink-table-common/src/main/java/org/apache/fl

[jira] [Updated] (FLINK-12797) Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-12797: Environment: (was: Some tests in \{{GroupWindowTableAggregateValidationTest}} are duplicate wi

[jira] [Updated] (FLINK-12797) Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-12797: Description: Some tests in {{GroupWindowTableAggregateValidationTest}} are duplicate with tests in

[jira] [Created] (FLINK-12797) Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-12797: --- Summary: Remove duplicate tests in GroupWindowTableAggregateValidationTest Key: FLINK-12797 URL: https://issues.apache.org/jira/browse/FLINK-12797 Project: Flink

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

2019-06-10 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860537#comment-16860537 ] vinoyang commented on FLINK-12662: -- Hi [~till.rohrmann] After getting your idea, I'd li

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292272829 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[jira] [Commented] (FLINK-11947) Support MapState value schema evolution for RocksDB

2019-06-10 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860524#comment-16860524 ] Congxian Qiu(klion26) commented on FLINK-11947: --- [~cre...@gmail.com] thank

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292272092 ## File path: flink-table/flink-table-common/src/main/java/org/apache/

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292272092 ## File path: flink-table/flink-table-common/src/main/java/org/apache/

[GitHub] [flink] zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292271629 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failov

[GitHub] [flink] zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292271205 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failov

[GitHub] [flink] zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292271395 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failov

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292271428 ## File path: flink-table/flink-table-planner-blink/src/ma

[GitHub] [flink] wuchong commented on issue #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on issue #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#issuecomment-500679727 @JingsongLi thanks for the reviewing. I have addressed the comments. ---

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292271043 ## File path: flink-table/flink-table-planner-blink/src/ma

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292271043 ## File path: flink-table/flink-table-planner-blink/src/ma

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292270945 ## File path: flink-table/flink-table-planner-blink/src/ma

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292270760 ## File path: flink-table/flink-table-runtime-blink/src/ma

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292270764 ## File path: flink-table/flink-table-runtime-blink/src/ma

[jira] [Updated] (FLINK-12788) Add support to run a Python job-specific cluster on Kubernetes

2019-06-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-12788: Labels: pull-request-available (was: ) > Add support to run a Python job-specific cluster on Kubernetes >

[GitHub] [flink] sunjincheng121 commented on issue #8664: [FLINK-12779][table] Avoid field conflicts when generate field names for non-composite Typeinformation

2019-06-10 Thread GitBox
sunjincheng121 commented on issue #8664: [FLINK-12779][table] Avoid field conflicts when generate field names for non-composite Typeinformation URL: https://github.com/apache/flink/pull/8664#issuecomment-500674980 @flinkbot approve description --

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292266500 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] sunjincheng121 commented on issue #8653: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers are recycled when FlinkKafk…

2019-06-10 Thread GitBox
sunjincheng121 commented on issue #8653: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers are recycled when FlinkKafk… URL: https://github.com/apache/flink/pull/8653#issuecomment-500673647 @flinkbot attention @pnowojski ---

[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-10 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-500671784 @tillrohrmann @sunjincheng121 I have updated the PR and the changes are only related to the build script for P

[GitHub] [flink] wuchong commented on issue #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on issue #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#issuecomment-500671448 Comments addressed and conflicts solved. -

[GitHub] [flink] c4emmmm commented on issue #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on issue #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#issuecomment-500671277 @bowenli86 @walterddr @Xpray @wuchong @zentol @shaoxuan-wang @ex00 @sunjincheng121 @bluelinsky I appreciate for your advices while re

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292264208 ## File path: flink-table/flink-table-common/src/main/java/org/apache/fl

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292263983 ## File path: flink-table/flink-table-common/src/main/java/org/apache/fl

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

2019-06-10 Thread GitBox
dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-500670192 @sunjincheng121 Have updated the PR according to your comments. Looking forwarding to your feedback.

[GitHub] [flink] asfgit closed pull request #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs

2019-06-10 Thread GitBox
asfgit closed pull request #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs URL: https://github.com/apache/flink/pull/8671 This is an automated message from the Apache Git Service. To respond to the me

[jira] [Closed] (FLINK-12787) Allow to specify directory in option -pyfs

2019-06-10 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12787. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: 74ef63672629e0498fb65c5ca91e378f36eb1

[GitHub] [flink] flinkbot commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread GitBox
flinkbot commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#issuecomment-500669024 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkb

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292262188 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292262305 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292262315 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[jira] [Updated] (FLINK-12796) Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12796: --- Labels: pull-request-available (was: ) > Introduce BaseArray and BaseMap to reduce conversi

[GitHub] [flink] JingsongLi opened a new pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread GitBox
JingsongLi opened a new pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682 ## What is the purpose of the change Currently, in internal data format of flink, the a

[jira] [Closed] (FLINK-12640) mvn install flink-shaded-hadoop2-uber: Error creating shaded jar: null

2019-06-10 Thread xiezhiqiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiezhiqiang closed FLINK-12640. --- Resolution: Abandoned Release Note: env issue > mvn install flink-shaded-hadoop2-uber: Erro

[jira] [Commented] (FLINK-12640) mvn install flink-shaded-hadoop2-uber: Error creating shaded jar: null

2019-06-10 Thread xiezhiqiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860495#comment-16860495 ] xiezhiqiang commented on FLINK-12640: - now build is ok ,i'll closed it > mvn instal

[GitHub] [flink] sunjincheng121 commented on issue #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs

2019-06-10 Thread GitBox
sunjincheng121 commented on issue #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs URL: https://github.com/apache/flink/pull/8671#issuecomment-500667684 @flinkbot approve all Merging... This is an au

[GitHub] [flink] c4emmmm commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml

2019-06-10 Thread GitBox
c4e commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml URL: https://github.com/apache/flink/pull/8526#issuecomment-500667561 > We have to update the documentation somehow. Either remove it entirely, blank it if you want to re-use the pages later on,

[jira] [Created] (FLINK-12796) Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12796: Summary: Introduce BaseArray and BaseMap to reduce conversion overhead to blink Key: FLINK-12796 URL: https://issues.apache.org/jira/browse/FLINK-12796 Project: Flink

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292256584 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlMa

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292257458 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292257986 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292255956 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/Exten

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292255627 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292257584 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292256767 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox
zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r292259702 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Tas

[GitHub] [flink] zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox
zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r292258862 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/Nett

[jira] [Comment Edited] (FLINK-12785) RocksDB savepoint recovery can use a lot of unmanaged memory

2019-06-10 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860481#comment-16860481 ] Congxian Qiu(klion26) edited comment on FLINK-12785 at 6/11/19 2:34 AM: --

[jira] [Commented] (FLINK-12785) RocksDB savepoint recovery can use a lot of unmanaged memory

2019-06-10 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860481#comment-16860481 ] Congxian Qiu(klion26) commented on FLINK-12785: --- I think your analysis is

[GitHub] [flink] zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox
zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r292257121 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Tas

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292252350 ## File path: flink-table/flink-table-common/src/main/java/org/apache/

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292251830 ## File path: flink-table/flink-table-common/src/main/java/org/apache/

[GitHub] [flink] flinkbot commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-10 Thread GitBox
flinkbot commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#issuecomment-500653848 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community t

[jira] [Updated] (FLINK-12585) Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12585: --- Labels: pull-request-available (was: ) > Align Stream/BatchTableEnvironment with JAVA Table

[GitHub] [flink] WeiZhong94 opened a new pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-10 Thread GitBox
WeiZhong94 opened a new pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681 ## What is the purpose of the change This pull request add `StreamExecutionEnvironment` and `ExecutionEnvironment`

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292245668 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlMa

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292248207 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292247958 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292248666 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292249000 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/validate/

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292245572 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/Exten

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292249140 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292248144 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichS

  1   2   3   >