zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r292257121
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -359,21 +360,13 @@ public Task(
final String taskNameWithSubtaskAndId = taskNameWithSubtask + "
(" + executionId + ')';
- // add metrics for buffers
- final MetricGroup buffersGroup =
metrics.getIOMetricGroup().addGroup("buffers");
-
- // similar to MetricUtils.instantiateNetworkMetrics() but
inside this IOMetricGroup
- final MetricGroup networkGroup =
metrics.getIOMetricGroup().addGroup("Network");
- final MetricGroup outputGroup = networkGroup.addGroup("Output");
- final MetricGroup inputGroup = networkGroup.addGroup("Input");
+ ShuffleIOOwnerContext taskShuffleContext = shuffleEnvironment
+ .createShuffleIOOwnerContext(taskNameWithSubtaskAndId,
executionId, metrics.getIOMetricGroup());
// produced intermediate result partitions
final ResultPartitionWriter[] resultPartitionWriters =
shuffleEnvironment.createResultPartitionWriters(
Review comment:
But the vars of `taskShuffleContext` and following `gates` are not defined
as final. ATM only `taskNameWithSubtaskAndId` and `resultPartitionWriters` are
final. Or we could make the new added `taskShuffleContext` as final to keep
consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
