sunjincheng121 commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-500711150 Thanks for the update @dianfu! Currently, the PR looks pretty clean form my side. only one improvement I am not pretty sure that is build command option `--opt-jars`. this way the opt jar does not need upload. but without this option, the user can build a fat jar with option jars. So this change is an improvement(not necessary change) So we may need some opinion from @tillrohrmann! Otherwise the PR LGTM. I'll merge it when @tillrohrmann says ok! Best, Jincheng
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
