c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r292290228
########## File path: flink-ml-parent/flink-ml/src/main/java/org/apache/flink/ml/params/dataproc/HasFraction.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.params.dataproc; + +import org.apache.flink.ml.api.misc.param.ParamInfo; +import org.apache.flink.ml.api.misc.param.ParamInfoFactory; +import org.apache.flink.ml.params.BaseWithParam; +import org.apache.flink.ml.params.validators.RangeValidator; + +/** + * Proportion of data allocated to left output after splitting. + */ +public interface HasFraction<T> extends BaseWithParam <T> { + ParamInfo <Double> FRACTION = ParamInfoFactory + .createParamInfo("fraction", Double.class) + .setDescription("Proportion of data allocated to left output after splitting") + .setRequired() + .setValidator(new RangeValidator <>(0.0, 1.0)) + .build(); + + default Double getFraction() { Review comment: It's better to use double rather than boxed Double as return type unless you assume a null value is valid, especially the param has already be defined as required, which means there will be null value only if the value is set by users manually. When do you think the value will be null? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
