[jira] [Commented] (FLINK-11616) Flink official document has an error

2019-02-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771673#comment-16771673 ] vinoyang commented on FLINK-11616: -- [~linjie]  I don't recommend starting this issue un

[jira] [Assigned] (FLINK-11616) Flink official document has an error

2019-02-18 Thread xulinjie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xulinjie reassigned FLINK-11616: Assignee: xulinjie (was: TANG Wen-hui) > Flink official document has an error >

[GitHub] flinkbot commented on issue #7748: [hotfix] fix some typos

2019-02-18 Thread GitBox
flinkbot commented on issue #7748: [hotfix] fix some typos URL: https://github.com/apache/flink/pull/7748#issuecomment-465015151 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment t

[GitHub] leesf opened a new pull request #7748: [hotfix] fix some typos

2019-02-18 Thread GitBox
leesf opened a new pull request #7748: [hotfix] fix some typos URL: https://github.com/apache/flink/pull/7748 ## What is the purpose of the change Fix some typos. ## Brief change log Fix some typos. ## Does this pull request potentially affect one of t

[jira] [Updated] (FLINK-11655) runnable field should be transient in RunAsync from RPC messages

2019-02-18 Thread Benchao Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-11655: --- Description: RunAsync > runnable field should be transient in RunAsync from RPC messages > -

[GitHub] carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257912554 ## File path: flink-state-backends/flink-stateb

[jira] [Updated] (FLINK-11655) runnable field should be transient in RunAsync from RPC messages

2019-02-18 Thread Benchao Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-11655: --- Description: The `runnable` in `RunAsync` should only be called locally. Like `CallAsync`, the fiel

[jira] [Assigned] (FLINK-11616) Flink official document has an error

2019-02-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11616: Assignee: TANG Wen-hui (was: vinoyang) > Flink official document has an error >

[GitHub] carp84 removed a comment on issue #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 removed a comment on issue #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#issuecomment-464794119 Got to leave the office now, will try to fix other review comments

[GitHub] carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257909986 ## File path: flink-state-backends/flink-stateb

[GitHub] carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257909432 ## File path: flink-state-backends/flink-stateb

[GitHub] sunjincheng121 commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-18 Thread GitBox
sunjincheng121 commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#discussion_r257908644 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/expre

[jira] [Comment Edited] (FLINK-11454) Support MergedStream operation

2019-02-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771583#comment-16771583 ] Jark Wu edited comment on FLINK-11454 at 2/19/19 6:28 AM: -- Hi [

[GitHub] alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-02-18 Thread GitBox
alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r257903161 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/

[jira] [Commented] (FLINK-11616) Flink official document has an error

2019-02-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771603#comment-16771603 ] vinoyang commented on FLINK-11616: -- [~fhueske]  Can we try to fix this incoherent "orde

[jira] [Assigned] (FLINK-11616) Flink official document has an error

2019-02-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11616: Assignee: vinoyang (was: xulinjie) > Flink official document has an error >

[jira] [Commented] (FLINK-6227) Introduce the DataConsumptionException for downstream task failure

2019-02-18 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771597#comment-16771597 ] zhijiang commented on FLINK-6227: - [~Salatich], I have not worked on it yet.  And I think

[jira] [Assigned] (FLINK-6227) Introduce the DataConsumptionException for downstream task failure

2019-02-18 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang reassigned FLINK-6227: --- Assignee: (was: zhijiang) > Introduce the DataConsumptionException for downstream task failure >

[jira] [Commented] (FLINK-11454) Support MergedStream operation

2019-02-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771583#comment-16771583 ] Jark Wu commented on FLINK-11454: - Hi [~walterddr], I think the main problem of moving O

[jira] [Commented] (FLINK-11616) Flink official document has an error

2019-02-18 Thread xulinjie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771549#comment-16771549 ] xulinjie commented on FLINK-11616: -- vinoyang  so I can't fix it. > Flink official docu

[jira] [Closed] (FLINK-11640) Caused by: java.lang.IllegalStateException: No operators defined in streaming topology. Cannot execute.

2019-02-18 Thread thinktothings (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] thinktothings closed FLINK-11640. - Resolution: Fixed Fix Version/s: 1.7.1 Release Note: Thank you very much, I understa

[GitHub] sjwiesman commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o…

2019-02-18 Thread GitBox
sjwiesman commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o… URL: https://github.com/apache/flink/pull/7747#discussion_r257877498 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/S

[GitHub] zhijiangW commented on a change in pull request #7549: [FLINK-11403][network] Remove ResultPartitionConsumableNotifier from ResultPartition

2019-02-18 Thread GitBox
zhijiangW commented on a change in pull request #7549: [FLINK-11403][network] Remove ResultPartitionConsumableNotifier from ResultPartition URL: https://github.com/apache/flink/pull/7549#discussion_r257878232 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/net

[GitHub] sjwiesman commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o…

2019-02-18 Thread GitBox
sjwiesman commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o… URL: https://github.com/apache/flink/pull/7747#discussion_r257877786 ## File path: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java

[jira] [Commented] (FLINK-11640) Caused by: java.lang.IllegalStateException: No operators defined in streaming topology. Cannot execute.

2019-02-18 Thread thinktothings (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771524#comment-16771524 ] thinktothings commented on FLINK-11640: --- Thank you very much, I understand, this i

[GitHub] sjwiesman commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o…

2019-02-18 Thread GitBox
sjwiesman commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o… URL: https://github.com/apache/flink/pull/7747#discussion_r257877498 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/S

[GitHub] HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

2019-02-18 Thread GitBox
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-464962219 @fhueske I finished rebase lastest upstream master just now. The compile error probably comes from the generated avro classe

[jira] [Created] (FLINK-11655) runnable field should be transient in RunAsync from RPC messages

2019-02-18 Thread Benchao Li (JIRA)
Benchao Li created FLINK-11655: -- Summary: runnable field should be transient in RunAsync from RPC messages Key: FLINK-11655 URL: https://issues.apache.org/jira/browse/FLINK-11655 Project: Flink

[jira] [Updated] (FLINK-11654) ProducerFencedExceptions from Kafka in EXACTLY_ONCE mode due to identical transactional IDs in multiple jobs

2019-02-18 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-11654: Fix Version/s: 1.8.0 > ProducerFencedExceptions from Kafka in EXACTLY_ONCE mode du

[jira] [Updated] (FLINK-11654) ProducerFencedExceptions from Kafka in EXACTLY_ONCE mode due to identical transactional IDs in multiple jobs

2019-02-18 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-11654: Priority: Blocker (was: Critical) > ProducerFencedExceptions from Kafka in EXACTL

[jira] [Commented] (FLINK-11654) ProducerFencedExceptions from Kafka in EXACTLY_ONCE mode due to identical transactional IDs in multiple jobs

2019-02-18 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771497#comment-16771497 ] Tzu-Li (Gordon) Tai commented on FLINK-11654: - This looks like a correct ass

[jira] [Commented] (FLINK-11616) Flink official document has an error

2019-02-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771495#comment-16771495 ] vinoyang commented on FLINK-11616: -- [~linjie]  It seems to be a page rendering problem

[jira] [Created] (FLINK-11654) ProducerFencedExceptions from Kafka in EXACTLY_ONCE mode due to identical transactional IDs in multiple jobs

2019-02-18 Thread JIRA
Jürgen Kreileder created FLINK-11654: Summary: ProducerFencedExceptions from Kafka in EXACTLY_ONCE mode due to identical transactional IDs in multiple jobs Key: FLINK-11654 URL: https://issues.apache.org/jira/

[jira] [Commented] (FLINK-11593) Check & port TaskManagerTest to new code base

2019-02-18 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771493#comment-16771493 ] Shimin Yang commented on FLINK-11593: - Hi [~till.rohrmann], it will be finished befo

[GitHub] klion26 commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o…

2019-02-18 Thread GitBox
klion26 commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o… URL: https://github.com/apache/flink/pull/7747#discussion_r257867156 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/Str

[GitHub] klion26 commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o…

2019-02-18 Thread GitBox
klion26 commented on a change in pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o… URL: https://github.com/apache/flink/pull/7747#discussion_r257866810 ## File path: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java

[jira] [Assigned] (FLINK-11492) Support the full Blink SQL runtime

2019-02-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young reassigned FLINK-11492: -- Assignee: Kurt Young > Support the full Blink SQL runtime > -

[jira] [Assigned] (FLINK-11491) Support all TPC-DS queries

2019-02-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young reassigned FLINK-11491: -- Assignee: Kurt Young > Support all TPC-DS queries > -- > >

[jira] [Commented] (FLINK-6263) Leader error in Kafka producer on leader change (broker restart/failrue)

2019-02-18 Thread Eugene Trubenok (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771480#comment-16771480 ] Eugene Trubenok commented on FLINK-6263: The same issue happens in Flink 1.7.1 wh

[GitHub] afedulov commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
afedulov commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257861101 ## File path: flink-connectors/flink-connector-pubsub/src/mai

[jira] [Commented] (FLINK-11067) Convert TableEnvironments to interfaces

2019-02-18 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771442#comment-16771442 ] sunjincheng commented on FLINK-11067: - Thanks for taking this ticket, I think [~twal

[GitHub] sunjincheng121 commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-18 Thread GitBox
sunjincheng121 commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#discussion_r257851306 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/expre

[GitHub] fhueske commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

2019-02-18 Thread GitBox
fhueske commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-464871415 Thanks for the update @HuangZhenQiu! I'll do another pass (and maybe even merge it) tomorrow. I tried to rebase the PR to t

[jira] [Commented] (FLINK-11454) Support MergedStream operation

2019-02-18 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771340#comment-16771340 ] Rong Rong commented on FLINK-11454: --- Yes Thanks [~fhueske] for the feedback.   *Rega

[jira] [Commented] (FLINK-7001) Improve performance of Sliding Time Window with pane optimization

2019-02-18 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771321#comment-16771321 ] Rong Rong commented on FLINK-7001: -- Thanks [~jark] for the response. Yes, the Blink imp

[GitHub] sjwiesman opened a new pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o…

2019-02-18 Thread GitBox
sjwiesman opened a new pull request #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o… URL: https://github.com/apache/flink/pull/7747 …n datastream ## What is the purpose of the change Current best practice when deploying Flink applications to production

[GitHub] flinkbot commented on issue #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o…

2019-02-18 Thread GitBox
flinkbot commented on issue #7747: [FLINK-11653][DataStream] Add configuration to enforce custom UID's o… URL: https://github.com/apache/flink/pull/7747#issuecomment-464851132 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-11653) Add configuration to enforce custom UID's on datastream

2019-02-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11653: --- Labels: pull-request-available (was: ) > Add configuration to enforce custom UID's on datas

[jira] [Updated] (FLINK-11653) Add configuration to enforce custom UID's on datastream

2019-02-18 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-11653: - Component/s: (was: Job-Submission) DataStream API > Add configuration to en

[GitHub] azagrebin commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-02-18 Thread GitBox
azagrebin commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r257804466 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/a

[jira] [Updated] (FLINK-11653) Add configuration to enforce custom UID's on datastream

2019-02-18 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-11653: - Component/s: (was: DataStream API) Job-Submission > Add configuration to en

[jira] [Created] (FLINK-11653) Add configuration to enforce custom UID's on datastream

2019-02-18 Thread Seth Wiesman (JIRA)
Seth Wiesman created FLINK-11653: Summary: Add configuration to enforce custom UID's on datastream Key: FLINK-11653 URL: https://issues.apache.org/jira/browse/FLINK-11653 Project: Flink Issue

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257797730 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257797730 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257797071 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257795775 ## File path: docs/dev/connectors/pubsub.md ## @@ -0,0 +

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257795582 ## File path: flink-streaming-java/src/main/java/org/apache/flink

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257790481 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257789867 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257787880 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257787097 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257787085 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257786623 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257786197 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257785238 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] feluelle commented on issue #7746: [docs] Add badges

2019-02-18 Thread GitBox
feluelle commented on issue #7746: [docs] Add badges URL: https://github.com/apache/flink/pull/7746#issuecomment-464821776 I would also add the docs, but I am not sure how to link the badge correctly so it links to https://ci.apache.org/projects/flink/flink-docs-stable/ --

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257780807 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257780464 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-02-18 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r257779554 ## File path: flink-connectors/flink-connector-pubsub/src/main/ja

[GitHub] flinkbot commented on issue #7746: [docs] Add badges

2019-02-18 Thread GitBox
flinkbot commented on issue #7746: [docs] Add badges URL: https://github.com/apache/flink/pull/7746#issuecomment-464819157 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to trac

[GitHub] feluelle opened a new pull request #7746: [docs] Add badges

2019-02-18 Thread GitBox
feluelle opened a new pull request #7746: [docs] Add badges URL: https://github.com/apache/flink/pull/7746 ## What is the purpose of the change It displays the current build status of the `master` branch, the used license and a link to the twitter page. ## Brief change log

[jira] [Closed] (FLINK-11629) Stop AkkaRpcActor immediately after onStop has finished

2019-02-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-11629. - Resolution: Fixed > Stop AkkaRpcActor immediately after onStop has finished > --

[jira] [Comment Edited] (FLINK-11629) Stop AkkaRpcActor immediately after onStop has finished

2019-02-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771146#comment-16771146 ] Till Rohrmann edited comment on FLINK-11629 at 2/18/19 5:10 PM: --

[jira] [Reopened] (FLINK-11629) Stop AkkaRpcActor immediately after onStop has finished

2019-02-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-11629: --- > Stop AkkaRpcActor immediately after onStop has finished >

[GitHub] alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-02-18 Thread GitBox
alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r257769263 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/

[jira] [Commented] (FLINK-11068) Convert the API classes *Table, *Window to interfaces

2019-02-18 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771210#comment-16771210 ] Timo Walther commented on FLINK-11068: -- I would like to avoid multiple language-spe

[GitHub] StefanRRichter commented on a change in pull request #7729: [FLINK-11643] remove useless code of externalizedCheckpointsDir

2019-02-18 Thread GitBox
StefanRRichter commented on a change in pull request #7729: [FLINK-11643] remove useless code of externalizedCheckpointsDir URL: https://github.com/apache/flink/pull/7729#discussion_r257763479 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoad

[GitHub] StefanRRichter merged pull request #7744: [hotfix] fix typo in MemorySegment

2019-02-18 Thread GitBox
StefanRRichter merged pull request #7744: [hotfix] fix typo in MemorySegment URL: https://github.com/apache/flink/pull/7744 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] StefanRRichter commented on issue #7744: [hotfix] fix typo in MemorySegment

2019-02-18 Thread GitBox
StefanRRichter commented on issue #7744: [hotfix] fix typo in MemorySegment URL: https://github.com/apache/flink/pull/7744#issuecomment-464800446 LGTM 👍 This is an automated message from the Apache Git Service. To respond to

[GitHub] twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-18 Thread GitBox
twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#discussion_r257758114 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/

[GitHub] twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-18 Thread GitBox
twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#discussion_r257714012 ## File path: a.a ## @@ -0,0 +1 @@ +ss Review comment: Please remove unrelated

[GitHub] twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-18 Thread GitBox
twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#discussion_r257726378 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/

[GitHub] twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-18 Thread GitBox
twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#discussion_r257757819 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/

[GitHub] StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257759063 ## File path: flink-streaming-java/src/

[GitHub] StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257759063 ## File path: flink-streaming-java/src/

[GitHub] ealtamir edited a comment on issue #7168: [FLINK-6756][DataStream API] Provide Rich AsyncFunction to Scala API …

2019-02-18 Thread GitBox
ealtamir edited a comment on issue #7168: [FLINK-6756][DataStream API] Provide Rich AsyncFunction to Scala API … URL: https://github.com/apache/flink/pull/7168#issuecomment-464223539 Hi @dawidwys, when could we expect to see this commit in a stable release?

[GitHub] Myasuka commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints

2019-02-18 Thread GitBox
Myasuka commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints URL: https://github.com/apache/flink/pull/7515#issuecomment-464795897 Sure, I agree with this configurable and extendable solution especially after your

[GitHub] carp84 commented on issue #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on issue #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#issuecomment-464794119 Got to leave the office now, will try to fix other review comments early n

[GitHub] carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257755359 ## File path: flink-streaming-java/src/main/jav

[GitHub] StefanRRichter commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints

2019-02-18 Thread GitBox
StefanRRichter commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints URL: https://github.com/apache/flink/pull/7515#issuecomment-464790827 I see, and I think it is ok that they don't have a common superclass, becaus

[GitHub] StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257750381 ## File path: flink-state-backends/flin

[GitHub] StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257749152 ## File path: flink-streaming-java/src/

[GitHub] carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257748314 ## File path: flink-state-backends/flink-stateb

[GitHub] carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257747108 ## File path: flink-streaming-java/src/main/jav

[jira] [Commented] (FLINK-11632) Make TaskManager automatic bind address picking more explicit (by default) and more configurable

2019-02-18 Thread Alex (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771163#comment-16771163 ] Alex commented on FLINK-11632: -- [~Salatich], I've prepared a change set some time ago and j

[GitHub] Myasuka commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints

2019-02-18 Thread GitBox
Myasuka commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints URL: https://github.com/apache/flink/pull/7515#issuecomment-464778180 aha, maybe "concern" is a too serious expression, I just thought adding both `setSt

[GitHub] carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257740847 ## File path: flink-state-backends/flink-stateb

[GitHub] StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

2019-02-18 Thread GitBox
StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257738180 ## File path: flink-state-backends/flin

[jira] [Updated] (FLINK-11632) Make TaskManager automatic bind address picking more explicit (by default) and more configurable

2019-02-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11632: --- Labels: pull-request-available (was: ) > Make TaskManager automatic bind address picking mo

[GitHub] flinkbot commented on issue #7745: [FLINK-11632] Add new config option for TaskManager automatic address…

2019-02-18 Thread GitBox
flinkbot commented on issue #7745: [FLINK-11632] Add new config option for TaskManager automatic address… URL: https://github.com/apache/flink/pull/7745#issuecomment-464773897 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

  1   2   3   4   >