twalthr commented on a change in pull request #7664: [FLINK-11449][table]
Uncouple the Expression class from RexNodes.
URL: https://github.com/apache/flink/pull/7664#discussion_r257726378
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/windows.scala
##########
@@ -62,7 +62,7 @@ object Slide {
* @param size the size of the window as time or row-count interval
* @return a partially specified sliding window
*/
- def over(size: Expression): SlideWithSize = new SlideWithSize(size)
+ def over(size: PlannerExpression): SlideWithSize = new SlideWithSize(size)
Review comment:
In my opinion, we neither need to rename `Expression` to `PlannerExpression`
nor move existing expressions to a new package. This would reduce the size of
this PR by 1K lines of changes, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
