Myasuka commented on issue #7515: [FLINK-11313][checkpoint] Introduce LZ4 
compression for keyed state in full checkpoints and savepoints
URL: https://github.com/apache/flink/pull/7515#issuecomment-464778180
 
 
   aha, maybe "concern" is a too serious expression, I just thought adding both 
`setStreamCompressionDecorator` in `RocksDBStateBackend` and 
`AbstractFileStateBackend` seems a bit strange as they have no the same parent 
class. But I really agree that current implementation of 
`ExecutionConfig#setUseSnapshotCompression(boolean)` is not suitable to add 
user-customized compression decorator.
   
   In a nutshell, I am still quite in favor of this suggestion as it would be 
configurable, expandable and not need to introduce compression algorithm 
dependencies into `flink-core` moudle. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to