[GitHub] flink pull request #5323: [FLINK-8441] [State Backend] [RocksDB] change Rock...

2018-01-19 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5323 [FLINK-8441] [State Backend] [RocksDB] change RocksDBListState to serialize values and separators in stream to avoid extra bytes copying ## What is the purpose of the change Currently, `R

[GitHub] flink pull request #5322: [hotfix] [REST] Fix WebMonitorEndpoint that missin...

2018-01-19 Thread ifndef-SleePy
GitHub user ifndef-SleePy opened a pull request: https://github.com/apache/flink/pull/5322 [hotfix] [REST] Fix WebMonitorEndpoint that missing parameters while initializing handlers ## What is the purpose of the change * Fix bugs in my recent PRs about migrating subtask RES

[jira] [Closed] (FLINK-8355) DataSet Should not union a NULL row for AGG without GROUP BY clause.

2018-01-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-8355. Resolution: Fixed Assignee: sunjincheng Fix Version/s: 1.4.1 1.5.0

[jira] [Commented] (FLINK-8355) DataSet Should not union a NULL row for AGG without GROUP BY clause.

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332919#comment-16332919 ] ASF GitHub Bot commented on FLINK-8355: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8465) Retrieve correct leader component address in ClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332920#comment-16332920 ] ASF GitHub Bot commented on FLINK-8465: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5321: [FLINK-8465] [flip6] Retrieve correct leader compo...

2018-01-19 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5321 [FLINK-8465] [flip6] Retrieve correct leader component address in ClusterClient ## What is the purpose of the change Rename ClusterClient#getJobManagerAddress into #getClusterConnectio

[GitHub] flink pull request #5320: [FLINK-8355][table] remove DataSetAggregateWithNul...

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5320 ---

[jira] [Created] (FLINK-8465) Retrieve correct leader component address in ClusterClient

2018-01-19 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8465: Summary: Retrieve correct leader component address in ClusterClient Key: FLINK-8465 URL: https://issues.apache.org/jira/browse/FLINK-8465 Project: Flink Issu

[jira] [Resolved] (FLINK-8464) TestRaftReconfigurationWithSimulatedRpc fails with assertion error

2018-01-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved FLINK-8464. --- Resolution: Won't Fix Wrong project. > TestRaftReconfigurationWithSimulatedRpc fails with assertion error > -

[jira] [Commented] (FLINK-8464) TestRaftReconfigurationWithSimulatedRpc fails with assertion error

2018-01-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332858#comment-16332858 ] Ted Yu commented on FLINK-8464: --- Initially I bumped into the following: {code} testRevertCon

[jira] [Created] (FLINK-8464) TestRaftReconfigurationWithSimulatedRpc fails with assertion error

2018-01-19 Thread Ted Yu (JIRA)
Ted Yu created FLINK-8464: - Summary: TestRaftReconfigurationWithSimulatedRpc fails with assertion error Key: FLINK-8464 URL: https://issues.apache.org/jira/browse/FLINK-8464 Project: Flink Issue Typ

[jira] [Updated] (FLINK-8464) TestRaftReconfigurationWithSimulatedRpc fails with assertion error

2018-01-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8464: -- Attachment: ratis-8464.tst > TestRaftReconfigurationWithSimulatedRpc fails with assertion error > --

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332842#comment-16332842 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supported

2018-01-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5241 Please rebase the PR on the master once #5320 was merged. I'll have a look at the changes after the rebase. Thank you, Fabian ---

[jira] [Commented] (FLINK-8355) DataSet Should not union a NULL row for AGG without GROUP BY clause.

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332840#comment-16332840 ] ASF GitHub Bot commented on FLINK-8355: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5320: [FLINK-8355][table] remove DataSetAggregateWithNullValues...

2018-01-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5320 Thanks for the PR @sunjincheng121. It looks very good. I'll run final tests and will merge it. Fabian ---

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332817#comment-16332817 ] ASF GitHub Bot commented on FLINK-8344: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162715070 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332814#comment-16332814 ] ASF GitHub Bot commented on FLINK-8344: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162714906 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -61,46 +69,77 @@ import org.apache.flink.runtime.

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332812#comment-16332812 ] ASF GitHub Bot commented on FLINK-8344: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162714628 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[jira] [Commented] (FLINK-8355) DataSet Should not union a NULL row for AGG without GROUP BY clause.

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332738#comment-16332738 ] ASF GitHub Bot commented on FLINK-8355: --- GitHub user sunjincheng121 opened a pull re

[GitHub] flink pull request #5320: [FLINK-8355][table] remove DataSetAggregateWithNul...

2018-01-19 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/5320 [FLINK-8355][table] remove DataSetAggregateWithNullValuesRule. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the communi

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332723#comment-16332723 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332726#comment-16332726 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332718#comment-16332718 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332725#comment-16332725 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332716#comment-16332716 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332719#comment-16332719 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332714#comment-16332714 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332724#comment-16332724 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332715#comment-16332715 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332722#comment-16332722 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332717#comment-16332717 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332721#comment-16332721 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332720#comment-16332720 ] ASF GitHub Bot commented on FLINK-8344: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162690747 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java --- @@ -144,6 +154,15 @@ public WebMonitorEndpoint(

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162695596 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162693549 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -327,13 +376,14 @@ public T getClusterId() {

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162696312 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162687082 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java --- @@ -30,49 +28,20 @@ */ pu

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162699368 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162694907 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162699002 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162696516 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -61,46 +69,77 @@ import org.apache.flink

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162696429 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162687806 --- Diff: flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java --- @@ -285,13 +289,45 @@ private static String createMessageHtml

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162689030 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -251,6 +245,12 @@ protected void channelRead0(ChannelHandlerC

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162692567 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -61,46 +69,77 @@ import org.apache.flink

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332687#comment-16332687 ] ASF GitHub Bot commented on FLINK-8384: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-01-19 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5295 It's `NoResourceAvailableException` error, not sure, but we can try to rebuild it. ---

[GitHub] flink pull request #5319: [FLINK-8463] [rest] Remove blocking of IO executor...

2018-01-19 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5319 [FLINK-8463] [rest] Remove blocking of IO executor in RestClient#submitRequest ## What is the purpose of the change Instead of waiting on the ChannelFuture we register a ChannelFutureL

[jira] [Commented] (FLINK-8463) Remove unnecessary thread blocking in RestClient#submitRequest

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332591#comment-16332591 ] ASF GitHub Bot commented on FLINK-8463: --- GitHub user tillrohrmann opened a pull requ

[jira] [Created] (FLINK-8463) Remove unnecessary thread blocking in RestClient#submitRequest

2018-01-19 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8463: Summary: Remove unnecessary thread blocking in RestClient#submitRequest Key: FLINK-8463 URL: https://issues.apache.org/jira/browse/FLINK-8463 Project: Flink

[jira] [Commented] (FLINK-8425) SpilledSubpartitionView not protected against concurrent release calls

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332553#comment-16332553 ] ASF GitHub Bot commented on FLINK-8425: --- Github user StefanRRichter commented on the

[GitHub] flink issue #5314: [FLINK-8425][network] fix SpilledSubpartitionView not pro...

2018-01-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5314 LGTM 👍 ---

[jira] [Commented] (FLINK-8022) Kafka at-least-once tests fail occasionally

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332551#comment-16332551 ] ASF GitHub Bot commented on FLINK-8022: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5316: [FLINK-8022][kafka-tests] Disable at-least-once tests for...

2018-01-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5316 Is it possible to "harden" the tests by adding a "retry three times" loop around the entire test? Would that reduce the chance of failure to a point where it virtually never happening, and we

[jira] [Commented] (FLINK-8462) TaskExecutor does not verify RM heartbeat timeouts

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332535#comment-16332535 ] ASF GitHub Bot commented on FLINK-8462: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5318: [FLINK-8462] [flip6] Filter invalid heartbeat time...

2018-01-19 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5318 [FLINK-8462] [flip6] Filter invalid heartbeat timeouts in TaskExecutor ## What is the purpose of the change This commit properly stops the heartbeating of disconnected RMs and addition

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332480#comment-16332480 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on the issu

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-01-19 Thread dyanarose
Github user dyanarose commented on the issue: https://github.com/apache/flink/pull/5295 looks like the build failed on: org.apache.flink.test.streaming.runtime.StreamTaskTimerITCase testOperatorChainedToSource I can't see why this change would cause that to fail, after the

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332422#comment-16332422 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r162639253 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CountAggFunction.scala --- @@ -33,7 +33,20 @@ class Count

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332421#comment-16332421 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332419#comment-16332419 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332423#comment-16332423 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332424#comment-16332424 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r162645683 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -157,6 +158,7 @@ class DataSetA

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r16264 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1130,259 +1137,263 @@ object Aggre

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r162643053 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala --- @@ -164,7 +164,6 @@ object FlinkRuleSets {

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332420#comment-16332420 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332417#comment-16332417 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332418#comment-16332418 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r162649590 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1130,259 +1137,263 @@ object Aggre

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r162644529 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetEmptyProcessMapPartition.scala --- @@ -0,0 +1,83 @@

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r162643699 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -829,7 +833,8 @@ object AggregateUt

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r162642637 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -157,6 +158,7 @@ class DataSetA

[jira] [Commented] (FLINK-8458) Add the switch for keeping both the old mode and the new credit-based mode

2018-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332411#comment-16332411 ] ASF GitHub Bot commented on FLINK-8458: --- GitHub user zhijiangW opened a pull request

[GitHub] flink pull request #5317: [FLINK-8458] Add the switch for keeping both the o...

2018-01-19 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/5317 [FLINK-8458] Add the switch for keeping both the old mode and the new credit-based mode ## What is the purpose of the change *After the whole feature of credit-based flow control is done,

[jira] [Comment Edited] (FLINK-8043) change fullRestarts (for fine grained recovery) from guage to counter

2018-01-19 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331007#comment-16331007 ] Steven Zhen Wu edited comment on FLINK-8043 at 1/19/18 3:24 PM:

[jira] [Updated] (FLINK-8458) Add the switch for keeping both the old mode and the new credit-based mode

2018-01-19 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-8458: Issue Type: Sub-task (was: Task) Parent: FLINK-7282 > Add the switch for keeping both the old mode

[jira] [Closed] (FLINK-7520) let our Buffer class extend from netty's buffer class

2018-01-19 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-7520. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 85bea23ace3133e1b2d239c4ee87270a201b9b6a > let

[jira] [Closed] (FLINK-8395) Create (derived) sliced Buffer class

2018-01-19 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-8395. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 665347cf867f0b807fe9d4787b5ef42b0581b510 > Crea

[jira] [Closed] (FLINK-7518) pass our own buffer instances to netty

2018-01-19 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-7518. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 03c797a1d279a6c09c988755f94566a3d46cbb17 > pass

[jira] [Created] (FLINK-8462) TaskExecutor does not verify RM heartbeat timeouts

2018-01-19 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8462: Summary: TaskExecutor does not verify RM heartbeat timeouts Key: FLINK-8462 URL: https://issues.apache.org/jira/browse/FLINK-8462 Project: Flink Issue Type:

[GitHub] flink pull request #4979: RMQSource support disabling queue declaration

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4979#discussion_r162632757 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java --- @@ -138,7 +138,9 @@ protecte

[jira] [Commented] (FLINK-8248) RocksDB state backend Checkpointing is not working with KeyedCEP in 1.4

2018-01-19 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332260#comment-16332260 ] Kostas Kloudas commented on FLINK-8248: --- Hi [~sonice_lj]! Did you manage to see if t

[jira] [Assigned] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2018-01-19 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-2155: - Assignee: (was: Kostas Kloudas) > Add an additional checkstyle validation for illegal

[jira] [Resolved] (FLINK-7925) Add CheckpointingOptions

2018-01-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-7925. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in e52db8bc411e93c245cc78a278854f2653e5f384 >

[jira] [Closed] (FLINK-7925) Add CheckpointingOptions

2018-01-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-7925. --- > Add CheckpointingOptions > - > > Key: FLINK-7925 >

[jira] [Resolved] (FLINK-8461) Wrong logger configurations for shaded Netty

2018-01-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8461. - Resolution: Fixed Fixed in   - 1.4.1 via 537552267a4e095fdf4120d17425814093bbd92a   - 1.5.0 via 

[jira] [Closed] (FLINK-8461) Wrong logger configurations for shaded Netty

2018-01-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-8461. --- > Wrong logger configurations for shaded Netty > > >

[jira] [Updated] (FLINK-8457) Documentation for Building from Source is broken

2018-01-19 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui updated FLINK-8457: --- Description: The documentation for how to build Flink from source is broken for all released versions

[jira] [Updated] (FLINK-8457) Documentation for Building from Source is broken

2018-01-19 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui updated FLINK-8457: --- Environment: (was: The documentation for how to build Flink from source is broken for all released

[jira] [Created] (FLINK-8461) Wrong logger configurations for shaded Netty

2018-01-19 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-8461: --- Summary: Wrong logger configurations for shaded Netty Key: FLINK-8461 URL: https://issues.apache.org/jira/browse/FLINK-8461 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-8455) Add Hadoop to the parent-first loading patterns

2018-01-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-8455. --- > Add Hadoop to the parent-first loading patterns > --- > >

[jira] [Resolved] (FLINK-8455) Add Hadoop to the parent-first loading patterns

2018-01-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8455. - Resolution: Fixed Fixed in   - 1.4.1 via 0677f08b8f49a5db0be6fe1916bc4eb8dd156867   - 1.5.0 via d

[jira] [Commented] (FLINK-7982) Bump commons-configuration to 2.2

2018-01-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332205#comment-16332205 ] Stephan Ewen commented on FLINK-7982: - Bocker is resolved / merged. > Bump commons-co

  1   2   3   >