[ 
https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332722#comment-16332722
 ] 

ASF GitHub Bot commented on FLINK-8344:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5312#discussion_r162687806
  
    --- Diff: 
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
    @@ -285,13 +289,45 @@ private static String createMessageHtmlEntry(Class<?> 
messageClass, Class<?> emp
                }
     
                private DocumentingDispatcherRestEndpoint() {
    -                   super(restConfig, dispatcherGatewayRetriever, config, 
handlerConfig, resourceManagerGatewayRetriever, executor, 
metricQueryServiceRetriever);
    +                   super(restConfig, dispatcherGatewayRetriever, config, 
handlerConfig, resourceManagerGatewayRetriever, executor, 
metricQueryServiceRetriever, NoOpElectionService.INSTANCE, 
NoOpFatalErrorHandler.INSTANCE);
                }
     
                @Override
                public List<Tuple2<RestHandlerSpecification, 
ChannelInboundHandler>> initializeHandlers(CompletableFuture<String> 
restAddressFuture) {
                        return super.initializeHandlers(restAddressFuture);
                }
    +
    +           private enum NoOpElectionService implements 
LeaderElectionService {
    --- End diff --
    
    Nice, didn't know about this technique :-)


> Add support for HA to RestClusterClient
> ---------------------------------------
>
>                 Key: FLINK-8344
>                 URL: https://issues.apache.org/jira/browse/FLINK-8344
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Gary Yao
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{RestClusterClient}} must be able to deal with changing JobMasters in 
> case of HA. We have to add functionality to reconnect to a newly elected 
> leader in case of HA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to