[
https://issues.apache.org/jira/browse/FLINK-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332920#comment-16332920
]
ASF GitHub Bot commented on FLINK-8465:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5321
[FLINK-8465] [flip6] Retrieve correct leader component address in
ClusterClient
## What is the purpose of the change
Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo.
The
returned LeaderConnectionInfo contains the address of the leading cluster
component. In the old code this is the JobManager whereas in Flip-6 it is
the
Dispatcher.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink clusterClientLeaderAddress
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5321
----
commit d7407d13a4e023d714312c9ebd854b6cc322a8da
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-19T21:18:35Z
[FLINK-8465] [flip6] Retrieve correct leader component address in
ClusterClient
Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo.
The
returned LeaderConnectionInfo contains the address of the leading cluster
component. In the old code this is the JobManager whereas in Flip-6 it is
the
Dispatcher.
----
> Retrieve correct leader component address in ClusterClient
> ----------------------------------------------------------
>
> Key: FLINK-8465
> URL: https://issues.apache.org/jira/browse/FLINK-8465
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{ClusterClient}} has a method {{#getJobManagerAddress}} which retrieves
> the address of the leading {{JobManager}}. In order to make this method work
> with Flip-6 I propose to rename it into {{getClusterConnectionInfo}} which
> retrieves the {{LeaderConnectionInfo}} for the leader component of the
> cluster. In Flip-6 this will be the {{Dispatcher}}. In the old code, this
> will be the {{JobManager}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
