[
https://issues.apache.org/jira/browse/FLINK-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332535#comment-16332535
]
ASF GitHub Bot commented on FLINK-8462:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5318
[FLINK-8462] [flip6] Filter invalid heartbeat timeouts in TaskExecutor
## What is the purpose of the change
This commit properly stops the heartbeating of disconnected RMs and
additionally
ignores outdated heartbeat timeouts for old RM connections out.
## Brief change log
- Unmonitor RMs when RM lost leadership
- Check that RM heartbeats are still valid
## Verifying this change
- Added `TaskExecutorTest#testRMHeartbeatStopWhenLeadershipRevoked`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
cc @GJL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink filterInvalidRMTimeouts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5318
----
commit 5169dcad7defb7421903582fda0217448eefb008
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-19T13:56:42Z
[FLINK-8462] [flip6] Filter invalid heartbeat timeouts in TaskExecutor
This commit properly stops the heartbeating of disconnected RMs and
additionally
ignores outdated heartbeat timeouts for old RM connections out.
----
> TaskExecutor does not verify RM heartbeat timeouts
> --------------------------------------------------
>
> Key: FLINK-8462
> URL: https://issues.apache.org/jira/browse/FLINK-8462
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{TaskExecutor}} does neither properly stop RM heartbeats nor does it
> check whether a RM heartbeat timeout is still valid. As a consequence, it can
> happen that the {{TaskExecutor}} closes the connection to an active {{RM}}
> due to an outdated heartbeat timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
