[jira] [Commented] (FLINK-6196) Support dynamic schema in Table Function

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958372#comment-15958372 ] ASF GitHub Bot commented on FLINK-6196: --- Github user clarkyzl commented on a diff in

[GitHub] flink pull request #3623: [FLINK-6196] [table] Support dynamic schema in Tab...

2017-04-05 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3623#discussion_r110086591 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -53,22 +54,9 @@ class TableSqlFun

[jira] [Commented] (FLINK-6261) Add support for TUMBLE, HOP, SESSION to batch SQL

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958360#comment-15958360 ] ASF GitHub Bot commented on FLINK-6261: --- Github user haohui commented on the issue:

[GitHub] flink issue #3675: [FLINK-6261] [table] Support TUMBLE, HOP, SESSION group w...

2017-04-05 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3675 Thanks for the PR! It looks good to me overall. One problem is that `dataSet.LogicalWindowAggregateRule` has duplicated quite a bit of code in the `dataStream.LogicalWindowAggregateRule`. May

[jira] [Commented] (FLINK-6012) Support WindowStart / WindowEnd functions in stream SQL

2017-04-05 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958351#comment-15958351 ] Fabian Hueske commented on FLINK-6012: -- Can we generalize this to include the batch s

[jira] [Closed] (FLINK-4848) keystoreFilePath should be checked against null in SSLUtils#createSSLServerContext

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-4848. --- Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 1.2: 2c0e915a4e5bc742d2

[jira] [Updated] (FLINK-4848) keystoreFilePath should be checked against null in SSLUtils#createSSLServerContext

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-4848: Affects Version/s: 1.2.0 > keystoreFilePath should be checked against null in > SSLUtils#cr

[GitHub] flink pull request #3677: [FLINK-4848] [ssl] Throw meaningful exception when...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Updated] (FLINK-4848) keystoreFilePath should be checked against null in SSLUtils#createSSLServerContext

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-4848: Affects Version/s: 1.3.0 > keystoreFilePath should be checked against null in > SSLUtils#cr

[jira] [Commented] (FLINK-4848) keystoreFilePath should be checked against null in SSLUtils#createSSLServerContext

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958314#comment-15958314 ] ASF GitHub Bot commented on FLINK-4848: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-5902) Some images can not show in IE

2017-04-05 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958261#comment-15958261 ] shijinkui commented on FLINK-5902: -- hi, [~ajithshetty] do we have some solution? > Some

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-05 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958250#comment-15958250 ] sunjincheng commented on FLINK-6228: Of course [~fhueske] I agree with you. 1.3 releas

[jira] [Commented] (FLINK-6257) Post-pass OVER windows

2017-04-05 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958243#comment-15958243 ] sunjincheng commented on FLINK-6257: Hi [~fhueske] I have opened the first PR which ad

[jira] [Commented] (FLINK-6257) Post-pass OVER windows

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958240#comment-15958240 ] ASF GitHub Bot commented on FLINK-6257: --- GitHub user sunjincheng121 opened a pull re

[GitHub] flink pull request #3681: [FLINK-6257][table] Consistent naming of {{Process...

2017-04-05 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3681 [FLINK-6257][table] Consistent naming of {{ProcessFunctions}} and met… …hods, And add ORDER BY checking Thanks for contributing to Apache Flink. Before you open your pull request,

[jira] [Commented] (FLINK-6216) DataStream unbounded groupby aggregate with early firing

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958232#comment-15958232 ] ASF GitHub Bot commented on FLINK-6216: --- Github user shaoxuan-wang commented on a di

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-04-05 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r110073336 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -299,27 +299,6 @@ cl

[GitHub] flink issue #3676: [FLINK-6241] [table] codeGen dataStream aggregates that u...

2017-04-05 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3676 Thanks @fhueske, these changes look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958205#comment-15958205 ] ASF GitHub Bot commented on FLINK-6241: --- Github user shaoxuan-wang commented on the

[jira] [Commented] (FLINK-6020) Blob Server cannot handle multiple job submits (with same content) parallelly

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958155#comment-15958155 ] ASF GitHub Bot commented on FLINK-6020: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3525: [FLINK-6020]add a random integer suffix to blob key to av...

2017-04-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3525 I am currently travelling and then attending Flink Forward. Will come back to this after that. Quick feedback: - I am still thinking that the random suffix breaks the original idea

[jira] [Commented] (FLINK-4953) Allow access to "time" in ProcessWindowFunction.Context

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958149#comment-15958149 ] ASF GitHub Bot commented on FLINK-4953: --- Github user manuzhang commented on the issu

[GitHub] flink issue #3661: [FLINK-4953] Allow access to "time" in ProcessWindowFunct...

2017-04-05 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/flink/pull/3661 It seems `WindowOperatorContractTest` is for `InternalWindowFunction` while there is no existing tests for `ProcessWindowFunction`. Should I add them there ? --- If your project is set up for it,

[jira] [Created] (FLINK-6269) var could be a val

2017-04-05 Thread CanBin Zheng (JIRA)
CanBin Zheng created FLINK-6269: --- Summary: var could be a val Key: FLINK-6269 URL: https://issues.apache.org/jira/browse/FLINK-6269 Project: Flink Issue Type: Wish Components: JobMana

[jira] [Comment Edited] (FLINK-6257) Post-pass OVER windows

2017-04-05 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958140#comment-15958140 ] sunjincheng edited comment on FLINK-6257 at 4/6/17 1:30 AM: Hi

[jira] [Comment Edited] (FLINK-6257) Post-pass OVER windows

2017-04-05 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958140#comment-15958140 ] sunjincheng edited comment on FLINK-6257 at 4/6/17 1:20 AM: Hi

[jira] [Commented] (FLINK-6257) Post-pass OVER windows

2017-04-05 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958140#comment-15958140 ] sunjincheng commented on FLINK-6257: Hi,[~fhueske] That's fine. About {{Consistent na

[jira] [Commented] (FLINK-6268) Object reuse for Either type

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958137#comment-15958137 ] ASF GitHub Bot commented on FLINK-6268: --- GitHub user greghogan opened a pull request

[GitHub] flink pull request #3680: [FLINK-6268] [core] Object reuse for Either type

2017-04-05 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3680 [FLINK-6268] [core] Object reuse for Either type Implement object reuse for Flink's Either type by storing a reference to Right in Left and Left in Right. These references are private and remain n

[jira] [Commented] (FLINK-5435) Cleanup the rules introduced by FLINK-5144 when calcite releases 1.12

2017-04-05 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958118#comment-15958118 ] Kurt Young commented on FLINK-5435: --- [~twalthr] Sure, i will open a PR soon. > Cleanup

[jira] [Commented] (FLINK-6237) support RAND and RAND_INTEGER on SQL

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957985#comment-15957985 ] ASF GitHub Bot commented on FLINK-6237: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3660: [FLINK-6237] [table] support RAND and RAND_INTEGER on SQL

2017-04-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3660 Thanks for the update @godfreyhe! Looks good, IMO. I think it would be good to add the Table API functions and documentation with this PR. Thanks, Fabian --- If your project

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r110041174 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -299,27 +299,6 @@ class Wi

[jira] [Commented] (FLINK-6216) DataStream unbounded groupby aggregate with early firing

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957917#comment-15957917 ] ASF GitHub Bot commented on FLINK-6216: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-05 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957817#comment-15957817 ] Fabian Hueske commented on FLINK-6228: -- That's true. It is not possible to define Tum

[jira] [Commented] (FLINK-5962) Cancel checkpoint canceller tasks in CheckpointCoordinator

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957816#comment-15957816 ] ASF GitHub Bot commented on FLINK-5962: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #3679: [FLINK-5962] [runtime-web] [tests] Replace depreca...

2017-04-05 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3679 [FLINK-5962] [runtime-web] [tests] Replace deprecated usage og JsonNo… This PR replaces the usage of `JsonNode#getValueAsText()` with `JsonNode#asText()` in the `JobCancellationWithSavepointHandler

[jira] [Assigned] (FLINK-5952) JobCancellationWithSavepointHandlersTest uses deprecated JsonNode#getValuesAsText

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-5952: --- Assignee: Chesnay Schepler > JobCancellationWithSavepointHandlersTest uses deprecated

[jira] [Closed] (FLINK-2728) Add missing features to new web dashboard

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-2728. --- Resolution: Fixed All subtasks are complete. > Add missing features to new web dashboard > --

[jira] [Assigned] (FLINK-5629) Unclosed RandomAccessFile in StaticFileServerHandler#respondAsLeader()

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-5629: --- Assignee: Chesnay Schepler > Unclosed RandomAccessFile in StaticFileServerHandler#res

[jira] [Closed] (FLINK-6203) DataSet Transformations

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6203. --- Resolution: Fixed Fix Version/s: (was: 1.2.0) 1.2.1

[jira] [Updated] (FLINK-6203) DataSet Transformations

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6203: Affects Version/s: 1.3.0 > DataSet Transformations > --- > >

[jira] [Updated] (FLINK-6203) DataSet Transformations

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6203: Component/s: Documentation > DataSet Transformations > --- > >

[jira] [Commented] (FLINK-5629) Unclosed RandomAccessFile in StaticFileServerHandler#respondAsLeader()

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957785#comment-15957785 ] ASF GitHub Bot commented on FLINK-5629: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #3678: [FLINK-5629] [runtime-web] Close RAF in FileServer...

2017-04-05 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3678 [FLINK-5629] [runtime-web] Close RAF in FileServerHandlers when exception occurs This PR makes sure that the RandomAccessFile opened by FileServerhandlers are closed if an exception occurs after ope

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957759#comment-15957759 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957757#comment-15957757 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957760#comment-15957760 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957754#comment-15957754 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957755#comment-15957755 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957758#comment-15957758 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957761#comment-15957761 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957756#comment-15957756 ] ASF GitHub Bot commented on FLINK-6241: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110032776 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateHelper.scala --- @@ -0,0 +1,73 @@ +/* + * Lic

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110031845 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -239,6 +241,212 @@ class CodeGenerator(

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110032217 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -239,6 +241,212 @@ class CodeGenerator(

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110032955 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateHelper.scala --- @@ -0,0 +1,73 @@ +/* + * Lic

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110032835 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateHelper.scala --- @@ -0,0 +1,73 @@ +/* + * Lic

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110032272 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -239,6 +241,212 @@ class CodeGenerator(

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110032463 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/generated.scala --- @@ -58,6 +58,16 @@ case class GeneratedFunction[F <:

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3676#discussion_r110032722 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateHelper.scala --- @@ -0,0 +1,73 @@ +/* + * Lic

[jira] [Commented] (FLINK-6183) TaskMetricGroup may not be cleanup when Task.run() is never called or exits early

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957740#comment-15957740 ] ASF GitHub Bot commented on FLINK-6183: --- Github user zentol closed the pull request

[jira] [Closed] (FLINK-6184) Buffer metrics can cause NPE

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6184. --- Resolution: Fixed Fix Version/s: (was: 1.3.0) 1.2.1 1.2: 961134d

[GitHub] flink pull request #3610: [FLINK-6183]/[FLINK-6184] Prevent some NPE and unc...

2017-04-05 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/3610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-6183) TaskMetricGroup may not be cleanup when Task.run() is never called or exits early

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6183. --- Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 1.2: 3c63c9e01c6f1ed10a

[jira] [Commented] (FLINK-4848) keystoreFilePath should be checked against null in SSLUtils#createSSLServerContext

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957734#comment-15957734 ] ASF GitHub Bot commented on FLINK-4848: --- Github user tedyu commented on the issue:

[GitHub] flink issue #3677: [FLINK-4848] [ssl] Throw meaningful exception when SSL is...

2017-04-05 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/3677 lgtm Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-4848) keystoreFilePath should be checked against null in SSLUtils#createSSLServerContext

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957731#comment-15957731 ] ASF GitHub Bot commented on FLINK-4848: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #3677: [FLINK-4848] [ssl] Throw meaningful exception when...

2017-04-05 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3677 [FLINK-4848] [ssl] Throw meaningful exception when SSL is misconfigured This PR provides better error messages when SSL is enabled but is missing crucial configuration options. You can merge this pu

[jira] [Assigned] (FLINK-6203) DataSet Transformations

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6203: --- Assignee: Chesnay Schepler > DataSet Transformations > --- > >

[jira] [Assigned] (FLINK-4848) keystoreFilePath should be checked against null in SSLUtils#createSSLServerContext

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-4848: --- Assignee: Chesnay Schepler > keystoreFilePath should be checked against null in > SS

[jira] [Updated] (FLINK-6181) Zookeeper scripts use invalid regex

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6181: Affects Version/s: 1.3.0 1.2.0 > Zookeeper scripts use invalid regex

[jira] [Closed] (FLINK-6181) Zookeeper scripts use invalid regex

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6181. --- Resolution: Fixed Fix Version/s: 1.2.1 1.2: d2a8df4c5556ec30c0de0f8bf874d6c2395a5cbf >

[jira] [Commented] (FLINK-6186) Remove unused import

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957692#comment-15957692 ] ASF GitHub Bot commented on FLINK-6186: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-6181) Zookeeper scripts use invalid regex

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957693#comment-15957693 ] ASF GitHub Bot commented on FLINK-6181: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-6246) Fix generic type of OutputTag in operator Output

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957691#comment-15957691 ] ASF GitHub Bot commented on FLINK-6246: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-6127) Add MissingDeprecatedCheck to checkstyle

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957690#comment-15957690 ] ASF GitHub Bot commented on FLINK-6127: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-6212) Missing reference to flink-avro dependency

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957689#comment-15957689 ] ASF GitHub Bot commented on FLINK-6212: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-6201) move python example files from resources to the examples

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957688#comment-15957688 ] ASF GitHub Bot commented on FLINK-6201: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3638: [FLINK-6212]

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3572: [FLINK-6127] [checkstyle] Add MissingDeprecation c...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3662: [FLINK-6246] Fix generic type of OutputTag in oper...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3605: [FLINK-6181][Start scripts] Fix regex in start scr...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3605 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3612: [FLINK-6186][cleanup]Remove unused import.

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3628: [FLINK-6201][example] move python example files fr...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-6212) Missing reference to flink-avro dependency

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6212. --- Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 1.2: 36b068b08ce76f360e

[jira] [Closed] (FLINK-6201) move python example files from resources to the examples

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6201. --- Resolution: Fixed Fix Version/s: 1.3.0 1.3: 995422c461bc2e58bc1590c313b940e05c0fabef >

[jira] [Updated] (FLINK-6201) move python example files from resources to the examples

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6201: Affects Version/s: 1.3.0 > move python example files from resources to the examples > --

[jira] [Updated] (FLINK-6201) move python example files from resources to the examples

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6201: Component/s: Python API > move python example files from resources to the examples > ---

[jira] [Closed] (FLINK-6186) Remove unused import

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6186. --- Resolution: Fixed Fix Version/s: 1.3.0 1.3: 6c224047fb5d7874db442bce3815ac797af8d942 >

[jira] [Updated] (FLINK-6186) Remove unused import

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6186: Affects Version/s: 1.3.0 > Remove unused import > > > K

[jira] [Assigned] (FLINK-6127) Add MissingDeprecatedCheck to checkstyle

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6127: --- Assignee: Ufuk Celebi > Add MissingDeprecatedCheck to checkstyle > --

[jira] [Updated] (FLINK-6127) Add MissingDeprecatedCheck to checkstyle

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6127: Affects Version/s: 1.3.0 > Add MissingDeprecatedCheck to checkstyle > --

[jira] [Closed] (FLINK-6246) Fix generic type of OutputTag in operator Output

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6246. --- Resolution: Fixed Assignee: Aljoscha Krettek Fix Version/s: 1.3.0 1.3: 9bdbe60

[jira] [Closed] (FLINK-6127) Add MissingDeprecatedCheck to checkstyle

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6127. --- Resolution: Fixed Fix Version/s: 1.3.0 1.3: 68605d05107e2c70c12178b1db6a9e49641dbfe4 >

[jira] [Updated] (FLINK-6246) Fix generic type of OutputTag in operator Output

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6246: Affects Version/s: 1.3.0 > Fix generic type of OutputTag in operator Output > --

[jira] [Closed] (FLINK-6086) Rework PythonSender/-Streamer generics

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6086. --- Resolution: Fixed 1.3: a7251c56d0d03293f95f0e3b084326a96fe50ce3 > Rework PythonSender/-Stream

[jira] [Reopened] (FLINK-6181) Zookeeper scripts use invalid regex

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-6181: - reopening to apply patch to 1.2 > Zookeeper scripts use invalid regex > -

[jira] [Closed] (FLINK-6181) Zookeeper scripts use invalid regex

2017-04-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6181. --- Resolution: Fixed Fix Version/s: 1.3.0 1.3: dc13500dd5c8061eb75a64a62db6aa13f8fd5408 >

[jira] [Commented] (FLINK-6181) Zookeeper scripts use invalid regex

2017-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957424#comment-15957424 ] ASF GitHub Bot commented on FLINK-6181: --- Github user zentol commented on the issue:

  1   2   3   >