Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3646#discussion_r110073336
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -299,27 +299,6 @@ class WindowAggregateTest extends TableTestBase {
}
@Test
- def testGroupWithFloorExpression() = {
- val sql = "SELECT COUNT(*) FROM MyTable GROUP BY FLOOR(localTimestamp
TO HOUR)"
--- End diff --
Yes, @fhueske . Let us merge this to the retraction branch.
I agree with you, with FLINK-6011, I think we should now only treat
(TUMBLE, HOP, SESSION) as Windows, while FLOOR and others as function (and
theirs return values should be grouping keys).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
