Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3676#discussion_r110032272
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -239,6 +241,212 @@ class CodeGenerator(
}
/**
+ * Generates a
[[org.apache.flink.table.runtime.aggregate.AggregateHelper]] that can be passed
+ * to Java compiler.
+ *
+ * @param name Class name of the Function. Must not be unique but
has to be a valid Java
+ * class identifier.
+ * @param clazz AggregateHelper Function to be generated.
+ * @param aggFields position (in the input Row) of the input value for
each aggregate
+ * @param aggregates List of all aggregate functions
+ * @param generator code generator instance
+ * @param inputType Input row type
+ *
+ * @tparam F Flink Function to be generated.
+ * @return instance of GeneratedFunction
+ */
+ def generateAggregateHelper[F <: Function](
--- End diff --
The generic type can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
