[
https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958155#comment-15958155
]
ASF GitHub Bot commented on FLINK-6020:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3525
I am currently travelling and then attending Flink Forward. Will come back
to this after that.
Quick feedback:
- I am still thinking that the random suffix breaks the original idea of
the cached blobs.
- The blob manager counts references to files and does not delete them as
long as someone has a reference. That prevents deletion if multiple parties
work with the same jar.
- Properly handling rename and add reference in one lock, as well as
de-reference and delete in the same lock should fix it, I think
- The blob manager needs to make sure it has an exclusive directory, so
that no other process accesses the files. But I think that is the case already.
> Blob Server cannot handle multiple job submits (with same content) parallelly
> -----------------------------------------------------------------------------
>
> Key: FLINK-6020
> URL: https://issues.apache.org/jira/browse/FLINK-6020
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Tao Wang
> Assignee: Tao Wang
> Priority: Critical
>
> In yarn-cluster mode, if we submit one same job multiple times parallelly,
> the task will encounter class load problem and lease occuputation.
> Because blob server stores user jars in name with generated sha1sum of those,
> first writes a temp file and move it to finalialize. For recovery it also
> will put them to HDFS with same file name.
> In same time, when multiple clients sumit same job with same jar, the local
> jar files in blob server and those file on hdfs will be handled in multiple
> threads(BlobServerConnection), and impact each other.
> It's better to have a way to handle this, now two ideas comes up to my head:
> 1. lock the write operation, or
> 2. use some unique identifier as file name instead of ( or added up to)
> sha1sum of the file contents.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
