Github user skavulya commented on the pull request:
https://github.com/apache/flink/pull/656#issuecomment-218651924
thanks @thvasilo! I created the PR https://github.com/apache/flink/pull/1985
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user skavulya opened a pull request:
https://github.com/apache/flink/pull/1985
[FLINK-1979] Add logistic loss, hinge loss and regularization penalties
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consid
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1896#issuecomment-218637517
Thanks for the docs update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1984
[FLINK-3889] Make File Monitoring Function checkpointable.
This pull request introduces the underlying functionality to make Streaming
File Sources persistent.
It does not yet change the API calls
[
https://issues.apache.org/jira/browse/FLINK-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280969#comment-15280969
]
Tzu-Li (Gordon) Tai commented on FLINK-3211:
[~rmetzger]
Hi Robert,
Can you te
[
https://issues.apache.org/jira/browse/FLINK-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas updated FLINK-3715:
--
Description:
As mentioned in
https://docs.google.com/document/d/1Xp-YBf87vLTduYSivgqWVEMjYUmkA-
[
https://issues.apache.org/jira/browse/FLINK-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280826#comment-15280826
]
Greg Hogan commented on FLINK-3879:
---
The current expectation for FLINK-2044 is that the
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1956#issuecomment-218543446
@greghogan thanks and relevant codes have been modified. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280541#comment-15280541
]
ASF GitHub Bot commented on FLINK-2044:
---
Github user gallenvara commented on the pul
[
https://issues.apache.org/jira/browse/FLINK-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280496#comment-15280496
]
ASF GitHub Bot commented on FLINK-3868:
---
GitHub user greghogan opened a pull request
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1983
[FLINK-3868] [core] Specialized CopyableValue serializers and comparators
Update ValueTypeInfo to use specialized serializers and comparators, many
of which were already present.
You can merge th
[
https://issues.apache.org/jira/browse/FLINK-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan updated FLINK-3868:
--
Fix Version/s: 1.1.0
> Specialized CopyableValue serializers and comparators
> -
Github user yjshen commented on the pull request:
https://github.com/apache/flink/pull/1958#issuecomment-218511092
@fhueske @twalthr thanks for the review work! I've updated the code just
now.
Look forward to more feedbacks on this :)
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280348#comment-15280348
]
ASF GitHub Bot commented on FLINK-3836:
---
Github user mbode closed the pull request a
[
https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280349#comment-15280349
]
ASF GitHub Bot commented on FLINK-3836:
---
GitHub user mbode reopened a pull request:
GitHub user mbode reopened a pull request:
https://github.com/apache/flink/pull/1966
[FLINK-3836] Add LongHistogram accumulator
New accumulator `LongHistogram`; the `Histogram` accumulator now throws an
`IllegalArgumentException` instead of letting the int overflow.
- [x]
Github user mbode closed the pull request at:
https://github.com/apache/flink/pull/1966
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
[
https://issues.apache.org/jira/browse/FLINK-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-2310.
-
Resolution: Later
Work on this algorithm is continuing in FLINK-3898.
> Add an Adamic-Adar Similarity exa
[
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280280#comment-15280280
]
ASF GitHub Bot commented on FLINK-2044:
---
Github user gallenvara commented on a diff
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/1956#discussion_r62868637
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java
---
@@ -0,0 +1,183 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/FLINK-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri closed FLINK-2375.
Resolution: Won't Fix
This technique can be considered as part of FLINK-3898.
> Add Approximate Ada
[
https://issues.apache.org/jira/browse/FLINK-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri closed FLINK-2634.
Resolution: Won't Fix
There is currently no need or demand for this version. The current
TriangleEn
[
https://issues.apache.org/jira/browse/FLINK-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280260#comment-15280260
]
Vasia Kalavri commented on FLINK-3898:
--
I guess we can close FLINK-2310 as a duplicat
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1956#discussion_r62863450
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java
---
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280246#comment-15280246
]
Vasia Kalavri commented on FLINK-3879:
--
[~greghogan]
- Do we agree that the PR for FL
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1956#discussion_r62863557
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java
---
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1913#issuecomment-218483592
Thanks for for your remarks. Instead of serializing/deserializing parts of
the `ExecutionConfig` whenever the usercode class loader needs to be passed, I
would like to seria
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1981#issuecomment-218481504
Thanks for this PR, @dawidwys! I haven't had a look yet but will do soon.
Just a quick comment: this PR touches some files that PR #1958 is also
modifying (most
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280204#comment-15280204
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user twalthr commented on the pull r
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1958#issuecomment-218475561
@yjshen great work! PR looks very good. I had only some minor refactoring
comments.
---
If your project is set up for it, you can reply to this email and have your
repl
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280218#comment-15280218
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user yjshen commented on the pull re
Github user yjshen commented on the pull request:
https://github.com/apache/flink/pull/1958#issuecomment-218477620
Hi @twalthr, thanks very much for the review work! I'll resolve your
comments shortly :)
---
If your project is set up for it, you can reply to this email and have your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1945#discussion_r62857420
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -141,7 +141,7 @@ object FlinkShell {
): (String, Int, Option[
[
https://issues.apache.org/jira/browse/FLINK-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280203#comment-15280203
]
ASF GitHub Bot commented on FLINK-3776:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280209#comment-15280209
]
ASF GitHub Bot commented on FLINK-3776:
---
Github user mxm commented on the pull reque
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1945#issuecomment-218476654
Thanks for the pull request. Looks good. Have you tested that the
configuration is loaded correctly?
---
If your project is set up for it, you can reply to this email and h
[
https://issues.apache.org/jira/browse/FLINK-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280193#comment-15280193
]
Maximilian Michels commented on FLINK-3733:
---
I think this might be a duplicate o
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280187#comment-15280187
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user yjshen commented on a diff in t
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62856490
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/UnresolvedException.scala
---
@@ -15,9 +15,6 @@
* See the Li
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280178#comment-15280178
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user yjshen commented on a diff in t
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62855247
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
---
@@ -18,85 +18,26 @@
package org.apache.flink.a
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62853599
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -130,19 +130,17 @@ trait ImplicitExpressionOp
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62854701
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/example/JDBCFullTest.java
---
@@ -0,0 +1,91 @@
+/*
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62851933
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
---
@@ -18,85 +18,26 @@
package org.apache.flink.
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280165#comment-15280165
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user yjshen commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280168#comment-15280168
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user yjshen commented on a diff in t
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62853748
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/TypeCoercion.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed t
[
https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan updated FLINK-3780:
--
Fix Version/s: 1.1.0
> Jaccard Similarity
> --
>
> Key: FLINK-3780
>
Greg Hogan created FLINK-3898:
-
Summary: Adamic-Adar Similarity
Key: FLINK-3898
URL: https://issues.apache.org/jira/browse/FLINK-3898
Project: Flink
Issue Type: New Feature
Components:
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62852662
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolea
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280151#comment-15280151
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280150#comment-15280150
]
ASF GitHub Bot commented on FLINK-2044:
---
Github user gallenvara commented on the pul
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62852367
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/cast.scala
---
@@ -20,19 +20,55 @@ package org.apache.flink.api.t
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1956#issuecomment-218467237
@vasia Thanks a lot and PR has been updated as you advised.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280145#comment-15280145
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280140#comment-15280140
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62851129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
---
@@ -18,85 +18,26 @@
package org.apache.flink.
[
https://issues.apache.org/jira/browse/FLINK-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280134#comment-15280134
]
Greg Hogan commented on FLINK-3879:
---
Implementations which merely showcase the use of Ge
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62850239
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
---
@@ -0,0 +1,182 @@
+/**
+ * Lic
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280129#comment-15280129
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62849325
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/UnresolvedException.scala
---
@@ -15,9 +15,6 @@
* See the L
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62848946
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/TypeCoercion.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280120#comment-15280120
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user twalthr commented on a diff in
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62847383
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +134,51 @@ public void co
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280074#comment-15280074
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62843680
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -130,19 +130,17 @@ trait ImplicitExpressionO
[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280049#comment-15280049
]
ASF GitHub Bot commented on FLINK-3754:
---
Github user yjshen commented on the pull re
Github user yjshen commented on the pull request:
https://github.com/apache/flink/pull/1958#issuecomment-218447948
Hi @fhueske , I've just finished my work, can you give a another pass of
review? Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1956#issuecomment-218446355
Thanks for the updates @gallenvara. I left a few minor comments. Could you
please also add the algorithm in the Gelly documentation under "library
methods"? It should be g
[
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280047#comment-15280047
]
ASF GitHub Bot commented on FLINK-2044:
---
Github user vasia commented on the pull req
[
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280042#comment-15280042
]
ASF GitHub Bot commented on FLINK-2044:
---
Github user vasia commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280040#comment-15280040
]
ASF GitHub Bot commented on FLINK-2044:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1956#discussion_r62838798
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apa
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1956#discussion_r62838726
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280037#comment-15280037
]
ASF GitHub Bot commented on FLINK-2044:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1956#discussion_r62837591
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/data/HITSData.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed t
[
https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280018#comment-15280018
]
Dawid Wysakowicz commented on FLINK-3848:
-
Sure I will have a look into current st
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-218438515
Thanks for the update @fpompermaier. Overall the PR looks good. I added a
few comments and suggestions. Thanks, Fabian
---
If your project is set up for it, you can rep
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62834635
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/example/JDBCFullTest.java
---
@@ -0,0 +1,91 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62834552
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -19,135 +19,42 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62834121
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
---
@@ -0,0 +1,182 @@
+/**
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833701
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -19,180 +19,224 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833691
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -19,180 +19,224 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833637
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -19,180 +19,224 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833518
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/ParameterValuesProvider.java
---
@@ -15,17 +15,21 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833327
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericBetweenParametersProvider.java
---
@@ -0,0 +1,70 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833293
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericBetweenParametersProvider.java
---
@@ -0,0 +1,70 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833230
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -95,32 +95,32 @@ private void establ
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833149
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -95,32 +95,32 @@ private void establ
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833050
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -352,6 +318,10 @@ public JDBCInputFor
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833018
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -314,6 +279,7 @@ public static JDBCIn
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832955
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832846
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832789
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832683
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -113,19 +192,7 @@ public void close()
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832699
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -113,19 +192,7 @@ public void close()
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832588
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +134,51 @@ public void configu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832479
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +134,51 @@ public void configu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832266
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -19,59 +19,112 @@
package org.ap
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832299
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -19,59 +19,112 @@
package org.ap
1 - 100 of 140 matches
Mail list logo
