[ 
https://issues.apache.org/jira/browse/FLINK-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280203#comment-15280203
 ] 

ASF GitHub Bot commented on FLINK-3776:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1945#discussion_r62857420
  
    --- Diff: 
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
    @@ -141,7 +141,7 @@ object FlinkShell {
       ): (String, Int, Option[Either[FlinkMiniCluster, 
AbstractFlinkYarnCluster]]) = {
         config.executionMode match {
           case ExecutionMode.LOCAL => // Local mode
    -        val config = new Configuration()
    +        val config = GlobalConfiguration.getConfiguration()
    --- End diff --
    
    I think the conflagration needs to be loaded similarly as in line 183.


> Flink Scala shell does not allow to set configuration for local execution
> -------------------------------------------------------------------------
>
>                 Key: FLINK-3776
>                 URL: https://issues.apache.org/jira/browse/FLINK-3776
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala Shell
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>
> Flink's Scala shell starts a {{LocalFlinkMiniCluster}} with an empty 
> configuration when the shell is started in local mode. In order to allow the 
> user to configure the mini cluster, e.g., number of slots, size of memory, it 
> would be good to forward a user specified configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to