[ 
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280187#comment-15280187
 ] 

ASF GitHub Bot commented on FLINK-3754:
---------------------------------------

Github user yjshen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1958#discussion_r62856490
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/UnresolvedException.scala
 ---
    @@ -15,9 +15,6 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.flink.api.table
    +package org.apache.flink.api.table.expressions
     
    -/**
    - * General Exception for all errors during table handling.
    - */
    -class TableException(msg: String) extends RuntimeException(msg)
    +case class UnresolvedException(msg: String) extends RuntimeException(msg)
    --- End diff --
    
    OK, will do this


> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
>                 Key: FLINK-3754
>                 URL: https://issues.apache.org/jira/browse/FLINK-3754
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>    Affects Versions: 1.0.0
>            Reporter: Yijie Shen
>            Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before 
> RelNode construction, Table API lacks the counterparts and the validation is 
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as 
> possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to