Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1958#discussion_r62851129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
---
@@ -18,85 +18,26 @@
package org.apache.flink.api.table.expressions
import org.apache.calcite.rex.RexNode
-import org.apache.calcite.sql.SqlOperator
-import org.apache.calcite.sql.fun.SqlStdOperatorTable
import org.apache.calcite.tools.RelBuilder
+import org.apache.flink.api.table.validate.{ExprValidationResult,
ValidationFailure}
/**
* General expression for unresolved function calls. The function can be
a built-in
* scalar function or a user-defined scalar function.
*/
-case class Call(functionName: String, args: Expression*) extends
Expression {
+case class Call(functionName: String, args: Seq[Expression]) extends
Expression {
override def children: Seq[Expression] = args
override def toRexNode(implicit relBuilder: RelBuilder): RexNode = {
- relBuilder.call(
- BuiltInFunctionNames.toSqlOperator(functionName),
- args.map(_.toRexNode): _*)
+ throw new UnresolvedException(s"trying to convert UnresolvedFunction
$functionName to RexNode")
}
override def toString = s"\\$functionName(${args.mkString(", ")})"
- override def makeCopy(newArgs: Seq[AnyRef]): this.type = {
- val copy = Call(
- newArgs.head.asInstanceOf[String],
- newArgs.drop(1).asInstanceOf[Seq[Expression]]: _*)
+ override def resultType =
+ throw new UnresolvedException(s"calling dataType on Unresolved
Function $functionName")
--- End diff --
resultType instead of dataType. Space between Unresolved Function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
