Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46792344
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/traversals/RangePartitionRewriter.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044496#comment-15044496
]
ASF GitHub Bot commented on FLINK-7:
Github user ChengXiangLi commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044158#comment-15044158
]
ASF GitHub Bot commented on FLINK-2978:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162349944
@sachingoel0101 , This looks good, let's get it merged soon.
Some comments on your questions:
1) Concerning the config key: Good that way, thanks!
[
https://issues.apache.org/jira/browse/FLINK-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3125.
-
Resolution: Fixed
Fix Version/s: (was: 0.7.1-incubating)
Fixed in
- 1.0.0 via a1f4dd
[
https://issues.apache.org/jira/browse/FLINK-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3125.
---
> Web dashboard does not start when log files are not found
>
[
https://issues.apache.org/jira/browse/FLINK-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3055.
---
> ExecutionVertex has duplicate method getParallelSubtaskIndex and
> getSubTaskIndex
> --
[
https://issues.apache.org/jira/browse/FLINK-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3055.
-
Resolution: Fixed
Fix Version/s: 1.0.0
Fixed via 4003352cdbb7cabf9446d73412994c3ab731e9c0
[
https://issues.apache.org/jira/browse/FLINK-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044153#comment-15044153
]
ASF GitHub Bot commented on FLINK-3055:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044152#comment-15044152
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1386#discussion_r46776269
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/BatchTask.java
---
@@ -1150,8 +1149,8 @@ else if (index < 0 || index >=
this.dr
[
https://issues.apache.org/jira/browse/FLINK-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044136#comment-15044136
]
Ovidiu Marcu commented on FLINK-1731:
-
Will you consider this issue within the next re
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1386#issuecomment-162345554
@StephanEwen thanks for the review. I have addressed all but one of your
comments.
---
If your project is set up for it, you can reply to this email and have yo
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044122#comment-15044122
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user sachingoel0101 commented on the
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044121#comment-15044121
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user sachingoel0101 commented on a d
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1386#discussion_r46775517
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/BatchTask.java
---
@@ -1150,8 +1149,8 @@ else if (index < 0 || index >=
this
[
https://issues.apache.org/jira/browse/FLINK-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sachin Goel reassigned FLINK-2524:
--
Assignee: Sachin Goel
> Add "getTaskNameWithSubtasks()" to RuntimeContext
> ---
[
https://issues.apache.org/jira/browse/FLINK-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044093#comment-15044093
]
ASF GitHub Bot commented on FLINK-2928:
---
Github user sachingoel0101 commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162341452
Makes sense. Lemme figure something out here, and I will post an update in
a day or two.
---
If your project is set up for it, you can reply to this email and ha
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r46774718
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
---
@@ -63,6 +67,10 @@ public Strin
[
https://issues.apache.org/jira/browse/FLINK-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044083#comment-15044083
]
ASF GitHub Bot commented on FLINK-3023:
---
Github user sachingoel0101 commented on a d
[
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044082#comment-15044082
]
ASF GitHub Bot commented on FLINK-2978:
---
Github user sachingoel0101 commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162340095
@rmetzger thanks. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044036#comment-15044036
]
Ufuk Celebi commented on FLINK-1518:
Yes, will do.
Sorry for the confusing formulatio
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1430#issuecomment-162335117
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
[
https://issues.apache.org/jira/browse/FLINK-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044007#comment-15044007
]
ASF GitHub Bot commented on FLINK-3073:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162334879
As followup to this, I would suggest two changes:
1. Adjust the log message, to reflect that not 0.7 are either used
immediately (eager allocation) or that t
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044006#comment-15044006
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1386#issuecomment-162334713
All in all, pretty good change. Makes many parts of the code nicer. Also
good java docs and comments!
Comments were added inline. Nothing major, few details.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1386#discussion_r46773807
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/misc/AttemptNumberITCase.java
---
@@ -0,0 +1,70 @@
+/*
--- End diff --
In orde
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044005#comment-15044005
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044003#comment-15044003
]
ASF GitHub Bot commented on FLINK-3073:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044000#comment-15044000
]
ASF GitHub Bot commented on FLINK-2978:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162334401
Tested the change on a cluster with a job reading some 100GBs of data ...
looks good ..
```
19:07:19,537 INFO org.apache.flink.runtime.taskmanager.TaskM
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162334327
I've tested the change again on a cluster, works nicely!
---
If your project is
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043989#comment-15043989
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1386#discussion_r46773630
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableMaterialization.java
---
@@ -178,9 +178,9 @@ private boolean de
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043990#comment-15043990
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1386#discussion_r46773625
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableMaterialization.java
---
@@ -85,9 +85,9 @@ public void material
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1386#discussion_r46773363
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java
---
@@ -65,6 +65,22 @@
int getIndexOfThisSubtask();
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043970#comment-15043970
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1386#discussion_r46773342
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java ---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundati
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043967#comment-15043967
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043965#comment-15043965
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1386#issuecomment-162331160
I am adding a number of comments. When you address them, please do not
squash commits, so we can review just the changes separately.
---
If your project is set up f
[
https://issues.apache.org/jira/browse/FLINK-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043961#comment-15043961
]
ASF GitHub Bot commented on FLINK-2928:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162331113
Layout is tricky. But the JobID is a very important field (for example to
copy for CLI commands) and needs to stay.
---
If your project is set up for it, you can re
[
https://issues.apache.org/jira/browse/FLINK-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-2765:
--
Description:
Currently 0.98.11 is used:
{code}
0.98.11-hadoop2
{code}
Stable release for hadoop-
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043957#comment-15043957
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1386#issuecomment-162330497
Checking this out...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
[
https://issues.apache.org/jira/browse/FLINK-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043956#comment-15043956
]
Stephan Ewen commented on FLINK-3126:
-
That is part of the "toString()" method in man
[
https://issues.apache.org/jira/browse/FLINK-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043954#comment-15043954
]
ASF GitHub Bot commented on FLINK-3055:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1438#issuecomment-162330308
Thanks, looks good.
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Robert Metzger created FLINK-3126:
-
Summary: Remove accumulator type from "value" in web frontend
Key: FLINK-3126
URL: https://issues.apache.org/jira/browse/FLINK-3126
Project: Flink
Issue Ty
Stephan Ewen created FLINK-3125:
---
Summary: Web dashboard does not start when log files are not found
Key: FLINK-3125
URL: https://issues.apache.org/jira/browse/FLINK-3125
Project: Flink
Issue T
[
https://issues.apache.org/jira/browse/FLINK-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-3008.
--
Resolution: Duplicate
Fix Version/s: 0.10.1
> Failing/restarting streaming jobs are buggy in the
[
https://issues.apache.org/jira/browse/FLINK-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043952#comment-15043952
]
Stephan Ewen commented on FLINK-1518:
-
@uce Can you double check this issue?
I don't
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043937#comment-15043937
]
ASF GitHub Bot commented on FLINK-2488:
---
Github user sachingoel0101 commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1386#issuecomment-162325866
@StephanEwen can you take a look again? I have introduced the `TaskInfo`
object in the second commit, and we can squash them before merging.
---
If your project
71 matches
Mail list logo
