Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162349944
@sachingoel0101 , This looks good, let's get it merged soon.
Some comments on your questions:
1) Concerning the config key: Good that way, thanks!
2) Concerning path parameters vs query parameters: I am not an expert on
REST, but I think they serve different roles, so let's keep them separate. I
think that two maps are actually not bad. Makes the distinction obvious and is
efficient. I am not so convinced of the enum-based approach...
3) Concerning error handling: Let's leave it as it is in this pull request
and consolidate it in a separate effort. Should not block this PR:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
