[ 
https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044158#comment-15044158
 ] 

ASF GitHub Bot commented on FLINK-2978:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1338#issuecomment-162349944
  
    @sachingoel0101 , This looks good, let's get it merged soon.
    Some comments on your questions:
    
    1) Concerning the config key: Good that way, thanks!
    
    2) Concerning path parameters vs query parameters: I am not an expert on 
REST, but I think they serve different roles, so let's keep them separate. I 
think that two maps are actually not bad. Makes the distinction obvious and is 
efficient. I am not so convinced of the enum-based approach...
    
    3) Concerning error handling: Let's leave it as it is in this pull request 
and consolidate it in a separate effort. Should not block this PR:


> Integrate web submission interface into the new dashboard
> ---------------------------------------------------------
>
>                 Key: FLINK-2978
>                 URL: https://issues.apache.org/jira/browse/FLINK-2978
>             Project: Flink
>          Issue Type: New Feature
>          Components: Web Client, Webfrontend
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> As discussed in 
> http://mail-archives.apache.org/mod_mbox/flink-dev/201511.mbox/%3CCAL3J2zQg6UBKNDnm=8tshpz6r4p2jvx7nrlom7caajrb9s6...@mail.gmail.com%3E,
>  we should integrate job submission from the web into the dashboard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to