breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2208902393
> Is there a version 13.0.0 of Cordova which targets Android 14? Thank you!
Yes. See
[here](https://cordova.apache.org/announcements/2024/05/23/cordova-android-13.0.0.html)
ramona-cristea commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2208896576
Hello,
Does Cordova support Android 14? I saw you were working on it
(api34-support), but didn't see any update on the oficial documentation here
https://cordova.apa
breautek merged PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@co
github-advanced-security[bot] commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107466397
This pull request sets up GitHub code scanning for this repository. Once the
scans have completed and the checks have passed, the analysis results for this
p
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107302119
I've reverted AGP down to 8.3
Jellyfish appears to bundle Gradle 8.4 by default and will fail on
installing the wrapper due to AGP 8.4's requirement on Gradle 8.6. In order
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107186674
> I consider it a 'hard requirement' for users to upgrade to Android Studio
Jellyfish at a minimum for successful builds and seamless functionality from
Android Studio, as the te
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107170202
> Also the .ratignore changes could be reverted, but if reverted, need to
add at least gradle-wrapper.properties. This this file is detected if anyone
runs locally a rat test aft
erisu commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2106576600
Additional note regarding PR description:
> Android Studio
>
> The recommended Android Studio version to use with AGP 8.4 is [Android
Studio Jellyfish](https://develope
erisu commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1597410943
##
LICENSE:
##
@@ -200,3 +200,7 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language gove
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2105392642
Some last few changes which I think improves the PR significantly.
Like in the original post I really don't like submitting generated content.
Utilising an empty gradle pro
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1597304675
##
lib/builders/ProjectBuilder.js:
##
@@ -116,16 +114,17 @@ class ProjectBuilder {
return args;
}
-/*
-* This returns a promise
-*/
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2104560822
FYI, was talking with Erisu last night and we came up with a plan to remove
the JAR and thus avoid the security concerns about the integrity (e.g. xz
backdoor style attacks) of t
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2103649607
> Latest Android Studio updates gradle wrapper to 8.6, should we use the
same version Android Studio updates to instead of latest?
Unless if there is a specific issue with
jcesarmobile commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2103643229
Latest Android Studio updates gradle wrapper to 8.6, should we use the same
version Android Studio updates to instead of latest?
--
This is an automated message from the A
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2103230938
> It's not regarding licensing per se, it's under the [source packages
policy](https://www.apache.org/legal/release-policy.html#source-packages):
>
> > ### Source packages
dpogue commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2103203262
It's not regarding licensing per se, it's under the source packages policy:
> ### Source packages
>
> Every ASF release MUST contain one or more source packages, which M
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2103195979
> IIRC we're not allowed to commit the gradle jar file, this was an issue
that came up when we were originally moving from ant to gradle and there were
ASF policies that prevente
dpogue commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2103170457
IIRC we're not allowed to commit the gradle jar file, this was an issue that
came up when we were originally moving from ant to gradle and there were ASF
policies that prevented re
breautek commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2102557642
> Having an issue with `npm t` not able to download and use gradle wrapper.
I think I know what you're running into. It's dumb but gradle cannot install
the gradle wrapper
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1593154277
##
lib/builders/ProjectBuilder.js:
##
@@ -116,16 +114,17 @@ class ProjectBuilder {
return args;
}
-/*
-* This returns a promise
-*/
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1592471109
##
lib/builders/ProjectBuilder.js:
##
@@ -116,16 +114,17 @@ class ProjectBuilder {
return args;
}
-/*
-* This returns a promise
-*/
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1592467270
##
lib/prepare.js:
##
@@ -110,7 +110,10 @@ function getUserGradleConfig (configXml) {
{ xmlKey: 'AndroidXWebKitVersion', gradleKey:
'ANDROIDX_WEBKIT_
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1592466516
##
lib/prepare.js:
##
@@ -110,7 +110,10 @@ function getUserGradleConfig (configXml) {
{ xmlKey: 'AndroidXWebKitVersion', gradleKey:
'ANDROIDX_WEBKIT_
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1592459122
##
framework/cdv-gradle-config-defaults.json:
##
@@ -1,16 +1,19 @@
{
"MIN_SDK_VERSION": 24,
-"SDK_VERSION": 33,
+"SDK_VERSION": 34,
"COMPILE
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1592459122
##
framework/cdv-gradle-config-defaults.json:
##
@@ -1,16 +1,19 @@
{
"MIN_SDK_VERSION": 24,
-"SDK_VERSION": 33,
+"SDK_VERSION": 34,
"COMPILE
erisu commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1591905025
##
framework/cdv-gradle-config-defaults.json:
##
@@ -1,16 +1,19 @@
{
"MIN_SDK_VERSION": 24,
-"SDK_VERSION": 33,
+"SDK_VERSION": 34,
"COMPILE_SD
bryan-hunter commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1545883119
##
lib/builders/ProjectBuilder.js:
##
@@ -116,16 +114,17 @@ class ProjectBuilder {
return args;
}
-/*
-* This returns a promise
-
bryan-hunter commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1545883119
##
lib/builders/ProjectBuilder.js:
##
@@ -116,16 +114,17 @@ class ProjectBuilder {
return args;
}
-/*
-* This returns a promise
-
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1451637860
##
framework/build.gradle:
##
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
-sourceCompa
EiyuuZack commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1413735730
##
framework/build.gradle:
##
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
-sourceComp
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1412435720
##
framework/build.gradle:
##
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
-sourceCompa
EiyuuZack commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1406580359
##
framework/build.gradle:
##
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
-sourceComp
EiyuuZack commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1406580359
##
framework/build.gradle:
##
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
-sourceComp
breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1406441207
##
framework/build.gradle:
##
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
-sourceCompa
EiyuuZack commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1406120145
##
framework/build.gradle:
##
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
-sourceComp
codecov-commenter commented on PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-1773582628
##
[Codecov](https://app.codecov.io/gh/apache/cordova-android/pull/1678?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
breautek opened a new pull request, #1678:
URL: https://github.com/apache/cordova-android/pull/1678
### Platforms affected
Android
### Motivation and Context
Adds in support for the next android platform
Closes https://github.com/apache/cordova-andr
37 matches
Mail list logo
