erisu commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1591905025
##########
framework/cdv-gradle-config-defaults.json:
##########
@@ -1,16 +1,19 @@
{
"MIN_SDK_VERSION": 24,
- "SDK_VERSION": 33,
+ "SDK_VERSION": 34,
"COMPILE_SDK_VERSION": null,
- "GRADLE_VERSION": "7.6",
- "MIN_BUILD_TOOLS_VERSION": "33.0.2",
- "AGP_VERSION": "7.4.2",
+ "GRADLE_VERSION": "8.5",
+ "MIN_BUILD_TOOLS_VERSION": "34.0.0",
+ "AGP_VERSION": "8.2.1",
"KOTLIN_VERSION": "1.7.21",
"ANDROIDX_APP_COMPAT_VERSION": "1.6.1",
"ANDROIDX_WEBKIT_VERSION": "1.6.0",
"ANDROIDX_CORE_SPLASHSCREEN_VERSION": "1.0.0",
"GRADLE_PLUGIN_GOOGLE_SERVICES_VERSION": "4.3.15",
"IS_GRADLE_PLUGIN_GOOGLE_SERVICES_ENABLED": false,
"IS_GRADLE_PLUGIN_KOTLIN_ENABLED": false,
- "PACKAGE_NAMESPACE": "io.cordova.helloCordova"
+ "PACKAGE_NAMESPACE": "io.cordova.helloCordova",
+ "JAVA_SOURCE_COMPATIBILITY": 8,
+ "JAVA_TARGET_COMPATIBILITY": 8,
+ "KOTLIN_JVM_TARGET": "1.8"
Review Comment:
Is there a conflict with this and `KOTLIN_VERSION`?
##########
lib/prepare.js:
##########
@@ -110,7 +110,10 @@ function getUserGradleConfig (configXml) {
{ xmlKey: 'AndroidXWebKitVersion', gradleKey:
'ANDROIDX_WEBKIT_VERSION', type: String },
{ xmlKey: 'GradlePluginGoogleServicesVersion', gradleKey:
'GRADLE_PLUGIN_GOOGLE_SERVICES_VERSION', type: String },
{ xmlKey: 'GradlePluginGoogleServicesEnabled', gradleKey:
'IS_GRADLE_PLUGIN_GOOGLE_SERVICES_ENABLED', type: Boolean },
- { xmlKey: 'GradlePluginKotlinEnabled', gradleKey:
'IS_GRADLE_PLUGIN_KOTLIN_ENABLED', type: Boolean }
+ { xmlKey: 'GradlePluginKotlinEnabled', gradleKey:
'IS_GRADLE_PLUGIN_KOTLIN_ENABLED', type: Boolean },
+ { xmlKey: 'AndroidJavaSourceCompatibility', gradleKey:
'JAVA_SOURCE_COMPATIBILITY', type: Number },
+ { xmlKey: 'AndroidJavaTargetCompatibility', gradleKey:
'JAVA_TARGET_COMPATIBILITY', type: Number },
+ { xmlKey: 'AndroidKotlinJVMTarget', gradleKey: 'KOTLIN_JVM_TARGET',
type: String }
Review Comment:
Where is this used? Some reason I can't find `AndroidKotlinJVMTarget` used
anywhere...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
