breautek commented on code in PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1412435720
########## framework/build.gradle: ########## @@ -50,8 +50,8 @@ android { buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION compileOptions { - sourceCompatibility JavaVersion.VERSION_1_8 - targetCompatibility JavaVersion.VERSION_1_8 + sourceCompatibility JavaVersion.VERSION_17 Review Comment: I've revert the change back to 8, but powered the source and target compatibility options via 2 new preferences so that it can be experimented with. The default will remain using Java 8. Overall I do agree that we should try to maintain the Android Studio default as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org