breautek commented on code in PR #1678:
URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1406441207
##########
framework/build.gradle:
##########
@@ -50,8 +50,8 @@ android {
buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
compileOptions {
- sourceCompatibility JavaVersion.VERSION_1_8
- targetCompatibility JavaVersion.VERSION_1_8
+ sourceCompatibility JavaVersion.VERSION_17
Review Comment:
JDK 17 compatibility was [added in AGP
8.1](https://developer.android.com/build/releases/gradle-plugin#8-1-0)
> how can you be sure there won't be any issues targeting Java 17?
It's my understanding that it will enable JDK 17 features on supported
devices. Different devices will have different java runtimes,so plugin authors
may still need to do an API check. But targeting JDK 17 doesn't necessarily
limit the ability to run on older devices.
Resources:
https://developer.android.com/build/jdks#compileSdk
https://developer.android.com/about/versions/14/features#core-libraries
Though you do bring a good point, it's hard to say with any level of
certainty that this won't break numerous of plugins that are likely built with
JDK 8 as a target. If there are any breaking changes in the language, the
compilation target may break builds. It hasn't in my own testing with the
plugins I have used, it might be smart to introduce a preference to set these
fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
