Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-05 Thread Xinchen Hui
Sent from my iPhone > On Feb 6, 2015, at 9:38 AM, Yasuo Ohgaki wrote: > > Hi Rasmus, > >> On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf wrote: >> >> Having just finished porting php-memcached (with help from Xinchen) to >> PHP7 I was wondering if it wouldn't be worthwhile to annotate the d

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Xinchen Hui
Hey: On Fri, Feb 6, 2015 at 7:06 PM, Yasuo Ohgaki wrote: > Hi Xinchen, > > On Fri, Feb 6, 2015 at 12:00 PM, Xinchen Hui wrote: >> >> > On Feb 6, 2015, at 9:38 AM, Yasuo Ohgaki wrote: >> > >> > Hi Rasmus, >> > >> >&

Re: [PHP-DEV] new json, push generated file?

2015-02-08 Thread Xinchen Hui
e > > @pierrejoye | http://www.libgd.org > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] new json, push generated file?

2015-02-08 Thread Xinchen Hui
Hey: On Mon, Feb 9, 2015 at 1:44 PM, Pierre Joye wrote: > On Mon, Feb 9, 2015 at 11:10 AM, Xinchen Hui wrote: >> Hey: >> >> On Mon, Feb 9, 2015 at 10:40 AM, Pierre Joye wrote: >>> hi, >>> >>> Should we push json_parser.tab.c? Which is generat

Re: [PHP-DEV] Re: Annotated PHP 5->7 extension diff

2015-02-08 Thread Xinchen Hui
_FETCH_RESOURCE2(ff_movie_ctx, ff_movie_context*, _tmp_zval, -1,\ > "ffmpeg_movie", le_ffmpeg_movie, le_ffmpeg_pmovie);\ > }\ > > I have tried a lot of things, but nothing works so far... > > An annotated diff would be very welcome! But more or less complete > docum

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Xinchen Hui
y). > > I'll keep the PR open for a week or so and if there are no objection, I > would like merge it. I'm also open changing the name of the option and will > be glad for any config.m4 related comments and reviews. why make this thing in this way complicated? why not just simply i

Re: [PHP-DEV] [VOTE] Scalar Type Hints

2015-02-10 Thread Xinchen Hui
r vote... thanks > -- > Andrea Faulds > http://ajf.me/ > > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Scalar Type Hints

2015-02-10 Thread Xinchen Hui
Hey: On Wed, Feb 11, 2015 at 11:36 AM, Xinchen Hui wrote: > Hey: > > > On Fri, Feb 6, 2015 at 4:14 AM, Andrea Faulds wrote: >> Good evening, >> >> At long last, I’m going to put the RFC to a vote. It’s been long enough - I >> don’t think there needs to be,

Re: [PHP-DEV] [VOTE] Scalar Type Hints

2015-02-10 Thread Xinchen Hui
Hey: On Wed, Feb 11, 2015 at 11:45 AM, Xinchen Hui wrote: > Hey: > > On Wed, Feb 11, 2015 at 11:36 AM, Xinchen Hui wrote: >> Hey: >> >> >> On Fri, Feb 6, 2015 at 4:14 AM, Andrea Faulds wrote: >>> Good evening, >>> >>> At long last, I

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-10 Thread Xinchen Hui
phpt] > = The fails must be know... relates to key name checking the leaks needs to be take care, I will look into it. anyway, these should not affects your work, thanks > > If this is normal, I'll ignore them all and start adopting new save handler > API. > > Regards, > > -- > Yasuo Ohgaki > yohg...@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Proposal: Introduce a new macro:php_error_docref_ex()

2015-02-11 Thread Xinchen Hui
gt; the docref parameter, default to NULL but not add a new macro. > > > What do you think about it? No. I can't see any benefit from it, but lots of changes. everything works well now. thanks > > [1] https://github.com/php/php-src/pull/1075 > > -- > Reeze Xia > htt

[PHP-DEV] Re: Proposal: Introduce a new macro:php_error_docref_ex()

2015-02-11 Thread Xinchen Hui
> > I've never used other than NULL also. > Everyone is going to remove TSRM macros, it's right time to clean up. fine, if you want to change.. please, _ex means extending, so the name should not be php_error_docref_ex... thanks > > Regards, > > -- > Yas

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-11 Thread Xinchen Hui
On Thu, Feb 12, 2015 at 10:05 AM, Yasuo Ohgaki wrote: > Hi all, > > On Wed, Feb 11, 2015 at 3:51 PM, Yasuo Ohgaki wrote: >> >> On Wed, Feb 11, 2015 at 3:27 PM, Xinchen Hui wrote: >>> >>> The fails must be know... relates to key name checking >>>

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-11 Thread Xinchen Hui
Hey: On Thu, Feb 12, 2015 at 1:35 PM, Yasuo Ohgaki wrote: > Hi Xinchen, > > On Thu, Feb 12, 2015 at 12:37 PM, Xinchen Hui wrote: >> >> > lazy_write=On: Requests per second:2218.55 [#/sec] (mean) >> > lazy_write=Off: Requests per second:24.58 [#/sec] (me

Re: [PHP-DEV] [RFC] Void Return Type

2015-02-13 Thread Xinchen Hui
> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Big Integer Support

2015-02-15 Thread Xinchen Hui
t; Thanks! > > -- > Andrea Faulds > http://ajf.me/ > > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Expectations

2015-02-20 Thread Xinchen Hui
throw SqliteException. // thus we can not optimized these statements ayway } thanks > > Cheers > Joe -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][VOTE] Improve array to string conversion

2015-02-25 Thread Xinchen Hui
t; François > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC] Exceptions in the engine

2015-02-25 Thread Xinchen Hui
aseExcepton). > I know this isn't a technical issue but it reduces readability a code. > > What are your thoughts about the following names ?: > > RootException > AbstractExcepton +1 for AbstarctException. thanks > >> > > > Marc > > > -- > PHP

[PHP-DEV] About optimization for compiler

2015-02-26 Thread Xinchen Hui
timization... considering Zend Compiler do things in -O0. since, optimization always are dangerous.. if we only do them in opcache, user can still run them codes with disable opcache, or at least disable some optimization level which cause that.. what do you think? thanks -- Xinchen Hui @Lar

[PHP-DEV] Re: About optimization for compiler

2015-02-26 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui wrote: > Hey Internals: > > I was looking Bob's switch optimization.. > > then I start to worry about where is the place optimization should > goes.. > > in generally, PHP is a interpreted langua

Re: [PHP-DEV] Re: About optimization for compiler

2015-02-26 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 2:41 PM, reeze wrote: > Hi, > > On 27 February 2015 at 14:26, Xinchen Hui wrote: >> >> Hey: >> >> On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui wrote: >> > Hey Internals: >> > >> > I was looking Bob&#

[PHP-DEV] Re: About optimization for compiler

2015-02-26 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui wrote: > Hey Internals: > > I was looking Bob's switch optimization.. And, I am not against this switch optimization.. I referring it to show where is my concerns came from thanks > > then I start to worry abou

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-26 Thread Xinchen Hui
es them and make "Script only include" RFC more effective. > > I don't use phar on regular basis, feedback from phar users are appreciated. > If you find yet another hole in [2], please let me know. > > [1] https://wiki.php.net/rfc/allow_url_include > [2] https://wiki.p

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-26 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 2:59 PM, Yasuo Ohgaki wrote: > Hi Xinchen, > > On Fri, Feb 27, 2015 at 3:55 PM, Xinchen Hui wrote: >> >> hmm, does that means, if this RFC won't pass, then script only include >> RFC should also be rejected? >> >> if

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Xinchen Hui
prove true : during the > next years, STH will be used mostly as a debugging tool, proving opposite > arguments were FUD or, at least, phantasm. > > Regards > > François > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 3:59 PM, Xinchen Hui wrote: > Hey: > > On Fri, Feb 27, 2015 at 10:06 AM, François Laupretre wrote: >>> De : Matthew Weier O'Phinney [mailto:matt...@zend.com] >>> >>> - PHPUnit passes a boolean false to `debug_backtra

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Xinchen Hui
hp#5.6.6 that would > explain this. > maybe related to your own build? http://3v4l.org/sD8SZ seems works always consistently same since PHP5 thanks > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laru

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 4:51 PM, Sebastian Bergmann wrote: > Am 27.02.2015 um 09:30 schrieb Xinchen Hui: >> maybe related to your own build? > > The test in the PHPUnit test suite fails with > >PHP 5.6.6 (cli) (built: Feb 19 2015 09:44:29) >Copyright (c)

[PHP-DEV] Re: About optimization for compiler

2015-02-27 Thread Xinchen Hui
On Fri, Feb 27, 2015 at 11:08 PM, Bob Weinand wrote: > Am 27.02.2015 um 07:53 schrieb Xinchen Hui : > > Hey: > > On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui wrote: > > Hey Internals: > > I was looking Bob's switch optimization.. > > And, I am not ag

[PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Xinchen Hui
t miss this mail :) the mail problem here is we can not get real performance improvement in reallife apps. opensource this, could maybe get more ideas on how to improve it. (except the icachemiss, dcachemiss we already knew). welcome to play with it, and give some thoughts :) thanks > &

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-03-04 Thread Xinchen Hui
e compile one PHP file at once, similar to what AOT compiler would do, but > we compile directly to memory and then execute it, With the type inference result we get in runtime. thanks > > Thanks. Dmitry. > > > >> >> Thanks, >> >> Anthony >> -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Enable Zend Signals Handler By Default

2015-03-05 Thread Xinchen Hui
tally removed the --enable-zend-signals option? thus make zend_signal.c always be compiled and linked. Is there any concerns or objections on this? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] Enable Zend Signals Handler By Default

2015-03-05 Thread Xinchen Hui
On Fri, Mar 6, 2015 at 6:31 AM, Pierre Joye wrote: > On Thu, Mar 5, 2015 at 5:27 AM, Xinchen Hui wrote: >> Hey internal: >> >> >> There is also a problem we have been suffering from for a quite >> long time, that is signal raised at OOM/Timeout when execut

Re: [PHP-DEV] Arrays being generated with length and no content on master

2015-03-06 Thread Xinchen Hui
Hey: > On Mar 7, 2015, at 1:23 PM, Juan Basso wrote: > > I was testing CakePHP framework with PHP 7 and some tests were failing. > Digging into the issue I found that using compact in a certain way can > cause PHP to create an array with length but no content inside. > > I reported and added so

Re: [PHP-DEV] Arrays being generated with length and no content on master

2015-03-07 Thread Xinchen Hui
Hey: > On Mar 7, 2015, at 1:23 PM, Juan Basso wrote: > > I was testing CakePHP framework with PHP 7 and some tests were failing. > Digging into the issue I found that using compact in a certain way can > cause PHP to create an array with length but no content inside. > > I reported and added so

Re: [PHP-DEV] [Discussion] Deprecate function sizeof()

2015-03-09 Thread Xinchen Hui
oved all DEPRECATED functions... then you want to brings new :< anyway, I'd prefer don't do it. especially with little gain. thanks > > Regards, > > -- > Yasuo Ohgaki > yohg...@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Drop Multiply VM kind support

2015-03-12 Thread Xinchen Hui
) = execute_data->opline->handler(execute_data); So, maybe it's time for us to remove GOTO and SWITCH at all? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Drop Multiply VM kind support

2015-03-13 Thread Xinchen Hui
xecute_data); won't work with CALL and global > CPU registers s well :( that exactly how the problem came to my :) thanks > > Thanks. Dmitry. > > > > On Fri, Mar 13, 2015 at 7:01 AM, Xinchen Hui wrote: >> >> Hey: >> >> We have CAL

Re: [PHP-DEV] Drop Multiply VM kind support

2015-03-14 Thread Xinchen Hui
Hey: On Sat, Mar 14, 2015 at 8:01 PM, Bob Weinand wrote: >> Am 13.03.2015 um 05:01 schrieb Xinchen Hui : >> >> Hey: >> >> We have CALL SWITCH GOTO vm kind supports for long time. >> >> And we use CALL for default. >> >> SWITCH GOT

[PHP-DEV] About declare(strict_types = 1)

2015-03-15 Thread Xinchen Hui
right? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] About declare(strict_types = 1)

2015-03-15 Thread Xinchen Hui
Hey: On Mon, Mar 16, 2015 at 1:49 PM, Dennis Birkholz wrote: > Hello Xinchen, > > Am 16.03.2015 um 06:28 schrieb Xinchen Hui: >> lib.php >> >declare(strict_types = 1); >>function add(int $a, int $b) { >>} >>

Re: [PHP-DEV] [RFC][DISCUSSION] Add preg_replace_callback_array function

2015-03-15 Thread Xinchen Hui
ink this is a good addition after we removed /e if you objections raise in couple days, I will merge this. thanks > > > — > Best, > Wei Dai > -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] About declare(strict_types = 1)

2015-03-15 Thread Xinchen Hui
Hey: On Mon, Mar 16, 2015 at 2:03 PM, Matthew Leverton wrote: > On Mon, Mar 16, 2015 at 12:55 AM, Xinchen Hui wrote: >> That is why I don't see it before (thousand times, too long to read... >> but not in RFC) >> > It's in the RFC: "Whether or not the fu

Re: [PHP-DEV] Minimum version of GCC required to build PHP

2015-03-15 Thread Xinchen Hui
- PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] About declare(strict_types = 1)

2015-03-16 Thread Xinchen Hui
Hey: On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye wrote: > Hi, > > On Mar 16, 2015 4:29 PM, "Xinchen Hui" wrote: >> >> Hey: >> >> The most unaccept feature in current STH thing(v.5.0) is this. >> >> acutaly, I believe

Re: [PHP-DEV] About declare(strict_types = 1)

2015-03-16 Thread Xinchen Hui
Hey: On Mon, Mar 16, 2015 at 7:18 PM, Derick Rethans wrote: > On Mon, 16 Mar 2015, Xinchen Hui wrote: > >> On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye wrote: >> > >> > On Mar 16, 2015 4:29 PM, "Xinchen Hui" wrote: >> >> >> >>

Re: [PHP-DEV] About declare(strict_types = 1)

2015-03-16 Thread Xinchen Hui
On Mon, Mar 16, 2015 at 7:32 PM, Xinchen Hui wrote: > Hey: > > On Mon, Mar 16, 2015 at 7:18 PM, Derick Rethans wrote: >> On Mon, 16 Mar 2015, Xinchen Hui wrote: >> >>> On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye wrote: >>> > >>&

Re: [PHP-DEV] About declare(strict_types = 1)

2015-03-16 Thread Xinchen Hui
Hey: On Mon, Mar 16, 2015 at 7:33 PM, Yasuo Ohgaki wrote: > Hi Derick, > > On Mon, Mar 16, 2015 at 8:18 PM, Derick Rethans wrote: >> >> On Mon, 16 Mar 2015, Xinchen Hui wrote: >> >> > On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye >> > wrote: >&g

Re: [PHP-DEV] About declare(strict_types = 1)

2015-03-16 Thread Xinchen Hui
Hey: On Mon, Mar 16, 2015 at 9:32 PM, Pascal Chevrel wrote: > Le 16/03/2015 12:39, Xinchen Hui a écrit : >> >> Hey: > > >> >> And last comment, if there no such declare thing, I will definitely >> vote yes to this RFC. > > > Hi Xinchen, >

Re: [PHP-DEV] Dual Mode STH

2015-03-16 Thread Xinchen Hui
can revisit casting rules in the future without time pressure, and in > general, see how this new feature is accepted and used. > > > > Again, I call upon everybody to vote Yes for the Dual Mode RFC to ensure > that we have some form of STH in PHP 7.0. Unecessary for everybody, one or

Re: [PHP-DEV] [RFC][DISCUSSION] Add preg_replace_callback_array function

2015-03-16 Thread Xinchen Hui
er > RFC bc break..(change the callback's signature) > > And give a few links to historical discussions in the same sort of area? > E.g Laruence's RFC: https://wiki.php.net/rfc/second_arg_to_preg_callback and > its discussion thread (http://php.markmail.org/thread/qwiyq5o2vwlbdcz

Re: [PHP-DEV] [RFC][DISCUSSION] Add preg_replace_callback_array function

2015-03-16 Thread Xinchen Hui
Hey: On Mon, Mar 16, 2015 at 11:32 PM, Peter Cowburn wrote: > On 16 March 2015 at 14:59, Xinchen Hui wrote: > >> Hey: >> >> On Mon, Mar 16, 2015 at 5:45 PM, Peter Cowburn >> wrote: >> > On 16 March 2015 at 01:40, Wei Dai wrote: >> > >> &

Re: [PHP-DEV] [RFC][Accepted] Scalar Type Declarations V0.5

2015-03-16 Thread Xinchen Hui
e > CoerciveSTH RFC. I hope many of us see the benefits of the RFC also. > > BTW, I suggest to remove the word "strict" from "strict_types" at least as > it is > not strict at all if caller(parent script) does not specify > "strict_types=1". > >

Re: [PHP-DEV] 回复: [RFC][DISCUSSION] Add preg_replace_callback_array function

2015-03-20 Thread Xinchen Hui
to do this, regardless of what mechanism is eventually > chosen. I also +1 for this. if there is no objections raises, I am going to merge it tomorrow.. thanks > > -- > Alain Williams > Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT > Lecturer. > +4

Re: [PHP-DEV] 回复: [RFC][DISCUSSION] Add preg_replace_callback_array function

2015-03-21 Thread Xinchen Hui
Hey: On Fri, Mar 20, 2015 at 9:14 PM, Xinchen Hui wrote: > Hey: > > On Fri, Mar 20, 2015 at 7:53 PM, Alain Williams wrote: >> On Fri, Mar 20, 2015 at 10:46:58PM +1100, Pierre Joye wrote: >>> On Fri, Mar 20, 2015 at 7:03 PM, Wei Dai wrote: >>> &g

Re: [PHP-DEV] Use "ropes" for string concatenation

2015-03-23 Thread Xinchen Hui
ons only and it is not a small change at this stage (post > features freeze). It sounds like a possible maintenance pain. Taking Actually, it's not. previously we have ADD_STRING/CHAR/VAR and CONCAT the 2nd branch cleanup these, and now we only deal with one type concat_list. :) thanks &

Re: [PHP-DEV] Use "ropes" for string concatenation

2015-03-23 Thread Xinchen Hui
Hey: On Tue, Mar 24, 2015 at 1:54 PM, Pierre Joye wrote: > On Tue, Mar 24, 2015 at 12:35 PM, Xinchen Hui wrote: >> Hey: >> >> On Tue, Mar 24, 2015 at 1:31 PM, Pierre Joye wrote: >>> hi! >>> >>> On Tue, Mar 24, 2015 at 5:41 AM, Dmitry Stogov wr

Re: [PHP-DEV] Use "ropes" for string concatenation

2015-03-23 Thread Xinchen Hui
Hey: On Tue, Mar 24, 2015 at 2:04 PM, Pierre Joye wrote: > On Tue, Mar 24, 2015 at 1:01 PM, Xinchen Hui wrote: >> Hey: >> >> On Tue, Mar 24, 2015 at 1:54 PM, Pierre Joye wrote: >>> On Tue, Mar 24, 2015 at 12:35 PM, Xinchen Hui wrote: >>>> Hey: >>

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey Sent from my iPhone > On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote: > >> On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: >> Hi, >> >> Recently, Xinchen and me worked on optimization that eliminates useless >> reallocations and copying during string concatenation (ZEND_ADD_STRIN

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey: On Tue, Mar 24, 2015 at 5:28 PM, Xinchen Hui wrote: > Hey > > Sent from my iPhone > > On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote: > > On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: >> >> Hi, >> >> Recently, Xinchen and me w

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
much the same, just one using a hardcoded 0 > instead of ex_val. > > Regarding exception-safety - is the problem that doing an EG(exception) > check and releasing the rope is too expensive? that won't work if : > Nikita -- Xinchen Hui @Laruence http://www.laruence.com/ -

[PHP-DEV] is_callable and function_exists with disable_functions

2015-03-26 Thread Xinchen Hui
disabled by disable_functions. function_exisis tell it is not exists but is_callable said it is callable.. do you mind if I change the current behavior of is_callable , to return false on this case? or, at least, change function_exists's behavior instead? thanks -- Xinchen Hu

Re: [PHP-DEV] is_callable and function_exists with disable_functions

2015-03-26 Thread Xinchen Hui
ommand line code on line 1 thanks > > -- > regards, > > Kalle Sommer Nielsen > ka...@php.net > > > -- > regards, > > Kalle Sommer Nielsen > ka...@php.net > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: h

Re: [PHP-DEV] [RFC] Fix the Tenary Operator -- Please!? Please?

2015-03-26 Thread Xinchen Hui
n 7.0 because of the feature freeze, it needs to go > into the next minor version if the RFC passes. We should've pulled the > trigger on this before the feature freeze and we shouldn't have to wait > until 8.0 because of that. > I don't think freeze should block bug fixes... thanks > --Kris -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] is_callable and function_exists with disable_functions

2015-03-26 Thread Xinchen Hui
Hey: On Fri, Mar 27, 2015 at 1:14 PM, Yasuo Ohgaki wrote: > Hi all, > > On Fri, Mar 27, 2015 at 11:57 AM, Xinchen Hui wrote: >> >> On Fri, Mar 27, 2015 at 3:06 AM, Kalle Sommer Nielsen >> wrote: >> > Forgot to CC list >> > >> > >>

Re: [PHP-DEV] is_callable and function_exists with disable_functions

2015-03-27 Thread Xinchen Hui
; > > I wouldn't make any changes in hurry. this should be discussed and analysed > carefully. > > However preventing conversion of disabled functions into opcodes and their > optimization makes full sense. > okey, I will separate these part to a single fix thanks >

Re: [PHP-DEV] Fixing bundled extension version mess

2015-04-14 Thread Xinchen Hui
Hey: Sent from my iPhone > On Apr 15, 2015, at 10:21 AM, Pierre Joye wrote: > > hi, > > We tried that many times but we fail to handle the version of bundled > extensions. > > Along with some installer work and other integration (projects > dependencies management, composer or other), we need

[PHP-DEV] Bug #69640 Unhandled EngineExceptions thrown from userland do not produce any output

2015-05-15 Thread Xinchen Hui
PHP Fatal error: Initilizing a system exception is disallowed will be trigged.. what do you think? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Bug #69640 Unhandled EngineExceptions thrown from userland do not produce any output

2015-05-15 Thread Xinchen Hui
Hey: >> On May 16, 2015, at 12:35 AM, Dan Ackroyd wrote: >> >> On 15 May 2015 at 14:38, Xinchen Hui wrote: >> Hey: >> >> as described in https://bugs.php.net/bug.php?id=69640&thanks=1 >> >> instead of fixing it by exam the error ty

Re: [PHP-DEV] Bug #69640 Unhandled EngineExceptions thrown from userland do not produce any output

2015-05-16 Thread Xinchen Hui
Hey: On Sat, May 16, 2015 at 1:41 AM, Dan Ackroyd wrote: > On 15 May 2015 at 17:12, Xinchen Hui wrote: >>> How would that work when people want to write unit/integration tests >>> to test the behaviour of a module when an EngineException is thrown? >>> >>>

Re: [PHP-DEV] Pull request labels handling

2015-05-27 Thread Xinchen Hui
t; -Hannes > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Bug #69180: Reflection does not honor trait conflict resolution / method aliasing

2015-05-29 Thread Xinchen Hui
Hey: Sent from my iPhone > On May 29, 2015, at 1:57 PM, Sebastian Bergmann wrote: > > Would be nice if somebody could have a look at > https://bugs.php.net/bug.php?id=69180 -- thanks! Actually, I had looked it, but there is no such Infos can be used after compiling is done in current traits

Re: [PHP-DEV] Bug #69180: Reflection does not honor trait conflict resolution / method aliasing

2015-05-31 Thread Xinchen Hui
Hey: On Fri, May 29, 2015 at 5:21 PM, Sebastian Bergmann wrote: > On 05/29/2015 08:59 AM, Xinchen Hui wrote: >> Actually, I had looked it, but there is no such Infos can be >> used after compiling is done in current traits design, so > > But calling C::bar() works, so

Re: [PHP-DEV] PR #1325 - array_column() for array of objects

2015-06-11 Thread Xinchen Hui
y BC I can imagine is when an array is populated with a mixed set of > objects and arrays; any professional would baulk at the idea, but rules of > the jungle are pervasive. > > Before I merge this, are there any objections to shipping this with 7.0? -- Xinchen Hui @Laruence http://

Re: [PHP-DEV] Segfault in master with PHPUnit

2015-06-13 Thread Xinchen Hui
egfault with Alpha 1. maybe related to this : 3cfa58367b1b85d346d9be6cf9ae116c63571247 could you please try again with revert that? thanks > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ --

Re: [PHP-DEV] Segfault in master with PHPUnit

2015-06-13 Thread Xinchen Hui
Hey Bob: On Sun, Jun 14, 2015 at 2:08 PM, Sebastian Bergmann wrote: > Am 14.06.2015 um 07:55 schrieb Xinchen Hui: >> maybe related to this : 3cfa58367b1b85d346d9be6cf9ae116c63571247 > > Yes, reverting that commit fixes it. Thanks for the pointer! please have a look of it.. I&#

Re: [PHP-DEV] Optimizing php_html_entities()

2015-06-23 Thread Xinchen Hui
t; } > echo 'Time: '.(microtime(true) - $start - $loop_time)."\n"; But passing an non-string to htmlspecialchars are not common used cases.. "optimize" not common used cases... will bring nothing to us.. thanks > > > -- > Yasuo Ohgaki > yohg...@

Re: [PHP-DEV] Optimizing php_html_entities()

2015-06-23 Thread Xinchen Hui
Hey: On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki wrote: > Hi Xinchen, > > On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui wrote: >> >> But passing an non-string to htmlspecialchars are not common used cases.. >> >> "optimize" not common used ca

Re: [PHP-DEV] Optimizing php_html_entities()

2015-06-23 Thread Xinchen Hui
Hey: On Wed, Jun 24, 2015 at 10:35 AM, Yasuo Ohgaki wrote: > Hi Xinchen, > > On Wed, Jun 24, 2015 at 11:31 AM, Xinchen Hui wrote: >> >> >> >> >> On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki wrote: >> > Hi Xinchen, >> > >> > On

Re: [PHP-DEV] Optimizing php_html_entities()

2015-06-24 Thread Xinchen Hui
t; $s = 'abcdefgh'; > echo "Escaping string ${s}\n"; > $t = []; > for ($n = 0; $n < ITER; $n++) { > $start = microtime(true); > for ($i = 0; $i < LOOP; $i++) { > htmlspecialchars($s); > } > $time = (microtime(true) - $start - $loop_time); > echo "Time: ${time}\n"; > $t[] = $time; > } > // Remove max for better approximation > unset($t[array_search(max($t), $t)]); > unset($t[array_search(max($t), $t)]); > $time = array_sum($t)/(ITER-2); > echo "Time Avg: ${time}\n"; > > $s = 12345678; > echo "Escaping integer ${s}\n"; > $t = []; > for ($n = 0; $n < ITER; $n++) { > $start = microtime(true); > for ($i = 0; $i < LOOP; $i++) { > htmlspecialchars($s); > } > $time = (microtime(true) - $start - $loop_time); > echo "Time: ${time}\n"; > $t[] = $time; > } > // Remove max for better approximation > unset($t[array_search(max($t), $t)]); > unset($t[array_search(max($t), $t)]); > $time = array_sum($t)/(ITER-2); > echo "Time Avg: ${time}\n"; > > > > -- > Yasuo Ohgaki > yohg...@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Make debug_zval_dump prints int as long

2015-07-24 Thread Xinchen Hui
worrying about this will break some APPs unit tests .. anyway, welting doesn't find any in github.. so, is there any objections to merge this into PHP7.0? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] bug35437.php fails on master?

2015-07-27 Thread Xinchen Hui
be fixed in https://github.com/php/php-src/commit/16d6dfddef5ac43de3b20ffa7818d5b11f4e6a4b could you please verify this? thanks > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Block requests to builtin SQL functions where PHP can prove the call is vulnerable to a potential SQL-injection attack

2015-07-30 Thread Xinchen Hui
ersed. Throwing more bloat into php >> > to create 'WTF' errors just adds to a new users frustration and annoys >> > experienced users who have very good reasons for building queries using >> > clean variables. MANY abstraction layers use variables to add prefixes >> >

Re: [PHP-DEV] Introduction and some opcache SSE related stuff

2015-07-30 Thread Xinchen Hui
thanks >> cycles later), while the time needed to get data from RAM is >100 cycles >> usually.. Nevertheless... they don't heart and it seems they still have a >> very small benefit so I preserved the original instruction and I added a >> new prefetch request for the destination pointer. >> >> Hope it helps, >> Bogdan >> -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Need help finding segfault in php 7

2015-08-14 Thread Xinchen Hui
f > reference counter quirk but I just can't find it. Any help is appreciated. thanks for the ssh access , I finally get the reason of this bug.. I get a simple reproduce script and quick fix. all listed in https://bugs.php.net/bug.php?id=70272&thanks=1 @dmitry: do you see a b

[PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
Hi: I have a new idea, which is simple and also works for Jason/serialized etc. That is Restricting a max length of a buckets list in a hash table. If a bucket's length exceed 1024, any insertion into this bucket will return failure and a warning will be generated. What do you think?

Re: [PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
Hi: I am not sure whether you have understood my point. If an array have more than 1024 buckets in an same bucket list(same index), there must already be an performance issue. Sent from my iPhone 在 2012-1-10,0:41,Stefan Esser 写道: > Hey, > >> That is Restricting a max length of a bucket

[PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
l with the current fix in 5.3. > > On Mon, Jan 9, 2012 at 5:36 PM, Xinchen Hui wrote: >> Hi: >> I have a new idea, which is simple and also works for Jason/serialized etc. >> >> That is Restricting a max length of a buckets list in a hash table. >> >> If

Re: [PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
Sent from my iPhone 在 2012-1-10,1:07,Stefan Esser 写道: > Hello, > >> I am not sure whether you have understood my point. > I understood your point: you want to break HashTables because 1024 colliding > entries could have an performance impact. This could break thousands of > scripts. > > for

Re: [PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
Sent from my iPhone 在 2012-1-10,1:14,Rasmus Lerdorf 写道: > On 01/09/2012 08:50 AM, Xinchen Hui wrote: >> Hi: >>I am not sure whether you have understood my point. >> >>If an array have more than 1024 buckets in an same bucket >> list(same index), the

Re: [PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
Sent from my iPhone 在 2012-1-10,1:18,Xinchen Hui 写道: > Sent from my iPhone > > 在 2012-1-10,1:14,Rasmus Lerdorf 写道: > >> On 01/09/2012 08:50 AM, Xinchen Hui wrote: >>> Hi: >>> I am not sure whether you have understood my point. >>> >>>

Re: [PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
Sent from my iPhone 在 2012-1-10,1:51,Rasmus Lerdorf 写道: > On 01/09/2012 09:18 AM, Xinchen Hui wrote: >> Sent from my iPhone >> >> 在 2012-1-10,1:14,Rasmus Lerdorf 写道: >> >>> On 01/09/2012 08:50 AM, Xinchen Hui wrote: >>>> Hi: >>&

[PHP-DEV] Re: 5.3.9, Hash DoS, release

2012-01-09 Thread Xinchen Hui
ut var one, not the random > (or derived version), can you post it in this thread again for the > record please? Hi, FYI thanks > > If not, we will go final with the current fix in 5.3. > > On Mon, Jan 9, 2012 at 5:36 PM, Xinchen Hui wrote: >> Hi: >>   I have a new i

[PHP-DEV] Please expose zend_vm_get_opcde_handler

2012-02-13 Thread Xinchen Hui
Hi: As dmitry said today, there is no way to get a user opcode handler which can be called *after* a specific built-in handler. So please expose zend_vm_get_opcde_handler. Before 5.4 release. :) Thanks. Sent from my iPad -- PHP Internals - PHP Runtime Development Mailing Li

[PHP-DEV] Re: Please expose zend_vm_get_opcde_handler

2012-02-13 Thread Xinchen Hui
er(zend_uchar opcode, zend_op* op) +ZEND_API opcode_handler_t zend_vm_get_opcode_handler(zend_uchar opcode, zend_op* op) { static const int zend_vm_decode[] = { _UNUSED_CODE, /* 0 */ thanks On Tue, Feb 14, 2012 at 1:13 AM, Xinchen Hui wrote: > H

Re: [PHP-DEV] Re: Please expose zend_vm_get_opcde_handler

2012-02-13 Thread Xinchen Hui
On Tue, Feb 14, 2012 at 3:00 PM, Dmitry Stogov wrote: > In general exposing zend_vm_get_opcode_handler() can't help. > You know that executor might be generated/compiled not only using > call-treading but also using switch or goto. In these cases > zend_vm_get_opcode_handler() won't return a funct

Re: [PHP-DEV] Re: Please expose zend_vm_get_opcde_handler

2012-02-13 Thread Xinchen Hui
On Tue, Feb 14, 2012 at 3:02 PM, Xinchen Hui wrote: > On Tue, Feb 14, 2012 at 3:00 PM, Dmitry Stogov wrote: >> In general exposing zend_vm_get_opcode_handler() can't help. >> You know that executor might be generated/compiled not only using >> call-treading but als

Re: [PHP-DEV] Re: Please expose zend_vm_get_opcde_handler

2012-02-13 Thread Xinchen Hui
On Tue, Feb 14, 2012 at 3:10 PM, Stas Malyshev wrote: > Hi! > > >> but you really remind me, that I shoud also add a flag to detect what >> the vm-kind now... > > > Adding ZEND_API in one place is no problem, but any messing with the engine > is out of the question now. okey, let's just talk about

Re: [PHP-DEV] Re: Please expose zend_vm_get_opcde_handler

2012-02-13 Thread Xinchen Hui
On Tue, Feb 14, 2012 at 3:13 PM, Stas Malyshev wrote: > Hi! > > >> okey, let's just talk about adding ZEND_API. :) > > > But as Dmitry noted, it's only present in one model, so how useful would it > be? I don't want to add patches that are not beneficial for anything but a > very narrow use case.

  1   2   3   4   >