On Wed, Feb 11, 2015 at 4:07 PM, reeze <re...@php.net> wrote: > Hi all, > There are a lot of code use php_error_docref() macro, the first > parameter > mostly is NULL, before PHP7, it looks like: > > php_error_docref(NULL TSRML, E_WARNING, "recursion detected"); > in PHP7 > php_error_docref(NULL, E_WARNING, "recursion detected"); > looks better, but the first parameter look dumb. > > I did a simple statics, there are: > > Null docref: 2530 > Not Null docref: 51 > > I searched on Github, it seems that almost all of the extension use NULL > docref. > > So I propose add a new macro, like: php_error_error_docref_ex(E_WARNING, > "xxx"). > this could make code looks better and the extension maintainer's easier. > > Another option would be just update the php_error_docref() macro to remove > the docref parameter, default to NULL but not add a new macro. > > > What do you think about it? No.
I can't see any benefit from it, but lots of changes. everything works well now. thanks > > [1] https://github.com/php/php-src/pull/1075 > > -- > Reeze Xia > http://reeze.cn -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
