On Thu, Feb 07, 2008 at 07:38:08PM +0300, Dmitry Stogov wrote:
> According to algorithm "used" and "free" in PHP_MD5Final cannot be more
> than 64, so I don't see any reason for unnecessary conversions. Looking
> more careful I think they must be changed into php_uint32 in
> PHP_MD5Update too.
On 07.02.2008 20:05, Dmitry Stogov wrote:
> I'm wondered, how did I change the comment style, because I didn't do it
> by hand. :)
-
The comments in the patch look a bit odd (looks like they were pasted to vim
without :set paste).
Regards,
Stefan
-
=)
--
Wbr,
Antony Dovgal
--
PHP
I'm wondered, how did I change the comment style, because I didn't do it
by hand. :)
Dmitry.
Dmitry Stogov wrote:
Hi,
Solar Designer wrote:
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
I assume now the patch is ready to commit.
I'll commit it tomorrow in case of no objecti
Hi,
Solar Designer wrote:
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
I assume now the patch is ready to commit.
I'll commit it tomorrow in case of no objections.
Yes, it is. No objections from me.
Just two minor points:
1. You have not yet fixed the size_t vs. php_uint3
On 07.02.2008 17:03, Stefan Walk wrote:
> On Thursday 07 February 2008 14:21:15 Dmitry Stogov wrote:
>> Thank you for fix.
>> I assume now the patch is ready to commit.
>> I'll commit it tomorrow in case of no objections.
>>
>> Thanks. Dmitry.
>
> The comments in the patch look a bit odd (looks li
Hi Alexander,
On Feb 7, 2008 3:08 PM, Solar Designer <[EMAIL PROTECTED]> wrote:
> Hi Pierre,
>
> On Thu, Feb 07, 2008 at 03:00:55PM +0100, Pierre Joye wrote:
> > Nice addition but can you please try to keep on thread for the
> > discussions? Thanks :-)
>
> Are you referring to the changing Subjec
Hi Pierre,
On Thu, Feb 07, 2008 at 03:00:55PM +0100, Pierre Joye wrote:
> Nice addition but can you please try to keep on thread for the
> discussions? Thanks :-)
Are you referring to the changing Subject? If so, I prefer Subjects
that reflect message content, whereas threading can, should, and
On Thursday 07 February 2008 14:21:15 Dmitry Stogov wrote:
> Thank you for fix.
> I assume now the patch is ready to commit.
> I'll commit it tomorrow in case of no objections.
>
> Thanks. Dmitry.
The comments in the patch look a bit odd (looks like they were pasted to vim
without :set paste).
R
Hi!
Nice addition but can you please try to keep on thread for the
discussions? Thanks :-)
On Feb 7, 2008 2:53 PM, Solar Designer <[EMAIL PROTECTED]> wrote:
> On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
> > I assume now the patch is ready to commit.
> > I'll commit it tomorrow
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
> I assume now the patch is ready to commit.
> I'll commit it tomorrow in case of no objections.
Yes, it is. No objections from me.
Just two minor points:
1. You have not yet fixed the size_t vs. php_uint32 issue in
PHP_MD5Final(),
Thank you for fix.
I assume now the patch is ready to commit.
I'll commit it tomorrow in case of no objections.
Thanks. Dmitry.
Solar Designer wrote:
I wrote:
OK, I think I found it. ext/hash/php_hash_md.h has this:
#define PHP_MD4Init PHP_MD5Init
which breaks when the t
11 matches
Mail list logo
