On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote: > I assume now the patch is ready to commit. > I'll commit it tomorrow in case of no objections.
Yes, it is. No objections from me. Just two minor points: 1. You have not yet fixed the size_t vs. php_uint32 issue in PHP_MD5Final(), leaving it inconsistent with PHP_MD5Update(). This should not affect correctness of the code, but it's just weird. 2. The way you have re-formatted my comments still looks weird to me. Thanks, Alexander -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
