Hi,
Solar Designer wrote:
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
I assume now the patch is ready to commit.
I'll commit it tomorrow in case of no objections.
Yes, it is. No objections from me.
Just two minor points:
1. You have not yet fixed the size_t vs. php_uint32 issue in
PHP_MD5Final(), leaving it inconsistent with PHP_MD5Update(). This
should not affect correctness of the code, but it's just weird.
According to algorithm "used" and "free" in PHP_MD5Final cannot be more
than 64, so I don't see any reason for unnecessary conversions. Looking
more careful I think they must be changed into php_uint32 in
PHP_MD5Update too.
2. The way you have re-formatted my comments still looks weird to me.
ops. sorry for that. I'll put them in proper place before commit.
Thanks. Dmitry.
Thanks,
Alexander
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
