On Wed, May 6, 2020 at 6:20 PM Xinchen Hui wrote:
>
> Hey:
>
> On Wed, May 6, 2020 at 3:32 PM Christoph M. Becker
> wrote:
>
>> Hi all,
>>
>> since master requires (mostly) C99 compliant compilers anyway, I wonder
>> if we like to update our coding
owadays.
>
> Thoughts?
>
> [1] <https://github.com/php/php-src/blob/master/CODING_STANDARDS.md>
> [2]
> <
> https://github.com/php/php-src/blob/master/CODING_STANDARDS.md#documentation-and-folding-hooks
> >
>
> --
> Christoph M. Becker
>
> --
> PHP Internals
ooking forward to hear from the engine guys. :)
>
FAST_CALL should only affects win32. and it can bring some improvement in
win32..
People should use zif_handler instead of define there own from now on, I
think documented it in UPGRADING is enough
thanks
>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
kes sense (for array)
>
> e.g. $a[$n]++ should change the type of array.
>
I
>
> Thanks. Dmitry.
>
>
> --
> *From:* Xinchen Hui
> *Sent:* Monday, October 30, 2017 10:05:30 AM
> *To:* Derick Rethans
> *Cc:* Dmitry Stogov; Nikita Popov;
tps://derickrethans.nl | https://xdebug.org | https://dram.io
> Like Xdebug? Consider a donation: https://xdebug.org/donate.php
> twitter: @derickr and @xdebug
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
st_shutdown problems, maybe we could
change it to :
fast_shutdown =
#if ZEND_DEBUG
!report_memleaks &&
#endif
is_zend_mm && !full_table_clean;
),
anyway, this feature is already exists in opcache for quite a long time, so
I think could commit it.
thanks
>
> Thanks. Dmitry.
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
The real problem is:
we are expecting __debugInfo always returns array, but it doesn't if
exception is threw.
so, if we keep the exception, then we need inserts checks for
exception (no array) after every debugInfo is called, or, make a FATAL
error like the way I did
however, I think latter is better, but maybe we could improve the
fatal error message:
" Fatal error, __debugInfo must return an array, but an exception
with " msg" is threw"
thanks
>
> Thanks
>
> Anatol
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
> Zend/bench.php 2>&1 | less
>
> As I mentioned we didn't try to achieve any real performance improvement
> yet, although we do currently see 20% speedup on bench.php, but a bit of a
> slowdown on real-life apps.
>
Actually, if you are lucky like me, you may see l
means alwasy start with index 0,
like:
$array = array(1 => 1, 2, 3, 4, 5, 6);
this is also a packed array
so, we can not do such opt only if offset == 0
thanks
>
> Ben
>
>
> == Original ==
> From: Xinchen Hui
> To: Benjamin Coutu
> Date: Tue,
_value, zcolval);
}
if zkey is NULL(index_key), then only add_next_index_zval is executed.
do you have any reproduce script to show the broken?
thanks
>
> Cheers,
>
> Benjamin
>
> == Original ==
> From: Xinchen Hui
> To: Benjamin Coutu
2b8503a45
thanks
>
> Please let me know your thoughts.
>
> Thanks,
>
> Ben
>
> --
>
> Bejamin Coutu
> ben.co...@zeyos.com
>
> ZeyOS, Inc.
> http://www.zeyos.com
>
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
e to commit your idea?
thanks
>
> Thanks,
>
> Ben
>
> --
>
> Bejamin Coutu
> ben.co...@zeyos.com
>
> ZeyOS, Inc.
> http://www.zeyos.com
>
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
, however, we can not remove
zend_qsort, because its a ZEND_API , some third extensions may use it.
thanks
> Thanks,
>
> Ben
>
> --
>
> Bejamin Coutu
> ben.co...@zeyos.com
>
> ZeyOS, Inc.
> http://www.zeyos.com
>
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
ere. I have been hitting annoying segfaults in 7.0 that
> will likely be helped by this.
>
No objections here neither, I already tried enable it in 7.0 :)
thanks
>
> -Rasmus
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
com/php/php-src/commit/40702799b5f08b093477098881b6e0cfcb3ea411
)
to -1
I think it's better also include this into the patch?
thanks
>
>
> Thanks. Dmitry.
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
work in 7.0 neither.
it will result in fatal error: PHP Fatal error: Cannot re-assign $this
thanks
>
> https://wiki.php.net/rfc/this_var
>
>
> Thanks. Dmitry.
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
triggers that recursion check. But
>
the array might be stored in shared memory(immutable array), in this case,
you should not edit the apply count ,
you should check it, like what json does:
https://github.com/php/php-src/blob/master/ext/json/json_encoder.c#L156
thanks
it's not always, and a php-fpm restart can make it go away.
>
> Can anyone think of why this might happen?
>
> Thanks,
> Adam
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
in PHP 7.1?
>
you could try https://github.com/laruence/yac
it's a "A fast shared memory user data cache for PHP "
thanks
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
H_OBJ_R UNUSED,
>> CONST -> TMP; RETURN TMP).
>>
>> Then INIT_METHOD_CALL may check this flag and execute "optimized code
>> sequence" instead of pushing stack frame and real call.
>>
>>
>> However, I'm not sure what kind of performance impact this
7.1, right?)
the value caller want to pass in should goes via arguments, which is a
more reasonable way.
thanks
>
>
> https://gist.github.com/dstogov/5550827aa695ff8cb803
>
>
> The tricky way was used in phpdbg only, but that code doesn't work, and
> should be fixed anyway.
>
>
> Thanks. Dmitry.
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
> --
> Regards,
> Mike
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
k.
otherwise, restore the exception, then goes like a new exception is
throw(jmp to a CATCH block or leave current function which will result
ZEND_HANDLE_EXCEPTION again).
- I can't come up with PHP code that sets extended_value here either.
>
try {
try {
} finally {
} /* this fast_ret will set to RET_TO_CATCH */
} catch () {
}
try {
try {
} finally {
} /* this fast_ret will set to RET_TO_FINALLY */
} finally {
}
thanks
> Can you?
thanks
>
> cheers,
> Derick
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
oo, so…
>
and also valgrind, which is quite useful, since it takes too long to run in
laptop.
thanks
>
> Anyway, you’ve probably got to talk to Nuno; IIRC he was/is managing the
> gcov box.
>
> Cheers,
> Mike
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
01e55
now it will print:
Zend OPcache
Opcode Caching => Up and Running
Optimization => Enabled
SHM Cache => Disabled
File Cache => Enabled
Startup => OK
thanks
> Thanks :)
>
> // Tom
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
ntial. If you are not an
> intended recipient, please notify the sender by return e-mail and delete
> this e-mail and any attachments. Certain required legal entity disclosures
> can be accessed on our website.<
> http://site.thomsonreuters.com/site/disclosures/>
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
Hey:
On Tue, Dec 22, 2015 at 7:41 PM, Xinchen Hui wrote:
> Hey：
>
> Sent from my iPhone
>
> > On Dec 22, 2015, at 18:23, Lester Caine wrote:
> >
> > On 22/12/15 08:43, Xinchen Hui wrote:
> >>> Here is a working patch of mine:
> >> ht
Hey：
Sent from my iPhone
> On Dec 22, 2015, at 18:23, Lester Caine wrote:
>
> On 22/12/15 08:43, Xinchen Hui wrote:
>>> Here is a working patch of mine:
>> https://gist.github.com/laruence/f3af903012902818d7da
>>
>> if you are going to work on this, ple
his one.
since I still don't have setup a evn to test it... so there might be some
problems
thanks
> Thanks
>
> Anatol
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
uild/tests after your commits:
> https://travis-ci.org/php/php-src/branches
>
> At the moment ext/session/tests/bug32330.phpt fails for 5.6, 7.0 and
> master.
>
most of them relates to session, Yasuo, could you please have a look
into them?
thanks
>
> Thanks,
>
Hey：
> On Nov 30, 2015, at 22:48, Rowan Collins wrote:
>
> Andreas Heigl wrote on 30/11/2015 12:23:
>>> Am 30.11.15 um 13:18 schrieb Peter Cowburn:
>>> class A {
const TEST = false;
public function test() {
var_dump(static::TEST);
}
}
class
Hey:
On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov wrote:
> On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui wrote:
>
>> Hey:
>>
>>
>>
>> On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand wrote:
>>
>> > > Am 24.11.2015 um 20:30 schrieb Matteo Becc
Hey:
On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov wrote:
> On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui wrote:
>
>> Hey:
>>
>>
>>
>> On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand wrote:
>>
>> > > Am 24.11.2015 um 20:30 schrieb Matteo Becc
int result a compiler
error, which seems a little in-consistent.
thanks
> Bob
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
lso go for a)
thanks
>
> If something is found, it doesn't make the release any less high quality.
> Any bugs that would be found between now and the 3rd will still be found
> (and probably more), and they will still be fixed. The only difference
> would be a 0.0.1 version number.
>
> /2c
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
ey pick up point releases" may be
> true for some, but the history is there that has caused MANY open
> source projects a TON of pain. So it's definitely not something to
> brush off.
>
> I'm less concerned by the specific issue here than by the 2 facts that
> surround it: It was known by engine maintainers for months, and the
>
I get a little confused, who said this was known months ago?
thanks
> cavalier attitude around what defines "stable". Both of these are far
> more critical and worth delaying to "get right" than this particular
> "bug" is...
>
> Anthony
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
uld go with more RC, sure. However
> in
> > that case IMO we would catch bugs at very low speed with no guarantee we
> > have a good thing at the end when we "think" it's good. This will cause
> us
> > to defer things for much longer time. Releasing on 26th (or on 3rd with
> > respect to Thanksgiving, if there are still strong concerns) were IMHO
> > convenient for this reasons.
> >
> > People that don't test RC won't start to test any later RC anyway. People
> > that don't test RC will start to use GA and that will lead to bug
> reports,
> > in any case. So IMHO at this point we are good enough to do the first
> > release with all the known bugs fixed, with the knowledge that no
> critical
> > bugs are present, with the knowledge that community projects like Drupal
> 8,
> > Symfony, etc. report the green tests, and with intention to get people
> > waiting for GA involved.
> >
> > Regards
> >
> > Anatol
> >
> >
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
hether it's okey for PHP-7.0.
will discuss with welting and Dmitry on Monday.
thanks
>
> Thoughts?
> Anthony
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
On Wed, Nov 11, 2015 at 11:10 AM, Xinchen Hui wrote:
> Hey:
>
> On Tue, Nov 10, 2015 at 7:29 PM, Dmitry Stogov wrote:
>
>>
>>
>> On Tue, Nov 10, 2015 at 1:42 PM, Nikita Popov
>> wrote:
>>
>>> On Tue, Nov 10, 2015 at 10:53 AM, Dmitry Stogov wr
like: previously we emit: ZEND_ADD, ZEND_FAST_CALL, ZEND_RETURN.
now we emit: ZEND_ADD, ZEND_RETURN, ZEND_FAST_CALL, ZEND_RETURN
then in HANDLE_EXCEPTION we can dtor EX(return_value) if it is
already set?
this could also fixed double return memory leak
like Zend/tests/try/bug70228.phpt
thanks
>
> Thanks. Dmitry,
>
>
>
>>
>> Nikita
>>
>>
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
e review and verify this once again,
> then add necessary tests and commit.
>
No problem, all issues we met are resovled , thanks :)
tested and committed.
and aslo thanks the fabian who provides us ssh access to a reproducible box
(it's really hard to reproduce locally)
thanks!
>
> Thanks. Dmitry.
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
erged.
thanks
>
> (I realize there's a lot overhead, but that's because I try to have a not
> too synthetic benchmark; but at least these methods are the bottleneck of
> most HTTP/2 traffic in this server app, so, if I can speed these up, it
> will be significant.)
>
> Bob
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
dy fixed it. :)
thanks
>
>
> Thanks. Dmitry.
>
> On Thu, Oct 22, 2015 at 5:43 AM, Xinchen Hui wrote:
>
>> Hey:
>>
>>
>>
>> On Wed, Oct 21, 2015 at 10:38 PM, Derick Rethans wrote:
>>
>>> On Tue, 20 Oct 2015, Bob Weinand wrote:
>>>
&
e miss? is it doable?
>>
>> I'm not sure if patritioning data of op_array, into frequntly and rarely
>> used, may make any significant difference. Because we usually work only
>> with a single instance of op_array in each moment. Fields reordering alrecy
>> helped to reduce cache-misses. But I may be wrog :)
>>
>> Thanks. Dmitry.
>>
>> >
>> >
>> >
>> > Cheers,
>> > Yo-An Lin
>> > https://github.com/c9s
>> >
>>
>
>
>
> --
> Best Regards,
>
> Yo-An Lin
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
Hey:
On Wed, Oct 21, 2015 at 10:38 PM, Derick Rethans wrote:
> On Tue, 20 Oct 2015, Bob Weinand wrote:
>
> > > Am 20.10.2015 um 18:08 schrieb Derick Rethans :
> > >
> > > On Tue, 20 Oct 2015, Bob Weinand wrote:
> > >
> > >>> Am 20.10.2
+bob
On Tue, Oct 20, 2015 at 11:11 PM, Xinchen Hui wrote:
> Hey:
>
>
>
> On Tue, Oct 20, 2015 at 10:45 PM, Derick Rethans wrote:
>
>> Hi!
>>
>> When hacking on Xdebug for PHP 7, I ran into some issues where PHP would
>> just spin around. This hap
ttp://xdebug.org/donate.php
> twitter: @derickr and @xdebug
> Posted with an email client that doesn't mangle email: alpine
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
;
hmm, I understand your ideas, but I think maybe we should forbid such
things as well for this moment, because it make things complicated to
judge(if it is critical or not), such things can goes to 7.1
let's only allows bugs fix (as you mentioned above) to be committed into
PHP-7.0 before the final release of its
thanks
>
> Hopefully I could express myself better now. Cherry-pick is of course a
> solution, but IMHO it is important every dev to understand the unique
> situation we currently have to face. It is better to avoid cherry-picking
> in favor of the "mission aware" code :)
> Regards
>
> Anatol
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
work is right.
Just for the record , Taint is ready for PHP7:
https://github.com/laruence/taint/tree/php7
thanks
> --
> Stas Malyshev
> smalys...@gmail.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
-
test "$PHP_OPCACHE_FILE" == "yes"; then
>> AC_DEFINE(HAVE_OPCACHE_FILE_CACHE, 1, [Define to enable file based
>> caching (experimental)])
>>fi
>>
>> + if test "$PHP_HUGE_CODE_PAGES" == "yes"; then
>> +AC_DEFINE(HAVE_HUGE_CODE_PAGES, 1, [Define to enable copying PHP CODE
>> pages into HUGE PAGES (experimental)])
>> + fi
>> +
>>AC_CHECK_FUNC(mprotect,[
>> AC_DEFINE(HAVE_MPROTECT, 1, [Define if you have mprotect() function])
>>])
>> diff --git a/ext/opcache/zend_accelerator_module.c
>> b/ext/opcache/zend_accelerator_module.c
>> index eb93f59..5dfa8c1 100644
>> --- a/ext/opcache/zend_accelerator_module.c
>> +++ b/ext/opcache/zend_accelerator_module.c
>> @@ -309,6 +309,9 @@ ZEND_INI_BEGIN()
>> STD_PHP_INI_ENTRY("opcache.file_cache_only" , "0"
>> , PHP_INI_SYSTEM, OnUpdateBool, accel_directives.file_cache_only,
>> zend_accel_globals, accel_globals)
>> STD_PHP_INI_ENTRY("opcache.file_cache_consistency_checks" , "1"
>> , PHP_INI_SYSTEM, OnUpdateBool,
>> accel_directives.file_cache_consistency_checks, zend_accel_globals,
>> accel_globals)
>> #endif
>> +#ifdef HAVE_HUGE_CODE_PAGES
>> + STD_PHP_INI_BOOLEAN("opcache.enable_huge_code_pages" , "1"
>> , PHP_INI_SYSTEM, OnUpdateBool,
>> accel_directives.enable_huge_code_pages,zend_accel_globals,
>> accel_globals)
>> +#endif
>> ZEND_INI_END()
>>
>> static int filename_is_in_cache(zend_string *filename)
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hey:
On Tue, Sep 8, 2015 at 9:23 AM, Ryan Pallas wrote:
>
> On Mon, Sep 7, 2015 at 7:11 PM, Xinchen Hui wrote:
>>
>>
>>
>> Sent from my iPhone
>>
>> > On Sep 8, 2015, at 02:09, Andrea Faulds wrote:
>> >
>> > Hi Stas,
>> >
Sent from my iPhone
> On Sep 8, 2015, at 02:09, Andrea Faulds wrote:
>
> Hi Stas,
>
> Stanislav Malyshev wrote:
>>
>> Private and protected methods and properties are private for a reason -
>> they may be radically changed or gone when the code is changing, and
>> thus external code should n
;
>> the shear number of tokens to follow, not to mention that I need to
>> pay attention to the use-blocks which may or may not be importing
>> certain variables. The bottom reads exactly how I would expect it to.
>
> That's because you wrote it and know in advance
f
> reference counter quirk but I just can't find it. Any help is appreciated.
thanks for the ssh access , I finally get the reason of this bug..
I get a simple reproduce script and quick fix. all listed in
https://bugs.php.net/bug.php?id=70272&thanks=1
@dmitry: do you see a b
thanks
>> cycles later), while the time needed to get data from RAM is >100 cycles
>> usually.. Nevertheless... they don't heart and it seems they still have a
>> very small benefit so I preserved the original instruction and I added a
>> new prefetch request for the destination pointer.
>>
>> Hope it helps,
>> Bogdan
>>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
ersed. Throwing more bloat into php
>> > to create 'WTF' errors just adds to a new users frustration and annoys
>> > experienced users who have very good reasons for building queries using
>> > clean variables. MANY abstraction layers use variables to add prefixes
>> >
be fixed in
https://github.com/php/php-src/commit/16d6dfddef5ac43de3b20ffa7818d5b11f4e6a4b
could you please verify this?
thanks
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
worrying about this will break some APPs unit tests
.. anyway, welting doesn't find any in github..
so, is there any objections to merge this into PHP7.0?
thanks
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe,
t; $s = 'abcdefgh';
> echo "Escaping string ${s}\n";
> $t = [];
> for ($n = 0; $n < ITER; $n++) {
> $start = microtime(true);
> for ($i = 0; $i < LOOP; $i++) {
> htmlspecialchars($s);
> }
> $time = (microtime(true) - $start - $loop_time);
> echo "Time: ${time}\n";
> $t[] = $time;
> }
> // Remove max for better approximation
> unset($t[array_search(max($t), $t)]);
> unset($t[array_search(max($t), $t)]);
> $time = array_sum($t)/(ITER-2);
> echo "Time Avg: ${time}\n";
>
> $s = 12345678;
> echo "Escaping integer ${s}\n";
> $t = [];
> for ($n = 0; $n < ITER; $n++) {
> $start = microtime(true);
> for ($i = 0; $i < LOOP; $i++) {
> htmlspecialchars($s);
> }
> $time = (microtime(true) - $start - $loop_time);
> echo "Time: ${time}\n";
> $t[] = $time;
> }
> // Remove max for better approximation
> unset($t[array_search(max($t), $t)]);
> unset($t[array_search(max($t), $t)]);
> $time = array_sum($t)/(ITER-2);
> echo "Time Avg: ${time}\n";
>
>
>
> --
> Yasuo Ohgaki
> yohg...@ohgaki.net
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hey:
On Wed, Jun 24, 2015 at 10:35 AM, Yasuo Ohgaki wrote:
> Hi Xinchen,
>
> On Wed, Jun 24, 2015 at 11:31 AM, Xinchen Hui wrote:
>>
>>
>>
>>
>> On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki wrote:
>> > Hi Xinchen,
>> >
>> > On
Hey:
On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki wrote:
> Hi Xinchen,
>
> On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui wrote:
>>
>> But passing an non-string to htmlspecialchars are not common used cases..
>>
>> "optimize" not common used ca
t; }
> echo 'Time: '.(microtime(true) - $start - $loop_time)."\n";
But passing an non-string to htmlspecialchars are not common used cases..
"optimize" not common used cases... will bring nothing to us..
thanks
>
>
> --
> Yasuo Ohgaki
> yohg...@
Hey Bob:
On Sun, Jun 14, 2015 at 2:08 PM, Sebastian Bergmann wrote:
> Am 14.06.2015 um 07:55 schrieb Xinchen Hui:
>> maybe related to this : 3cfa58367b1b85d346d9be6cf9ae116c63571247
>
> Yes, reverting that commit fixes it. Thanks for the pointer!
please have a look of it.. I&#
egfault with Alpha 1.
maybe related to this : 3cfa58367b1b85d346d9be6cf9ae116c63571247
could you please try again with revert that?
thanks
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
y BC I can imagine is when an array is populated with a mixed set of
> objects and arrays; any professional would baulk at the idea, but rules of
> the jungle are pervasive.
>
> Before I merge this, are there any objections to shipping this with 7.0?
--
Xinchen Hui
@Laruence
http://
Hey:
On Fri, May 29, 2015 at 5:21 PM, Sebastian Bergmann wrote:
> On 05/29/2015 08:59 AM, Xinchen Hui wrote:
>> Actually, I had looked it, but there is no such Infos can be
>> used after compiling is done in current traits design, so
>
> But calling C::bar() works, so
Hey：
Sent from my iPhone
> On May 29, 2015, at 1:57 PM, Sebastian Bergmann wrote:
>
> Would be nice if somebody could have a look at
> https://bugs.php.net/bug.php?id=69180 -- thanks!
Actually, I had looked it, but there is no such Infos can be used after
compiling is done in current traits
t; -Hannes
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hey:
On Sat, May 16, 2015 at 1:41 AM, Dan Ackroyd wrote:
> On 15 May 2015 at 17:12, Xinchen Hui wrote:
>>> How would that work when people want to write unit/integration tests
>>> to test the behaviour of a module when an EngineException is thrown?
>>>
>>>
Hey：
>> On May 16, 2015, at 12:35 AM, Dan Ackroyd wrote:
>>
>> On 15 May 2015 at 14:38, Xinchen Hui wrote:
>> Hey:
>>
>> as described in https://bugs.php.net/bug.php?id=69640&thanks=1
>>
>> instead of fixing it by exam the error ty
PHP Fatal error: Initilizing a system exception is disallowed
will be trigged..
what do you think?
thanks
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hey：
Sent from my iPhone
> On Apr 15, 2015, at 10:21 AM, Pierre Joye wrote:
>
> hi,
>
> We tried that many times but we fail to handle the version of bundled
> extensions.
>
> Along with some installer work and other integration (projects
> dependencies management, composer or other), we need
;
>
> I wouldn't make any changes in hurry. this should be discussed and analysed
> carefully.
>
> However preventing conversion of disabled functions into opcodes and their
> optimization makes full sense.
>
okey, I will separate these part to a single fix
thanks
>
Hey:
On Fri, Mar 27, 2015 at 1:14 PM, Yasuo Ohgaki wrote:
> Hi all,
>
> On Fri, Mar 27, 2015 at 11:57 AM, Xinchen Hui wrote:
>>
>> On Fri, Mar 27, 2015 at 3:06 AM, Kalle Sommer Nielsen
>> wrote:
>> > Forgot to CC list
>> >
>> >
>>
n 7.0 because of the feature freeze, it needs to go
> into the next minor version if the RFC passes. We should've pulled the
> trigger on this before the feature freeze and we shouldn't have to wait
> until 8.0 because of that.
>
I don't think freeze should block bug fixes...
thanks
> --Kris
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
ommand line code on line 1
thanks
>
> --
> regards,
>
> Kalle Sommer Nielsen
> ka...@php.net
>
>
> --
> regards,
>
> Kalle Sommer Nielsen
> ka...@php.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: h
disabled by disable_functions.
function_exisis tell it is not exists but is_callable said it is
callable..
do you mind if I change the current behavior of is_callable , to
return false on this case?
or, at least, change function_exists's behavior instead?
thanks
--
Xinchen Hu
much the same, just one using a hardcoded 0
> instead of ex_val.
>
> Regarding exception-safety - is the problem that doing an EG(exception)
> check and releasing the rope is too expensive?
that won't work if :
> Nikita
--
Xinchen Hui
@Laruence
http://www.laruence.com/
-
Hey:
On Tue, Mar 24, 2015 at 5:28 PM, Xinchen Hui wrote:
> Hey
>
> Sent from my iPhone
>
> On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote:
>
> On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote:
>>
>> Hi,
>>
>> Recently, Xinchen and me w
Hey
Sent from my iPhone
> On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote:
>
>> On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote:
>> Hi,
>>
>> Recently, Xinchen and me worked on optimization that eliminates useless
>> reallocations and copying during string concatenation (ZEND_ADD_STRIN
Hey:
On Tue, Mar 24, 2015 at 2:04 PM, Pierre Joye wrote:
> On Tue, Mar 24, 2015 at 1:01 PM, Xinchen Hui wrote:
>> Hey:
>>
>> On Tue, Mar 24, 2015 at 1:54 PM, Pierre Joye wrote:
>>> On Tue, Mar 24, 2015 at 12:35 PM, Xinchen Hui wrote:
>>>> Hey:
>>
Hey:
On Tue, Mar 24, 2015 at 1:54 PM, Pierre Joye wrote:
> On Tue, Mar 24, 2015 at 12:35 PM, Xinchen Hui wrote:
>> Hey:
>>
>> On Tue, Mar 24, 2015 at 1:31 PM, Pierre Joye wrote:
>>> hi!
>>>
>>> On Tue, Mar 24, 2015 at 5:41 AM, Dmitry Stogov wr
ons only and it is not a small change at this stage (post
> features freeze). It sounds like a possible maintenance pain. Taking
Actually, it's not.
previously we have ADD_STRING/CHAR/VAR and CONCAT
the 2nd branch cleanup these, and now we only deal with one type concat_list. :)
thanks
&
Hey:
On Fri, Mar 20, 2015 at 9:14 PM, Xinchen Hui wrote:
> Hey:
>
> On Fri, Mar 20, 2015 at 7:53 PM, Alain Williams wrote:
>> On Fri, Mar 20, 2015 at 10:46:58PM +1100, Pierre Joye wrote:
>>> On Fri, Mar 20, 2015 at 7:03 PM, Wei Dai wrote:
>>> &g
to do this, regardless of what mechanism is eventually
> chosen.
I also +1 for this.
if there is no objections raises, I am going to merge it tomorrow..
thanks
>
> --
> Alain Williams
> Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT
> Lecturer.
> +4
e
> CoerciveSTH RFC. I hope many of us see the benefits of the RFC also.
>
> BTW, I suggest to remove the word "strict" from "strict_types" at least as
> it is
> not strict at all if caller(parent script) does not specify
> "strict_types=1".
>
>
Hey:
On Mon, Mar 16, 2015 at 11:32 PM, Peter Cowburn wrote:
> On 16 March 2015 at 14:59, Xinchen Hui wrote:
>
>> Hey:
>>
>> On Mon, Mar 16, 2015 at 5:45 PM, Peter Cowburn
>> wrote:
>> > On 16 March 2015 at 01:40, Wei Dai wrote:
>> >
>> &
er
> RFC
bc break..(change the callback's signature)
>
> And give a few links to historical discussions in the same sort of area?
> E.g Laruence's RFC: https://wiki.php.net/rfc/second_arg_to_preg_callback and
> its discussion thread (http://php.markmail.org/thread/qwiyq5o2vwlbdcz
can revisit casting rules in the future without time pressure, and in
> general, see how this new feature is accepted and used.
>
>
>
> Again, I call upon everybody to vote Yes for the Dual Mode RFC to ensure
> that we have some form of STH in PHP 7.0.
Unecessary for everybody, one or
Hey:
On Mon, Mar 16, 2015 at 9:32 PM, Pascal Chevrel wrote:
> Le 16/03/2015 12:39, Xinchen Hui a écrit :
>>
>> Hey:
>
>
>>
>> And last comment, if there no such declare thing, I will definitely
>> vote yes to this RFC.
>
>
> Hi Xinchen,
>
Hey:
On Mon, Mar 16, 2015 at 7:33 PM, Yasuo Ohgaki wrote:
> Hi Derick,
>
> On Mon, Mar 16, 2015 at 8:18 PM, Derick Rethans wrote:
>>
>> On Mon, 16 Mar 2015, Xinchen Hui wrote:
>>
>> > On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye
>> > wrote:
>&g
On Mon, Mar 16, 2015 at 7:32 PM, Xinchen Hui wrote:
> Hey:
>
> On Mon, Mar 16, 2015 at 7:18 PM, Derick Rethans wrote:
>> On Mon, 16 Mar 2015, Xinchen Hui wrote:
>>
>>> On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye wrote:
>>> >
>>&
Hey:
On Mon, Mar 16, 2015 at 7:18 PM, Derick Rethans wrote:
> On Mon, 16 Mar 2015, Xinchen Hui wrote:
>
>> On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye wrote:
>> >
>> > On Mar 16, 2015 4:29 PM, "Xinchen Hui" wrote:
>> >>
>> >>
Hey:
On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye wrote:
> Hi,
>
> On Mar 16, 2015 4:29 PM, "Xinchen Hui" wrote:
>>
>> Hey:
>>
>> The most unaccept feature in current STH thing(v.5.0) is this.
>>
>> acutaly, I believe
- PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hey:
On Mon, Mar 16, 2015 at 2:03 PM, Matthew Leverton wrote:
> On Mon, Mar 16, 2015 at 12:55 AM, Xinchen Hui wrote:
>> That is why I don't see it before (thousand times, too long to read...
>> but not in RFC)
>>
> It's in the RFC: "Whether or not the fu
ink this is a good addition after we removed /e
if you objections raise in couple days, I will merge this.
thanks
>
>
> —
> Best,
> Wei Dai
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hey:
On Mon, Mar 16, 2015 at 1:49 PM, Dennis Birkholz wrote:
> Hello Xinchen,
>
> Am 16.03.2015 um 06:28 schrieb Xinchen Hui:
>> lib.php
>> >declare(strict_types = 1);
>>function add(int $a, int $b) {
>>}
>>
right?
thanks
--
Xinchen Hui
@Laruence
http://www.laruence.com/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hey:
On Sat, Mar 14, 2015 at 8:01 PM, Bob Weinand wrote:
>> Am 13.03.2015 um 05:01 schrieb Xinchen Hui :
>>
>> Hey:
>>
>> We have CALL SWITCH GOTO vm kind supports for long time.
>>
>> And we use CALL for default.
>>
>> SWITCH GOT
xecute_data); won't work with CALL and global
> CPU registers s well :(
that exactly how the problem came to my :)
thanks
>
> Thanks. Dmitry.
>
>
>
> On Fri, Mar 13, 2015 at 7:01 AM, Xinchen Hui wrote:
>>
>> Hey:
>>
>> We have CAL
1 - 100 of 302 matches
Mail list logo
