> On Thursday 07 February 2008, Lukas Kahwe Smith wrote:
>> On 07.02.2008, at 00:59, Pierre Joye wrote:
>> > Hi Andi,
>> >
>> > On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote:
>> >> -1
>> >>
>> >> Suggestion to enhance the suggestion: return false + emit E_STRICT
>> >> message (but
Hi,
I'm having a terrible time removing a memory leak in pecl/phar that is
caused by a zval_dtor() call in zlib_filter.c. I think the source of
the problem is that zlib_filter's creation function uses SEPARATE_ZVAL()
to separate from the passed in filter parameters. Unfortunately, I
don't think
On Thursday 07 February 2008, Lukas Kahwe Smith wrote:
> On 07.02.2008, at 00:59, Pierre Joye wrote:
> > Hi Andi,
> >
> > On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote:
> >> -1
> >>
> >> Suggestion to enhance the suggestion: return false + emit E_STRICT
> >> message (but I am also
On Fri, 1 Feb 2008 22:11:54 +0100, "Pierre Joye" <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Globally -1. I'm against any CLA in php.net. It was a mistake in the
> first place to accept restricted modules. There is many repositories
> out there, and the companies that need a CLA also have the resource
Marcus Boerger wrote:
> helly Thu Feb 7 18:40:29 2008 UTC
>
> Modified files:
> /php-src README.UNICODE-UPGRADES
> /php-src/main snprintf.c spprintf.c
> Log:
> - Add %Z to *printf
>
> http://cvs.php.net/viewvc.cgi/php-src/README.UNICODE-UPGRADES?r1=1.
On Wed, 30 Jan 2008 11:59:42 -0800, Rasmus Lerdorf <[EMAIL PROTECTED]> wrote:
> Greg Beaver wrote:
>> Dmitry Stogov wrote:
>>> The feature is very useful, however, I agree, the syntax would be
>>> better. :)
>>> The current syntax:
>>>
>>> $var = <<<'TEXT'
>>> text
>>> TEXT;
>>
>> I would like to
Hi,
A short update on improvements to phar
* Phar::webPhar() now works with CGI sapi (endless redirect happened
before)
* Phar::webPhar() now recognizes urls exactly the same way as apache,
so http://localhost/myphar.phar/file.php/extra/stuff will find
"file.php" hidden in the url and retrieve
On Thu, Feb 07, 2008 at 07:38:08PM +0300, Dmitry Stogov wrote:
> According to algorithm "used" and "free" in PHP_MD5Final cannot be more
> than 64, so I don't see any reason for unnecessary conversions. Looking
> more careful I think they must be changed into php_uint32 in
> PHP_MD5Update too.
On 07.02.2008 20:05, Dmitry Stogov wrote:
> I'm wondered, how did I change the comment style, because I didn't do it
> by hand. :)
-
The comments in the patch look a bit odd (looks like they were pasted to vim
without :set paste).
Regards,
Stefan
-
=)
--
Wbr,
Antony Dovgal
--
PHP
I'm wondered, how did I change the comment style, because I didn't do it
by hand. :)
Dmitry.
Dmitry Stogov wrote:
Hi,
Solar Designer wrote:
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
I assume now the patch is ready to commit.
I'll commit it tomorrow in case of no objecti
Hi,
Solar Designer wrote:
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
I assume now the patch is ready to commit.
I'll commit it tomorrow in case of no objections.
Yes, it is. No objections from me.
Just two minor points:
1. You have not yet fixed the size_t vs. php_uint3
Bah. You're right. I glanced over it.
Guess my Russian's not as good as I thought it was to miss a city
name like that.
On Feb 7, 2008 10:43 AM, Vesselin Kenashkov <[EMAIL PROTECTED]> wrote:
> location: г. Москва
>
> in translation: city of Moscow
>
>
> 2008/2/7 Daniel Brown <[EMAIL PRO
location: г. Москва
in translation: city of Moscow
2008/2/7 Daniel Brown <[EMAIL PROTECTED]>:
>If people want to SPAM about a seminar, why not at least mention
> where it's going to be held? :-\
>
If people want to SPAM about a seminar, why not at least mention
where it's going to be held? :-\
2008/2/7 Аленка <[EMAIL PROTECTED]>:
> Навыки эффективности. Умение управлять собой и временемДата проведения
> семинара: Одиннадцатое - двенадцатое февраля 2OO8 г.
> Продолжительность: 2 дня
>
On 07.02.2008 17:03, Stefan Walk wrote:
> On Thursday 07 February 2008 14:21:15 Dmitry Stogov wrote:
>> Thank you for fix.
>> I assume now the patch is ready to commit.
>> I'll commit it tomorrow in case of no objections.
>>
>> Thanks. Dmitry.
>
> The comments in the patch look a bit odd (looks li
Hi Alexander,
On Feb 7, 2008 3:08 PM, Solar Designer <[EMAIL PROTECTED]> wrote:
> Hi Pierre,
>
> On Thu, Feb 07, 2008 at 03:00:55PM +0100, Pierre Joye wrote:
> > Nice addition but can you please try to keep on thread for the
> > discussions? Thanks :-)
>
> Are you referring to the changing Subjec
Hi Pierre,
On Thu, Feb 07, 2008 at 03:00:55PM +0100, Pierre Joye wrote:
> Nice addition but can you please try to keep on thread for the
> discussions? Thanks :-)
Are you referring to the changing Subject? If so, I prefer Subjects
that reflect message content, whereas threading can, should, and
On Thursday 07 February 2008 14:21:15 Dmitry Stogov wrote:
> Thank you for fix.
> I assume now the patch is ready to commit.
> I'll commit it tomorrow in case of no objections.
>
> Thanks. Dmitry.
The comments in the patch look a bit odd (looks like they were pasted to vim
without :set paste).
R
Hi!
Nice addition but can you please try to keep on thread for the
discussions? Thanks :-)
On Feb 7, 2008 2:53 PM, Solar Designer <[EMAIL PROTECTED]> wrote:
> On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
> > I assume now the patch is ready to commit.
> > I'll commit it tomorrow
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
> I assume now the patch is ready to commit.
> I'll commit it tomorrow in case of no objections.
Yes, it is. No objections from me.
Just two minor points:
1. You have not yet fixed the size_t vs. php_uint32 issue in
PHP_MD5Final(),
Thank you for fix.
I assume now the patch is ready to commit.
I'll commit it tomorrow in case of no objections.
Thanks. Dmitry.
Solar Designer wrote:
I wrote:
OK, I think I found it. ext/hash/php_hash_md.h has this:
#define PHP_MD4Init PHP_MD5Init
which breaks when the t
On Thu, 2008-02-07 at 02:17 -0800, Rasmus Lerdorf wrote:
> Jani Taskinen wrote:
> > On Thu, 2008-02-07 at 01:43 -0800, Rasmus Lerdorf wrote:
> >> Jani Taskinen wrote:
> >>> On Wed, 2008-02-06 at 20:27 -0800, Rasmus Lerdorf wrote:
> Stanislav Malyshev wrote:
> > The proposal(s):
> > 1.
I wrote:
> OK, I think I found it. ext/hash/php_hash_md.h has this:
>
> #define PHP_MD4Init PHP_MD5Init
>
> which breaks when the two implementations are not that similar anymore.
> Replacing the MD4 implementation with mine as well would fix this (or
> hide the bug, dependin
I wrote:
> Oh, I am able to reproduce this with my original patch:
>
> PASS hmac-md5 algorithm [ext/hash/tests/hmac-md5.phpt]
> PASS md2 algorithm [ext/hash/tests/md2.phpt]
> FAIL md4 algorithm [ext/hash/tests/md4.phpt]
> PASS md5 algorithm [ext/hash/tests/md5.phpt]
> PASS ripemd128 algorithm
Am 07.02.2008 um 11:02 schrieb Jani Taskinen:
On Thu, 2008-02-07 at 01:43 -0800, Rasmus Lerdorf wrote:
Well, plenty of people know about this feature and make use of it.
Especially since it has been documented to work this way for a long
time.
See: http://php.net/manual/en/ini.core.php#ini.
On Thu, Feb 07, 2008 at 01:11:38PM +0300, Dmitry Stogov wrote:
> However new version breaks ext/hash md4. (ext/hash/tests/md4.phpt is
> broken).
Oh, I am able to reproduce this with my original patch:
PASS hmac-md5 algorithm [ext/hash/tests/hmac-md5.phpt]
PASS md2 algorithm [ext/hash/tests/md2.
A followup on my own posting:
> ...and except for adding a note that I'm not the only author (not of the
> modified code). That's fine, if it's your preference, I don't care much
> either way.
Actually, I am also not the author of some of the code that you're
leaving intact in PHP's md5.c - that
A minor clarification: The auto-globals are always there, they're not
always _populated_ though. (JIC someone misunderstood this part :)
On Thu, 2008-02-07 at 02:17 -0800, Rasmus Lerdorf wrote:
[clip]
> directives. We should focus on the actual problem and make the fewest
> changes possible to so
On 06.02.2008 16:13, Scott MacVicar wrote:
> Hi Dmitry,
>
> I don't have karma for TSRM only php-src.
Patch committed, thanks a lot.
Ilia, should I commit it to 5_2?
This looks more like a regular bugfix, not as an improvement.
--
Wbr,
Antony Dovgal
--
PHP Internals - PHP Runtime Developmen
Hi Dmitry,
On Thu, Feb 07, 2008 at 01:11:38PM +0300, Dmitry Stogov wrote:
> I've updated the files according to your notes, except
> php_uint32/MD5_u32plus.
...and except for adding a note that I'm not the only author (not of the
modified code). That's fine, if it's your preference, I don't car
On 06/02/2008, Stefan Priebsch <[EMAIL PROTECTED]> wrote:
> Sam Barrow schrieb:
> > If anyone has any objections to a scalar type hint please raise a
> > valid point.
>
> Chris Stockton schrieb:
> > This library would probably have ~300(String) + ~110(Int)
> > ~40(Resource) ~30(Bool) ~10(Float) =
Jani Taskinen wrote:
> On Thu, 2008-02-07 at 01:43 -0800, Rasmus Lerdorf wrote:
>> Jani Taskinen wrote:
>>> On Wed, 2008-02-06 at 20:27 -0800, Rasmus Lerdorf wrote:
Stanislav Malyshev wrote:
> The proposal(s):
> 1. One way to fix it is to create a new .ini request_order that would
>>>
Hi Alexander,
I've updated the files according to your notes, except
php_uint32/MD5_u32plus.
However new version breaks ext/hash md4. (ext/hash/tests/md4.phpt is
broken).
Sara, did you have a solution for this issue?
Or could you look into it please?
Thanks. Dmitry.
Solar Designer wrote:
On Thu, 2008-02-07 at 01:43 -0800, Rasmus Lerdorf wrote:
> Jani Taskinen wrote:
> > On Wed, 2008-02-06 at 20:27 -0800, Rasmus Lerdorf wrote:
> >> Stanislav Malyshev wrote:
> >>> The proposal(s):
> >>> 1. One way to fix it is to create a new .ini request_order that would
> >>> control just _REQUEST
Jani Taskinen wrote:
> On Wed, 2008-02-06 at 20:27 -0800, Rasmus Lerdorf wrote:
>> Stanislav Malyshev wrote:
>>> Hi!
>>>
>>> This topic was already discussed here but never arrived to a conclusion,
>>> so I will raise it again.
>>> The Problem:
>>> We have $_REQUEST superglobal, which is often use
On Wed, 2008-02-06 at 20:27 -0800, Rasmus Lerdorf wrote:
> Stanislav Malyshev wrote:
> > Hi!
> >
> > This topic was already discussed here but never arrived to a conclusion,
> > so I will raise it again.
> > The Problem:
> > We have $_REQUEST superglobal, which is often used to abstract GET/POST
On 07.02.2008, at 00:59, Pierre Joye wrote:
Hi Andi,
On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote:
-1
Suggestion to enhance the suggestion: return false + emit E_STRICT
message (but I am also fine with pure return false if people don't
like
this suggestion).
Sounds re
37 matches
Mail list logo
