Re: [Intel-wired-lan] [PATCH bpf-next v12 0/5] xsk: TX metadata Launch Time support

2025-02-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (net) by Martin KaFai Lau : On Sun, 16 Feb 2025 17:34:25 +0800 you wrote: > This series expands the XDP TX metadata framework to allow user > applications to pass per packet 64-bit launch time directly to the kernel > driver, requesting launch ti

Re: [Intel-wired-lan] [RFC net-next v2 1/2] devlink: add whole device devlink instance

2025-02-20 Thread Jakub Kicinski
On Wed, 19 Feb 2025 17:32:54 +0100 Przemek Kitszel wrote: > Add a support for whole device devlink instance. Intented as a entity > over all PF devices on given physical device. > > In case of ice driver we have multiple PF devices (with their devlink > dev representation), that have separate driv

Re: [Intel-wired-lan] [PATCH iwl-next v5 1/9] net: ethtool: mm: extract stmmac verification logic into common library

2025-02-20 Thread Vladimir Oltean
On Wed, Feb 19, 2025 at 09:53:41PM -0500, Faizal Rahim wrote: > +/** > + * ethtool_mmsv_stop() - Stop MAC Merge Software Verification > + * @mmsv: MAC Merge Software Verification state > + * > + * Drivers should call this method in a state where the hardware is > + * about to lose state, like ndo_s

Re: [Intel-wired-lan] [PATCH iwl-next v5 0/9] igc: Add support for Frame Preemption feature in IGC

2025-02-20 Thread Vladimir Oltean
On Wed, Feb 19, 2025 at 09:53:40PM -0500, Faizal Rahim wrote: > Introduces support for the FPE feature in the IGC driver. > > The patches aligns with the upstream FPE API: > https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1156614-1-vladimir.olt...@nxp.com/ > https://patchwork.k

Re: [Intel-wired-lan] [PATCH iwl-net v2] iavf: fix circular lock dependency with netdev_lock

2025-02-20 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of Jakub > Kicinski > Sent: Friday, February 14, 2025 8:40 PM > To: Keller, Jacob E > Cc: Intel Wired LAN ; netdev > ; Nguyen, Anthony L ; > Kitszel, Przemyslaw > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] iavf: fix circular l

[Intel-wired-lan] [PATCH iwl-net v2] ice: fix Get Tx Topology AQ command error on E830

2025-02-20 Thread Jacob Keller
From: Paul Greenwalt The Get Tx Topology AQ command (opcode 0x0418) has different read flag requriements depending on the hardware/firmware. For E810, E822, and E823 firmware the read flag must be set, and for newer hardware (E825 and E830) it must not be set. This results in failure to configur

Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix Get Tx Topology AQ command error on E830

2025-02-20 Thread Jacob Keller
On 2/19/2025 1:37 AM, Michal Swiatkowski wrote: > On Tue, Feb 18, 2025 at 04:46:34PM -0800, Jacob Keller wrote: >> From: Paul Greenwalt >> >> With E830 Get Tx Topology AQ command (opcode 0x0418) returns an error when >> setting the AQ command read flag, and since the get command is a direct >>

Re: [Intel-wired-lan] [PATCH iwl-next] igc: Change Tx mode for MQPRIO offloading

2025-02-20 Thread Abdul Rahim, Faizal
On 17/2/2025 7:45 pm, Kurt Kanzenbach wrote: The current MQPRIO offload implementation uses the legacy TSN Tx mode. In this mode the hardware uses four packet buffers and considers queue priorities. In order to harmonize the TAPRIO implementation with MQPRIO switch to the Missed "," ? In ord

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix Get Tx Topology AQ command error on E830

2025-02-20 Thread Michal Swiatkowski
On Thu, Feb 20, 2025 at 03:15:24PM -0800, Jacob Keller wrote: > From: Paul Greenwalt > > The Get Tx Topology AQ command (opcode 0x0418) has different read flag > requriements depending on the hardware/firmware. For E810, E822, and E823 > firmware the read flag must be set, and for newer hardware

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 76e04786735e2864bec8666e116cb1ba7bc4f578

2025-02-20 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alpha allyesconfiggcc-14.2.0 arc allmodconfiggcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250220gcc

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS a67a634dde15f8decd1d18738fe672afb185732b

2025-02-20 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alpha allyesconfiggcc-14.2.0 arc allmodconfiggcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250220

[Intel-wired-lan] The ice driver may rarely return incorrect statistics counter values

2025-02-20 Thread Masakazu Asama
We have observed a very rare issue in Intel E810 environments where SNMP-retrieved TX/RX counter values are sometimes nearly twice the actual values. Upon investigation, we identified a problem in the process that updates the transmit and receive ring statistics in the ice driver. This issue occur

Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix Get Tx Topology AQ command error on E830

2025-02-20 Thread Michal Swiatkowski
On Thu, Feb 20, 2025 at 02:45:41PM -0800, Jacob Keller wrote: > > > On 2/19/2025 1:37 AM, Michal Swiatkowski wrote: > > On Tue, Feb 18, 2025 at 04:46:34PM -0800, Jacob Keller wrote: > >> From: Paul Greenwalt > >> > >> With E830 Get Tx Topology AQ command (opcode 0x0418) returns an error when > >

Re: [Intel-wired-lan] [PATCH iwl-next 3/3] ice: add ice driver PTP pin documentation

2025-02-20 Thread Simon Horman
On Fri, Feb 07, 2025 at 07:02:54PM +0100, Arkadiusz Kubalewski wrote: > From: Karol Kolacinski > > Add a description of PTP pins support by the adapters to ice driver > documentation. > > Reviewed-by: Milena Olech > Signed-off-by: Karol Kolacinski > Signed-off-by: Arkadiusz Kubalewski Review

Re: [Intel-wired-lan] [PATCH iwl-next v4 5/6] ice: support egress drop rules on PF

2025-02-20 Thread Simon Horman
On Fri, Feb 14, 2025 at 09:50:39AM +0100, Larysa Zaremba wrote: > tc clsact qdisc allows us to add offloaded egress rules with commands such > as the following one: > > tc filter add dev egress protocol lldp flower skip_sw action drop > > Support the egress rule drop action when added to PF, wit

Re: [Intel-wired-lan] [PATCH iwl-next v4 6/6] ice: enable LLDP TX for VFs through tc

2025-02-20 Thread Simon Horman
On Fri, Feb 14, 2025 at 09:50:40AM +0100, Larysa Zaremba wrote: > Only a single VSI can be in charge of sending LLDP frames, sometimes it is > beneficial to assign this function to a VF, that is possible to do with tc > capabilities in the switchdev mode. It requires first blocking the PF from > se

Re: [Intel-wired-lan] [PATCH iwl-next v4 1/6] ice: fix check for existing switch rule

2025-02-20 Thread Simon Horman
On Fri, Feb 14, 2025 at 09:50:35AM +0100, Larysa Zaremba wrote: > From: Mateusz Pacuszka > > In case the rule already exists and another VSI wants to subscribe to it > new VSI list is being created and both VSIs are moved to it. > Currently, the check for already existing VSI with the same rule i

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/6] ice: remove headers argument from ice_tc_count_lkups

2025-02-20 Thread Simon Horman
On Fri, Feb 14, 2025 at 09:50:38AM +0100, Larysa Zaremba wrote: > Remove the headers argument from the ice_tc_count_lkups() function, because > it is not used anywhere. > > Reviewed-by: Michal Swiatkowski > Signed-off-by: Larysa Zaremba Reviewed-by: Simon Horman

[Intel-wired-lan] [PATCH iwl-net] ice: fix fwlog after driver reinit

2025-02-20 Thread Martyna Szapar-Mudlaw
Fix an issue when firmware logging stops after devlink reload action driver_reinit or driver reset. Fix it by restoring fw logging when it was previously registered before these events. Restoring fw logging in these cases was faultily removed with new debugfs fw logging implementation. Failure to i

Re: [Intel-wired-lan] [PATCH iwl-next v4 2/6] ice: do not add LLDP-specific filter if not necessary

2025-02-20 Thread Simon Horman
On Fri, Feb 14, 2025 at 09:50:36AM +0100, Larysa Zaremba wrote: > Commit 34295a3696fb ("ice: implement new LLDP filter command") > introduced the ability to use LLDP-specific filter that directs all > LLDP traffic to a single VSI. However, current goal is for all trusted VFs > to be able to see LLD

Re: [Intel-wired-lan] [ixgbe] Crash when running an XDP program

2025-02-20 Thread Samuel Dobron
Hey, Thanks for cooperation. The issue seems to be fixed in kernel-6.14.0-0.rc3.29.eln146. Sam. On Wed, Feb 12, 2025 at 2:04 PM Toke Høiland-Jørgensen wrote: > > Maciej Fijalkowski writes: > > > On Wed, Feb 12, 2025 at 01:33:09PM +0100, Toke Høiland-Jørgensen wrote: > >> Hi folks, > >> > >> Ou

Re: [Intel-wired-lan] [PATCH iwl-next v4 3/6] ice: receive LLDP on trusted VFs

2025-02-20 Thread Simon Horman
On Fri, Feb 14, 2025 at 09:50:37AM +0100, Larysa Zaremba wrote: > From: Mateusz Pacuszka > > When a trusted VF tries to configure an LLDP multicast address, configure a > rule that would mirror the traffic to this VF, untrusted VFs are not > allowed to receive LLDP at all, so the request to add L

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS a92c3228766429fe175ecc815f895043ea505587

2025-02-20 Thread kernel test robot
13.2.0 arc allnoconfiggcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250220gcc-13.2.0 arc randconfig-002-20250220gcc-13.2.0 arm allmodconfiggcc-

Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix fwlog after driver reinit

2025-02-20 Thread Paul Menzel
Dear Martyna, Thank you for your patch. Am 20.02.25 um 16:04 schrieb Martyna Szapar-Mudlaw: Fix an issue when firmware logging stops after devlink reload action driver_reinit or driver reset. Fix it by restoring fw logging when Maybe elaborate, why/how driver reinit or reset disables fwlog.

Re: [Intel-wired-lan] [PATCH iwl-next 2/3] ice: change SMA pins to SDP in PTP API

2025-02-20 Thread Simon Horman
On Fri, Feb 07, 2025 at 07:02:53PM +0100, Arkadiusz Kubalewski wrote: > From: Karol Kolacinski > > This change aligns E810 PTP pin control to all other products. > > Currently, SMA/U.FL port expanders are controlled together with SDP pins > connected to 1588 clock. To align this, separate this c

Re: [Intel-wired-lan] [PATCH iwl-next 1/3] ice: redesign dpll sma/u.fl pins control

2025-02-20 Thread Simon Horman
On Fri, Feb 07, 2025 at 07:02:52PM +0100, Arkadiusz Kubalewski wrote: > DPLL-enabled E810 NIC driver provides user with list of input and output > pins. Hardware internal design impacts user control over SMA and U.FL > pins. Currently end-user view on those dpll pins doesn't provide any layer > of

Re: [Intel-wired-lan] [PATCH bpf-next v12 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-20 Thread Jakub Kicinski
On Sun, 16 Feb 2025 17:34:26 +0800 Song Yoong Siang wrote: > Extend the XDP Tx metadata framework so that user can requests launch time > hardware offload, where the Ethernet device will schedule the packet for > transmission at a pre-determined time called launch time. The value of > launch time i

Re: [Intel-wired-lan] [PATCH iwl-next v5 5/9] igc: Add support for frame preemption verification

2025-02-20 Thread Vladimir Oltean
On Wed, Feb 19, 2025 at 09:53:45PM -0500, Faizal Rahim wrote: > @@ -3956,6 +3970,30 @@ static int igc_uc_unsync(struct net_device *netdev, > const unsigned char *addr) > return 0; > } > > +/** > + * igc_enable_empty_addr_recv - Enable rx of packets with all-zeroes MAC > address > + * @ad

Re: [Intel-wired-lan] [PATCH iwl-next v5 9/9] igc: Block setting preemptible traffic class in taprio

2025-02-20 Thread Vladimir Oltean
On Wed, Feb 19, 2025 at 09:53:49PM -0500, Faizal Rahim wrote: > Since preemptible tc implementation is not ready yet, block it from being > set in taprio. The existing code already blocks it in mqprio. > > Signed-off-by: Faizal Rahim > --- > drivers/net/ethernet/intel/igc/igc_main.c | 4 >