On Wed, Feb 19, 2025 at 09:53:40PM -0500, Faizal Rahim wrote: > Introduces support for the FPE feature in the IGC driver. > > The patches aligns with the upstream FPE API: > https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1156614-1-vladimir.olt...@nxp.com/ > https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.73054-1-vladimir.olt...@nxp.com/ > > It builds upon earlier work: > https://patchwork.kernel.org/project/netdevbpf/cover/20220520011538.1098888-1-vinicius.go...@intel.com/ > > The patch series adds the following functionalities to the IGC driver: > a) Configure FPE using `ethtool --set-mm`. > b) Display FPE settings via `ethtool --show-mm`. > c) View FPE statistics using `ethtool --include-statistics --show-mm'. > e) Block setting preemptible tc in taprio since it is not supported yet. > Existing code already blocks it in mqprio.
Thanks for the work, the patch set looks ok to me apart from the minor things I highlighted. It would be good to know that you've tested: - a netdev down/up cycle - a suspend/resume cycle - with CONFIG_PROVE_LOCKING, CONFIG_DEBUG_ATOMIC_SLEEP, CONFIG_DMA_API_DEBUG, CONFIG_KASAN all enabled - the kselftest again just so we have more confidence we are not missing some non-obvious issues. @Furong, the set looks close to final state to me, would you mind leaving a Tested-by: tag on patch 1/9?
