Re: [Intel-wired-lan] [PATCH net-next v2 0/8] drivers: net: Convert EEE handling to use linkmode bitmaps

2024-02-14 Thread Paul Menzel
Dear Andrew, Thank you very much for this patch-set. Am 15.02.24 um 12:13 AM schrieb Andrew Lunn: EEE has until recently been limited to lower speeds due to the use of the legacy u32 for link speeds. This restriction has been lifted, with the use of linkmode bitmaps. This patchset convert som

Re: [Intel-wired-lan] [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets

2024-02-14 Thread Jakub Kicinski
On Tue, 13 Feb 2024 14:16:47 +0100 Alexander Lobakin wrote: > > Fix softirq's not being handled during napi_schedule() call when > > receiving marker packets for queue disable by disabling local bottom > > half. > > BTW, how exactly does this help? > > __napi_schedule() already disables interru

Re: [Intel-wired-lan] [PATCH net-next v2 5/8] net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities

2024-02-14 Thread Jacob Keller
On 2/14/2024 3:13 PM, Andrew Lunn wrote: > Energy Efficient Ethernet should always be negotiated with the link > peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for > supported, advertised or lp_advertised, since it is > assumed. Additionally, ethtool(1) ignores the set bit, an

Re: [Intel-wired-lan] [PATCH iwl-next v7 2/2] ice: Implement 'flow-type ether' rules

2024-02-14 Thread Jacob Keller
On 2/12/2024 3:03 AM, Lukasz Plachno wrote: > From: Jakub Buchocki > > Add support for 'flow-type ether' Flow Director rules via ethtool. > > Create packet segment info for filter configuration based on ethtool > command parameters. Reuse infrastructure already created for > ipv4 and ipv6 flo

Re: [Intel-wired-lan] [PATCH iwl-next v7 2/2] ice: Implement 'flow-type ether' rules

2024-02-14 Thread Jacob Keller
On 2/12/2024 3:03 AM, Lukasz Plachno wrote: > +err_mask: > + dev_warn(dev, "Only 00:00:00:00:00:00 or ff:ff:ff:ff:ff:ff MAC address > mask is allowed for flow-type ether"); > + return -EOPNOTSUPP; > +} > + It would be nice if this message could be reported via extack over netlink... A

Re: [Intel-wired-lan] [PATCH iwl-next v7 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules()

2024-02-14 Thread Jacob Keller
On 2/12/2024 3:03 AM, Lukasz Plachno wrote: > Passing v6 argument is unnecessary as flow_type is still > analyzed inside the function. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Lukasz Plachno > Reviewed-by: Simon Horman Good cleanup. Reviewed-by: Jacob Keller

Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix connection state of DPLL and out pin

2024-02-14 Thread Mekala, SunithaX D
> -Original Message- > From: Intel-wired-lan On Behalf Of > Yochai Hagvi > Sent: Thursday, January 25, 2024 5:41 AM > To: intel-wired-...@lists.osuosl.org > Cc: Drewek, Wojciech ; Hagvi, Yochai > ; Kubalewski, Arkadiusz > > Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix connect

[Intel-wired-lan] [PATCH net-next v2 8/8] net: intel: igc: Use linkmode helpers for EEE

2024-02-14 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 + 1 file changed, 5 insertions(+), 4 deletion

[Intel-wired-lan] [PATCH net-next v2 7/8] net: intel: igb: Use linkmode helpers for EEE

2024-02-14 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 33 ++-- 1 file changed, 22 inse

[Intel-wired-lan] [PATCH net-next v2 6/8] net: intel: e1000e: Use linkmode helpers for EEE

2024-02-14 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/intel/e1000e/ethtool.c | 17 - 1 file changed, 12 insertions(+), 5

[Intel-wired-lan] [PATCH net-next v2 5/8] net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities

2024-02-14 Thread Andrew Lunn
Energy Efficient Ethernet should always be negotiated with the link peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for supported, advertised or lp_advertised, since it is assumed. Additionally, ethtool(1) ignores the set bit, and no other driver sets this. Signed-off-by: Andrew

[Intel-wired-lan] [PATCH net-next v2 4/8] net: ethernet: ixgbe: Convert EEE to use linkmodes

2024-02-14 Thread Andrew Lunn
Convert the tables to make use of ETHTOOL link mode bits, rather than the old u32 SUPPORTED speeds. Make use of the linkmode helps to set bits and compare linkmodes. As a result, the _u32 members of keee are no longer used, a step towards removing them. Signed-off-by: Andrew Lunn --- drivers/net

[Intel-wired-lan] [PATCH net-next v2 3/8] net: qlogic: qede: Use linkmode helpers for EEE

2024-02-14 Thread Andrew Lunn
Make use of the existing linkmode helpers for bit manipulation of EEE advertise, support and link partner support. The aim is to drop the restricted _u32 variants in the near future. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 - 1

[Intel-wired-lan] [PATCH net-next v2 2/8] net: usb: ax88179_178a: Use linkmode helpers for EEE

2024-02-14 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/usb/ax88179_178a.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --g

[Intel-wired-lan] [PATCH net-next v2 1/8] net: usb: r8152: Use linkmode helpers for EEE

2024-02-14 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Rework determining if EEE is active to make is similar as to how phylib decides, and make use of a phylib helper to validate if EEE is v

[Intel-wired-lan] [PATCH net-next v2 0/8] drivers: net: Convert EEE handling to use linkmode bitmaps

2024-02-14 Thread Andrew Lunn
EEE has until recently been limited to lower speeds due to the use of the legacy u32 for link speeds. This restriction has been lifted, with the use of linkmode bitmaps. This patchset convert some MAC drivers still using the old _u32 to link modes, with the aim of soon being able to remove the lega

Re: [Intel-wired-lan] ixgbe probe failure on Proxmox 8

2024-02-14 Thread Brandeburg, Jesse
-- Jesse Brandeburg > On Feb 13, 2024, at 3:52 PM, Bjorn Helgaas wrote: > > Just a heads-up about an ixgbe probe failure seen with Proxmox 8. I > suspect this is a PCI core problem, probably not an ixgbe problem. > > The ixgbe device logs an Advisory Non-Fatal Error and it seems like > subs

Re: [Intel-wired-lan] [PATCH net v1 1/1] igb: extend PTP timestamp adjustments to i211

2024-02-14 Thread Jacob Keller
On 2/13/2024 3:54 AM, Oleksij Rempel wrote: > The i211 requires the same PTP timestamp adjustments as the i210, > according to its datasheet. To ensure consistent timestamping across > different platforms, this change extends the existing adjustments to > include the i211. > > The adjustment re

Re: [Intel-wired-lan] [iwl-next v1 04/15] ice: add basic devlink subfunctions support

2024-02-14 Thread Jacob Keller
On 2/13/2024 12:55 AM, Jiri Pirko wrote: > Tue, Feb 13, 2024 at 08:27:13AM CET, michal.swiatkow...@linux.intel.com wrote: >> From: Piotr Raczynski >> >> Implement devlink port handlers responsible for ethernet type devlink >> subfunctions. Create subfunction devlink port and setup all resources

Re: [Intel-wired-lan] [iwl-next v1 07/15] ice: add auxiliary device sfnum attribute

2024-02-14 Thread Keller, Jacob E
> -Original Message- > From: Jiri Pirko > Sent: Wednesday, February 14, 2024 12:45 AM > To: Keller, Jacob E > Cc: Michal Swiatkowski ; intel-wired- > l...@lists.osuosl.org; net...@vger.kernel.org; Kubiak, Michal > ; Fijalkowski, Maciej ; > Samudrala, Sridhar ; Kitszel, Przemyslaw > ; D

[Intel-wired-lan] [tnguy-net-queue:100GbE] BUILD SUCCESS 16cd3f3b88a9af630cfa8f92bfbd4655d0c69417

2024-02-14 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc nsimosci_hs_defconfig gcc arc randconfig-001-20240214 gcc arc randconfig-002

[Intel-wired-lan] [tnguy-next-queue:1GbE] BUILD SUCCESS d059a37286a85db786d677c41bd77608d4744d83

2024-02-14 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc nsimosci_hs_defconfig gcc arc randconfig-001-20240214 gcc arc randconfig-002-20240214 gcc

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS bed90b06b6812d9c8c848414b090ddf38f0e6cc1

2024-02-14 Thread kernel test robot
allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc nsimosci_hs_defconfig gcc arc randconfig-001-20240214 gcc arc

Re: [Intel-wired-lan] [bug report] ixgbe: add VF IPsec management

2024-02-14 Thread Nelson, Shannon
On 2/14/2024 5:58 AM, Przemek Kitszel wrote: On 2/9/24 18:57, Nelson, Shannon wrote: On 2/9/2024 4:59 AM, Dan Carpenter wrote: Hello Shannon Nelson, The patch eda0333ac293: "ixgbe: add VF IPsec management" from Aug 13, 2018 (linux-next), leads to the following Smatch static checker warning:

Re: [Intel-wired-lan] [PATCH v4 00/10 iwl-next] idpf: refactor virtchnl messages

2024-02-14 Thread Alan Brady
On 2/14/2024 6:49 AM, Alexander Lobakin wrote: From: Alexander Lobakin Date: Tue, 6 Feb 2024 18:02:33 +0100 From: Alan Brady Date: Mon, 5 Feb 2024 19:37:54 -0800 The motivation for this series has two primary goals. We want to enable support of multiple simultaneous messages and make the ch

Re: [Intel-wired-lan] [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets

2024-02-14 Thread Tantilov, Emil S
On 2/14/2024 6:54 AM, Alexander Lobakin wrote: From: Alexander Lobakin Date: Tue, 13 Feb 2024 14:16:47 +0100 From: Alan Brady Date: Wed, 7 Feb 2024 16:42:43 -0800 From: Emil Tantilov Fix softirq's not being handled during napi_schedule() call when receiving marker packets for queue di

Re: [Intel-wired-lan] [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets

2024-02-14 Thread Alexander Lobakin
From: Alexander Lobakin Date: Tue, 13 Feb 2024 14:16:47 +0100 > From: Alan Brady > Date: Wed, 7 Feb 2024 16:42:43 -0800 > >> From: Emil Tantilov >> >> Fix softirq's not being handled during napi_schedule() call when >> receiving marker packets for queue disable by disabling local bottom >> ha

Re: [Intel-wired-lan] [PATCH v4 00/10 iwl-next] idpf: refactor virtchnl messages

2024-02-14 Thread Alexander Lobakin
From: Alexander Lobakin Date: Tue, 6 Feb 2024 18:02:33 +0100 > From: Alan Brady > Date: Mon, 5 Feb 2024 19:37:54 -0800 > >> The motivation for this series has two primary goals. We want to enable >> support of multiple simultaneous messages and make the channel more >> robust. The way it works

Re: [Intel-wired-lan] [bug report] ixgbe: add VF IPsec management

2024-02-14 Thread Przemek Kitszel
On 2/9/24 18:57, Nelson, Shannon wrote: On 2/9/2024 4:59 AM, Dan Carpenter wrote: Hello Shannon Nelson, The patch eda0333ac293: "ixgbe: add VF IPsec management" from Aug 13, 2018 (linux-next), leads to the following Smatch static checker warning: drivers/net/ethernet/intel/ixgbe/ixgb

Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations

2024-02-14 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jesse > Brandeburg > Sent: Sunday, February 11, 2024 3:31 AM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Brandeburg, Jesse ; > Eric Dumazet ; Nguyen, Anthony L > ; Brady, Alan ; Jakub > Kicinski ; Paolo

Re: [Intel-wired-lan] [PATCH iwl-next v1 1/2] igb: simplify pci ops declaration

2024-02-14 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jesse > Brandeburg > Sent: Sunday, February 11, 2024 3:31 AM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Brandeburg, Jesse ; > Eric Dumazet ; Nguyen, Anthony L > ; Brady, Alan ; Jakub > Kicinski ; Paolo

Re: [Intel-wired-lan] [PATH iwl-next v2 1/1] e1000e: Minor flow correction in e1000_shutdown function

2024-02-14 Thread naamax.meir
On 1/4/2024 21:34, Vitaly Lifshits wrote: Add curly braces to avoid entering to an if statement where it is not always required in e1000_shutdown function. This improves code readability and might prevent a non-deterministic behaviour in the future. Signed-off-by: Vitaly Lifshits --- v2: fix co

Re: [Intel-wired-lan] [iwl-next v1 07/15] ice: add auxiliary device sfnum attribute

2024-02-14 Thread Jiri Pirko
Tue, Feb 13, 2024 at 11:04:00PM CET, jacob.e.kel...@intel.com wrote: > > >On 2/13/2024 3:55 AM, Michal Swiatkowski wrote: >> On Tue, Feb 13, 2024 at 12:29:40PM +0100, Jiri Pirko wrote: >>> Tue, Feb 13, 2024 at 10:53:50AM CET, michal.swiatkow...@linux.intel.com >>> wrote: On Tue, Feb 13, 2024

Re: [Intel-wired-lan] [PATCH iwl-net v4 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

2024-02-14 Thread naamax.meir
On 1/4/2024 16:16, Vitaly Lifshits wrote: On some Meteor Lake systems accessing the PHY via the MDIO interface may result in an MDI error. This issue happens sporadically and in most cases a second access to the PHY via the MDIO interface results in success. As a workaround, introduce a retry co