> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Yochai Hagvi
> Sent: Thursday, January 25, 2024 5:41 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: Drewek, Wojciech <wojciech.dre...@intel.com>; Hagvi, Yochai
> <yochai.ha...@intel.com>; Kubalewski, Arkadiusz
> <arkadiusz.kubalew...@intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix connection state of
> DPLL and out pin
>
> Fix the connection state between source DPLL and output pin, updating the
> attribute 'state' of 'parent_device'. Previously, the connection state
> was broken, and didn't reflect the correct state.
>
> When 'state_on_dpll_set' is called with the value
> 'DPLL_PIN_STATE_CONNECTED' (1), the output pin will switch to the given
> DPLL, and the state of the given DPLL will be set to connected.
> E.g.:
> --do pin-set --json '{"id":2, "parent-device":{"parent-id":1,
> "state": 1 }}'
> This command will connect DPLL device with id 1 to output pin with id 2.
>
> When 'state_on_dpll_set' is called with the value
> 'DPLL_PIN_STATE_DISCONNECTED' (2) and the given DPLL is currently
> connected, then the output pin will be disabled.
> E.g:
> --do pin-set --json '{"id":2, "parent-device":{"parent-id":1,
> "state": 2 }}'
> This command will disable output pin with id 2 if DPLL device with ID 1 is
> connected to it; otherwise, the command is ignored.
>
> Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu")
> Reviewed-by: Wojciech Drewek <wojciech.dre...@intel.com>
> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalew...@intel.com>
> Signed-off-by: Yochai Hagvi <yochai.ha...@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_dpll.c | 43 +++++++++++++++++------
> 1 file changed, 32 insertions(+), 11 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mek...@intel.com> (A Contingent worker at
Intel)
