From: Alexander Lobakin <aleksander.loba...@intel.com> Date: Tue, 13 Feb 2024 14:16:47 +0100
> From: Alan Brady <alan.br...@intel.com> > Date: Wed, 7 Feb 2024 16:42:43 -0800 > >> From: Emil Tantilov <emil.s.tanti...@intel.com> >> >> Fix softirq's not being handled during napi_schedule() call when >> receiving marker packets for queue disable by disabling local bottom >> half. > > BTW, how exactly does this help? > > __napi_schedule() already disables interrupts (local_irq_save()). > napi_schedule_prep() only has READ_ONCE() and other atomic read/write > helpers. > > It's always been safe to call napi_schedule() with enabled BH, so I > don't really understand how this works. This also needs to be dropped from the fixes queue until investigated. For now, it looks like a cheap hack (without the explanation how exactly it does help), not a proper fix. Thanks, Olek
