[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 2318d58f358e7aef726c038aff87a68bec8f09e0

2023-10-11 Thread kernel test robot
arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20231011 gcc arm allmodconfig gcc arm

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS f875e4431b614f455016bf2b036542a4efec3dd2

2023-10-11 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20231011 gcc arm allmodconfig gcc arm

[Intel-wired-lan] [tnguy-net-queue:main] BUILD SUCCESS da6192ca72d5ad913d109d43dc896290ad05d98f

2023-10-11 Thread kernel test robot
arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20231011 gcc arm allmodconfig gcc arm

[Intel-wired-lan] [tnguy-next-queue:main] BUILD SUCCESS f0107b864f004bc6fa19bf6d5074b4a366f3e16a

2023-10-11 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20231011 gcc arm allmodconfig gcc arm

Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-11 Thread Willem de Bruijn
On Tue, Oct 10, 2023 at 5:34 PM Ahmed Zaki wrote: > > > On 2023-10-10 14:40, Willem de Bruijn wrote: > > On Tue, Oct 10, 2023 at 4:05 PM Ahmed Zaki wrote: > > Symmetric RSS hash functions are beneficial in applications that monitor > both Tx and Rx packets of the same flow (IDS, software firewall

Re: [Intel-wired-lan] [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state()

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:55PM +0300, Ilpo Järvinen wrote: > pci_disable_link_state() lacks a symmetric pair. Some drivers want to > disable ASPM during certain phases of their operation but then > re-enable it later on. If pci_disable_link_state() is made for the > device, there is currently n

Re: [Intel-wired-lan] [PATCH v2 03/13] PCI/ASPM: Disable ASPM when driver requests it

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote: > PCI core/ASPM service driver allows controlling ASPM state through > pci_disable_link_state() and pci_enable_link_state() API. It was > decided earlier (see the Link below), to not allow ASPM changes when OS > does not have control ov

Re: [Intel-wired-lan] [PATCH iwl-next] ice: Don't disable PHY before settime

2023-10-11 Thread Jacob Keller
On 10/11/2023 4:02 AM, Karol Kolacinski wrote: > When settime is called, the driver tries to disable the PHY to avoid > PHY clock running and giving incorrect timestamps during time change. > PHY stop procedure takes more HW writes than just marking timestamps as > invalid. After settime, the PHYs

Re: [Intel-wired-lan] [PATCH iwl-next] ice: Re-enable timestamping correctly after reset

2023-10-11 Thread Jacob Keller
On 10/11/2023 4:04 AM, Karol Kolacinski wrote: > During reset, TX_TSYN interrupt should be processed as it may process > timestamps in brief moments before and after reset. > Timestamping should be enabled on VSIs at the end of reset procedure. > On ice_get_phy_tx_tstamp_ready error, interrupt s

Re: [Intel-wired-lan] [PATCH v2 03/13] PCI/ASPM: Disable ASPM when driver requests it

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote: > PCI core/ASPM service driver allows controlling ASPM state through > pci_disable_link_state() and pci_enable_link_state() API. It was > decided earlier (see the Link below), to not allow ASPM changes when OS > does not have control ov

Re: [Intel-wired-lan] [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper

2023-10-11 Thread Bjorn Helgaas
On Mon, Sep 18, 2023 at 04:10:54PM +0300, Ilpo Järvinen wrote: > ASPM service driver does the same L0S / L1S / sub states allowed > calculation in __pci_disable_link_state() and > pci_set_default_link_state(). Is there a typo or something here? This patch only adds a call to __pci_disable_link_st

Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-11 Thread Jakub Kicinski
On Wed, 11 Oct 2023 14:25:55 +0900 takeru hayasaka wrote: > > Regarding the patch - you are only adding flow types, not a new field > > (which are defined as RXH_*). If we want to hash on an extra field, > > I think we need to specify that field as well? > > I've been really struggling with this

Re: [Intel-wired-lan] [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps

2023-10-11 Thread Jiri Pirko
Wed, Oct 11, 2023 at 03:13:47PM CEST, pawel.chmielew...@intel.com wrote: >From: Paul Greenwalt > >The need to map Ethtool forced speeds to Ethtool supported link modes is >common among drivers. To support this, add a common structure for forced >speed maps and a function to init them. This is sol

Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-11 Thread Ahmed Zaki
[ Resend - rejected by netdev and linux-doc MLs for HTML content] On 2023-10-10 14:40, Willem de Bruijn wrote: On Tue, Oct 10, 2023 at 4:05 PM Ahmed Zaki wrote: Symmetric RSS hash functions are beneficial in applications that monitor both Tx and Rx packets of the same flow (IDS, software fir

[Intel-wired-lan] [PATCH net-next v4 2/2] ice: Refactor finding advertised link speed

2023-10-11 Thread Pawel Chmielewski
Refactor ice_get_link_ksettings to using forced speed to link modes mapping. Suggested-by : Alexander Lobakin Reviewed-by: Jacob Keller Reviewed-by: Przemek Kitszel Signed-off-by: Paul Greenwalt Signed-off-by: Pawel Chmielewski --- drivers/net/ethernet/intel/ice/ice.h | 1 + driver

[Intel-wired-lan] [PATCH net-next v4 1/2] ethtool: Add forced speed to supported link modes maps

2023-10-11 Thread Pawel Chmielewski
From: Paul Greenwalt The need to map Ethtool forced speeds to Ethtool supported link modes is common among drivers. To support this, add a common structure for forced speed maps and a function to init them. This is solution was originally introduced in commit 1d4e4ecccb11 ("qede: populate suppor

[Intel-wired-lan] [PATCH net-next v4 0/2] ethtool: Add link mode maps for forced speeds

2023-10-11 Thread Pawel Chmielewski
The following patch set was initially a part of [1]. As the purpose of the original series was to add the support of the new hardware to the intel ice driver, the refactoring of advertised link modes mapping was extracted to a new set. The patch set adds a common mechanism for mapping Ethtool force

Re: [Intel-wired-lan] [PATCH net-next v5 0/5] dpll: add phase-offset and phase-adjust

2023-10-11 Thread Jiri Pirko
Wed, Oct 11, 2023 at 12:12:31PM CEST, arkadiusz.kubalew...@intel.com wrote: >Improve monitoring and control over dpll devices. >Allow user to receive measurement of phase difference between signals >on pin and dpll (phase-offset). >Allow user to receive and control adjustable value of pin's signal

[Intel-wired-lan] [PATCH iwl-next] ice: Re-enable timestamping correctly after reset

2023-10-11 Thread Karol Kolacinski
During reset, TX_TSYN interrupt should be processed as it may process timestamps in brief moments before and after reset. Timestamping should be enabled on VSIs at the end of reset procedure. On ice_get_phy_tx_tstamp_ready error, interrupt should not be rearmed, because error only happens on resets

[Intel-wired-lan] [PATCH iwl-next] ice: Don't disable PHY before settime

2023-10-11 Thread Karol Kolacinski
When settime is called, the driver tries to disable the PHY to avoid PHY clock running and giving incorrect timestamps during time change. PHY stop procedure takes more HW writes than just marking timestamps as invalid. After settime, the PHYs is recalibrated and timestamping is reenabled. Change d

Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed when changed PHY doesn't support it

2023-10-11 Thread Loktionov, Aleksandr
> -Original Message- > From: Lobakin, Aleksander > Sent: Wednesday, October 11, 2023 11:25 AM > To: Loktionov, Aleksandr > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; Jagielski, Jedrzej > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default > s

Re: [Intel-wired-lan] [PATCH net-next v4 0/5] dpll: add phase-offset and phase-adjust

2023-10-11 Thread Kubalewski, Arkadiusz
>From: Jakub Kicinski >Sent: Wednesday, October 11, 2023 4:35 AM > >On Tue, 10 Oct 2023 00:26:11 +0200 Arkadiusz Kubalewski wrote: >> Improve monitoring and control over dpll devices. >> Allow user to receive measurement of phase difference between signals >> on pin and dpll (phase-offset). >> All

[Intel-wired-lan] [PATCH net-next v5 5/5] dpll: netlink/core: change pin frequency set behavior

2023-10-11 Thread Arkadiusz Kubalewski
Align the approach of pin frequency set behavior with the approach introduced with pin phase adjust set. Fail the request if any of devices did not registered the callback ops. If callback op on any pin's registered device fails, return error and rollback the value to previous one. Signed-off-by:

[Intel-wired-lan] [PATCH net-next v5 4/5] ice: dpll: implement phase related callbacks

2023-10-11 Thread Arkadiusz Kubalewski
Implement new callback ops related to measurement and adjustment of signal phase for pin-dpll in ice driver. Signed-off-by: Arkadiusz Kubalewski --- drivers/net/ethernet/intel/ice/ice_dpll.c | 220 +- drivers/net/ethernet/intel/ice/ice_dpll.h | 10 +- 2 files changed, 226 in

[Intel-wired-lan] [PATCH net-next v5 3/5] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-11 Thread Arkadiusz Kubalewski
Add callback ops for pin-dpll phase measurement. Add callback for pin signal phase adjustment. Add min and max phase adjustment values to pin proprties. Invoke callbacks in dpll_netlink.c when filling the pin details to provide user with phase related attribute values. Signed-off-by: Arkadiusz Kub

[Intel-wired-lan] [PATCH net-next v5 2/5] dpll: spec: add support for pin-dpll signal phase offset/adjust

2023-10-11 Thread Arkadiusz Kubalewski
Add attributes for providing the user with: - measurement of signals phase offset between pin and dpll - ability to adjust the phase of pin signal Signed-off-by: Arkadiusz Kubalewski --- Documentation/netlink/specs/dpll.yaml | 30 +++ drivers/dpll/dpll_nl.c

[Intel-wired-lan] [PATCH net-next v5 1/5] dpll: docs: add support for pin signal phase offset/adjust

2023-10-11 Thread Arkadiusz Kubalewski
Add documentation on: - measurement of phase of signal between pin and dpll - adjustment of pin signal phase Signed-off-by: Arkadiusz Kubalewski --- Documentation/driver-api/dpll.rst | 53 ++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/Documentation

[Intel-wired-lan] [PATCH net-next v5 0/5] dpll: add phase-offset and phase-adjust

2023-10-11 Thread Arkadiusz Kubalewski
Improve monitoring and control over dpll devices. Allow user to receive measurement of phase difference between signals on pin and dpll (phase-offset). Allow user to receive and control adjustable value of pin's signal phase (phase-adjust). v4->v5: - rebase series on top of net-next/main, fix conf

Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed when changed PHY doesn't support it

2023-10-11 Thread Alexander Lobakin
From: Alexander Lobakin Date: Wed, 11 Oct 2023 11:22:21 +0200 > From: Aleksandr Loktionov > Date: Wed, 11 Oct 2023 11:13:42 +0200 > > Please add netdev and linux-kernel MLs to CCs when sending the next version. > >> In order to avoid no link after plugging a different type PHY module. > > The

Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed when changed PHY doesn't support it

2023-10-11 Thread Alexander Lobakin
From: Aleksandr Loktionov Date: Wed, 11 Oct 2023 11:13:42 +0200 Please add netdev and linux-kernel MLs to CCs when sending the next version. > In order to avoid no link after plugging a different type PHY module. The sentence is incomplete, it tells "why", but no "what". > > Add reset link sp

[Intel-wired-lan] [PATCH iwl-next v2] i40e: add restore default speed when changed PHY doesn't support it

2023-10-11 Thread Aleksandr Loktionov
In order to avoid no link after plugging a different type PHY module. Add reset link speed settings to the default values for PHY module, if different PHY module is inserted and currently defined user-specified speed is not compatible with this module. Reviewed-by: Jedrzej Jagielski Signed-off-b

Re: [Intel-wired-lan] [PATCH iwl-next v1] i40e: add restore default speed when changed PHY doesn't support it

2023-10-11 Thread Larysa Zaremba
On Wed, Oct 11, 2023 at 10:05:06AM +0200, Aleksandr Loktionov wrote: > In order to avoid no link after plugging a different type PHY module. > > Add reset link speed settings to the default values for PHY module, > if different PHY module is inserted and currently defined user-specified > speed is

[Intel-wired-lan] [PATCH iwl-next v1] i40e: add restore default speed when changed PHY doesn't support it

2023-10-11 Thread Aleksandr Loktionov
In order to avoid no link after plugging a different type PHY module. Add reset link speed settings to the default values for PHY module, if different PHY module is inserted and currently defined user-specified speed is not compatible with this module. Signed-off-by: Radoslaw Tyl Signed-off-by:

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Fix SRIOV LAG disable on non-compliant aggreagate

2023-10-11 Thread Drewek, Wojciech
> -Original Message- > From: Intel-wired-lan On Behalf Of > Dave Ertman > Sent: Tuesday, October 10, 2023 7:32 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH iwl-next v2] ice: Fix SRIOV LAG disable on > non-compliant aggreagate