> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Dave Ertman
> Sent: Tuesday, October 10, 2023 7:32 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-next v2] ice: Fix SRIOV LAG disable on
> non-compliant aggreagate
>
> If an attribute of an aggregate interface disqualifies it from supporting
> SRIOV, the driver will unwind the SRIOV support. Currently the driver is
> clearing the feature bit for all interfaces in the aggregate, but this is
> not allowing the other interfaces to unwind successfully on driver unload.
>
> Only clear the feature bit for the interface that is currently unwinding.
>
> Fixes: bf65da2eb279 ("ice: enforce interface eligibility and add messaging for
> SRIOV LAG")
> Signed-off-by: Dave Ertman <david.m.ert...@intel.com>
Thanks Dave!
Reviewed-by: Wojciech Drewek <wojciech.dre...@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_lag.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c
> b/drivers/net/ethernet/intel/ice/ice_lag.c
> index 2c96d1883e19..f405c07410a7 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lag.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lag.c
> @@ -1513,18 +1513,12 @@ static void ice_lag_chk_disabled_bond(struct
> ice_lag *lag, void *ptr)
> */
> static void ice_lag_disable_sriov_bond(struct ice_lag *lag)
> {
> - struct ice_lag_netdev_list *entry;
> struct ice_netdev_priv *np;
> - struct net_device *netdev;
> struct ice_pf *pf;
>
> - list_for_each_entry(entry, lag->netdev_head, node) {
> - netdev = entry->netdev;
> - np = netdev_priv(netdev);
> - pf = np->vsi->back;
> -
> - ice_clear_feature_support(pf, ICE_F_SRIOV_LAG);
> - }
> + np = netdev_priv(lag->netdev);
> + pf = np->vsi->back;
> + ice_clear_feature_support(pf, ICE_F_SRIOV_LAG);
> }
>
> /**
> --
> 2.40.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
