From: Alexander Lobakin <aleksander.loba...@intel.com>
Date: Wed, 11 Oct 2023 11:22:21 +0200

> From: Aleksandr Loktionov <aleksandr.loktio...@intel.com>
> Date: Wed, 11 Oct 2023 11:13:42 +0200
> 
> Please add netdev and linux-kernel MLs to CCs when sending the next version.
> 
>> In order to avoid no link after plugging a different type PHY module.
> 
> The sentence is incomplete, it tells "why", but no "what".
> 
>>
>> Add reset link speed settings to the default values for PHY module,
>> if different PHY module is inserted and currently defined user-specified
>> speed is not compatible with this module.
>>
>> Reviewed-by: Jedrzej Jagielski <jedrzej.jagiel...@intel.com>
>> Signed-off-by: Radoslaw Tyl <radoslawx....@intel.com>
> 
> How did Radoslaw participate?
> If he's the author, he must be in the "From" field as well. If not, his
> SoB tells me nothing. Author, co-developer, reviewer, ...?

Also, his email address bounces, IOW there's no point in adding this
SoB. If you want to credit his work, use his working email, either
private or dunno, otherwise makes no sense.

> 
>> Signed-off-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com>

[...]

Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Reply via email to