Re: [Intel-gfx] [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable

2011-11-20 Thread Eugeni Dodonov
On Sat, Nov 19, 2011 at 16:32, Keith Packard wrote: > On Sat, 19 Nov 2011 07:25:09 -0200, Eugeni Dodonov wrote: > >> Just one question I caught on 2nd read. Shouldn't we have #else within >> this #ifdef block, to return 1? Otherwise, if CONFIG_INTEL_IOMMU is >> not

[Intel-gfx] [PATCH] drm/i915: enable semaphores on per-device defaults

2011-11-21 Thread Eugeni Dodonov
arnes Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862 Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/i915: enable semaphores on per-device defaults

2011-11-21 Thread Eugeni Dodonov
p.org/show_bug.cgi?id=41353 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862 Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c|4 +- drivers/gpu/drm/i915/i915_drv.h|2 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 29 ++

[Intel-gfx] [PATCH 2/2] drm/i915: allow per-device fbc to work with default settings

2011-11-21 Thread Eugeni Dodonov
The change which added support for default settings for fbc has not changed the variable type of i915_enable_fbc from unsigned int to int. So we were unable to get into the default ('-1') state with the default settings. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_dr

Re: [Intel-gfx] [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable

2011-11-22 Thread Eugeni Dodonov
ndom gpu hangs and crashes when both are enabled :(. When the root cause will be discovered, we should allow both of course. But so far, all the attempts on this weren't successful. -- Eugeni Dodonov <http://eugeni.dodonov.net/> __

Re: [Intel-gfx] [PATCH 2/2] drm/i915: drpc debugfs update for gen6

2011-11-23 Thread Eugeni Dodonov
is that we're not using forcewake, ie. the software isn't > forcing the hardware to stay awake. The downside is that in doing this > we may wait a while and that causes an unnaturally idle state on the > GPU. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42578

[Intel-gfx] [PATCH] iommu: export no_iommu and dmar_disabled symbols

2011-11-23 Thread Eugeni Dodonov
Those are needed by the rc6 and semaphores support in i915 driver. In i915 driver, we do not enable either rc6 or semaphores on SNB when dmar is enabled. So we use those variables to check the io remapping and iommu status. CC: Keith Packard CC: Daniel Vetter Signed-off-by: Eugeni Dodonov

Re: [Intel-gfx] [PATCH] drm/i915: check ACTHD of all rings

2011-11-28 Thread Eugeni Dodonov
> > This fixes spurious gpu hang detection when running > tests/gem_hangcheck_forcewake on snb/ivb. > > Signed-Off-by: Daniel Vetter > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Int

[Intel-gfx] [PATCH 8/8] drm/i915: enable rc6 by default on IVB onwards

2011-11-28 Thread Eugeni Dodonov
always be enabled by the i915.i915_enable_rc6=1 kernel parameter though. CC: Daniel Vetter CC: Ben Widawsky CC: Keith Packard CC: Jesse Barnes CC: Chris Wilson Signed-off-by: Keith Packard Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 7/8] drm/i915: allow per-device fbc to work with default settings

2011-11-28 Thread Eugeni Dodonov
The change which added support for default settings for fbc has not changed the variable type of i915_enable_fbc from unsigned int to int. So we were unable to get into the default ('-1') state with the default settings. Reviewed-by: Chris Wilson Signed-off-by: Eugeni Dodonov --- d

[Intel-gfx] [PATCH 6/8] drm/i915: enable semaphores on per-device defaults

2011-11-28 Thread Eugeni Dodonov
/show_bug.cgi?id=38862 Reviewed-by: Chris Wilson Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c|4 ++-- drivers/gpu/drm/i915/i915_drv.h|2 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 18 +- 3 files changed, 20 insertions(+), 4

[Intel-gfx] [PATCH 5/8] platform/x86: fix typos in function comments

2011-11-28 Thread Eugeni Dodonov
Fix small typos in comments. Signed-off-by: Eugeni Dodonov --- drivers/platform/x86/intel_ips.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c index 809a3ae..8dec469 100644 --- a/drivers/platform

[Intel-gfx] [PATCH 4/8] drm/i915: fix typo in function name

2011-11-28 Thread Eugeni Dodonov
Fix function name in comments, a left-over from when i965_reset was renamed to i915_reset. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/8] drm/i915: prevent division by zero when asking for chipset power

2011-11-28 Thread Eugeni Dodonov
: Jesse Barnes Acked-by: Keith Packard Reviewed-by: Chris Wilson Cc: Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_dma.c | 10 ++ drivers/gpu/drm/i915/i915_drv.h |1 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b

[Intel-gfx] [PATCH 2/8] drm: give up on edid retries when i2c bus is not responding

2011-11-28 Thread Eugeni Dodonov
27; command: Machine 4: from 3.210s to 1.060s Reviewed-by: Chris Wilson Reviewed-by: Keith Packard Tested-by: Sean Finney Tested-by: Soren Hansen Tested-by: Hernando Torque Tested-by: Mike Lothian Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41059 Signed-off-by: Eugeni Dodonov

[Intel-gfx] [PATCH 1/8] drm/i915: there is no pipe CxSR on ironlake

2011-11-28 Thread Eugeni Dodonov
After checking the specs and discussing with Jesse, turns out CxSR is not available on Ironlake and gen5, and its advertisement on the device description is misleading. Acked-by: Jesse Barnes Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c |2 +- 1 files changed, 1

[Intel-gfx] [PATCH 0/8] misc fixes for 3.2

2011-11-28 Thread Eugeni Dodonov
, there is no reason to not have them on by default there. Eugeni Dodonov (8): drm/i915: there is no pipe CxSR on ironlake drm: give up on edid retries when i2c bus is not responding drm/i915: prevent division by zero when asking for chipset power drm/i915: fix typo in function name platform

[Intel-gfx] [PATCH] drm/i915: enable rc6 by default on IVB onwards

2011-11-28 Thread Eugeni Dodonov
always be enabled by the i915.i915_enable_rc6=1 kernel parameter though. CC: Daniel Vetter CC: Ben Widawsky CC: Keith Packard CC: Jesse Barnes CC: Chris Wilson Signed-off-by: Keith Packard Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 1/2] drm/i915: enable deepest RC6 state

2011-11-29 Thread Eugeni Dodonov
This should allow even more energy saving when GPU is not in use. According to the testing, this state results in around 0.1 - 0.4 W better power usage. No issues or regressions observed so far, but additional testing is certainly welcome. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915: add debugfs interface to control rc6 and rps

2011-11-29 Thread Eugeni Dodonov
, to allow the module to know the latest status of rc6 requested by user. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_debugfs.c | 101 ++ drivers/gpu/drm/i915/intel_display.c |2 +- drivers/gpu/drm/i915/intel_drv.h |3 + 3 files changed

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add debugfs interface to control rc6 and rps

2011-11-29 Thread Eugeni Dodonov
On Tue, Nov 29, 2011 at 12:12, Daniel Vetter wrote: > On Tue, Nov 29, 2011 at 01:05:03PM +, Chris Wilson wrote: > > On Tue, 29 Nov 2011 10:55:05 -0200, Eugeni Dodonov < > eugeni.dodo...@intel.com> wrote: > > > This allows to enable/disable rps and rc6 from userspa

Re: [Intel-gfx] [PATCH 00/15] [RFC] Forced throttling/scheduling

2011-11-29 Thread Eugeni Dodonov
lable_schedulers none *fair batch or list them in the output of i915_scheduler, like: # cat /sys/kernel/debug/dri/0/i915_scheduler ... Scheduler: batch Available schedulers: none fair batch To see what schedulers are available for usage. But besides this, fo

Re: [Intel-gfx] [PATCH] drm/i915: Only clear the GPU domains upon a successful finish

2011-11-29 Thread Eugeni Dodonov
t; > Signed-off-by: Chris Wilson > Cc: sta...@kernel.org > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: multithreaded forcewake is an ivb+ feature

2011-11-29 Thread Eugeni Dodonov
On Mon, Nov 28, 2011 at 19:12, Daniel Vetter wrote: > Name the function accordingly. Suggested by Chris Wilson. > > Signed-Off-by: Daniel Vetter > Reviewed-by: Eugeni Dodonov Such patches are so hard to review. The only ones harder than those are the white space-related ones :).

Re: [Intel-gfx] [PATCH 3/4] drm/i915: drop register special-casing in forcewake

2011-11-29 Thread Eugeni Dodonov
t accessed with _NOTRACE. > s/FROCEWAKE/FORCEWAKE/g :) Besides this, Reviewed-by: Eugeni Dodonov for the series. -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.or

Re: [Intel-gfx] [PATCH] drm/i915: capture error_state also for stuck rings

2011-11-29 Thread Eugeni Dodonov
angs. > > > > Signed-Off-by: Daniel Vetter > Reviewed-and-tested-by: Chris Wilson > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Handle unmappable buffers during error state capture

2011-11-29 Thread Eugeni Dodonov
otentially happen anyway as a result of a pathological error. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists

Re: [Intel-gfx] [PATCH 1/2] drm/i915: enable deepest RC6 state

2011-11-29 Thread Eugeni Dodonov
On Tue, Nov 29, 2011 at 19:42, Ben Widawsky wrote: > On Tue, Nov 29, 2011 at 01:01:31PM +, Chris Wilson wrote: > > On Tue, 29 Nov 2011 10:55:04 -0200, Eugeni Dodonov < > eugeni.dodo...@intel.com> wrote: > > > This should allow even more energy saving when GPU is

Re: [Intel-gfx] [PATCH 00/11] aliasing ppgtt support v2

2011-11-29 Thread Eugeni Dodonov
> > Comments, test reports, reviews and flames highly welcome. > For the series (with the latest patches on your fd.o repo) Tested-by: Eugeni Dodonov I left it running on 2 SNBs and 1 IVB for couple of hours under different set of workloads, and haven't seen any issues so far

Re: [Intel-gfx] [PATCH 07/11] drm/i915: per-ring fault reg

2011-11-29 Thread Eugeni Dodonov
On Mon, Nov 28, 2011 at 18:35, Daniel Vetter wrote: > +#define ERROR 0x40a0 > You do not seem to use this, and it is the same value as ERROR_GEN6. Do we need it? Or I misread something? -- Eugeni Dodonov <http://eugeni.do

Re: [Intel-gfx] [PATCH] drm/i915: remove the i915_batchbuffer_info debugfs file

2011-11-29 Thread Eugeni Dodonov
el Vetter > Yep, I think that error_state does the job just fine now. Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] Intel 2011Q4 graphics package

2011-12-05 Thread Eugeni Dodonov
hanks, Eugeni Dodonov Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Intel 2011Q4 graphics package

2011-12-06 Thread Eugeni Dodonov
2011/12/6 Alan W. Irwin > On 2011-12-05 23:03-0200 Eugeni Dodonov wrote: > > Hi, >> >> We’d like to announce Intel 2011Q4 graphics package, focused on >> performance and stability improvements in the Intel Linux Graphics >> stack. >> >> Please che

Re: [Intel-gfx] [BUG] Minecraft graphics issues

2011-12-07 Thread Eugeni Dodonov
ktop.org/show_bug.cgi?id=39730#c48 for this problem? -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: enable semaphores on per-device defaults

2011-12-09 Thread Eugeni Dodonov
: https://bugs.freedesktop.org/show_bug.cgi?id=41353 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862 Reviewed-by: Chris Wilson Reviewed-by: Daniel Vetter Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c|4 ++-- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH] drm/i915: add a LLC feature flag in device description

2011-12-12 Thread Eugeni Dodonov
LLC is not SNB-specific, so we should check for it in a more generic way. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c |2 ++ drivers/gpu/drm/i915/i915_drv.h |2 ++ drivers/gpu/drm/i915/i915_gem.c |4 ++-- 3 files changed, 6 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH] drm/i915: add a LLC feature flag in device description

2011-12-13 Thread Eugeni Dodonov
From: Eugeni Dodonov LLC is not SNB-specific, so we should check for it in a more generic way. v2: export LLC support status via debugfs and DRM GETPARAM. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_debugfs.c |1 + drivers/gpu/drm/i915/i915_dma.c |3 +++ drivers

[Intel-gfx] [PATCH] drm/i915: add a LLC feature flag in device description

2011-12-13 Thread Eugeni Dodonov
From: Eugeni Dodonov LLC is not SNB-specific, so we should check for it in a more generic way. v2: export LLC support status via debugfs and DRM GETPARAM. v3: rebase on newer kernel version which says that IVB supports LLC as well. Reviewed-by: Chris Wilson Reviewed-by: Daniel Vetter Signed

[Intel-gfx] [PATCH] [RFC] LLC and per-BO cache handling

2011-12-13 Thread Eugeni Dodonov
With base on comments and feedback on LLC handling from Daniel Vetter, Chris Wilson and Ben Widawsky, I reworked my patch into a more useful approach for detecting presence of different cache levels from userspace. So, in this context, PATCH 1 adds the very same .has_llc flag and debugfs entry for

[Intel-gfx] [PATCH 1/4] drm/i915: add a LLC feature flag in device description

2011-12-13 Thread Eugeni Dodonov
From: Eugeni Dodonov LLC is not SNB-specific, so we should check for it in a more generic way. v2: export LLC support status via debugfs. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_debugfs.c |1 + drivers/gpu/drm/i915/i915_drv.c |4 drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/4] drm/i915: simplify cache parameters for userspace

2011-12-13 Thread Eugeni Dodonov
From: Eugeni Dodonov Simplify the code and cache-related parameters handling, and prepare to export them to userspace in subsequent patches. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.h | 10 ++ drivers/gpu/drm/i915/i915_gem.c |2 +- drivers/gpu/drm

[Intel-gfx] [PATCH 3/4] drm/i915: add drm PARAM to query available cache levels

2011-12-13 Thread Eugeni Dodonov
From: Eugeni Dodonov This allows to query available cache levels from libdrm and check for presence of LLC from userspace. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_dma.c |6 ++ include/drm/i915_drm.h |1 + 2 files changed, 7 insertions(+), 0 deletions

[Intel-gfx] [PATCH 4/4] drm/i915: add support to get/set cache type for bo

2011-12-13 Thread Eugeni Dodonov
From: Eugeni Dodonov Allow userspace to discover current cache level for a bo and set a specific cache level if necessary. The patch is mostly based on the original patch from Ben Widawsky. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_dma.c |2 + drivers/gpu/drm/i915

Re: [Intel-gfx] Fan running with Intel Graphics

2011-12-13 Thread Eugeni Dodonov
understanding what is going on with your machine, could you setup some thermal sensors and check what do they say about temperature? And also check with powertop about what is using the most power out there? -- Eugeni Dodonov <http://eugeni.dodonov.net/> _

Re: [Intel-gfx] [PATCH 13/43] drm/i915: refactor debugfs open function

2011-12-14 Thread Eugeni Dodonov
On Wed, Dec 14, 2011 at 10:57, Daniel Vetter wrote: > Only forcewake has an open with special semantics, the other r/w > debugfs only assign the file private pointer. > > Signed-Off-by: Daniel Vetter > Reviewed-by: Ben Widawsky > Reviewed-by: Kenneth Graunke > Review

Re: [Intel-gfx] [PATCH 16/43] drm/i915: rework dev->first_error locking

2011-12-14 Thread Eugeni Dodonov
the error_state to protect from concurent freeeing. > This will be only really used in the next patch. > > Signed-Off-by: Daniel Vetter > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing

Re: [Intel-gfx] [PATCH 02/43] drm/i915: don't bail out of intel_wait_ring_buffer too early

2011-12-14 Thread Eugeni Dodonov
prevent > resume bugs from totally hanging the machine. > > Signed-off-by: Daniel Vetter > Reviewed-by: Chris Wilson > Acked-by: Ben Widawsky > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 03/43] drm/i915: switch ring->id to be a real id

2011-12-14 Thread Eugeni Dodonov
around because I'll reuse ring_str in the next > patch. > > Signed-off-by: Daniel Vetter > Reviewed-by: Chris Wilson > Reviewed-by: Ben Widawsky > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> _

Re: [Intel-gfx] [PATCH 04/43] drm/i915: refactor ring error state capture to use arrays

2011-12-14 Thread Eugeni Dodonov
on. > > Signed-off-by: Daniel Vetter > Reviewed-by: Chris Wilson > Signed-off-by: Ben Widawsky > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedeskto

Re: [Intel-gfx] [PATCH 05/43] drm/i915: collect more per ring error state

2011-12-14 Thread Eugeni Dodonov
te where just guessing these is not good enough. > > v2: Also dump INSTPM for every ring. > > v3: Fix a few really silly goof-ups spotted by Chris Wilson. > > Signed-off-by: Daniel Vetter > Reviewed-by: Chris Wilson > Signed-off-by: Ben Wida

Re: [Intel-gfx] [PATCH 14/43] drm/i915: refactor debugfs create functions

2011-12-14 Thread Eugeni Dodonov
eth Graunke > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 17/43] drm/i915: destroy existing error_state when simulating a gpu hang

2011-12-14 Thread Eugeni Dodonov
On Wed, Dec 14, 2011 at 10:57, Daniel Vetter wrote: > This way we can simulate a bunch of gpu hangs and run the error_state > capture code every time (without the need to reload the module). > > Signed-Off-by: Daniel Vetter > Reviewed-by: Eugeni Dodonov -- Eugen

Re: [Intel-gfx] [PATCH 28/43] drm/i915: Handle unmappable buffers during error state capture

2011-12-14 Thread Eugeni Dodonov
lazy GTT binding, > but could potentially happen anyway as a result of a pathological error. > > Signed-off-by: Chris Wilson > Reviewed-by: Daniel Vetter > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> _

Re: [Intel-gfx] [PATCH 31/43] drm/i915: Use kcalloc instead of kzalloc to allocate array

2011-12-14 Thread Eugeni Dodonov
e semantic patch that makes this change is available > in https://lkml.org/lkml/2011/11/25/107 > > Signed-off-by: Thomas Meyer > Signed-Off-by: Daniel Vetter > It looks nicer indeed, so: Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> _

Re: [Intel-gfx] [PATCH 40/43] drm/i915: ppgtt register definitions

2011-12-14 Thread Eugeni Dodonov
On Wed, Dec 14, 2011 at 10:57, Daniel Vetter wrote: > Signed-off-by: Daniel Vetter > Reviewed-by: Ben Widawsky > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.

Re: [Intel-gfx] [PATCH 42/43] drm/i915: per-ring fault reg

2011-12-14 Thread Eugeni Dodonov
y > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 15/43] drm/i915: add interface to simulate gpu hangs

2011-12-14 Thread Eugeni Dodonov
915_ring_stop automatically > resets after a gpu hang is detected to avoid hanging the gpu to fast > and declaring it wedged. > > v2: Incorporate feedback from Chris Wilson. > > v3: Add the missing cleanup. > > Signed-Off-by: Da

Re: [Intel-gfx] [PATCH 40/43] drm/i915: ppgtt register definitions

2011-12-14 Thread Eugeni Dodonov
On Wed, Dec 14, 2011 at 16:58, Eugeni Dodonov wrote: > On Wed, Dec 14, 2011 at 10:57, Daniel Vetter wrote: > >> Signed-off-by: Daniel Vetter >> Reviewed-by: Ben Widawsky >> > > Reviewed-by: Eugeni Dodonov > Just clarifying - the R-b is for the ppgtt series

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Update GEN6_RP_CONTROL definitions

2011-12-14 Thread Eugeni Dodonov
On Tue, Dec 13, 2011 at 01:21, Ben Widawsky wrote: > This matches the modern specs more accurately. > > This will be used by the following patch to fix the way we display RC > status. > > Signed-off-by: Ben Widawsky > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <h

Re: [Intel-gfx] [PATCH 4/4] drm/i915: drpc debugfs update for gen6

2011-12-14 Thread Eugeni Dodonov
naturally idle state on the > > GPU. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42578 > > Signed-off-by: Ben Widawsky > > --- > > Aside from the merge error: > > Reviewed-by: Jesse Barnes > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Force sync command ordering (Gen6+)

2011-12-15 Thread Eugeni Dodonov
on IVB at least. Anyone else wanna give it a try and confirm? > I've only tested with Eric's blit-and-wait.c test so far. > I am still hitting missed IRQs with gem_dummy_reloc_loop even with this one on IVB mobile :(. -- Eugeni Dodonov <http://eugeni.dodonov.net/>

Re: [Intel-gfx] [PATCH] tests/testdisplay.c: make the 3th pipe finish all the mode setting.

2011-12-16 Thread Eugeni Dodonov
On Thu, Dec 1, 2011 at 08:57, Yi Sun wrote: > If test all modes rather than preferred mode, remove framebuffer and set > CRTC to zero after each connector mode setting. > > Signed-off-by: Sun Yi > I forgot to comment on this before, but better late than never. Reviewed-by:

Re: [Intel-gfx] Moving intel_decode.c to libdrm

2011-12-21 Thread Eugeni Dodonov
and has been sitting on my todo list for way to long). > > Very-Much-Acked-by: Daniel Vetter > Yeah, I agree with Daniel - I'll be very happy to have this in libdrm. Thanks a lot! -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: re-disable semaphores on sandy bridge

2011-12-23 Thread Eugeni Dodonov
From: Eugeni Dodonov Per report from Udo Steinberg, enablement of semaphores causes issues on his Sandy Bridge. So disabling them again for this platform. Note that they are still enabled by default for Ivy Bridge. Reported-by: Udo Steinberg Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/3] intel: Disable drm_intel_probe_agp_aperture_size() on Android

2011-12-28 Thread Eugeni Dodonov
On Dec 27, 2011 6:41 PM, "Eric Anholt" wrote: > > On Fri, 23 Dec 2011 12:11:10 -0800, Chad Versace < chad.vers...@linux.intel.com> wrote: > > The function uses libpciaccess, which is not present on Android. So, make > > it a no-op that returns 0. > > It's a bug that we're not using this function

Re: [Intel-gfx] system freeze with kernel 3.2-rc7

2012-01-02 Thread Eugeni Dodonov
d check what happens during the hangs? The last dying words of the machine could be very helpful. Thanks! -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add support for resetting the SO write pointers on gen7.

2012-01-02 Thread Eugeni Dodonov
lue = IS_GEN7(dev); as it is gen7+-specific item. This way, userspace could check for this support early, and avoid setting the flag on the batchbuffer in vain on pre-gen7 architectures. Either way, it will work, so: Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/&g

Re: [Intel-gfx] gen7 missed IRQ workaround series.

2012-01-02 Thread Eugeni Dodonov
ould enable polling, and '0' would use the usual gen6_ring_get_irq. This would default to '1' on gen7, and '0' on older architectures. Other than that, Tested-by: Eugeni Dodonov Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___

Re: [Intel-gfx] [PATCH] drm/i915: paper over missed irq issues with force wake vodoo

2012-01-04 Thread Eugeni Dodonov
d with Eric's glCopyPixels loop which without this patch scores a > missed irq every few seconds. > > This patch needs my forcewake rework to use a spinlock instead of > dev->struct_mutex. > > Cc: sta...@kernel.org > Cc: Eric Anholt > Cc: Kenneth Graunke > Cc: Eug

Re: [Intel-gfx] [PATCH] drm/i915: paper over missed irq issues with force wake vodoo

2012-01-05 Thread Eugeni Dodonov
ms to work even without HWSTAM, I tried this too with base on Ben's HWSTAM disabling patches. So I think we have a winner :). -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/2] drm: give up on edid retries when i2c bus is not responding

2012-01-05 Thread Eugeni Dodonov
27; command: Machine 4: from 3.210s to 1.060s Reviewed-by: Chris Wilson Reviewed-by: Keith Packard Tested-by: Sean Finney Tested-by: Soren Hansen Tested-by: Hernando Torque Tested-by: Mike Lothian Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41059 Signed-off-by: Eugeni Dodonov

[Intel-gfx] [PATCH 2/2] drm/i915: there is no pipe CxSR on ironlake

2012-01-05 Thread Eugeni Dodonov
After checking the specs and discussing with Jesse, turns out CxSR is not available on Ironlake and gen5, and its advertisement on the device description is misleading. Acked-by: Jesse Barnes Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c |2 +- 1 files changed, 1

Re: [Intel-gfx] [PATCH 1/2] drm: give up on edid retries when i2c bus is not responding

2012-01-05 Thread Eugeni Dodonov
On Thu, Jan 5, 2012 at 12:43, Daniel Vetter wrote: > On Thu, Jan 05, 2012 at 09:34:28AM -0200, Eugeni Dodonov wrote: > > This allows to avoid talking to a non-responding bus repeatedly until we > > finally timeout after 15 attempts. We can do this by catching the -ENXIO > &g

Re: [Intel-gfx] linux intel and xorg status on i915GM hardware

2012-01-06 Thread Eugeni Dodonov
/bugs.freedesktop.org/show_bug.cgi?id=41059 apparently) shortly. -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: rip out the HWSTAM missed irq workaround

2012-01-06 Thread Eugeni Dodonov
y ducttape! Reviewed-by: Eugeni Dodonov Tested-by: Eugeni Dodonov I wonder if we could drop the definitions of GEN6_*_HWSTAM from i915_reg.h as well now... -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Compute a loadavg as the number of pending requests

2012-01-07 Thread Eugeni Dodonov
the GPU goes idle before the counters are reset and > sampling ceases. > > Sample output for running aa10text under gnome-shell: > > Total: 55.29 57.54 61.14 > render ring: 54.80 57.17 60.76 > gen6 bsd ring: 0.00 0.00 0.00 > blt ring: 0.48 0.37 0.37 > > Signed-off-by

[Intel-gfx] [PATCH 1/2] drm/i915: simplify pipe checking

2012-01-07 Thread Eugeni Dodonov
This is also handled by i915_reg.h, so just reuse this trick to reduce universe enthropy. Signed-off-by: Eugeni Dodonov Reviewed-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_suspend.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915: handle 3rd pipe

2012-01-07 Thread Eugeni Dodonov
We don't need to check 3rd pipe specifically, as it shares PLL with some other one. Signed-off-by: Eugeni Dodonov Reviewed-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_suspend.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_suspend

Re: [Intel-gfx] [PATCH] Add tools/intel_infoframes

2012-01-09 Thread Eugeni Dodonov
nge_avi_infoframe and parse_infoframe_option_s - you could just pass all the values as parameters instead. Other than that, Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://li

Re: [Intel-gfx] [PATCH] drm/i915: Compute a loadavg as the number of pending requests

2012-01-09 Thread Eugeni Dodonov
r statistics ... > Or we could start the worker when someone 'echo 1 > load_avg'. When it is not started, cat load_avg would say: "load_avg counter is stopped, echo 1 to enable it" for example. -- Eugeni Dodonov <http://eugeni.dodonov.net/> __

[Intel-gfx] 3.0/3.1 drm-intel-backports branches

2012-01-12 Thread Eugeni Dodonov
e-i915-for-stable-kernels/. Cheers, Eugeni -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] I915 regression : black screen at boot / Sandybridge Mobile (GT2)

2012-01-12 Thread Eugeni Dodonov
I wonder if it's an eDP config; my > t420 here works ok with current bits, but it uses LVDS. > If you are using eDP, you might be facing https://bugs.freedesktop.org/show_bug.cgi?id=42263 or https://bugs.freedesktop.org/show_bug.cgi?id=42278. Could you try with patch mentioned at http

Re: [Intel-gfx] I915 regression : black screen at boot / Sandybridge Mobile (GT2)

2012-01-12 Thread Eugeni Dodonov
On Jan 12, 2012 8:45 PM, "Jesse Barnes" wrote: > > On Thu, 12 Jan 2012 23:42:35 +0100 > Vincent Vanackere wrote: > > > On Thu, Jan 12, 2012 at 23:24, Jesse Barnes wrote: > > > > > On Thu, 12 Jan 2012 23:21:10 +0100 > > > Vincent Vanackere wrote: > > > > I'm happy to report that this patch indeed

Re: [Intel-gfx] [PATCH 0/2] drm/i915: interlaced mode support (G35 VGA/SDVO)

2012-01-16 Thread Eugeni Dodonov
familiar with this area, but both patches look correct to me and are according to the specs as far as I can see. So, for both of them: Reviewed-by: Eugeni Dodonov Thanks! P.S.: it would be interested to gather some Tested-by's for this though.. -- Eugeni Dodonov <http://eugeni.dodono

Re: [Intel-gfx] [PATCH] Android port of intel-gpu-tools

2012-01-16 Thread Eugeni Dodonov
eaks, we'll be able to notice it pretty shortly and fix it. -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] New drm-intel-next tree

2012-01-16 Thread Eugeni Dodonov
you running stable kernels who want to test the latest breakages^w features :). [1] http://comments.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/7961 -- Eugeni Dodonov ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: specify vertical timings in frame units for interlaced modes (gen4+)

2012-01-16 Thread Eugeni Dodonov
On Mon, Jan 16, 2012 at 17:50, Jesse Barnes wrote: > Do we get the ILK+ side right here? > >From the specs, looks like ILK and SNB+ share same logic for this part. -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing

Re: [Intel-gfx] [PATCH] drm/i915:: Disable FBC on SandyBridge

2012-01-17 Thread Eugeni Dodonov
n power saving figures for snb? > The FBC is good in some cases and bad in others. Let me confirm with our windows drivers friends first, but I'd say that we could disable it as it brings no significant improvements.. -- Eugeni Dodonov <http://eugeni.dodonov.net/>

Re: [Intel-gfx] [PATCH] drm/i915: kill i915_mem.c

2012-01-17 Thread Eugeni Dodonov
; > >> /me would like to kill this cruft > > All sounds good to me, kill it with fire. I've never known this code > to be used in anything. > I think we can kill it, it does not seems to be used by anything. Just to be sure - Eric, you was the last one to touch it

[Intel-gfx] [PATCH 1/1] drm/i915: add a LLC feature flag in device description

2012-01-17 Thread Eugeni Dodonov
LLC is not SNB/IVB-specific, so we should check for it in a more generic way. Reviewed-by: Chris Wilson Reviewed-by: Daniel Vetter Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_debugfs.c |1 + drivers/gpu/drm/i915/i915_dma.c |3 +++ drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH 1/1] intel: query for LLC support

2012-01-17 Thread Eugeni Dodonov
This adds support for querying the kernel about the LLC support in the hardware. In case the ioctl fails, we assume that it is present on GEN6 and GEN7. Signed-off-by: Eugeni Dodonov --- include/drm/i915_drm.h |1 + intel/intel_bufmgr_gem.c | 12 2 files changed, 13

[Intel-gfx] [PATCH 1/1] intel: query for LLC support

2012-01-17 Thread Eugeni Dodonov
This adds support for querying the kernel about the LLC support in the hardware. In case the ioctl fails, we assume that it is present on GEN6 and GEN7. Signed-off-by: Eugeni Dodonov --- include/drm/i915_drm.h |1 + intel/intel_bufmgr_gem.c | 12 2 files changed, 13

Re: [Intel-gfx] [PATCH 1/1] intel: query for LLC support

2012-01-17 Thread Eugeni Dodonov
On Tue, Jan 17, 2012 at 14:44, Eugeni Dodonov wrote: > This adds support for querying the kernel about the LLC support in the > hardware. > > In case the ioctl fails, we assume that it is present on GEN6 and GEN7. > > Signed-off-by: Eugeni Dodonov > Please ignore this and

[Intel-gfx] [PATCH 1/1] drm/i915: print out which pixel format we do not support

2012-01-17 Thread Eugeni Dodonov
Otherwise, we are left with pretty bogus message saying that the pixel format is not supported while leaving the details to the telepatic powers. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/intel_display.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a

[Intel-gfx] [PATCH 1/1] intel: query for LLC support

2012-01-17 Thread Eugeni Dodonov
This adds support for querying the kernel about the LLC support in the hardware. In case the ioctl fails, we assume that it is present on GEN6 and GEN7. v2: fix the return code checking Signed-off-by: Eugeni Dodonov --- include/drm/i915_drm.h |1 + intel/intel_bufmgr_gem.c | 12

[Intel-gfx] [PATCH 1/1] drm/i915: print out which pixel format we do not support

2012-01-17 Thread Eugeni Dodonov
Otherwise, we are left with pretty bogus message saying that the pixel format is not supported while leaving the details to the telepatic powers. v2: use DRM_DEBUG_KMS instead of DRM_ERROR Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/intel_display.c |3 ++- 1 files changed, 2

[Intel-gfx] [PATCH 1/2] sna: check for LLC support

2012-01-17 Thread Eugeni Dodonov
Instead of checking for CPU generation, use the libdrm-provided I915_PARAM_HAS_LLC instead. Signed-off-by: Eugeni Dodonov --- src/sna/kgem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sna/kgem.c b/src/sna/kgem.c index 970e462..96c5ddd 100644 --- a/src/sna

[Intel-gfx] [PATCH 2/2] configure: check for libdrm >= 2.4.31

2012-01-17 Thread Eugeni Dodonov
This is requried for I915_PARAM_HAS_LLC support. Signed-off-by: Eugeni Dodonov --- configure.ac |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 63beb64..604ea6d 100644 --- a/configure.ac +++ b/configure.ac @@ -132,6 +132,7

[Intel-gfx] [PATCH] sna: check for LLC support

2012-01-17 Thread Eugeni Dodonov
Instead of checking for CPU generation, use the libdrm-provided I915_PARAM_HAS_LLC instead. v2: use a define check to verify if we have I915_PARAM_HAS_LLC. Signed-off-by: Eugeni Dodonov --- src/sna/kgem.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src

Re: [Intel-gfx] Sandy Bridge Desktop - 1920x1080i interlace not working

2012-01-17 Thread Eugeni Dodonov
org/gmane.comp.freedesktop.xorg.drivers.intel/8006 Don't know if they will fix the problem, but they could help perhaps. -- Eugeni Dodonov <http://eugeni.dodonov.net/> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

<    1   2   3   4   5   6   7   >