Re: [Intel-gfx] [PATCH 20/31] drm/i915: simplify the reduced clock handling for pch plls

On Wed, Jun 05, 2013 at 01:34:22PM +0200, Daniel Vetter wrote: > Just move the lowfreq_avail logic out of the register writing as a > prep step for the next patch, which will coalesce all the pch pll > enabling into one spot. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_di

Re: [Intel-gfx] [PATCH 20/31] drm/i915: simplify the reduced clock handling for pch plls

On Thu, Jun 13, 2013 at 01:35:44PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 1:26 PM, Damien Lespiau > wrote: > > On Wed, Jun 05, 2013 at 01:34:22PM +0200, Daniel Vetter wrote: > >> Just move the lowfreq_avail logic out of the register writing as a > >>

[Intel-gfx] [PATCH] drm/i915: Add 0x2a43, a Cantiga device

on of that device on the mesa ml: http://comments.gmane.org/gmane.comp.video.mesa3d.devel/39899 (but we don't support it in either libdrm or mesa)? [1] http://en.wikipedia.org/wiki/Comparison_of_Intel_graphics_processing_units Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Add 0x2a43, a Cantiga device

On Thu, Jun 13, 2013 at 02:32:24PM +0100, Damien Lespiau wrote: > While browsing the nice list of Intel GPU devices on wikipedia [1], I > noticed that we don't have 0x2a43 in the list of Cantiga devices in our > driver. Turns out this device seems to be out there: > >

[Intel-gfx] [PATCH 2/10 v2] drm/i915: We implement WaFbcAsynchFlipDisableFbcQueue on ilk and snb

v2: Put the comment a bit closer to the actual write (Paulo Zanoni) Reviewed-by: Paulo Zanoni Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 57e99b1

[Intel-gfx] [PATCH] drm/i915: Bail out once we've found the context object

Once we've found the the context object programmed in CCID, there's no need to look the other objects in the list. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gp

Re: [Intel-gfx] [PATCH 21/31] drm/i915: consolidate pch pll enable sequence

t;mode_set callback to set the > divisors. Also streamline the enabling/disabling code a bit by > removing some cargo-cult duplication and clearing registers where > possible in the ->disable hook. > > v4: Remove now unused local variable. > > Signed-off-by: Daniel Vetter For

[Intel-gfx] Small FBC fix

I noticed on pre-HSW machines we get a spurious debug message: [drm:intel_update_fbc], fbc set to per-chip default [drm:intel_update_fbc], fbc disabled per module param but the fbc module parameter is not set. This series fixes it up. -- Damien ___

[Intel-gfx] [PATCH 2/2] drm/i915: Fix reason for per-chip disabling of FBC

overridden inside the "per-chip default" code. Fix up the logic and add another reason for the FBC to the be disabled. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 14 ++-

[Intel-gfx] [PATCH 1/2] drm/i915: Make intel_enable_fbc() static

This function has no user outside of intel_pm.c. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_pm.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h

Re: [Intel-gfx] [PATCH] drm/i915: tune down DIDL warning about too many outputs

On Mon, Jun 24, 2013 at 06:32:36PM +0200, Daniel Vetter wrote: > Nothing the user (nor we) really can do about this, but upsets a nice > quiet boot. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65988 > Signed-off-by: Daniel Vetter Reviewed-by: Damien Lespi

[Intel-gfx] [PATCH] drm/i915: Introduce an HAS_IPS() macro

Follow the trend and don't code conditions with platforms but with features. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_display.c | 4 ++-- 3 files changed, 5 insertions(+), 3 dele

[Intel-gfx] [PATCH 1/3] drm/i915: Use seq_puts/seq_putc when possible

Caught with checkpatch.pl. Suggested-by: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 110 ++-- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/3] drm/i915: Fix a few style issues found by checkpatch.pl

Missing spaces and misplaced '*'. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 858688d..7afc967 10

[Intel-gfx] [PATCH 3/3] drm/i915: Fix a couple of "should it be static?" sparse warnings

A genuine 'static' omission and 2 other warnings triggered by not including the header where those functions where defined. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_pm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH] drm/i915: Remove duplicated WaForceL3Serialization:vlv

On Tue, Jun 25, 2013 at 04:38:21PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > No need to apply WaForceL3Serialization:vlv twice. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_pm.c | 4

Re: [Intel-gfx] [PATCH 1/3] intel/aub: Sync the AUB defines with mesa's

Just remembered that Ken reviewed those 3 patches on IRC. So pushed them. -- Damien On Wed, Feb 20, 2013 at 12:11:48PM +, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau > --- > intel/intel_aub.h | 76 > + > 1 fi

Re: [Intel-gfx] [PATCH 1/2] drm/i915: explicitly cast pipe -> cpu_transcoder

> and the cpu transcoder. > > Signed-off-by: Daniel Vetter For both patches: Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_display.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/int

Re: [Intel-gfx] [PATCH -next] drm/i915: fix potential NULL pointer dereference in i915_gem_context_get_hang_stats()

On Thu, Jun 20, 2013 at 08:01:47AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > The dereference should be moved below the NULL test. > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/i915/i915_gem_context.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/d

[Intel-gfx] [PATCH] drm/i915: Don't check if a drm_file * is NULL in the ioctl code path

Right now code checkers point out that we try to dereference file before testing it for NULL. This check doesn't seem necessary as file needs to be valid for the ioctl() code to run. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_gem_context.c | 3 --- 1 file changed, 3 dele

[Intel-gfx] [PATCH] drm/i915: Skip pixel multiplier x-check if we fail to send the command

If intel_sdvo_get_value() fails here, val is unitialized and the cross check won't check anything. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_sdvo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gp

[Intel-gfx] [PATCH] drm/i915: Use for_each_pipe() when possible

Came accross two open coding of for_each_pipe(), might as well use the macro. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Skip pixel multiplier x-check if we fail to send the command

On Thu, Jul 11, 2013 at 09:52:33PM +0200, Daniel Vetter wrote: > On Thu, Jul 11, 2013 at 07:46:00PM +0100, Damien Lespiau wrote: > > If intel_sdvo_get_value() fails here, val is unitialized and the cross > > check won't check anything. > > > > Signed-off-by: Dami

[Intel-gfx] [PATCH 1/2] drm/i915: Don't attempt to read an unitialized stack value

: Do the cross check with the initial value of encoder_pixel_multiplier (0) if the sdvo command fails (and thus keep the warning) (Daniel Vetter) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_sdvo.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions

Re: [Intel-gfx] [PATCH 1/5] drm/i915/hsw: Set correct Haswell PTE encodings.

esolve conflicts due to patch series reordering. > > v4: Rebased on top of Kenneth Graunke's ->pet_encode refactoring. > > v5: Removed eLLC bits for separate patch. > > In the internal repository this was: > Signed-off-by: Ben Widawsky > Signed-off-by: Kenneth Graunk

Re: [Intel-gfx] [PATCH 1/5] drm/i915/hsw: Set correct Haswell PTE encodings.

On Thu, Jul 04, 2013 at 11:02:03AM -0700, Ben Widawsky wrote: > +/* Cacheability Control is a 4-bit value. The low three bits are stored in * > + * bits 3:1 of the PTE, while the fourth bit is stored in bit 11 of the PTE. > + */ > +#define HSW_CACHEABILITY_CONTROL(bits) bits) & 0x7) << 1)

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Don't try to calculate RC6 residency on GEN4 and before

On Tue, Jul 16, 2013 at 10:34:06AM +0200, Daniel Vetter wrote: > Ok, I've merged the patches in this series for which I've found an r-b > tag. Some are still in limbo though. Thanks for doing that, I still need to answer questions from Paulo and the last two of them are 'hard' because we don't kno

[Intel-gfx] [PATCH i-g-t] build: Depend on cairo 1.12.0 for CAIRO_FORMAT_RGB30

We've somewhat recently added RGB30 support to testdisplay, but we need cairo 1.12.0 for that. Barf early. Signed-off-by: Damien Lespiau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f65942f..2eba12a 100644

[Intel-gfx] Provide a simulation friendly test environment v4

It was high time to follow up on: http://lists.freedesktop.org/archives/intel-gfx/2013-April/027361.html Changes from v2: • Take into account Daniel's comments and add the tests he listed • Actually runs on simulation now -- Damien ___ Intel-gfx

[Intel-gfx] [PATCH 1/8] lib: Rename IGT_QUICK to INTEL_SIMULATION

It's more accurate this way as the quick mode is really useful for in the simulation environment. v2: Use the INTEL_ prefix to have a chance to share the same environment variable as piglit OpenGL tests Signed-off-by: Damien Lespiau --- lib/drmtest.c | 10 +- lib/drmtest.h

[Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

This will allow us to explicitely blacklist tests we don't want to run on simulation. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 12 lib/drmtest.h | 1 + 2 files changed, 13 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index 76c84b1..a9a7498 100644 ---

[Intel-gfx] [PATCH 4/8] tests: Black list tests we don't want to run on simulation

blits gem_tiled_blits gem_cpu_reloc gem_exec_nop gem_mmap_gtt v2 add (Daniel Vetter) gem_exec_bad_domains gem_exec_faulting_reloc gem_flink gem_reg_read gem_reloc_overflow gem_tiling_max_stride prime_* Signed-off-by: Damien Lespiau --- tests/drm_lib.sh | 7 +++

[Intel-gfx] [PATCH 5/8] tests: Instrument tests run in simulation to run quickly

Signed-off-by: Damien Lespiau --- tests/gem_cpu_reloc.c | 3 +++ tests/gem_ctx_basic.c | 5 + tests/gem_exec_nop.c| 2 +- tests/gem_mmap_gtt.c| 5 - tests/gem_pipe_control_store_loop.c | 2 +- tests/gem_render_linear_blits.c

[Intel-gfx] [PATCH 7/8] tests: Instrument gem_seqno_wrap to run in simulation

Signed-off-by: Damien Lespiau --- tests/gem_seqno_wrap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/gem_seqno_wrap.c b/tests/gem_seqno_wrap.c index f354a52..8d94858 100644 --- a/tests/gem_seqno_wrap.c +++ b/tests/gem_seqno_wrap.c @@ -577,7 +577,7 @@ static void

[Intel-gfx] [PATCH 8/8] tests: Add some tiled tests to the runs on simulation

Signed-off-by: Damien Lespiau --- tests/gem_tiled_pread.c| 2 -- tests/gem_tiled_pread_pwrite.c | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/gem_tiled_pread.c b/tests/gem_tiled_pread.c index 779f66f..189affc 100644 --- a/tests/gem_tiled_pread.c +++ b

[Intel-gfx] [PATCH 3/8] lib: Remove old dead code intel_batchbuffer_emit_mi_flush()

Signed-off-by: Damien Lespiau --- lib/intel_batchbuffer.c | 7 --- lib/intel_batchbuffer.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index 724e23d..c6c8153 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c

[Intel-gfx] [PATCH 6/8] tests: Instrument gem_lut_handle for simulation

Signed-off-by: Damien Lespiau --- tests/gem_lut_handle.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/gem_lut_handle.c b/tests/gem_lut_handle.c index fdd2ab8..f3e5734 100644 --- a/tests/gem_lut_handle.c +++ b/tests/gem_lut_handle.c @@ -183,8 +183,6 @@ int main(int

Re: [Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

On Thu, Jul 18, 2013 at 09:31:15AM -0700, Ben Widawsky wrote: > On Thu, Jul 18, 2013 at 09:18:34AM -0700, Jesse Barnes wrote: > > On Thu, 18 Jul 2013 16:19:07 +0100 > > Damien Lespiau wrote: > > > > > This will allow us to explicitely blacklist tests we don

Re: [Intel-gfx] Provide a simulation friendly test environment v4

On Thu, Jul 18, 2013 at 05:50:55PM +0200, Daniel Vetter wrote: > On Thu, Jul 18, 2013 at 04:19:05PM +0100, Damien Lespiau wrote: > > It was high time to follow up on: > > http://lists.freedesktop.org/archives/intel-gfx/2013-April/027361.html > > > > Changes from v2

[Intel-gfx] [PATCH 2/8] build: Fix unbalanced quoting in the python dumper AC_ARG_ENABLE()

Signed-off-by: Damien Lespiau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 59d01cf..caf929c 100644 --- a/configure.ac +++ b/configure.ac @@ -104,7 +104,7 @@ AM_CONDITIONAL(HAVE_NOUVEAU, [test "x$NOUVEAU&qu

[Intel-gfx] i-g-t --enable-simulation and various build fixes

Jesse suggested an --enable-simulation configure option because having to remember setting the env variable is too hard. After having experienced that myself and gone through several painful stop/restart cycles of the simulation, I decided it was worth making it happen. -- Damien ___

[Intel-gfx] [PATCH 3/8] build: Fix automake 1.13 warnings

warning: deprecated feature: target 'sr' overrides 'sr$(EXEEXT)' Signed-off-by: Damien Lespiau --- debugger/system_routine/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debugger/system_routine/Makefile.am b/debugger/system_routine/Makef

[Intel-gfx] [PATCH 5/8] lib: Allow users of env_set() to specify a default value

So when the environment value isn't set, one can specify the default value to return. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 016619c..26748b3 100644 --- a/lib/drmtest.c

[Intel-gfx] [PATCH 4/8] build: Pimp up the configure summary

This helps people compiling i-g-t figuring out what can be optional. Signed-off-by: Damien Lespiau --- configure.ac | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index caf929c..1626ce8 100644 --- a/configure.ac +++ b/configure.ac

[Intel-gfx] [PATCH 7/8] tests: Source drm_lib.sh instead of having its own INTEL_SIMULATION test

One code path to maintain is always better. Signed-off-by: Damien Lespiau --- tests/sysfs_edid_timing | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/sysfs_edid_timing b/tests/sysfs_edid_timing index 2a43cca..e90e374 100755 --- a/tests/sysfs_edid_timing +++ b/tests

[Intel-gfx] [PATCH 6/8] tests: Allow a shell test to declare it doesn't need to be DRM master

Signed-off-by: Damien Lespiau --- tests/drm_lib.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh index 2532352..25197d4 100755 --- a/tests/drm_lib.sh +++ b/tests/drm_lib.sh @@ -26,7 +26,8 @@ fi # read everything we can if [ `cat

[Intel-gfx] [PATCH 8/8] build: Provide an --enable-simulation configure option

Remembering to set an environment variable is too much trouble, we can now specify --enable-simulation at configure time and always run the test suite tuned for simulation. Signed-off-by: Damien Lespiau --- configure.ac| 11 +++ lib/drmtest.c

[Intel-gfx] [PATCH 1/8] build: Fix a small typo in configure.ac

Signed-off-by: Damien Lespiau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 2eba12a..59d01cf 100644 --- a/configure.ac +++ b/configure.ac @@ -61,7 +61,7 @@ XORG_MACROS_VERSION(1.16) XORG_DEFAULT_OPTIONS # warning flags

Re: [Intel-gfx] [PATCH 8/8] build: Provide an --enable-simulation configure option

On Fri, Jul 19, 2013 at 07:05:29PM +0200, Daniel Vetter wrote: > On Fri, Jul 19, 2013 at 05:49:48PM +0100, Damien Lespiau wrote: > > Remembering to set an environment variable is too much trouble, we can > > now specify --enable-simulation at configure time and always run the >

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

On Mon, Jul 22, 2013 at 08:05:10AM +0200, Daniel Vetter wrote: > +static int hdmi_portclock_limit(struct intel_hdmi *hdmi) > +{ > + struct drm_device *dev = intel_hdmi_to_dev(hdmi); > + > + if (IS_G4X(dev)) > + return 165000; > + else if (IS_HASWELL(dev)) > + ret

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67048 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 > Tested-by: Andreas Reis (v2) > Cc: Damien Lespiau > Signed-off-by: Daniel Vetter Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

On Mon, Jul 22, 2013 at 12:17:12PM +0100, Damien Lespiau wrote: > On Mon, Jul 22, 2013 at 08:05:10AM +0200, Daniel Vetter wrote: > > +static int hdmi_portclock_limit(struct intel_hdmi *hdmi) > > +{ > > + struct drm_device *dev = intel_hdmi_to_dev(hdmi); > &g

[Intel-gfx] [edid-decode] Decode HDMI 1.4 4k VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 9840db6..f74bbe4 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -625,7 +625,7 @@ cea_hdmi_block(unsigned char *x

[Intel-gfx] [PATCH] uxa/display: Keep the EDID blob around for the lifetime of an output

xf86InterpretEDID() doesn't copy the EDID raw data in xf86MonPtr but just stores the given pointer. The DDX driver needs to make sure that data stays valid. Signed-off-by: Damien Lespiau --- src/uxa/intel_display.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[Intel-gfx] Port the i915 HDMI infoframe code to the common infrastructure

It's time to revive Thierry and Paulo effort to port the i915 HDMI infoframe code to the common helpers. Last attempt was: http://lists.freedesktop.org/archives/dri-devel/2013-February/035202.html I've split the series a bit to address Daniel's concerns about reviewability and pimped up video/h

[Intel-gfx] [PATCH 1/8] video/hdmi: Replace the payload length by their defines

Cc: Thierry Reding Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index 4017833..dbd882f 100644 --- a/drivers/video/hdmi.c +++ b/drivers/video/hdmi.c @@ -52,7 +52,7

[Intel-gfx] [PATCH 2/8] video/hdmi: Introduce a generic hdmi_infoframe union

And a way to pack hdmi_infoframe generically. Cc: Thierry Reding Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 43 +++ include/linux/hdmi.h | 17 + 2 files changed, 60 insertions(+) diff --git a/drivers/video/hdmi.c b/drivers

[Intel-gfx] [PATCH 3/8] video/hdmi: Add a macro to return the size of a full infoframe

Cc: Thierry Reding Signed-off-by: Damien Lespiau --- include/linux/hdmi.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h index 0f3f82e..bc6743e 100644 --- a/include/linux/hdmi.h +++ b/include/linux/hdmi.h @@ -23,6 +23,9 @@ enum

[Intel-gfx] [PATCH 4/8] drm/i915/hdmi: Change the write_infoframe vfunc to take a buffer and a type

First step in the move to the shared infoframe infrastructure, let's move the different infoframe helpers and the write_infoframe() vfunc to a type (enum hdmi_infoframe_type) and a buffer + len instead of using our struct dip_infoframe. Signed-off-by: Damien Lespiau Signed-off-by: Paulo Z

[Intel-gfx] [PATCH 5/8] drm/i915/hdmi: Port the infoframe code to the common hdmi helpers

Let's use the drivers/video/hmdi.c and drm infoframe helpers to build our infoframes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_hdmi.c | 94 +-- 1 file changed, 70 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 6/8] drm/i915/hmdi: Rename set_infoframe() to write_infoframe()

set_frame() wraps the write_frame() vfunc. Be consistent and name the wrapping function like the vfunc being called. It's doubly confusing as we also have a set_infoframes() vfunc and set_infoframe() doesn't wrap it. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 7/8] drm/i915/sdvo: Port the infoframe code to the shared infrastructure

Signed-off-by: Damien Lespiau Signed-off-by: Paulo Zanoni Signed-off-by: Thierry Reding --- drivers/gpu/drm/i915/intel_sdvo.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 8/8] drm/i915: Remove the now obsolete infoframe definitions

All the HDMI infoframe code has been ported to use video/hdmi.c, so it's time to say bye bye to this code. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_drv.h | 61 --- drivers/gpu/drm/i915/intel_hdmi.c | 15 -- 2 files change

Re: [Intel-gfx] [PATCH 6/8] drm/i915/hmdi: Rename set_infoframe() to write_infoframe()

On Mon, Aug 05, 2013 at 08:50:45PM +0300, Ville Syrjälä wrote: > On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote: > > set_frame() wraps the write_frame() vfunc. Be consistent and name the > > wrapping function like the vfunc being called. > > > > It&#x

Re: [Intel-gfx] [PATCH 6/8] drm/i915/hmdi: Rename set_infoframe() to write_infoframe()

On Tue, Aug 06, 2013 at 08:01:34PM +0200, Daniel Vetter wrote: > On Tue, Aug 6, 2013 at 7:49 PM, Damien Lespiau > wrote: > > On Mon, Aug 05, 2013 at 08:50:45PM +0300, Ville Syrjälä wrote: > >> On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote: > &g

Re: [Intel-gfx] [PATCH 5/8] drm/i915/hdmi: Port the infoframe code to the common hdmi helpers

On Mon, Aug 05, 2013 at 04:12:11PM +0300, Ville Syrjälä wrote: > > static void intel_set_infoframe(struct drm_encoder *encoder, > > - struct dip_infoframe *frame) > > + union hdmi_infoframe *frame) > > { > > struct intel_hdmi *intel_hdmi = e

[Intel-gfx] Port the i915 HDMI infoframe code to the common infrastructure v2

Re-posting the whole series because I forgot dri-devel in the first version and also added a few patches from the review. Version 2 of the series: http://lists.freedesktop.org/archives/intel-gfx/2013-August/031183.html With Ville's comments so far addressed. I've also added the already posted

[Intel-gfx] [PATCH 01/12] video/hdmi: Replace the payload length by their defines

Cc: Thierry Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index 4017833..dbd882f 100644 --- a/drivers/video/hdmi.c +++ b/drivers

[Intel-gfx] [PATCH 02/12] video/hdmi: Introduce a generic hdmi_infoframe union

And a way to pack hdmi_infoframe generically. Cc: Thierry Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 43 +++ include/linux/hdmi.h | 17 + 2 files changed, 60 insertions(+) diff --git a

[Intel-gfx] [PATCH 03/12] video/hdmi: Add a macro to return the size of a full infoframe

Cc: Thierry Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- include/linux/hdmi.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h index 0f3f82e..bc6743e 100644 --- a/include/linux/hdmi.h +++ b/include/linux/hdmi.h @@ -23,6

[Intel-gfx] [PATCH 04/12] video/hmdi: Clear the whole incoming buffer, not just the infoframe size

x27;s zero the whole incoming buffer as those extra bytes are also used to compute the ECC and need to be 0. Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index f7

[Intel-gfx] [PATCH 05/12] drm: Don't generate invalid AVI infoframes for CEA modes

Reding Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 95d6f4b..8d1139f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH 06/12] drm/i915/hdmi: Change the write_infoframe vfunc to take a buffer and a type

mix signs (Ville Syrjälä) Signed-off-by: Damien Lespiau Signed-off-by: Paulo Zanoni Signed-off-by: Thierry Reding --- drivers/gpu/drm/i915/intel_drv.h | 4 +- drivers/gpu/drm/i915/intel_hdmi.c | 106 -- 2 files changed, 59 insertions(+), 51 deletions(-) di

[Intel-gfx] [PATCH 07/12] drm/i915/hdmi: Port the infoframe code to the common hdmi helpers

Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_hdmi.c | 82 +++ 1 file changed, 58 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index ee67e23..455dfa7 100644

[Intel-gfx] [PATCH 08/12] drm/i915/sdvo: Port the infoframe code to the shared infrastructure

Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau Signed-off-by: Paulo Zanoni Signed-off-by: Thierry Reding --- drivers/gpu/drm/i915/intel_sdvo.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 09/12] drm/i915: Remove the now obsolete infoframe definitions

All the HDMI infoframe code has been ported to use video/hdmi.c, so it's time to say bye bye to this code. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_drv.h | 61 --- drivers/gpu/drm/i915/intel_hdmi.c

[Intel-gfx] [PATCH 10/12] drm: Handle the DBLCLK flag in the common infoframe helper

Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c| 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 8d1139f..a9c8980

[Intel-gfx] [PATCH 11/12] drm: Set aspect ratio fields in the AVI infoframe even for non CEA modes

I cannot find any evidence what we shouldn't try to set those fields when setting a non-CEA mode on an HDMI sink. So just kill that return. Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH 12/12] drm/i915/hmdi: Rename set_infoframe() to write_infoframe()

set_frame() wraps the write_frame() vfunc. Be consistent and name the wrapping function like the vfunc being called. It's doubly confusing as we also have a set_infoframes() vfunc and set_infoframe() doesn't wrap it. Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drive

Re: [Intel-gfx] [PATCH 04/12] video/hmdi: Clear the whole incoming buffer, not just the infoframe size

On Wed, Aug 07, 2013 at 01:56:58PM +0300, Ville Syrjälä wrote: > On Tue, Aug 06, 2013 at 08:32:16PM +0100, Damien Lespiau wrote: > > If the user if this API is providing a bigger buffer than the infoframe > > size, it could be for a could reason. For instance it could be because &

[Intel-gfx] Some edid-decode patches

A bit more context than the previous patch that was a bit alone. This series parses yet a bit more of the EDID: - The HDMI VICs in the HDMI vendor specific block (HDMI 1.4, 4k modes) - The CEA Video Capability Data Block It also includes 2 EDIDs of TVs that have those bits. -- Damien __

[Intel-gfx] [edid-decode 1/7] Print the resolutions next to the CEA VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 84 +-- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 9840db6..7515181 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -32,6 +32,8

[Intel-gfx] [edid-decode 2/7] Add Skyworth 50E780U 50" edid (4k TV)

Signed-off-by: Damien Lespiau --- data/skyworth-50e780u-hdmi | Bin 0 -> 256 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 data/skyworth-50e780u-hdmi diff --git a/data/skyworth-50e780u-hdmi b/data/skyworth-50e780u-hdmi new file mode 100644 in

[Intel-gfx] [edid-decode 3/7] Decode HDMI 1.4 4k VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 7515181..55e48a7 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -705,7 +705,7 @@ cea_hdmi_block(unsigned char *x

[Intel-gfx] [edid-decode 4/7] Print the HDMI resolution next to the HDMI VICs

Signed-off-by: Damien Lespiau --- edid-decode.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 55e48a7..5061228 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -659,6 +659,13 @@ cea_video_block(unsigned char *x

[Intel-gfx] [edid-decode 5/7] Add the EDID of a Samsung TV that has a VCDB

--- data/samsung-UE40D8000YU-hmdi | Bin 0 -> 256 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 data/samsung-UE40D8000YU-hmdi diff --git a/data/samsung-UE40D8000YU-hmdi b/data/samsung-UE40D8000YU-hmdi new file mode 100644 index

[Intel-gfx] [edid-decode 6/7] Add a small framework to decode fields generically

Signed-off-by: Damien Lespiau --- edid-decode.c | 69 +-- 1 file changed, 67 insertions(+), 2 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 5061228..7aed3c6 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -32,8 +32,6

[Intel-gfx] [edid-decode 7/7] Decode the Video Capability Data Block

Signed-off-by: Damien Lespiau --- edid-decode.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/edid-decode.c b/edid-decode.c index 7aed3c6..58297c9 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -861,6 +861,44 @@ cea_hdmi_block(unsigned char *x

[Intel-gfx] [edid-decode] Add a small framework to decode fields generically

v2: Fix rebase fail that removed a necessary hunk Signed-off-by: Damien Lespiau --- edid-decode.c | 67 +++ 1 file changed, 67 insertions(+) diff --git a/edid-decode.c b/edid-decode.c index 5061228..083ddd9 100644 --- a/edid-decode.c

[Intel-gfx] HDMI 4k support

(and in 2.21.14) Author: Damien Lespiau Date: Wed Jul 31 18:50:51 2013 +0100 uxa/display: Keep the EDID blob around for the lifetime of an output * My "Use the TMDS maximum frequency to check mode dot clock" xserver series: http://lists.x.org/archiv

[Intel-gfx] [PATCH 1/2] drm/edid: Fix add_cea_modes() style issues

A few styles issues have creept in here, fix them before touching this code again. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 95d6f4b

[Intel-gfx] [PATCH 2/2] drm/edid: Parse the HDMI CEA block and look for 4k modes

HDMI 1.4 adds 4 "4k x 2k" modes in the the CEA vendor specific block. With this commit, we now parse this block and expose the 4k modes that we find there. Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 --- drive

[Intel-gfx] [PATCH 1/7] drm/i915: Remove stale prototypes

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 8 drivers/gpu/drm/i915/intel_drv.h | 2 -- 2 files changed, 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 7863c8a..db54923 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] Dead code cleanups

Procrastinating... at least a small consolation prize: 5 files changed, 11 insertions(+), 104 deletions(-) -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/7] drm/i915: Fix #endif comment

Did you say OCD? Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_gem_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_debug.c b/drivers/gpu/drm/i915/i915_gem_debug.c index bcdbafc..775d506 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/7] drm/i915: Remove i915_gem_object_check_coherency()

This code was dead since: commit 432e58edc9de1d9c3d6a7b444b3c455b8f209a7d Author: Chris Wilson Date: Thu Nov 25 19:32:06 2010 + drm/i915: Avoid allocation for execbuffer object list so just put it to rest for good. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 6/7] drm/i915: Remove intel_modeset_disable()

Caught by the dead code police! Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 10 -- drivers/gpu/drm/i915/intel_drv.h | 1 - 2 files changed, 11 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index

[Intel-gfx] [PATCH 4/7] drm/i915: Make i915_hangcheck_elapsed() static

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/i915_irq.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 0be923e..6141253 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 5/7] drm/i915: Make intel_encoder_dpms() static

And also fix a small typo in the intel_encoder_dpms() comment. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b

[Intel-gfx] [PATCH 7/7] drm/i915: Make intel_set_mode() static

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 10 +++--- drivers/gpu/drm/i915/intel_drv.h | 2 -- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 30bd7f1..6755525

<    1   2   3   4   5   6   7   8   9   10   >