[Intel-gfx] [PATCH v2] drm/i915:gen9: restrict WaC6DisallowByGfxPause

2016-07-20 Thread tim . gore
From: Tim Gore WaC6DisallowByGfxPause is currently applied unconditionally but is not required in all revisions. v2: extend application of workaround to agree with w/a database, which differs from the HSD. References: HSD#2133391 Signed-off-by: Tim Gore --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause

2016-07-15 Thread tim . gore
From: Tim Gore WaC6DisallowByGfxPause is currently applied unconditionally but is not required in all revisions. References: HSD#2133391 Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/intel_guc_loader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2] drm/i915:gen9: implement WaMediaPoolStateCmdInWABB

2016-07-05 Thread tim . gore
From: Tim Gore This patch applies WaMediaPoolStateCmdInWABB which fixes a problem with the restoration of thread counts on resuming from RC6. References: HSD#2137167 Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/intel_lrc.c | 25 + 1 file changed, 25 insertions

[Intel-gfx] [PATCH] drm/i915:gen9: implement WaMediaPoolStateCmdInWABB

2016-07-04 Thread tim . gore
From: Tim Gore This patch applies WaMediaPoolStateCmdInWABB which fixes a problem with the restoration of thread counts on resuming from RC6. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/intel_lrc.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH v2] drm/i915:gen9: implement WaMtpRenderPowerGatingBug

2016-06-20 Thread tim . gore
From: Tim Gore This patch applies WaMtpRenderPowerGatingBug which overcomes a hang during mid thread pre-emption when running OCL test: test_allocations64.exe single 5 all. v2: Fix build break due to some git fail on my part Fix camel case variable names (Dave Gordon) Only apply to G0

[Intel-gfx] [PATCH] drm/i915:gen9: implement WaMtpRenderPowerGatingBug

2016-06-16 Thread tim . gore
From: Tim Gore This patch applies WaMtpRenderPowerGatingBug which overcomes a hang during mid thread pre-emption when running OCL test: test_allocations64.exe single 5 all. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 5 drivers/gpu/drm/i915/intel_lrc.c | 52

[Intel-gfx] [PATCH v3] drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate

2016-06-13 Thread tim . gore
From: Tim Gore This patch enables a workaround for a mid thread preemption issue where a hardware timing problem can prevent the context restore from happening, leading to a hang. v2: move to gen9_init_workarounds (Arun) v3: move to start of gen9_init_workarounds (Arun) Signed-off-by: Tim Gore

[Intel-gfx] [PATCH v2] drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate

2016-06-09 Thread tim . gore
From: Tim Gore This patch enables a workaround for a mid thread preemption issue where a hardware timing problem can prevent the context restore from happening, leading to a hang. v2: move to gen9_init_workarounds (Arun) Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 4

[Intel-gfx] [PATCH] drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate

2016-06-09 Thread tim . gore
From: Tim Gore This patch enables a workaround for a mid thread preemption issue where a hardware timing problem can prevent the context restore from happening, leading to a hang. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++ drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf

2016-04-22 Thread tim . gore
From: Tim Gore This patch applies a performance enhancement workaround based on analysis of DX and OCL S-Curve workloads. We increase the General Priority Credits for L3SQ from the hardware default of 56 to the max value 62, and decrease the High Priority credits from 8 to 2. v2: Only apply to

[Intel-gfx] [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf

2016-04-21 Thread tim . gore
From: Tim Gore This patch applies a performance enhancement workaround based on analysis of DX and OCL S-Curve workloads. We increase the General Priority Credits for L3SQ from the hardware default of 56 to the max value 62, and decrease the High Priority credits from 8 to 2. v2: Only apply to

[Intel-gfx] [PATCH v2] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf

2016-04-20 Thread tim . gore
From: Tim Gore This patch applies a performance enhancement workaround based on analysis of DX and OCL S-Curve workloads. v2: Only apply to B0 onwards Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions

[Intel-gfx] [PATCH] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf

2016-04-20 Thread tim . gore
From: Tim Gore This patch applies a performance enhancement workaround based on analysis of DX and OCL S-Curve workloads. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

2016-04-19 Thread tim . gore
From: Tim Gore WaEnableSamplerGPGPUPreemptionSupport fixes a problem related to mid thread pre-emption. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 7 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915:bxt: Enable Pooled EU support

2016-04-15 Thread tim . gore
From: Tim Gore This is a re-send of patch 3/3 from Arun Siluvery's patch series "Add Pooled EU support to BXT", originally submitted 20 July 2015. Patches 1 and 2 are already merged in preparation. This final patch actually enables the feature. The rest of this commit message is

[Intel-gfx] [PATCH] drm/i915:bxt: Enable Pooled EU support

2016-04-14 Thread tim . gore
From: Tim Gore This is a re-send of patch 3/3 from Arun Siluvery's patch series "Add Pooled EU support to BXT", originally submitted 20 July 2015. Patches 1 and 2 are already merged in preparation. This final patch actually enables the feature. The rest of this commit message is

[Intel-gfx] [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

2016-04-12 Thread tim . gore
From: Tim Gore WaEnableSamplerGPGPUPreemptionSupport fixes a problem related to mid thread pre-emption. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 7 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

2016-04-07 Thread tim . gore
From: Tim Gore WaEnableSamplerGPGPUPreemptionSupport fixes a problem related to mid thread pre-emption. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 7 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

2016-04-06 Thread tim . gore
From: Tim Gore WaEnableSamplerGPGPUPreemptionSupport fixes a problem related to mid thread pre-emption. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 7 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH v4] drm/i915: implement WaClearTdlStateAckDirtyBits

2016-03-21 Thread tim . gore
From: Tim Gore This is to fix a GPU hang seen with mid thread pre-emption and pooled EUs. v2. Use IS_BXT_REVID instead of IS_BROXTON and INTEL_REVID v3. And use correct type for register addresses Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 12 drivers/gpu

[Intel-gfx] [PATCH v3] drm/i915/gen9: add WaClearFlowControlGpgpuContextSave

2016-03-18 Thread tim . gore
From: Tim Gore This allows writes to EU flow control registers. Together with SIP code from the user-mode driver this resolves a hang seen in some pre-emption scenarios. Note that this patch is just the kernel mode part of this workaround. v2. Oops, add FLOW_CONTROL_ENABLE macro to i915_reg.h

[Intel-gfx] [PATCH v3] drm/i915: implement WaClearTdlStateAckDirtyBits

2016-03-10 Thread tim . gore
From: Tim Gore This is to fix a GPU hang seen with mid thread pre-emption and pooled EUs. v2. Use IS_BXT_REVID instead of IS_BROXTON and INTEL_REVID v3. And use correct type for register addresses Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 12 drivers/gpu

[Intel-gfx] [PATCH] drm/i915: implement WaClearTdlStateAckDirtyBits

2016-03-09 Thread tim . gore
From: Tim Gore This is to fix a GPU hang seen with mid thread pre-emption and pooled EUs. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/i915_reg.h | 12 drivers/gpu/drm/i915/intel_lrc.c | 19 +++ 2 files changed, 31 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2] drm/i915/gen9: add WaClearFlowControlGpgpuContextSave

2016-03-09 Thread tim . gore
From: Tim Gore This allows writes to EU flow control registers. Together with SIP code from the user-mode driver this resolves a hang seen in some pre-emption scenarios. Note that this patch is just the kernel mode part of this workaround. v2. Oops, add FLOW_CONTROL_ENABLE macro to i915_reg.h

[Intel-gfx] [PATCH] drm/i915/gen9: add WaClearFlowControlGpgpuContextSave

2016-03-09 Thread tim . gore
From: Tim Gore This allows writes to EU flow control registers. Together with SIP code from the user-mode driver this resolves a hang seen in some pre-emption scenarios. Note that this patch is just the kernel mode part of this workaround. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: implement WaIncreaseDefaultTLBEntries

2016-02-04 Thread tim . gore
From: Tim Gore WaIncreaseDefaultTLBEntries increases the number of TLB entries available for GPGPU workloads and gives significant ( > 10% ) performance gain for some OCL benchmarks. Put this in a new function that can be a place for workarounds that are GT related but not required per r

[Intel-gfx] [PATCH v3] drm/i915: add WaIncreaseDefaultTLBEntries

2016-02-01 Thread tim . gore
From: Tim Gore WaIncreaseDefaultTLBEntries increases the number of TLB entries available for GPGPU workloads and gives significant ( > 10% ) performance gain for some OCL benchmarks. Put this in a new function that can be a place for workarounds that are GT related but not required per r

[Intel-gfx] [PATCH v2] drm/i915: add WaIncreaseDefaultTLBEntries

2016-01-27 Thread tim . gore
From: Tim Gore WaIncreaseDefaultTLBEntries increases the number of TLB entries available for GPGPU workloads and gives significant ( > 10% ) performance gain for some OCL benchmarks. Put this in a new function that can be a place for workarounds that are GT related but not required per r

[Intel-gfx] [PATCH 3/3] drm/i915/gen9: add WaIncreaseDefaultTLBEntries

2016-01-25 Thread tim . gore
From: Tim Gore Add WaIncreaseDefaultTLBEntries:skl,bxt. This workaround provides significant perfromance boost for some OpenCL workloads by adjusting the L3_LRA_1_GPGPU register. This is for skl/bxt. Further patches will provide the workaround for other sku's. Signed-off-by: Tim

[Intel-gfx] [PATCH 0/3] drm/i915: add WaIncreaseDefaultTLBEntries

2016-01-25 Thread tim . gore
From: Tim Gore These 3 patches introduce a performance workaround that can have significant impact (> 10%) on some OCL workloads. It is split into 3 patches as follows. 1) The first patch introduces a new function to collect together workarounds that are GT specific and apply globa

[Intel-gfx] [PATCH 2/3] drm/i915/gen8: add WaIncreaseDefaultTLBEntries

2016-01-25 Thread tim . gore
From: Tim Gore Add WaIncreaseDefaultTLBEntries:chv,bdw. This workaround provides significant perfromance boost for some OpenCL workloads by adjusting the L3_LRA_1_GPGPU register. This is for bdw/chv. Further patches will provide the workaround for other sku's. Signed-off-by: Tim

[Intel-gfx] [PATCH 1/3] drm/i915: add function for GT related workarounds

2016-01-25 Thread tim . gore
From: Tim Gore Add a function that is a place for workarounds that are GT related but not required per ring. This function is called on driver load and also after a reset and on resume, so it is safe for workarounds that get clobbered in these situations. Signed-off-by: Tim Gore --- drivers

[Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats.c: prepare for per engine resets

2015-11-18 Thread tim . gore
From: Tim Gore when checking to make sure that the driver has performed the expected number of resets, this test looks at the reset_count, which is incremented each time the GPU is reset. Upcoming changes in the way GPU hangs are handled mean that in most cases (and in all the cases in this test

[Intel-gfx] [RFC i-g-t] tests/gem_reset_stats.c: prepare for per engine resets

2015-11-11 Thread tim . gore
From: Tim Gore when checking to make sure that the driver has performed the expected number of resets, this test looks at the reset_count, which is incremented each time the GPU is reset. Upcoming changes in the way GPU hangs are handled mean that in most cases (and in all the cases in this test

[Intel-gfx] [PATCH] drm/i915: make A0 wa's applied to A1

2015-10-26 Thread tim . gore
From: Tim Gore Since A1 chips use the same GPU as A0, they need all the same wa's in the i915 driver. Update some conditionals to do this. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/intel_guc_loader.c | 2 +- drivers/gpu/drm/i915/intel_lrc.c| 8 drivers/gpu/drm

[Intel-gfx] [PATCH i-g-t] tests/gem_ctx_exec.c: only hang the ring we are testing

2015-08-19 Thread tim . gore
From: Tim Gore In the reset-pin-leak test we were calling igt_set_stop_rings(STOP_RING_DEFAULTS) which sets the stop_rings bits for all gpu engines. But we only submit work to the render engine. When TDR is enabled (as it is in Android currently) only the render engine gets reset, which clears

[Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats.c: fix "ban" tests with scheduler

2015-07-10 Thread tim . gore
From: Tim Gore The tests for context banning fail when the gpu scheduler is enabled. The test causes a hang (using an infinite loop batch) and then queues up some work behind it on both the hanging context and also on a second "good" context. On the "good" context it queue

[Intel-gfx] [PATCH i-g-t] lib/igt_gt.c : allow changes to stop_rings mode bits

2015-07-10 Thread tim . gore
From: Tim Gore In function igt_set_stop_rings, the test igt_assert_f(flags == 0 || current == 0, .. will fail if we are trying to force a hang but the STOP_RINGS_ALLOW_BAN or STOP_RINGS_ALLOW_ERROR bit is set. With the introduction of per ring resets in the driver (in android) these bits do

[Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats : mask off ring_stop bits

2015-06-03 Thread tim . gore
From: Tim Gore Function check_gpu_ok checks to make sure that any hangs have cleared by testing for (flags == 0). Some tests set the STOP_RINGS_ALLOW_BAN and STOP_RINGS_ALLOW_ERRORS flags but these do not get cleared by an individual ring reset, (a feature added recently to the driver), leading

[Intel-gfx] [PATCH i-g-t v2] lib/igt_core.c : only disable low mem killer once

2015-04-27 Thread tim . gore
From: Tim Gore The call to low_mem_killer_disable(true) was being done from within function oom_adjust_for_doom. However, oom_adjust_for_doom gets called from 3 places. We only want the call to low_mem_killer_disable(true) to happen during common_init, so call it from here instead of from

[Intel-gfx] [PATCH i-g-t] lib/igt_core.c : only disable low mem killer once

2015-04-24 Thread tim . gore
From: Tim Gore The call to low_mem_killer_disable(true) was being done from within function oom_adjust_for_doom. However, oom_adjust_for_doom gets called from 3 places. We only want the call to low_mem_killer_disable(true) to happen during common_init, so call it from here instead of from

[Intel-gfx] [PATCH i-g-t] tests/Android.mk : skip kms_legacy_colorkey if no cairo

2015-04-22 Thread tim . gore
From: Tim Gore test kms_legacy_colorkey depends on cairo, so add it to the list of test not to build unless "ANDROID_HAS_CAIRO" is set. Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Android.mk b/tests/Androi

[Intel-gfx] [PATCH i-g-t] tools/quick_dump/makefile.am: add -lrt to get clock_gettime

2015-04-21 Thread tim . gore
From: Tim Gore Attempting to build IGT on linux without libunwind fails due to tools/quick_dump not linking the rt library, causing an undefined symbol error for clock_gettime. Adding -lrt to the list of libraries in Makefile.am fixes this. Signed-off-by: Tim Gore --- tools/quick_dump

[Intel-gfx] [PATCH i-g-t] lib/drmtest.h : fix mmap64 again

2015-04-21 Thread tim . gore
From: Tim Gore In android mmap64 was redirected to mmap2 because mmap64 was not alway available. But now mmap2 has been removed from 64 bit android builds (and mmap64 is available), so update preprocessor conditional to check for __x86_64__. Signed-off-by: Tim Gore --- lib/drmtest.h | 2 +- 1

[Intel-gfx] [PATCH i-g-t] tests/Android.mk : skip kms_pipe_b_c_ivb if no cairo

2015-04-01 Thread tim . gore
From: Tim Gore test kms_pipe_b_c_ivb depends on cairo, so add it to the list of test not to build unless "ANDROID_HAS_CAIRO" is set. Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Android.mk b/tests/Androi

[Intel-gfx] [PATCH i-g-t] tests/gem_concurrent.c: rename to gem_concurrent_all

2015-04-01 Thread tim . gore
From: Tim Gore Recent patch #7763349a9a87.. renamed gem_concurrent_blit.c to gem_concurrent.c and then added entries to Makefile.am to make two identical executeables (but with different names) from this source file. This executeable changes its behaviour based on argv[0]. But, this has broken

[Intel-gfx] [PATCH i-g-t] tests/gem_tiled_fence_blits: split into subtests

2015-03-24 Thread tim . gore
From: Tim Gore The gem_tiled_fence_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. As with a simi

[Intel-gfx] [PATCH i-g-t v2] tests/gem_render_tiled_blits: split into subtests

2015-03-03 Thread tim . gore
From: Tim Gore The gem_render_tiled_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. A similar issue w

[Intel-gfx] [PATCH i-g-t v4] tests/gem_render_linear_blits: split into two subtests

2015-03-03 Thread tim . gore
From: Tim Gore The gem_render_linear_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. After a discuss

[Intel-gfx] [PATCH i-g-t] tests/gem_render_tiled_blits: split into subtests

2015-03-02 Thread tim . gore
From: Tim Gore The gem_render_tiled_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. A similar issue w

[Intel-gfx] [PATCH i-g-t v3] tests/gem_render_linear_blits: split into two subtests

2015-03-02 Thread tim . gore
From: Tim Gore The gem_render_linear_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. After a discuss

[Intel-gfx] [PATCH i-g-t v2] tests/gem_render_linear_blits: split into two subtests

2015-02-25 Thread tim . gore
From: Tim Gore The gem_render_linear_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. After a discuss

[Intel-gfx] [PATCH i-g-t] tests/gem_render_linear_blits: split into two subtests

2015-02-17 Thread tim . gore
From: Tim Gore The gem_render_linear_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. After a discuss

[Intel-gfx] [PATCH i-g-t v2] tools/intel_gpu_frequency: remove use of getsubopt

2015-01-16 Thread tim . gore
From: Tim Gore getsubopt is not available in android. The "get" option doesn't really need sub-options, just display all the current frequency settings (as per discussion with Ben Widawsky) Signed-off-by: Tim Gore --- man/intel_gpu_frequency.man | 6 +++--- tools/intel_gpu_f

[Intel-gfx] [PATCH i-g-t] tools/intel_gpu_frequency: remove use of getsubopt

2015-01-15 Thread tim . gore
From: Tim Gore getsubopt is not available in android. The "get" option doesn't really need sub-options, just display all the current frequency settings (as per discussion with Ben Widawsky) Signed-off-by: Tim Gore --- man/intel_gpu_frequency.man | 6 +++--- tools/intel_gpu_f

[Intel-gfx] [PATCH i-g-t] tests/gem_exec_params: change flags used in invalid-flags test

2015-01-12 Thread tim . gore
From: Tim Gore The invalid-flags test in gem_exec_params uses (I915_EXEC_HANDLE_LUT << 1) as an invalid flag, but this is no longer invalid for recent android versions, and may not be invalid in Linux in the future. So I have changed this test to use (__I915_EXEC_UNKNOWN_FLAGS) i

[Intel-gfx] [PATCH i-g-t v2] lib/Android.mk: add -DHAVE_LINUX_KD_H to fix android build

2015-01-12 Thread tim . gore
From: Tim Gore commit cf93bc8df9f5f94a0aedc8b52bad0ad4e036737c by Alan Coopersmith (introduced to enable solaris builds) reqires HAVE_LINUX_KD_H to be set in order for kd.h to get picked up in igt_kms.c. This is not currently set in the Android makefile so Android builds are broken. Signed-off

[Intel-gfx] [PATCH i-g-t] lib/Android.mk: add -DHAVE_LINUX_KD_H to fix android build

2015-01-08 Thread tim . gore
From: Tim Gore A recent change to igt_kms.c reqires HAVE_LINUX_KD_H to be set in order to pick up the kd.h header file. Signed-off-by: Tim Gore --- lib/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Android.mk b/lib/Android.mk index 548bca4..2251c15 100644

[Intel-gfx] [PATCH i-g-t] Demos/Android.mk: build intel_sprite_on

2014-12-17 Thread tim . gore
From: Tim Gore This reverts the effect of two commits 06fb6c233dd82aac766aa9206644f6eff668ca99 264e1ac10ac14a098a78cc9f96c4e7cabb124ee5 Both of these were to stop demos/intel_sprite_on from being built, but the first was just broken. So this commit re-enables building intel_sprite_on. However

[Intel-gfx] [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on

2014-12-12 Thread tim . gore
From: Tim Gore intel_sprite_on wont build on Android. Previous attempt to disable was just wrong! Signed-off-by: Tim Gore --- demos/Android.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/demos/Android.mk b/demos/Android.mk index b20d61e..5a00116 100644 --- a

[Intel-gfx] [PATCH i-g-t v2] Android.mk: replace std=c99 with std=gnu99

2014-12-12 Thread tim . gore
From: Tim Gore The android makefiles were passing the -std=c99 flag to the compiler which disables the typeof keyword. This causes a build fail for a recent addition to igt_aux.h. Change this to -std=gnu99, which is the flag used in the linux build Signed-off-by: Tim Gore --- benchmarks

[Intel-gfx] [PATCH i-g-t v2] Demos/Android.mk: dont build intel_sprite_on

2014-12-12 Thread tim . gore
From: Tim Gore intel_sprite_on wont build on Android. Signed-off-by: Tim Gore --- demos/Android.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/demos/Android.mk b/demos/Android.mk index 6227e06..d2592b1 100644 --- a/demos/Android.mk +++ b/demos/Android.mk @@ -4,7

[Intel-gfx] [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on

2014-12-12 Thread tim . gore
From: Tim Gore intel_sprite_on wont build on Android, due to use of a particular API that has changed in Gmin Signed-off-by: Tim Gore --- demos/Android.mk | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/demos/Android.mk b/demos/Android.mk index 6227e06..be7f3c2

[Intel-gfx] [PATCH i-g-t] Android.mk: replace std=c99 with std=gnu99

2014-12-12 Thread tim . gore
From: Tim Gore The android makefiles were passing the -std=c99 flag to the compiler which disables the typeof keyword. This causes a build fail for a recent addition to igt_aux.h. Change this to -std=gnu99, which is the flag used in the linux build Signed-off-by: Tim Gore --- benchmarks

[Intel-gfx] [PATCH i-g-t] tests/drv_hangman: remove check for other drm clients

2014-12-01 Thread tim . gore
From: Tim Gore This test will not run on Android as the coreu service remains running even after the android system is stopped. Coreu is a client of drm and when the test finds this it fails an assert. Coreu is started by the init process and there is no tidy, non invasive way to stop it (init

[Intel-gfx] [RFC] tests/gem_ring_sync_copy: reduce memory usage

2014-11-28 Thread tim . gore
From: Tim Gore gem_ring_sync_copy uses a lot of memory and gets OOM killed on smaller systems (eg android devices). Most of the allocation is for "busy work" to keep the render rings busy and for this we can just re-use the same few buffers over and over. This enables the test to be

[Intel-gfx] [PATCH] tests/Android.mk: add gem_fence_upload excluded tests

2014-11-18 Thread tim . gore
From: Tim Gore gem_fence_upload implements some performance measurements, but fails on both android and linux systems and does not generally seem to be a usefull test, so exclude it. Signed-off-by: Tim Gore --- tests/Android.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests

[Intel-gfx] [PATCH] tests/Android.mk: Add kms_pwrite_crc to cairo test list

2014-11-18 Thread tim . gore
From: Tim Gore kms_pwrite_crc was recently added and requires cairo, so add this to the list of tests to exclude if cairo is not avaiable Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Android.mk b/tests/Android.mk

[Intel-gfx] [PATCH] lib/Android.mk: add define of IGT_DATADIR for igt_fb.c

2014-10-02 Thread tim . gore
From: Tim Gore Since the igt_create_stereo_fb function moved into igt_fb.c we need to add the definition of IGT_DATADIR in the Android makefile in order to build the cairo dependent tests. Signed-off-by: Tim Gore --- lib/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH] lib/igt_core.c: disable lowmemorykiller during tests

2014-10-01 Thread tim . gore
From: Tim Gore Several IGT tests cycle through a lot of GEM memory and when running these tests on Android they tend to get killed by the lowmemorykiller. The lowmemorykiller really is not usefull in this context and is just preventing the test from doing its job. This commit adds a function to

[Intel-gfx] [PATCH v2 0/2] Disable Android low memory killer

2014-09-29 Thread tim . gore
From: Tim Gore For some tests that put pressure on memory, the Android lowmemorykiller needs to be disabled for the test to run to completion. The first patch is a simple bit of preparation to ensure that all (well written) "simple" tests exit via a call to igt_exit, in the same wa

[Intel-gfx] [PATCH v2 1/2] lib/igt_core: make single/simple tests use igt_exit

2014-09-29 Thread tim . gore
From: Tim Gore Currently tests that use igt_simple_main will simply call "exit()" if they pass, making it difficult to ensure that any required cleanup is done. At present this is not an issue, but it will be when I submit a patch to turn off the lowmemorykiller for all tests. Sig

[Intel-gfx] [PATCH v2 2/2] lib/igt_core.c: add function to disable lowmemorykiller

2014-09-29 Thread tim . gore
From: Tim Gore Several IGT tests put a lot of pressure on memory and when running these tests on Android they tend to get killed by the lowmemorykiller. The lowmemorykiller really is not usefull in this context and is just preventing the test from doing its job. This commit adds a function to

[Intel-gfx] [PATCH 2/2] lib/igt_core.c: disable lowmemorykiller during tests

2014-09-26 Thread tim . gore
From: Tim Gore Several IGT tests put a lot of pressure on memory and when running these tests on Android they tend to get killed by the lowmemorykiller. The lowmemorykiller really is not usefull in this context and is just preventing the test from doing its job. So this commit disables the

[Intel-gfx] [PATCH 0/2] Disable Android low memory killer

2014-09-26 Thread tim . gore
From: Tim Gore For some tests that put pressure on memory, the Android lowmemorykiller needs to be disabled for the test to run to completion. The first patch is a simple bit of preparation to ensure that all (well written) "simple" tests exit via a call to igt_exit, in the same wa

[Intel-gfx] [PATCH 1/2] lib/igt_core: make single/simple tests use igt_exit

2014-09-26 Thread tim . gore
From: Tim Gore Currently tests that use igt_simple_main will simply call "exit()" if they pass, making it difficult to ensure that any required cleanup is done. At present this is not an issue, but it will be when I submit a patch to turn off the lowmemorykiller for all tests. Sig

[Intel-gfx] [PATCH] intel-gpu-tools: skip kms_flip_event_leak unless we have cairo

2014-08-18 Thread tim . gore
From: Tim Gore kms_flip_event_leak depends on cairo, so add it to the list of tests to skip (in Android.mk) if ANDROID_HAS_CAIRO is not set to 1. Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Android.mk b/tests

[Intel-gfx] [PATCH] intel-gpu-tools: skip gem_mmap_offset_exhaustion on Android

2014-07-25 Thread tim . gore
From: Tim Gore gem_mmap_offset_exhaustion relies on purgeable memory allocations getting swapped out, freeing up physical memory for further allocations. On Android we have no swap partition so this cannot happen and the test gets killed by the low memory killer before mmap offset exhaustion can

[Intel-gfx] [PATCH v2] intel-gpu-tools: fix version.h creation in android

2014-07-24 Thread tim . gore
From: Tim Gore commit 743dc7997aa9f5210055896940d87c88983dcda6 breaks the build under Android because version.h is not created. This happens because the android make executes from the ANDROID_BUILD_TOP directory rather than from the directory containing the source files, so we need to

[Intel-gfx] [PATCH] intel-gpu-tools: fix version.h creation in android

2014-07-24 Thread tim . gore
From: Tim Gore commit 743dc7997aa9f5210055896940d87c88983dcda6 breaks the build under Android because version.h is not created. This happens because the android make executes from the ANDROID_BUILD_TOP directory rather than from the directory containing the source files, so we need Android

[Intel-gfx] [PATCH] intel-gpu-tools: add sys/wait.h to pm_rps.c

2014-07-24 Thread tim . gore
From: Tim Gore commit 745945546f7366a413a3a51a37f90caa3a227b1d breaks the build under Android because some of the macros used in pm_rps.c are defined in sys/wait.h which is not included. Signed-off-by: Tim Gore --- tests/pm_rps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests

[Intel-gfx] [PATCH] intel-gpu-tools: Dont build kms_force_connector if no cairo

2014-07-11 Thread tim . gore
From: Tim Gore kms_force_connector is a new test that requires cairo. I have added it to the list of tests not to build on Android unless ANDROID_HAS_CAIRO is set. Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[Intel-gfx] [PATCH] intel-gpu-tools: Dont build kms_univeral_plane if no cairo

2014-07-08 Thread tim . gore
From: Tim Gore kms_univeral_plane is a new test that requires cairo. I have added it to the list of tests not to build on Android unless ANDROID_HAS_CAIRO is set. Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[Intel-gfx] [PATCH v2 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-07 Thread tim . gore
From: Tim Gore igt_subtest_init mainly does stuff that we also want for simple/single tests, such as looking for --list-subtests and --help options and calling common_init. So just call this from igt_simple_init and then set tests_with_subtests to false. NOTE that this means that check_igt_exit

[Intel-gfx] [PATCH v2 1/2] intel-gpu-tools: pass argc/argv to simple main

2014-07-07 Thread tim . gore
From: Tim Gore Quite a few single tests do not use the igt_simple_main macro because they want access to argc/argv. So change the igt_simple_main macro to pass these arguments through to the "__real_mainxxx" function, and change these tests to use the macro. Also rename the igt_simp

[Intel-gfx] [PATCH v2 0/2] Single tests to respond to --list-subtests

2014-07-07 Thread tim . gore
From: Tim Gore A step towards towards removing the distinction between single and multiple tests. The first step is to change the igt_simple_main macro to pass argc/v through to the real_main function, so that several simple tests that want argc/v can still use this macro. Once this is done, all

[Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-06-27 Thread tim . gore
From: Tim Gore igt_subtest_init mainly does stuff that we also want for simple/single tests, such as looking for --list-subtests and --help options and calling common_init. So just call this from igt_simple_init and then set tests_with_subtests to false. NOTE that this means that check_igt_exit

[Intel-gfx] [PATCH 1/2] intel-gpu-tools: pass argc/argv to simple main

2014-06-27 Thread tim . gore
From: Tim Gore Quite a few single tests do not use the igt_simple_main macro because they want access to argc/argv. So change the igt_simple_main macro to pass these arguments through to the "__real_mainxxx" function, and change these tests to use the macro. Signed-off-by: Tim Gore

[Intel-gfx] [PATCH 0/2] Single tests to respond to --list-subtests

2014-06-27 Thread tim . gore
From: Tim Gore A step towards towards removing the distinction between single and multiple tests. The first step is to change the igt_simple_main macro to pass argc/v through to the real_main function, so that several simple tests that want argc/v can still use this macro. Once this is done, all

[Intel-gfx] [PATCH] intel-gpu-tools: add igt_core init func calls to some tests

2014-06-20 Thread tim . gore
From: Tim Gore igt-core.h/c provides some macros and initialisation functions to support the tests but some of the single tests do not use these. Modifying these tests to use the igt_simple_main macro and igt_simple_init function is the first step towards a consistent command line across all

[Intel-gfx] [PATCH] intel-gpu-tools: remove the --cmd option from gem_seqno_wrap

2014-06-16 Thread tim . gore
From: Tim Gore gem_seqno_wrap was not being built on Android because it uses wordexp which is not in Bionic. After discussion with Mika Kuoppala (the test author) it seems that wordexp was used to implement the --cmd option that was really only intended for use during development of the test and

[Intel-gfx] [PATCH] intel-gpu-tools: move kms_fence_pin_leak to single test list

2014-06-04 Thread tim . gore
From: Tim Gore In Makefile.sources, kms_fence_pin_leak was in the "Multi" test list, ie tests with subtests, whereas it is actually simple/single test. This was confusing the Android script for enumerating tests. Signed-off-by: Tim Gore --- tests/Makefile.sources | 2 +- 1 file

[Intel-gfx] [PATCH] intel-gpu-tools: remove testdisplay.h from kms_render.c

2014-06-03 Thread tim . gore
From: Tim Gore kms_render.c included testdisplay.h but did not need it. This was preventing it from building on Android due to the lack of a Glib port. So I have removed this #include and changed Android.mk so that kms_render is built if we have cairo. Signed-off-by: Tim Gore --- tests

[Intel-gfx] [PATCH] intel-gpu-tools: re-enable gem_exec_params on Android

2014-06-03 Thread tim . gore
From: Tim Gore The missing macro that was preventing the gem_exec_params test from building is now in i915_drm.h, in ABT at least, and this test can now build. So I have removed it from the skip list in Android.mk For Gmin I have added a patch for i915_drm.h to the Wiki Signed-off-by: Tim Gore

[Intel-gfx] [PATCH] intel-gpu-tools: Skip kms_mmio_vs_cs_flip if no cairo

2014-05-27 Thread tim . gore
From: Tim Gore The kms_mmio_vs_cs_flip test uses igt_kms.c which in turn uses cairo. So in Android.mk add this test to the skip list if we dont have cairo Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Android.mk b

[Intel-gfx] [PATCH] intel-gpu-tools: Skip kms_fence_pin_leak if no cairo

2014-05-15 Thread tim . gore
From: Tim Gore The kms_fence_pin_leak test uses igt_kms.c which in turn uses cairo. So in Android.mk add this test to the skip list if we dont have cairo Issue: VIZ-3894 Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[Intel-gfx] [PATCH] intel-gpu-tools: Move igt tests to intel validation area

2014-05-13 Thread tim . gore
From: Tim Gore Currently when IGT is built for Android the resulting test executables go to /system/bin, which is not ideal. After discussion with the core validation team i have moved them to /system/vendor/intel/validation/core/igt by setting LOCAL_MODULE_PATH. I have also added a --defsym

[Intel-gfx] [PATCH] intel-gpu-tools: Build tests needing cairo if ANDROID_HAS_CAIRO=1

2014-05-12 Thread tim . gore
From: Tim Gore Until now the tests that depended on libcairo were simply skipped in the android build. Now that I have a cairo port working, build these cairo dependent tests if ANDROID_HAS_CAIRO is set to 1 in the environment. For information on building cairo for IGT on Android see the wiki at

[Intel-gfx] [PATCH 1/3] libdrm: fix some potential security issues

2014-04-25 Thread tim . gore
From: Tim Gore A static analysis of libdrm source code has identified several potential bugs. This commit addresses the critical issues in xf86drm.c, which are all possible null pointer dereferences. NOTE: I have kept to the indenting style already used in this file, which is a mixture of spaces

[Intel-gfx] [PATCH 0/3] libdrm, Fix some issues from static analysis

2014-04-25 Thread tim . gore
From: Tim Gore A static analysis tool reported several "critical" issues in libdrm code. This patchset addresses a subset of these in the xf86drm*** source files. Most of these issues are potential null pointer dereferences and are simply fixed by explicit null check. Tim Gore (3)

  1   2   >