Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Wang, Xingchao
ser may not let audio subsystem always active, may bring some delay from codec/controllers, or harm some chips. Do you think we should add an exception for Haswell only or just make it as a common solution for audio subsystem? Thanks --xingchao > -Original Message- > From: Wang

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Wang, Xingchao
> -Original Message- > From: Wang, Xingchao > Sent: Wednesday, July 24, 2013 10:00 PM > To: 'Takashi Iwai' > Cc: Wysocki, Rafael J; David Henningsson; Paulo Zanoni; Daniel Vetter; > daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.fr

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, July 24, 2013 9:43 PM > To: Wang, Xingchao > Cc: Wysocki, Rafael J; David Henningsson; Paulo Zanoni; Daniel Vetter; > daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, July 24, 2013 9:43 PM > To: Wang, Xingchao > Cc: Wysocki, Rafael J; David Henningsson; Paulo Zanoni; Daniel Vetter; > daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Wang, Xingchao
> -Original Message- > From: Wysocki, Rafael J > Sent: Wednesday, July 24, 2013 9:15 PM > To: David Henningsson > Cc: Wang, Xingchao; Takashi Iwai; Paulo Zanoni; Daniel Vetter; > daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Wang, Xingchao
+Rafael. > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, July 24, 2013 7:02 PM > To: Wang, Xingchao > Cc: Paulo Zanoni; Daniel Vetter; daniel.vet...@ffwll.ch; > alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org; Girdw

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Wang, Xingchao
an exception. I test this patch on Harris beach with charger connected, the power-well could be released as expected. Thanks --xingchao > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Thursday, July 18, 2013 5:35 PM > To: Wang, Xingchao > Cc: Da

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-18 Thread Wang, Xingchao
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Thursday, July 18, 2013 2:44 PM > To: Wang, Xingchao > Cc: Paulo Zanoni; daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; Daniel > Vetter; intel-gfx@lis

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Wang, Xingchao
may cause some confuse. Thanks --xingchao > -Original Message----- > From: Wang, Xingchao > Sent: Thursday, July 18, 2013 7:18 AM > To: 'Takashi Iwai'; David Henningsson; Paulo Zanoni > Cc: alsa-de...@alsa-project.org; Daniel Vetter; daniel.vet...@ffwll.ch; > int

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, July 17, 2013 10:22 PM > To: David Henningsson > Cc: Paulo Zanoni; Wang, Xingchao; alsa-de...@alsa-project.org; Daniel Vetter; > daniel.vet...@ffwll.ch; intel-gfx@lists.freedesktop.

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, July 17, 2013 4:18 PM > To: Wang, Xingchao > Cc: Paulo Zanoni; alsa-de...@alsa-project.org; Daniel Vetter; > daniel.vet...@ffwll.ch; intel-gfx@lists.freedesktop.org; Wang xingchao;

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, July 17, 2013 3:34 PM > To: Wang, Xingchao > Cc: Paulo Zanoni; alsa-de...@alsa-project.org; Daniel Vetter; > daniel.vet...@ffwll.ch; intel-gfx@lists.freedesktop.org; Wang xingchao;

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-16 Thread Wang, Xingchao
this value dynamically per AC-cable plug/unplug depending on the > configuration, and often it's set to 0 (= no power save) when AC-cable is > plugged. > [Wang, Xingchao] Paulo used a new Ultrabook board with charger connected, and see the default parameter "auto=on".

Re: [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-08 Thread Wang xingchao
On Sat, Jul 06, 2013 at 08:20:59AM +0200, Takashi Iwai wrote: > > >> >> > drm-intel-next. I'll show up in the next linux-next and I'll > > >> >> > forward it to > > >> >> > Dave for mergin into drm-next in roughly 2 weeks. > > >> >> > > >> >> So today I unblacklisted the audio modules on one of my

Re: [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-04 Thread Wang xingchao
On Thu, Jul 04, 2013 at 10:24:15AM -0300, Paulo Zanoni wrote: > 2013/7/4 Wang xingchao : > > On Wed, Jul 03, 2013 at 05:00:51PM -0300, Paulo Zanoni wrote: > >> 2013/6/6 Daniel Vetter : > >> > On Thu, May 30, 2013 at 10:07:07PM +0800, Wang Xingchao wrote: > >>

Re: [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-04 Thread Wang xingchao
On Wed, Jul 03, 2013 at 05:00:51PM -0300, Paulo Zanoni wrote: > 2013/6/6 Daniel Vetter : > > On Thu, May 30, 2013 at 10:07:07PM +0800, Wang Xingchao wrote: > >> Hi all, > >> > >>This is V7 and here're some changes notes: > >>change fro

Re: [Intel-gfx] [PATCH V1] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, June 18, 2013 10:14 PM > To: Wang Xingchao > Cc: daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; Wang, Xingchao > Subject: Re: [PATCH V1] ALSA: hd

[Intel-gfx] [PATCH V1] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Wang Xingchao
or pin 2, pin 1 could get audio data too. This patch configure unused pins to choose different converter. Signed-off-by: Wang Xingchao --- sound/pci/hda/patch_hdmi.c | 91 1 file changed, 76 insertions(+), 15 deletions(-) diff --git a/sound/pci/hda

Re: [Intel-gfx] [PATCH] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, June 18, 2013 8:07 PM > To: Wang Xingchao > Cc: daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; Wang, Xingchao > Subject: Re: [PAT

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add display audio routing APIs for ALSA

2013-06-18 Thread Wang, Xingchao
Hi Daniel, > -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Tuesday, June 18, 2013 3:13 PM > To: Wang, Xingchao > Cc: Daniel Vetter; Wang Xingchao; Takashi Iwai; alsa-de...@alsa-project.org;

Re: [Intel-gfx] [PATCH] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Wang, Xingchao
routing issues. thanks --xingchao > -Original Message- > From: Wang Xingchao [mailto:xingchao.w...@linux.intel.com] > Sent: Tuesday, June 18, 2013 4:32 PM > To: ti...@suse.de > Cc: daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; Wa

[Intel-gfx] [PATCH] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Wang Xingchao
or pin 2, pin 1 could get audio data too. This patch configure unused pins to choose different converter. Signed-off-by: Wang Xingchao --- sound/pci/hda/patch_hdmi.c | 89 +--- 1 file changed, 75 insertions(+), 14 deletions(-) diff --git a/sound/pci/hda

Re: [Intel-gfx] [PATCH 2/4] ALSA: hda - Return error when open empty hdmi device

2013-06-17 Thread Wang, Xingchao
nnings...@canonical.com] > Sent: Monday, June 17, 2013 8:15 PM > To: Wang, Xingchao > Cc: Wang Xingchao; ti...@suse.de; daniel.vet...@ffwll.ch; > alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/4] ALSA: hda - Return error when open empty hdmi > d

[Intel-gfx] [PATCH] ALSA: hda - Haswell converter power state D0 verify

2013-06-17 Thread Wang Xingchao
This patch check converter's power state and set D0 if it's in D3 mode. Signed-off-by: Wang Xingchao --- sound/pci/hda/patch_hdmi.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index e12f7a0..760ee

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Add display audio routing API for haswell

2013-06-17 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Monday, June 17, 2013 5:04 PM > To: Wang Xingchao > Cc: daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; david.hennings...@canonical.com; Wang, > Xingchao

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add display audio routing APIs for ALSA

2013-06-17 Thread Wang, Xingchao
Hi Daniel, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > Sent: Saturday, June 15, 2013 3:18 AM > To: Wang Xingchao > Cc: Takashi Iwai; alsa-de...@alsa-project.org; intel-gfx; David Henningsson; > Wang, Xingchao > Subject: Re: [PAT

Re: [Intel-gfx] [PATCH 2/4] ALSA: hda - Return error when open empty hdmi device

2013-06-17 Thread Wang, Xingchao
> -Original Message- > From: David Henningsson [mailto:david.hennings...@canonical.com] > Sent: Monday, June 17, 2013 8:15 PM > To: Wang, Xingchao > Cc: Wang Xingchao; ti...@suse.de; daniel.vet...@ffwll.ch; > alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop

Re: [Intel-gfx] [PATCH 2/4] ALSA: hda - Return error when open empty hdmi device

2013-06-17 Thread Wang, Xingchao
> -Original Message- > From: David Henningsson [mailto:david.hennings...@canonical.com] > Sent: Monday, June 17, 2013 4:24 PM > To: Wang Xingchao > Cc: ti...@suse.de; daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; Wang, Xing

Re: [Intel-gfx] [PATCH 1/4] ALSA: hda - Haswell converter power state D0 verify

2013-06-17 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Monday, June 17, 2013 5:01 PM > To: Wang Xingchao > Cc: daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; david.hennings...@canonical.com; Wang, > Xingchao

[Intel-gfx] [PATCH 4/4] ALSA: hda - Add display audio routing API for haswell

2013-06-14 Thread Wang Xingchao
ALSA side use these apis to know display audio routing map in gfx side. And use the API to disable unused pin's audio output. Signed-off-by: Wang Xingchao --- sound/pci/hda/hda_i915.c | 83 ++ sound/pci/hda/hda_i915.h | 4 +++ sound/pc

[Intel-gfx] [PATCH 3/4] drm/i915: Add display audio routing APIs for ALSA

2013-06-14 Thread Wang Xingchao
would cause audio output to all minitors. Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/i915_drv.h | 18 + drivers/gpu/drm/i915/intel_ddi.c | 131 +-- drivers/gpu/drm/i915/intel_display.c | 7 +- drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH 2/4] ALSA: hda - Return error when open empty hdmi device

2013-06-14 Thread Wang Xingchao
-by: Wang Xingchao --- sound/pci/hda/patch_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 8db5eb6..d766f40 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1139,6 +1139,9 @@ static int

[Intel-gfx] [PATCH 1/4] ALSA: hda - Haswell converter power state D0 verify

2013-06-14 Thread Wang Xingchao
Haswell converters maybe in wrong power state before usage. i.e. only converter 0 is in D0, converter 1/2 are in D3. When pin choose converter 1/2, there's no audio output. Signed-off-by: Wang Xingchao --- sound/pci/hda/patch_hdmi.c | 20 1 file changed, 20 inser

[Intel-gfx] [PATCH 0/4] Haswell Display audio routing bug fix

2013-06-14 Thread Wang Xingchao
t-queued last commit 80e83831a64b9a5d49e844691037b2d4be0f14f9 Please feel free to let me know the issues you meet during test. Wang Xingchao (4): ALSA: hda - Haswell converter power state D0 verify ALSA: hda - Return error when open empty hdmi device drm/i915: Add display audio routing APIs for ALSA ALSA: hda - Add displ

[Intel-gfx] [PATCH 4/4 V7] i915/drm: Add private api for power well usage

2013-05-30 Thread Wang Xingchao
: Wang Xingchao Reviewed-by: Takashi Iwai Reviewed-by: Damien Lespiau Reviewed-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c |6 +++ drivers/gpu/drm/i915/i915_drv.h | 12 ++ drivers/gpu/drm/i915/intel_drv.h |4 ++ drivers/gpu/drm/i915/intel_pm.c | 81

[Intel-gfx] [PATCH 3/4 V7] ALSA: hda - Add power-welll support for haswell HDA

2013-05-30 Thread Wang Xingchao
one on the audio device, it will deadlock. This patch introduce a work to store remaining probe stuff, and let request_module run in safe work context. Signed-off-by: Wang Xingchao Reviewed-by: Takashi Iwai Reviewed-by: Liam Girdwood Reviewed-by: David Henningsson --- sound/pci/hda/Kconfig

[Intel-gfx] [PATCH 2/4] ALSA: hda - Move azx_first_init() into azx_probe_continue()

2013-05-30 Thread Wang Xingchao
From: Takashi Iwai This is a preliminary work for the upcoming Haswell HDMI audio fixes. azx_first_init() function can be safely called after the f/w loader, since the f/w loader doesn't require the sound hardware initialization beforehand. Moving it into azx_probe_continue() cleans up the code

[Intel-gfx] [PATCH 1/4 V7] ALSA: hda - Fix runtime PM check

2013-05-30 Thread Wang Xingchao
: Wang Xingchao Reviewed-by: Takashi Iwai Reviewed-by: Rafael J. Wysocki --- sound/pci/hda/hda_intel.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 418bfc0..cf3d36c 100644 --- a/sound/pci/hda

[Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-05-30 Thread Wang Xingchao
fixes Takashi Iwai (1): ALSA: hda - Move azx_first_init() into azx_probe_continue() Wang Xingchao (3): ALSA: hda - Fix runtime PM check ALSA: hda - Add power-welll support for haswell HDA i915/drm: Add private api for power well usage drivers/gpu/drm/i915/i915_dma.c |6 +++ drivers/

Re: [Intel-gfx] [PATCH 4/4 V6] i915/drm: Add private api for power well usage

2013-05-30 Thread Wang, Xingchao
0, 2013 2:11 AM > To: Wang Xingchao > Cc: alsa-de...@alsa-project.org; Girdwood, Liam R; ti...@suse.de; > intel-gfx@lists.freedesktop.org; Li, Jocelyn; david.hennings...@canonical.com > Subject: Re: [Intel-gfx] [PATCH 4/4 V6] i915/drm: Add private api for power > well > usage &

[Intel-gfx] [PATCH 4/4 V6] i915/drm: Add private api for power well usage

2013-05-27 Thread Wang Xingchao
: Wang Xingchao --- drivers/gpu/drm/i915/i915_dma.c |6 +++ drivers/gpu/drm/i915/i915_drv.h | 12 + drivers/gpu/drm/i915/intel_drv.h |4 ++ drivers/gpu/drm/i915/intel_pm.c | 92 +++--- include/drm/i915_powerwell.h | 36 +++ 5 files

[Intel-gfx] [PATCH 3/4 V6] ALSA: hda - Add power-welll support for haswell HDA

2013-05-27 Thread Wang Xingchao
one on the audio device, it will deadlock. This patch introduce a work to store remaining probe stuff, and let request_module run in safe work context. Signed-off-by: Wang Xingchao --- sound/pci/hda/Kconfig | 10 ++ sound/pci/hda/Makefile|2 ++

[Intel-gfx] [PATCH 2/4] ALSA: hda - Move azx_first_init() into azx_probe_continue()

2013-05-27 Thread Wang Xingchao
From: Takashi Iwai This is a preliminary work for the upcoming Haswell HDMI audio fixes. azx_first_init() function can be safely called after the f/w loader, since the f/w loader doesn't require the sound hardware initialization beforehand. Moving it into azx_probe_continue() cleans up the code

[Intel-gfx] [PATCH 1/4 V6] ALSA: hda - Fix runtime PM check

2013-05-27 Thread Wang Xingchao
: Wang Xingchao --- sound/pci/hda/hda_intel.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 418bfc0..cf3d36c 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -3091,8 +3091,13

[Intel-gfx] [PATCH 0/4 V6] Power-well API implementation for Haswell

2013-05-27 Thread Wang Xingchao
dio callback for gfx driver to avoid dependency - split whole patch into two pieces for easy review - more typo fixes Takashi Iwai (1): ALSA: hda - Move azx_first_init() into azx_probe_continue() Wang Xingchao (3): ALSA: hda - Fix runtime PM check ALSA: hda - Add power-welll support fo

Re: [Intel-gfx] Haswell: Ensuring HDA codec pins refer to physical outputs

2013-05-27 Thread Wang xingchao
On Thu, May 16, 2013 at 09:00:06AM +0200, David Henningsson wrote: > Hi, > > I want to take this problem up again, because it's important we get > this right. > > The HDA driver assumes that a codec pin widget node always refers to > the same physical output. With Haswell, it seems like this is n

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-23 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Thursday, May 23, 2013 6:27 PM > To: Wang, Xingchao > Cc: Wang Xingchao; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; david.hennings...@canonical.com; Girdwood, > Lia

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-23 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Thursday, May 23, 2013 4:10 PM > To: Wang, Xingchao > Cc: dan...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; david.hennings...@canonical.com; Girdwood, > Liam

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-23 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Thursday, May 23, 2013 2:49 PM > To: Wang Xingchao > Cc: alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org; > david.hennings...@canonical.com; Girdwood, Liam R; Li, Jocelyn

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-23 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Thursday, May 23, 2013 2:03 PM > To: Wang Xingchao > Cc: dan...@ffwll.ch; alsa-de...@alsa-project.org; > intel-gfx@lists.freedesktop.org; david.hennings...@canonical.com; Girdwood, >

[Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-22 Thread Wang Xingchao
t; which in turn tries all locks on pci bus, and when it tries the one on the audio device, it will deadlock. This patch introduce a work to store remaining probe stuff, and let request_module run in safe work context. Signed-off-by: Wang Xingchao --- sound/pci/hda/hda_i915.c | 13 --

[Intel-gfx] [PATCH 4/4] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-22 Thread Wang Xingchao
t; which in turn tries all locks on pci bus, and when it tries the one on the audio device, it will deadlock. This patch introduce a work to store remaining probe stuff, and let request_module run in safe work context. Signed-off-by: Wang Xingchao ---

[Intel-gfx] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-22 Thread Wang Xingchao
: Wang Xingchao --- sound/pci/hda/hda_intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 54c7c22..f20a88c 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -3755,7 +3755,7 @@ static int

[Intel-gfx] [PATCH 1/4 V5] i915/drm: Add private api for power well usage

2013-05-22 Thread Wang Xingchao
: Wang Xingchao --- drivers/gpu/drm/i915/i915_dma.c | 6 +++ drivers/gpu/drm/i915/i915_drv.h | 12 ++ drivers/gpu/drm/i915/intel_drv.h | 4 ++ drivers/gpu/drm/i915/intel_pm.c | 92 +--- include/drm/i915_powerwell.h | 36 5 files changed

[Intel-gfx] [PATCH 2/4 V5] ALSA: hda - Add power-welll support for haswell HDA

2013-05-22 Thread Wang Xingchao
For Intel Haswell chip, HDA controller and codec have power well dependency from GPU side. This patch added support to request/release power well in audio driver. Power save feature should be enabled to get runtime power saving. Signed-off-by: Wang Xingchao --- sound/pci/hda/Kconfig | 10

[Intel-gfx] [PATCH 0/4 V5] Power-well API implementation for Haswell

2013-05-22 Thread Wang Xingchao
x driver to avoid dependency - split whole patch into two pieces for easy review - more typo fixes Wang Xingchao (4): i915/drm: Add private api for power well usage ALSA: hda - Add power-welll support for haswell HDA ALSA: hda - Fix runtime PM check ALSA: hda - Continue probe in work

Re: [Intel-gfx] [PATCH 1/2 V4] i915/drm: Add private api for power well usage

2013-05-21 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, May 21, 2013 3:18 PM > To: Wang Xingchao > Cc: dan...@ffwll.ch; Girdwood, Liam R; david.hennings...@canonical.com; Lin, > Mengdong; Li, Jocelyn; alsa-de...@alsa-project.org; > intel-gfx@

Re: [Intel-gfx] [PATCH 2/2 V4] ALSA: hda - Add power-welll support for haswell HDA

2013-05-21 Thread Wang, Xingchao
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, May 21, 2013 3:19 PM > To: Wang Xingchao > Cc: dan...@ffwll.ch; Girdwood, Liam R; david.hennings...@canonical.com; Lin, > Mengdong; Li, Jocelyn; alsa-de...@alsa-project.org; > intel-gfx@

Re: [Intel-gfx] [PATCH 1/2 V3] drm/915: Add private api for power well usage

2013-05-20 Thread Wang, Xingchao
Hi Jesse, > -Original Message- > From: Barnes, Jesse > Sent: Friday, May 17, 2013 11:44 PM > To: Wang Xingchao > Cc: ti...@suse.de; dan...@ffwll.ch; Girdwood, Liam R; > david.hennings...@canonical.com; Lin, Mengdong; Li, Jocelyn; > alsa-de...@alsa-p

[Intel-gfx] [PATCH 0/2 V4] Power-well API implementation for Haswell

2013-05-20 Thread Wang Xingchao
ad - manage symbols and module loading properly - remove IS_HSW macro, use flag instead - remove audio callback for gfx driver to avoid dependency - split whole patch into two pieces for easy review - more typo fixes Wang Xingchao (2): i915/drm: Add private api for power well usa

[Intel-gfx] [PATCH 2/2 V4] ALSA: hda - Add power-welll support for haswell HDA

2013-05-20 Thread Wang Xingchao
For Intel Haswell chip, HDA controller and codec have power well dependency from GPU side. This patch added support to request/release power well in audio driver. Power save feature should be enabled to get runtime power saving. Signed-off-by: Wang Xingchao --- sound/pci/hda/Kconfig | 10

[Intel-gfx] [PATCH 1/2 V4] i915/drm: Add private api for power well usage

2013-05-20 Thread Wang Xingchao
: Wang Xingchao --- drivers/gpu/drm/i915/i915_dma.c |6 +++ drivers/gpu/drm/i915/i915_drv.h | 12 + drivers/gpu/drm/i915/intel_drv.h |4 ++ drivers/gpu/drm/i915/intel_pm.c | 98 +++--- include/drm/i915_powerwell.h | 36 ++ 5 files

Re: [Intel-gfx] [PATCH 1/2 V3] drm/915: Add private api for power well usage

2013-05-20 Thread Wang, Xingchao
Hi Jesse, > -Original Message- > From: Barnes, Jesse > Sent: Friday, May 17, 2013 11:44 PM > To: Wang Xingchao > Cc: ti...@suse.de; dan...@ffwll.ch; Girdwood, Liam R; > david.hennings...@canonical.com; Lin, Mengdong; Li, Jocelyn; > alsa-de...@alsa-p

Re: [Intel-gfx] [PATCH 0/2 V3] Power-well API implementation for Haswell

2013-05-16 Thread Wang, Xingchao
Hi Daniel, Do you have further comments on this patchset? thanks --xingchao > -Original Message- > From: Wang Xingchao [mailto:xingchao.w...@linux.intel.com] > Sent: Thursday, May 16, 2013 3:53 PM > To: ti...@suse.de; dan...@ffwll.ch; Girdwood, Liam R > Cc:

[Intel-gfx] [PATCH 2/2 V3] ALSA: hda - Add power-welll support for haswell HDA

2013-05-16 Thread Wang Xingchao
For Intel Haswell chip, HDA controller and codec have power well dependency from GPU side. This patch added support to request/release power well in audio driver. Power save feature should be enabled to get runtime power saving. Signed-off-by: Wang Xingchao --- sound/pci/hda/Kconfig | 10

[Intel-gfx] [PATCH 1/2 V3] drm/915: Add private api for power well usage

2013-05-16 Thread Wang Xingchao
: Wang Xingchao --- drivers/gpu/drm/i915/intel_pm.c | 75 +++ include/drm/i915_powerwell.h| 36 +++ 2 files changed, 104 insertions(+), 7 deletions(-) create mode 100644 include/drm/i915_powerwell.h diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/2 V3] Power-well API implementation for Haswell

2013-05-16 Thread Wang Xingchao
dependency - split whole patch into two pieces for easy review - more typo fixes Wang Xingchao (2): drm/915: Add private api for power well usage ALSA: hda - Add power-welll support for haswell HDA drivers/gpu/drm/i915/intel_pm.c | 76 +++

Re: [Intel-gfx] [PATCH 2/2] ALSA: hda - Add power-welll support for haswell HDA

2013-05-15 Thread Wang, Xingchao
Hi Takashi, Thanks your quick feedback, please see my comments below. > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, May 14, 2013 8:15 PM > To: Wang Xingchao > Cc: dan...@ffwll.ch; Girdwood, Liam R; david.hennings...@canonical.com; Lin,

Re: [Intel-gfx] [alsa-devel] [PATCH 1/2] drm/915: Add private api for power well usage

2013-05-15 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, May 14, 2013 8:32 PM > To: Wang Xingchao > Cc: dan...@ffwll.ch; Girdwood, Liam R; alsa-de...@alsa-project.org; Zanoni, > Paulo R; Li, Jocelyn; Lin, Mengdong; intel-gfx@lis

[Intel-gfx] [PATCH 2/2] ALSA: hda - Add power-welll support for haswell HDA

2013-05-14 Thread Wang Xingchao
For Intel Haswell chip, HDA controller and codec have power well dependency from GPU side. This patch added support to request/release power well in audio driver. Power save feature should be enabled to get runtime power saving. Signed-off-by: Wang Xingchao --- sound/pci/hda/Kconfig |8

[Intel-gfx] [PATCH 1/2] drm/915: Add private api for power well usage

2013-05-14 Thread Wang Xingchao
-by: Wang Xingchao --- drivers/gpu/drm/i915/intel_pm.c | 76 +++ include/drm/i915_powerwell.h| 36 +++ 2 files changed, 105 insertions(+), 7 deletions(-) create mode 100644 include/drm/i915_powerwell.h diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/2 V2] Power-well API implementation for Haswell

2013-05-14 Thread Wang Xingchao
for gfx driver to avoid dependency - split whole patch into two pieces for easy review - more typo fixes Wang Xingchao (2): drm/915: Add private api for power well usage ALSA: hda - Add power-welll support for haswell HDA drivers/gpu/drm/i915/intel_pm.c | 76

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Wang, Xingchao
> -Original Message- > From: David Henningsson [mailto:david.hennings...@canonical.com] > Sent: Monday, May 13, 2013 8:13 PM > To: Wang, Xingchao > Cc: Wang Xingchao; alsa-de...@alsa-project.org; dan...@ffwll.ch; > ti...@suse.de; Lin, Mengdong; intel-gfx@lists.freedeskto

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Monday, May 13, 2013 8:17 PM > To: Wang, Xingchao > Cc: David Henningsson; Wang Xingchao; alsa-de...@alsa-project.org; > dan...@ffwll.ch; Lin, Mengdong; intel-gfx@lists.freedeskto

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Wang, Xingchao
ti...@suse.de; Lin, > Mengdong; intel-gfx@lists.freedesktop.org; Wang Xingchao; Li, Jocelyn; > Barnes, Jesse; dan...@ffwll.ch; Zanoni, Paulo R > Subject: Re: [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API > existense before calling > > Date 13.5.2013 10:28, David Henningss

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Wang, Xingchao
Hi David, > -Original Message- > From: alsa-devel-boun...@alsa-project.org > [mailto:alsa-devel-boun...@alsa-project.org] On Behalf Of David Henningsson > Sent: Monday, May 13, 2013 4:29 PM > To: Wang Xingchao > Cc: alsa-de...@alsa-project.org; dan...@ffwll.ch;

[Intel-gfx] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Wang Xingchao
I915 module maybe loaded after snd_hda_intel, the power-well API doesnot exist in such case. This patch intended to avoid loading dependency between snd-hda-intel and i915 module. Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/i915_dma.c |3 ++ drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH 4/5] ALSA: hda - Fix module dependency with gfx i915

2013-05-13 Thread Wang Xingchao
hda_i915 has dependency on i915 module, this patch check whether symbol exist before calling API there. If i915 module not loaded it will try to load before use. Signed-off-by: Wang Xingchao --- sound/pci/hda/hda_i915.c | 42 -- 1 file changed, 40

[Intel-gfx] [PATCH 3/5] ALSA: hda - Power well request/release for hda controller

2013-05-13 Thread Wang Xingchao
ecs, it can be added as another new user "hdmi-codec". Signed-off-by: Wang Xingchao --- sound/pci/hda/hda_i915.c |2 +- sound/pci/hda/hda_intel.c | 18 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_i915.c b/sound/pci/hda/hda

[Intel-gfx] [PATCH 2/5] ALSA: hda - Add external module hda-i915 for power well

2013-05-13 Thread Wang Xingchao
This new added external module hda_i915 only built in when gfx i915 module built in. It includes hda_display_power() api implementation for hda controller driver, which will ask gfx driver for reqeust/release power well on Intel Haswell. Signed-off-by: Wang Xingchao --- sound/pci/hda/Kconfig

[Intel-gfx] [PATCH 1/5] drm/915: Add private api for power well usage

2013-05-13 Thread Wang Xingchao
-by: Wang Xingchao --- drivers/gpu/drm/i915/intel_pm.c | 127 --- include/drm/i915_powerwell.h| 39 2 files changed, 159 insertions(+), 7 deletions(-) create mode 100644 include/drm/i915_powerwell.h diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/5] Power-well API implementation for Haswell

2013-05-13 Thread Wang Xingchao
quest at its side, so it's safe too. This patch could make sure it would not cause damage when snd-hda-intel and i915 module loaded in any order. If i915 module loaded at first, it's safe to get the symbol. If snd-hda-intel loaded first, it will try to load i915 manually and get notificatio

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Wang, Xingchao
Hi Jesse, > -Original Message- > From: Barnes, Jesse > Sent: Friday, May 10, 2013 2:30 AM > To: Takashi Iwai > Cc: Daniel Vetter; Wang, Xingchao; david.hennings...@canonical.com; > Girdwood, Liam R; Li, Jocelyn; Lin, Mengdong; Zanoni, Paulo R; Wang Xingchao; > intel

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Friday, May 10, 2013 1:18 AM > To: Daniel Vetter > Cc: Wang, Xingchao; david.hennings...@canonical.com; Girdwood, Liam R; > Barnes, Jesse; Li, Jocelyn; Lin, Mengdong; Zanoni, Paul

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Wang, Xingchao
Hi Daniel, > -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Thursday, May 09, 2013 5:23 PM > To: Wang, Xingchao > Cc: david.hennings...@canonical.com; Girdwood, Liam R; ti...@suse.de; > Barnes, Je

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Friday, May 03, 2013 10:27 PM > To: Barnes, Jesse > Cc: Daniel Vetter; Wang, Xingchao; Li, Jocelyn; Daniel Vetter; Zanoni, Paulo > R; > ville.syrj...@linux.intel.com; Lin, Mengd

Re: [Intel-gfx] [alsa-devel] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Wang, Xingchao
> Sent: Thursday, May 02, 2013 10:49 PM > To: Liam Girdwood > Cc: Barnes, Jesse; alsa-de...@alsa-project.org; Zanoni, Paulo R; Takashi Iwai; > Daniel Vetter; intel-gfx@lists.freedesktop.org; Wysocki, Rafael J; Wang > Xingchao; Wang, Xingchao; Li, Jocelyn; Hindman, Gav

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-02 Thread Wang, Xingchao
Hi Jesse, > -Original Message- > From: Barnes, Jesse > Sent: Monday, April 29, 2013 11:02 PM > To: Daniel Vetter > Cc: Wang, Xingchao; Takashi Iwai; Li, Jocelyn; Daniel Vetter; Zanoni, Paulo R; > ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, L

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-27 Thread Wang, Xingchao
Hi Daniel/Takashi, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Saturday, April 27, 2013 1:18 AM > To: Takashi Iwai > Cc: Daniel Vetter; Li, Jocelyn; Daniel Vetter; Wang, Xingchao; Zanoni, Paulo &g

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-27 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Friday, April 26, 2013 11:13 PM > To: Daniel Vetter > Cc: Li, Jocelyn; Daniel Vetter; Wang, Xingchao; Zanoni, Paulo R; > ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, L

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-27 Thread Wang, Xingchao
Hi Daniel, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Friday, April 26, 2013 10:57 PM > To: Li, Jocelyn > Cc: Daniel Vetter; Wang, Xingchao; Zanoni, Paulo R; > ville.syrj...@linux.intel.com; Lin, Mengdong

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-25 Thread Wang, Xingchao
Hi Daniel, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > Sent: Thursday, April 25, 2013 3:52 PM > To: Wang, Xingchao > Cc: Zanoni, Paulo R; ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, > Liam R; Li, Jocelyn; intel-gfx@lists.freed

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-24 Thread Wang, Xingchao
Hi Daniel/Paulo, Any comments on this? Add Jesse and Rafael in loop. thanks --xingchao > -Original Message- > From: Wang, Xingchao > Sent: Wednesday, April 24, 2013 3:29 PM > To: daniel.vet...@ffwll.ch; Zanoni, Paulo R; 'Takashi Iwai' > Cc: ville.syrj...@linux

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-24 Thread Wang, Xingchao
power_well_device", it should be set NULL when i915 module unloaded, I added the caller but have no idea where to call it, if anyone has suggestion, that would be fine. thanks --xingchao > -Original Message- > From: Wang Xingchao [mailto:xingchao.w...@linux.intel.com] &

[Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-24 Thread Wang Xingchao
* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * + **/ +/* + * Authors: + * Wang Xingchao + */ + +#ifndef _AUDIO_DRM_H_ +#define _AUDIO_DRM_H_ + +extern void request_power_well(void); +e

[Intel-gfx] Power well issue could not be reproduced with drm-intel-next branch

2013-04-22 Thread Wang, Xingchao
Hi Daniel/Paulo, In order to verify an RFC patch to fix the power well issue, I'm trying to reproduce it on my Haswell ULT C stepping board, with " drm-intel-next" branch, the last commit is: commit 80ad9206c0d863832bc5f6008c4d1868d1df8e70 Author: Ville Syrjälä Date: Fri Apr 19 14:36:51 2013

[Intel-gfx] [PATCH] drm/i915: HDMI/DP - ELD info refresh support for Haswell

2013-01-22 Thread Wang Xingchao
ELD info should be updated dynamically according to hot plug event. For haswell chip, clear/set the eld valid bit and output enable bit from callback intel_disable/eanble_ddi(). Reviewed-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2] drm/i915: HDMI/DP - ELD info refresh support for Haswell

2013-01-21 Thread Wang, Xingchao
> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Monday, January 21, 2013 9:11 PM > To: Wang, Xingchao > Cc: intel-gfx@lists.freedesktop.org; daniel.vet...@ffwll.ch; Zanoni, Paulo R > Subject: Re: [Intel-gfx] [PATCH v2] drm/i

[Intel-gfx] [PATCH v3] drm/i915: HDMI/DP - ELD info refresh support for Haswell

2013-01-21 Thread Wang Xingchao
ELD info should be updated dynamically according to hot plug event. For haswell chip, clear/set the eld valid bit and output enable bit from callback intel_disable/eanble_ddi(). Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/intel_ddi.c | 22 ++ drivers/gpu/drm

Re: [Intel-gfx] [PATCH v2] drm/i915: HDMI/DP - ELD info refresh support for Haswell

2013-01-20 Thread Wang, Xingchao
Hi Ville Syrjälä, > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, January 18, 2013 9:14 PM > To: Wang, Xingchao > Cc: intel-gfx@lists.freedesktop.org; daniel.vet...@ffwll.ch; Zanoni, Paulo R > Subject: Re: [Intel-gfx] [

  1   2   >