Re: [PATCH v3 1/6] drm/ci: uprev mesa version

2024-05-28 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 08:10:44AM +0530, Vignesh Raman wrote: > zlib.net is not allowing tarball download anymore and results > in below error in kernel+rootfs_arm32 container build, > urllib.error.HTTPError: HTTP Error 403: Forbidden > urllib.error.HTTPError: HTTP Error 415: Unsupported Media Typ

Re: [PATCH v6 3/6] drm/display: Add missing aux less alpm wake related bits

2024-05-28 Thread Nautiyal, Ankit K
On 5/27/2024 1:56 PM, Animesh Manna wrote: From: Jouni Högander eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+)

Re: [PATCH 0/5] Panel Replay eDP debugfs support

2024-05-28 Thread Hogander, Jouni
On Tue, 2024-05-28 at 14:44 +0300, Jouni Högander wrote: > This is a subset of Panel Replay eDP patch set > (https://patchwork.freedesktop.org/series/133684). This contains > debugfs changes and is supposed to be safe to be merged alone  > Sending > here to get CI result for this subset before merg

✓ Fi.CI.IGT: success for drm/i915/display: update handling of FBC when VT-d active workaround (rev3)

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915/display: update handling of FBC when VT-d active workaround (rev3) URL : https://patchwork.freedesktop.org/series/134117/ State : success == Summary == CI Bug Log - changes from CI_DRM_14834_full -> Patchwork_134117v3_full

✓ Fi.CI.BAT: success for drm/ci: uprev mesa/IGT and generate testlist (rev2)

2024-05-28 Thread Patchwork
== Series Details == Series: drm/ci: uprev mesa/IGT and generate testlist (rev2) URL : https://patchwork.freedesktop.org/series/133735/ State : success == Summary == CI Bug Log - changes from CI_DRM_14841 -> Patchwork_133735v2 Summary -

✗ Fi.CI.CHECKPATCH: warning for drm/ci: uprev mesa/IGT and generate testlist (rev2)

2024-05-28 Thread Patchwork
== Series Details == Series: drm/ci: uprev mesa/IGT and generate testlist (rev2) URL : https://patchwork.freedesktop.org/series/133735/ State : warning == Summary == Error: dim checkpatch failed 743a104c33ea drm/ci: uprev mesa version ce8ea01f6e6c drm/ci: add farm variable -:7: WARNING:COMMIT_

[PATCH v3 4/6] drm/ci: uprev IGT

2024-05-28 Thread Vignesh Raman
test-list.txt and test-list-full.txt are not generated for cross-builds and they are required by drm-ci for testing arm32 targets. This is fixed in igt-gpu-tools. So uprev IGT to include the commit which fixes this issue. Also disable building xe driver tests for non-intel platforms. Reviewed-by:

[PATCH v3 6/6] drm/ci: update xfails for the new testlist

2024-05-28 Thread Vignesh Raman
Now the testlist is used from IGT build, so update xfails with the new testlist. Set the timeout of all i915 jobs to 1h30m since some jobs takes more than 1 hour to complete. Reviewed-by: Dmitry Baryshkov Signed-off-by: Vignesh Raman --- v2: - Set the timeout of all i915 jobs to 1h30m and up

[PATCH v3 5/6] drm/ci: skip driver specific tests

2024-05-28 Thread Vignesh Raman
Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Reviewed-by: Dmitry Baryshkov Signed-off-by: Vignesh Raman --- v2: - Skip xe tests for amdgpu and virtio. v3: - No changes. --- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 15 +++

[PATCH v3 3/6] drm/ci: generate testlist from build

2024-05-28 Thread Vignesh Raman
Stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Signed-off-by: Vignesh Raman --- v2: - Fix testlist generation for arm and arm64 builds. v3: - Rename generated testlist file to ci-testlist. ---

[PATCH v3 2/6] drm/ci: add farm variable

2024-05-28 Thread Vignesh Raman
Mesa uses structured logs for logging and debug purpose, https://mesa.pages.freedesktop.org/-/mesa/-/jobs/59165650/artifacts/results/job_detail.json Since drm-ci uses the mesa scripts, add the farm variable and update the device type for missing jobs. Signed-off-by: Vignesh Raman --- v3: - Ne

[PATCH v3 1/6] drm/ci: uprev mesa version

2024-05-28 Thread Vignesh Raman
zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa to latest version which includes a fix for this issue. ht

[PATCH v3 0/6] drm/ci: uprev mesa/IGT and generate testlist

2024-05-28 Thread Vignesh Raman
Uprev mesa and IGT to the latest version and stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Update the xfails with the latest testlist run. Add farm variable and update device type variable. https://

linux-next: build failure after merge of the drm-misc tree

2024-05-28 Thread Stephen Rothwell
drm_hdmi_compute_mode_clock cc1: some warnings being treated as errors Caused by commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") I have used the drm-misc tree from next-20240528 for today. -- Cheers, Stephen Rothwell pgp7cArRfjvZS.pgp Description: OpenPGP digital signature

✓ Fi.CI.IGT: success for Fix cursor FB unpinning. (rev2)

2024-05-28 Thread Patchwork
== Series Details == Series: Fix cursor FB unpinning. (rev2) URL : https://patchwork.freedesktop.org/series/133896/ State : success == Summary == CI Bug Log - changes from CI_DRM_14829_full -> Patchwork_133896v2_full Summary --- **SU

linux-next: build failure after merge of the drm-misc tree

2024-05-28 Thread Stephen Rothwell
7;v3d_v42_performance_counters' defined but not used [-Wunused-const-variable=] 118 | static const struct v3d_perf_counter_desc v3d_v42_performance_counters[] = { | ^~~~ Caused by commit 3cbcbe016c31 ("drm/v3d: Add

✓ Fi.CI.BAT: success for drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL URL : https://patchwork.freedesktop.org/series/134162/ State : success == Summary == CI Bug Log - changes from CI_DRM_14841 -> Patchwork_134162v1 Summary

✗ Fi.CI.SPARSE: warning for drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL URL : https://patchwork.freedesktop.org/series/134162/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL URL : https://patchwork.freedesktop.org/series/134162/ State : warning == Summary == Error: dim checkpatch failed 16065d9c8471 drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL -:49: WARNING:AVOID_BU

[PATCH v2] drm/i915/guc: Enable w/a 16021333562 for DG2, MTL and ARL

2024-05-28 Thread John . C . Harrison
From: John Harrison Enable another workaround that is implemented inside the GuC. v2: Use the correct Gen12 w/a id rather than the Xe version (review feedback from Matthew R) also extend to include ARL. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 1 + dri

Re: Lockdep annotation introduced warn in VMD driver

2024-05-28 Thread Nirmal Patel
On Tue, 28 May 2024 15:36:54 +0300 Imre Deak wrote: > Hi, > > commit 7e89efc6e9e402839643cb297bab14055c547f07 > Author: Dave Jiang > Date: Thu May 2 09:57:31 2024 -0700 > > PCI: Lock upstream bridge for pci_reset_function() > > introduced the WARN below in the VMD driver, see [1] for th

Re: [PATCH] drm/i915/guc: Enable w/a 14019882105 for DG2 and MTL

2024-05-28 Thread John Harrison
On 5/28/2024 13:21, Matt Roper wrote: On Fri, May 24, 2024 at 06:41:20PM -0700, john.c.harri...@intel.com wrote: From: John Harrison Enable another workaround that is implemented inside the GuC. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 1 + drivers

✓ Fi.CI.BAT: success for drm/panel: two fixes for lg-sw43408 (rev2)

2024-05-28 Thread Patchwork
== Series Details == Series: drm/panel: two fixes for lg-sw43408 (rev2) URL : https://patchwork.freedesktop.org/series/133900/ State : success == Summary == CI Bug Log - changes from CI_DRM_14840 -> Patchwork_133900v2 Summary --- **S

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Tue, May 28, 2024 at 10:38:06PM +0300, Ville Syrjälä wrote: > On Tue, May 28, 2024 at 02:27:52PM +0300, Imre Deak wrote: > > On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Different planes could have different alignment requirements > > > e

Re: [linux-next:master] BUILD REGRESSION 6dc544b66971c7f9909ff038b62149105272d26a

2024-05-28 Thread David Sterba
On Wed, May 29, 2024 at 02:19:47AM +0800, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 6dc544b66971c7f9909ff038b62149105272d26a Add linux-next > specific files for 20240528 > > Err

Re: [PATCH] drm/i915/guc: Enable w/a 14019882105 for DG2 and MTL

2024-05-28 Thread Matt Roper
On Fri, May 24, 2024 at 06:41:20PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Enable another workaround that is implemented inside the GuC. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 1 + > drivers/gpu/drm/i915/gt/uc/intel_g

✓ Fi.CI.BAT: success for drm/i915: Cleanups around scanline arithmetic

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915: Cleanups around scanline arithmetic URL : https://patchwork.freedesktop.org/series/134151/ State : success == Summary == CI Bug Log - changes from CI_DRM_14837 -> Patchwork_134151v1 Summary ---

[PATCH v4 3/3] drm/display: split DSC helpers from DP helpers

2024-05-28 Thread Dmitry Baryshkov
Currently the DRM DSC functions are selected by the DRM_DISPLAY_DP_HELPER Kconfig symbol. This is not optimal, since the DSI code (both panel and host drivers) end up selecting the seemingly irrelevant DP helpers. Split the DSC code to be guarded by the separate DRM_DISPLAY_DSC_HELPER Kconfig symbo

[PATCH v4 2/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-28 Thread Dmitry Baryshkov
Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Reviewed-by: Neil Armstrong Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") Signed-of

[PATCH v4 0/3] drm/panel: two fixes for lg-sw43408

2024-05-28 Thread Dmitry Baryshkov
Fix two issues with the panel-lg-sw43408 driver reported by the kernel test robot. Signed-off-by: Dmitry Baryshkov --- Changes in v4: - Reoder patches so that fixes come first, to be able to land them to drm-misc-fixes - Link to v3: https://lore.kernel.org/r/20240522-panel-sw43408-fix-v3-0-690

[PATCH v4 1/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-28 Thread Dmitry Baryshkov
This panel driver uses DSC PPS functions and as such depends on the DRM_DISPLAY_DP_HELPER. Select this symbol to make required functions available to the driver. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kysryyli-...@intel.com/ Fixes: 069a6c0e94f9

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Ville Syrjälä
On Tue, May 28, 2024 at 02:27:52PM +0300, Imre Deak wrote: > On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Different planes could have different alignment requirements > > even for the same format/modifier. Collect the alignment > > requirements ac

✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/cdclk: Plumb the full atomic state deeper

2024-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/cdclk: Plumb the full atomic state deeper URL : https://patchwork.freedesktop.org/series/134150/ State : success == Summary == CI Bug Log - changes from CI_DRM_14837 -> Patchwork_134150v1

✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/cdclk: Plumb the full atomic state deeper

2024-05-28 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/cdclk: Plumb the full atomic state deeper URL : https://patchwork.freedesktop.org/series/134150/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separate

Re: [PATCH 8/9] drm/i915: Update plane alignment requirements for TGL+

2024-05-28 Thread Ville Syrjälä
On Tue, May 28, 2024 at 04:22:59PM +0300, Imre Deak wrote: > On Mon, May 13, 2024 at 08:59:41PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we still use the SKL+ PLANE_SURF alignment even > > for TGL+ even though the hardware no longer needs it. > > Introduce a separate

Re: [linux-next:master] BUILD REGRESSION 6dc544b66971c7f9909ff038b62149105272d26a

2024-05-28 Thread Jakub Kicinski
On Wed, 29 May 2024 02:19:47 +0800 kernel test robot wrote: > | `-- > net-ipv6-route.c-rt6_fill_node()-error:we-previously-assumed-dst-could-be-null-(see-line-) Is there a way for us to mark this as false positive?

[PATCH 6/7] drm/i915: Switch intel_usecs_to_scanlines() to 64bit maths

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä Dotclocks can reach ~1GHz these days, so intel_usecs_to_scanlines(), with its 32bit maths, is currently limited to a few milliseconds. I want bigger numbers in DSB selftests, so switch over to 64bit maths. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_

[PATCH 7/7] drm/i915/dsb: Convert dewake_scanline to a hw scanline number earlier

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä Currently we switch from out software idea of a scanline to the hw's idea of a scanline during the commit phase in _intel_dsb_commit(). While that is slightly easier due to fastsets fiddling with the timings, we'll also need to generate proper hw scanline numbers already when

[PATCH 2/7] drm/i915: Extract intel_mode_vblank_end()

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä Extract intel_mode_vblank_end() in the same vein as intel_mode_vblank_start(). While we have only one use of this it seems nicer to unify the approach. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vblank.c | 16 drivers/gpu/drm/i915/d

[PATCH 5/7] drm/i915: Move intel_crtc_scanline_offset()

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä I want to use intel_crtc_scanline_offset() in intel_crtc_scanline_to_hw(). Relocate intel_crtc_scanline_offset() a bit to avoid a forward declaration. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vblank.c | 76 ++--- 1 file changed, 38

[PATCH 4/7] drm/i915: Simplify scanline_offset handling for gen2

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä Currently intel_crtc_scanline_offset() is careful to always return a positive offset. That is not actually necessary as long as we take care of negative values when applying the offset in __intel_get_crtc_scanline(). This simplifies intel_crtc_scanline_offset(), and makes the

[PATCH 3/7] drm/i915: Extract intel_mode_vtotal()

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä We have several copies of code calculating the hardware's idea of vtotal. Pull that to a helper, similar to intel_mode_vblank_{start,end}(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vblank.c | 40 + drivers/gpu/drm/i915/display

[PATCH 1/7] drm/i915: Reuse intel_mode_vblank_start()

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä Replace a few hand rolled copies of intel_mode_vblank_start() with the real thing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsb.c| 10 +++--- drivers/gpu/drm/i915/display/intel_vblank.c | 9 +++-- drivers/gpu/drm/i915/display/intel_vb

[PATCH 0/7] drm/i915: Cleanups around scanline arithmetic

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä A few cleanups around parts what deal with scanline numbers. Ville Syrjälä (7): drm/i915: Reuse intel_mode_vblank_start() drm/i915: Extract intel_mode_vblank_end() drm/i915: Extract intel_mode_vtotal() drm/i915: Simplify scanline_offset handling for gen2 drm/i915: M

[PATCH 3/3] drm/i915: Plumb the full atomic state into skl_ddb_add_affected_planes()

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä skl_ddb_add_affected_planes() needs the full atomic state. Instead of digging that out from dubious sources plumb it in explicitly. The wm counterpart (skl_wm_add_affected_planes()) already does things in the proper way. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i91

[PATCH 2/3] drm/i915: Plumb the full atomic state into icl_check_nv12_planes()

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä icl_check_nv12_planes() needs the full atomic state. Instead of digging that out from dubious sources plumb it in explicitly. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) dif

[PATCH 1/3] drm/i915/cdclk: Plumb the full atomic state deeper

2024-05-28 Thread Ville Syrjala
From: Ville Syrjälä Various parts of the cdclk code need access the full atomic state. Currently it's being dug out via the cdclk_state->base.state pointer, which is not great as that pointer isn't always valid. Instead plumb the full atomic state from the top so that it's clear that it is in fac

[linux-next:master] BUILD REGRESSION 6dc544b66971c7f9909ff038b62149105272d26a

2024-05-28 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6dc544b66971c7f9909ff038b62149105272d26a Add linux-next specific files for 20240528 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202405282036.maedo54q-...@intel.com https

Re: [PATCH v3 1/3] drm/display: split DSC helpers from DP helpers

2024-05-28 Thread Jessica Zhang
On 5/21/2024 11:25 PM, Dmitry Baryshkov wrote: Currently the DRM DSC functions are selected by the DRM_DISPLAY_DP_HELPER Kconfig symbol. This is not optimal, since the DSI code (both panel and host drivers) end up selecting the seemingly irrelevant DP helpers. Split the DSC code to be guarded

Re: [PATCH 1/2] drm/i915/bios: double check array-boundary in parse_sdvo_lvds_data

2024-05-28 Thread Rodrigo Vivi
On Tue, May 28, 2024 at 02:29:00PM +0300, Luca Coelho wrote: > During static analysis, a concern was raised that we may access the > dtd->dtd[] array out of bounds, because we are not checking whether > the index we use is larger than the array. > > This should not be a problem as is, because the

Re: [PATCH 2/2] drm/i915: move uapi.event outside spinlock in intel_crtc_vblank_work

2024-05-28 Thread Rodrigo Vivi
On Tue, May 28, 2024 at 02:29:01PM +0300, Luca Coelho wrote: > In intel_crtc_vblank_work(), we access uapi.event before grabbing the > event_lock spinlock, but modify it inside the spinlock block. This > causes some static analyzers to get confused and issue a warning. > > The uapi.event value is

Re: [PATCH v2] drm/i915: Increase FLR timeout from 3s to 9s

2024-05-28 Thread Rodrigo Vivi
On Mon, May 27, 2024 at 04:00:25PM +0100, Andi Shyti wrote: > On Mon, May 27, 2024 at 11:47:49AM +0100, Andi Shyti wrote: > > On Fri, May 24, 2024 at 10:07:44AM -0400, Rodrigo Vivi wrote: > > > On Fri, May 24, 2024 at 01:58:53AM +0200, Andi Shyti wrote: > > > > Following the guidelines it takes 3 s

✓ Fi.CI.BAT: success for drm/i915: mem/fsb/rawclk freq cleanups

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915: mem/fsb/rawclk freq cleanups URL : https://patchwork.freedesktop.org/series/134145/ State : success == Summary == CI Bug Log - changes from CI_DRM_14835 -> Patchwork_134145v1 Summary --- **SUCCE

✗ Fi.CI.SPARSE: warning for drm/i915: mem/fsb/rawclk freq cleanups

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915: mem/fsb/rawclk freq cleanups URL : https://patchwork.freedesktop.org/series/134145/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/display: update handling of FBC when VT-d active workaround (rev3)

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915/display: update handling of FBC when VT-d active workaround (rev3) URL : https://patchwork.freedesktop.org/series/134117/ State : success == Summary == CI Bug Log - changes from CI_DRM_14834 -> Patchwork_134117v3 ==

Re: Lockdep annotation introduced warn in VMD driver

2024-05-28 Thread Dave Jiang
On 5/28/24 5:36 AM, Imre Deak wrote: > Hi, > > commit 7e89efc6e9e402839643cb297bab14055c547f07 > Author: Dave Jiang > Date: Thu May 2 09:57:31 2024 -0700 > > PCI: Lock upstream bridge for pci_reset_function() > > introduced the WARN below in the VMD driver, see [1] for the full log. >

✓ Fi.CI.BAT: success for Panel Replay eDP debugfs support

2024-05-28 Thread Patchwork
== Series Details == Series: Panel Replay eDP debugfs support URL : https://patchwork.freedesktop.org/series/134125/ State : success == Summary == CI Bug Log - changes from CI_DRM_14833 -> Patchwork_134125v1 Summary --- **SUCCESS**

[PATCH 12/12] drm/xe/display: drop unused rawclk_freq and RUNTIME_INFO()

2024-05-28 Thread Jani Nikula
With rawclk_freq moved to display runtime info, xe has no users left for them. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 - drivers/gpu/drm/xe/xe_device_types.h | 6 -- 2 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/xe/co

[PATCH 11/12] drm/i915: move rawclk from runtime to display runtime info

2024-05-28 Thread Jani Nikula
It's mostly about display, so move it under display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_backlight.c | 10 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/display/intel_display_device.c| 2 ++ drivers/gpu/

[PATCH 10/12] drm/i915: move rawclk init to intel_cdclk_init()

2024-05-28 Thread Jani Nikula
The rawclk initialization is a bit out of place in intel_device_info_runtime_init(). Move it to intel_cdclk_init(), with a bit of refactoring on intel_read_rawclk(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 23 +++--- drivers/gpu/drm/i915/displa

[PATCH 09/12] drm/i915/cdclk: use i9xx_fsb_freq() for rawclk_freq initialization

2024-05-28 Thread Jani Nikula
Instead of duplicating the CLKCFG parsing, reuse i9xx_fsb_freq() to figure out rawclk_freq where applicable. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 46 ++ 1 file changed, 3 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/i915/

[PATCH 08/12] drm/i915: use i9xx_fsb_freq() for GT clock frequency

2024-05-28 Thread Jani Nikula
Reuse i9xx_fsb_freq() for GT clock frequency initialization instead of depending on rawclk_freq. Note: If the init order was changed, we could use i915->fsb_freq directly. However, GT clock initialization is done in i915_driver_mmio_probe(), but intel_dram_detect() later in i915_driver_hw_probe(),

[PATCH 07/12] drm/i915: extend the fsb_freq initialization to more platforms

2024-05-28 Thread Jani Nikula
Initialize fsb frequency for more platforms to be able to use it for GT clock and rawclk frequency initialization. Note: There's a discrepancy between existing pnv_fsb_freq() and i9xx_hrawclk() regarding CLKCFG interpretation. Presume all PNV is mobile. FIXME: What should the default or failure m

[PATCH 06/12] drm/i915: convert fsb_freq and mem_freq to kHz

2024-05-28 Thread Jani Nikula
We'll want to use fsb frequency for deriving GT clock and rawclk frequencies in the future. Increase the accuracy by converting to kHz. Do the same for mem freq to be aligned. Round the frequencies ending in 666 to 667. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 6

[PATCH 05/12] drm/i915/dram: rearrange mem freq init

2024-05-28 Thread Jani Nikula
Follow the same style in mem freq init as in fsb freq init, returning the value instead of assigning in multiple places. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 59 --- 1 file changed, 25 insertions(+), 34 deletions(-) diff --git a/drivers/

[PATCH 04/12] drm/i915/dram: split out pnv DDR3 detection

2024-05-28 Thread Jani Nikula
Split out the PNV DDR3 detection to a distinct step instead of conflating it with mem freq detection. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/soc/intel_dram.c b/dri

[PATCH 03/12] drm/i915/dram: separate fsb freq detection from mem freq

2024-05-28 Thread Jani Nikula
To simplify further changes, add separate functions for reading the fsb frequency. This ends up reading CLKCFG register twice, but it's not a big deal. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 106 +++--- 1 file changed, 60 insertions(+), 46 del

[PATCH 01/12] drm/i915/wm: rename intel_get_cxsr_latency -> pnv_get_cxsr_latency

2024-05-28 Thread Jani Nikula
Clarify that the function is specific to PNV, making subsequent changes slightly easier to grasp. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/

[PATCH 02/12] drm/i915/wm: clarify logging on not finding CxSR latency config

2024-05-28 Thread Jani Nikula
Clarify and unify the logging on not finding PNV CxSR latency config. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/displa

[PATCH 00/12] drm/i915: mem/fsb/rawclk freq cleanups

2024-05-28 Thread Jani Nikula
This is a rewitten version of [1]. I think it's good progress overall though there are still minor issues here and there. BR, Jani. [1] https://lore.kernel.org/all/20240408172315.3418692-1-jani.nik...@intel.com/ Jani Nikula (12): drm/i915/wm: rename intel_get_cxsr_latency -> pnv_get_cxsr_late

✗ Fi.CI.SPARSE: warning for Panel Replay eDP debugfs support

2024-05-28 Thread Patchwork
== Series Details == Series: Panel Replay eDP debugfs support URL : https://patchwork.freedesktop.org/series/134125/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 9/9] drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:42PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > I don't think the display hardware really has such chroma > plane tile row alignment requirements as outlined in > commit d156135e6a54 ("drm/i915/tgl: Make sure a semiplanar > UV plane is tile row size aligne

Re: [PATCH v3 2/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-28 Thread Marijn Suijten
On 2024-05-22 09:25:54, Dmitry Baryshkov wrote: > This panel driver uses DSC PPS functions and as such depends on the > DRM_DISPLAY_DP_HELPER. Select this symbol to make required functions Here and in the title: maybe this is a remnant from v2, but you split out a DRM_DISPLAY_DSC_HELPER and should

Re: [linux-next:master] BUILD REGRESSION 124cfbcd6d185d4f50be02d5f5afe61578916773

2024-05-28 Thread Björn Töpel
kernel test robot writes: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 124cfbcd6d185d4f50be02d5f5afe61578916773 Add linux-next > specific files for 20240521 [...] > Error/Warning ids grouped by kconfigs: > > gcc_recent_errors [..

Re: [PATCH 8/9] drm/i915: Update plane alignment requirements for TGL+

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:41PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we still use the SKL+ PLANE_SURF alignment even > for TGL+ even though the hardware no longer needs it. > Introduce a separate tgl_plane_min_alignment() and update > it to more accurately reflect th

Re: [PATCH v3 02/20] drm/panel replay: Add edp1.5 Panel Replay bits and register

2024-05-28 Thread Maarten Lankhorst
Acked-by: Maarten Lankhorst Den 2024-05-27 kl. 09:22, skrev Jouni Högander: Add PANEL_REPLAY_CONFIGURATION_2 register and some missing Panel Replay bits. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-)

✓ Fi.CI.BAT: success for drm/i915: prevent some static analyzer warnings

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915: prevent some static analyzer warnings URL : https://patchwork.freedesktop.org/series/134124/ State : success == Summary == CI Bug Log - changes from CI_DRM_14831 -> Patchwork_134124v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915: prevent some static analyzer warnings

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915: prevent some static analyzer warnings URL : https://patchwork.freedesktop.org/series/134124/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bit

Lockdep annotation introduced warn in VMD driver

2024-05-28 Thread Imre Deak
Hi, commit 7e89efc6e9e402839643cb297bab14055c547f07 Author: Dave Jiang Date: Thu May 2 09:57:31 2024 -0700 PCI: Lock upstream bridge for pci_reset_function() introduced the WARN below in the VMD driver, see [1] for the full log. Not sure if the annotation is incorrect or the VMD driver is

✓ Fi.CI.BAT: success for drm/i915: DP AUX CH macro cleanups

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915: DP AUX CH macro cleanups URL : https://patchwork.freedesktop.org/series/134123/ State : success == Summary == CI Bug Log - changes from CI_DRM_14831 -> Patchwork_134123v1 Summary --- **SUCCESS**

✗ Fi.CI.CHECKPATCH: warning for drm/i915: DP AUX CH macro cleanups

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915: DP AUX CH macro cleanups URL : https://patchwork.freedesktop.org/series/134123/ State : warning == Summary == Error: dim checkpatch failed ca25b65c7605 drm/i915/gvt: use proper macros for DP AUX CH CTL registers f1103051a69e drm/i915: remove unused DP AUX

Re: [PATCH 7/9] drm/i915: Move intel_surf_alignment() into skl_univerals_plane.c

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:40PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that all pre-skl platforms have their own .min_alignment() > functions the remainder of intel_surf_alignment() can be hoisted > into skl_univerals_plane.c (and renamed appropriately). > > Signed-off-by:

Re: [PATCH 6/9] drm/i915: Split pre-skl platforms out from intel_surf_alignment()

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:39PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract the necessary chunks from intel_surf_alignment() > into per-platform variants for all pre-skl primary/sprite > planes. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/i9xx_pla

✗ Fi.CI.BAT: failure for drm/i915/display: update handling of FBC when VT-d active workaround (rev2)

2024-05-28 Thread Patchwork
== Series Details == Series: drm/i915/display: update handling of FBC when VT-d active workaround (rev2) URL : https://patchwork.freedesktop.org/series/134117/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14831 -> Patchwork_134117v2 ==

[PATCH v3] drm/i915/display: update handling of FBC when VT-d active workaround

2024-05-28 Thread Vinod Govindapillai
Move the handling of the disabling FBC when VT-d is active wa as part of the intel_fbc_check_plane(). As the hw is still there, intel_fbc_sanitize should be able to handle the state properly. v2: update the patch description (Jani Nikula) v3: fix the return value in wa handling (Jani Nikula) Bsp

[PATCH 3/5] drm/i915/psr: Move printing sink PSR support to own function

2024-05-28 Thread Jouni Högander
intel_psr_status has grown and is about to grow even. Let's split it a bit and move printing sink psr support to an own function. Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_psr.c | 22 +++--- 1 file changed, 15 insertions(+),

[PATCH 5/5] drm/i915/psr: modify psr status debugfs to support eDP Panel Replay

2024-05-28 Thread Jouni Högander
Some PSR2_CTL bits are applicable for eDP panel replay as well. Dump this register for eDP Panel Replay as well. Bspec: 68920 Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_psr.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-)

[PATCH 4/5] drm/i915/psr: Move printing PSR mode to own function

2024-05-28 Thread Jouni Högander
intel_psr_status has grown and is about to grow even. Let's split it a bit and move printing PSR mode to an own function. v2: s/intel_psr_psr_mode/intel_psr_print_mode/ Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_psr.c | 26 --

[PATCH 2/5] drm/panel replay: Add edp1.5 Panel Replay bits and register

2024-05-28 Thread Jouni Högander
Add PANEL_REPLAY_CONFIGURATION_2 register and some missing Panel Replay bits. Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna Acked-by: Maxime Ripard --- include/drm/display/drm_dp.h | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/include/drm/disp

[PATCH 1/5] drm/i915/psr: Store pr_dpcd in intel_dp

2024-05-28 Thread Jouni Högander
We need pr_dpcd contents for early transport validity check on eDP Panel Replay and in debugfs interface to dump out panel early transport capability. Also remove unnecessarily printing out "Panel replay is not supported by panel" v2: commit message modified Signed-off-by: Jouni Högander Reviewe

[PATCH 0/5] Panel Replay eDP debugfs support

2024-05-28 Thread Jouni Högander
This is a subset of Panel Replay eDP patch set (https://patchwork.freedesktop.org/series/133684). This contains debugfs changes and is supposed to be safe to be merged alone Sending here to get CI result for this subset before merging. Jouni Högander (5): drm/i915/psr: Store pr_dpcd in intel_dp

Re: [PATCH 5/9] drm/i915: Split cursor alignment to per-platform vfuncs

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:38PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Split intel_cursor_alignment() into per-platform variants. > > Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_cursor.c | 40 +++-- > drive

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Tue, May 28, 2024 at 02:27:58PM +0300, Imre Deak wrote: > [...] > > +} > > + > > static unsigned int > > intel_plane_fb_min_alignment(const struct intel_plane_state *plane_state) > > { > > struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane); > > - const struct drm_frameb

[PATCH 2/2] drm/i915: move uapi.event outside spinlock in intel_crtc_vblank_work

2024-05-28 Thread Luca Coelho
In intel_crtc_vblank_work(), we access uapi.event before grabbing the event_lock spinlock, but modify it inside the spinlock block. This causes some static analyzers to get confused and issue a warning. The uapi.event value is not protected by the event_lock, so we can safely move it out of the p

[PATCH 1/2] drm/i915/bios: double check array-boundary in parse_sdvo_lvds_data

2024-05-28 Thread Luca Coelho
During static analysis, a concern was raised that we may access the dtd->dtd[] array out of bounds, because we are not checking whether the index we use is larger than the array. This should not be a problem as is, because the enumeration that is used for this index comes from "panel_type", which

[PATCH 0/2] drm/i915: prevent some static analyzer warnings

2024-05-28 Thread Luca Coelho
Hi, Here's a couple of patches to prevent some static analyzer warnings. They are not really an issue as is, but with these two patches the code will be cleaner and a bit safer, while at the same time silencing these warnings. Plese review. Cheers, Luca. Luca Coelho (2): drm/i915/bios: doubl

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Different planes could have different alignment requirements > even for the same format/modifier. Collect the alignment > requirements across all planes capable of scanning out the > fb such that the alignmen

✓ Fi.CI.BAT: success for WA for Re-initialize dispcnlunitt1 xosc clock

2024-05-28 Thread Patchwork
== Series Details == Series: WA for Re-initialize dispcnlunitt1 xosc clock URL : https://patchwork.freedesktop.org/series/134114/ State : success == Summary == CI Bug Log - changes from CI_DRM_14831 -> Patchwork_134114v1 Summary ---

Re: [PATCH v2] drm/i915/display: update handling of FBC when VT-d active workaround

2024-05-28 Thread Govindapillai, Vinod
On Tue, 2024-05-28 at 14:19 +0300, Jani Nikula wrote: > On Tue, 28 May 2024, Vinod Govindapillai > wrote: > > Move the handling of the disabling FBC when VT-d is active wa > > as part of the intel_fbc_check_plane(). As the hw is still there, > > intel_fbc_sanitize should be able to handle the sta

Re: [PATCH v2] drm/i915/display: update handling of FBC when VT-d active workaround

2024-05-28 Thread Jani Nikula
On Tue, 28 May 2024, Vinod Govindapillai wrote: > Move the handling of the disabling FBC when VT-d is active wa > as part of the intel_fbc_check_plane(). As the hw is still there, > intel_fbc_sanitize should be able to handle the state properly. > > v2: update the patch description (Jani Nikula) >

  1   2   >