On 5/27/2024 1:56 PM, Animesh Manna wrote:
From: Jouni Högander <jouni.hogan...@intel.com>

eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and
DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these.

Signed-off-by: Jouni Högander <jouni.hogan...@intel.com>
---
  include/drm/display/drm_dp.h | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
index 906949ca3cee..3317ff88ed59 100644
--- a/include/drm/display/drm_dp.h
+++ b/include/drm/display/drm_dp.h
@@ -232,6 +232,8 @@
#define DP_RECEIVER_ALPM_CAP 0x02e /* eDP 1.4 */
  # define DP_ALPM_CAP                      (1 << 0)
+# define DP_ALPM_PM_STATE_2A_SUPPORT       (1 << 1) /* eDP 1.5 */
+# define DP_ALPM_AUX_LESS_CAP              (1 << 2) /* eDP 1.5 */

This bit seems to be derived from DP 2.1.

As per eDP1.5: Only bits [1 and 0] are eDP-specific. The register’s other bits are defined in DP Standard.

In any case, patch looks good to me.

Reviewed-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>


Regards,

Ankit

#define DP_SINK_DEVICE_AUX_FRAME_SYNC_CAP 0x02f /* eDP 1.4 */
  # define DP_AUX_FRAME_SYNC_CAP                    (1 << 0)
@@ -683,7 +685,8 @@
#define DP_RECEIVER_ALPM_CONFIG 0x116 /* eDP 1.4 */
  # define DP_ALPM_ENABLE                           (1 << 0)
-# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE  (1 << 1)
+# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE  (1 << 1) /* eDP 1.5 */
+# define DP_ALPM_MODE_AUX_LESS             (1 << 2) /* eDP 1.5 */
#define DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF 0x117 /* eDP 1.4 */
  # define DP_AUX_FRAME_SYNC_ENABLE         (1 << 0)

Reply via email to