Re: [Intel-gfx] [PATCH 1/6] drm/i915: Replace hardcoded cacheline size with macro

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 02:57:11PM -0700, Jesse Barnes wrote: > On Wed, 2 Apr 2014 16:36:06 +0100 > Chris Wilson wrote: > > > For readibility and guess at the meaning behind the constants. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/intel_ringbuffer.c | 29 +++

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Preserve ring buffers objects across resume

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 03:10:13PM -0700, Jesse Barnes wrote: > On Wed, 2 Apr 2014 16:36:08 +0100 > Chris Wilson wrote: > > > +static void > > +i915_gem_stop_ringbuffers(struct drm_device *dev) > > +{ > > + struct drm_i915_private *dev_priv = dev->dev_private; > > + struct intel_ring_buffer

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Allow the module to load even if we fail to setup rings

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 03:11:40PM -0700, Jesse Barnes wrote: > On Wed, 2 Apr 2014 16:36:09 +0100 > Chris Wilson wrote: > > > Even without enabling the ringbuffers to allow command execution, we can > > still control the display engines to enable modesetting. So make the > > ringbuffer initializ

Re: [Intel-gfx] 3.14 kills i810 with xf86-video-intel

2014-04-02 Thread Tobias Powalowski
Am 02.04.2014 17:41, schrieb Daniel Vetter: > On Wed, Apr 2, 2014 at 4:15 PM, Tobias Powalowski > wrote: >> Am 02.04.2014 15:53, schrieb Daniel Vetter: >>> On Wed, Apr 2, 2014 at 3:34 PM, Tobias Powalowski >>> wrote: Hi, https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/co

[Intel-gfx] drm/i915: XPS13 backlight regression in v3.14

2014-04-02 Thread James Hogan
Hi, I've noticed that v3.14 breaks the backlight on Dell XPS13. Reverting the following commit fixes the issue for me (i.e. the GUI brightness controls work again): bc0bb9fd1c78 drm/i915: remove QUIRK_NO_PCH_PWM_ENABLE It appears that in v3.14 (with the above patch): * intel_backlight/brightne

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-04-02 Thread Sagar Arun Kamble
Hi Ville, Could you please review these patches. thanks, Sagar On Wed, 2014-04-02 at 11:42 +0530, Sagar Arun Kamble wrote: > Reminder for review :) > > On Tue, 2014-04-01 at 10:21 +0530, Sagar Arun Kamble wrote: > > Gentle Reminder for reviewing this and related patches: > > http://lists.freed

[Intel-gfx] [PATCH] drm/i915: Invariably invalidate before ctx switch

2014-04-02 Thread Ben Widawsky
We have been setting the bit which was originally BIOS dependent since: commit f05bb0c7b624252a5e768287e340e8e45df96e42 Author: Chris Wilson Date: Sun Jan 20 16:33:32 2013 + drm/i915: GFX_MODE Flush TLB Invalidate Mode must be '1' for scanline waits Therefore, we do not need to try to

[Intel-gfx] [PATCH v3 5/6] drm/i915/vlv:Implement the WA 'WaDisable_RenderCache_OperationalFlush'

2014-04-02 Thread sourab . gupta
From: Akash Goel On Gen4+ platforms (except BDW), Render Cache Operational flush cannot be enabled. This WA is apparently required for all Gen4+ platforms,except BDW. In BDW, the bit has been repurposed otherwise. This has been tested only on vlv. v2: Corrected the code regarding the wrong usage

[Intel-gfx] [PATCH] drm/i915/bdw: Disable idle DOP clock gating

2014-04-02 Thread Ben Widawsky
It seems we need this at least for the current platforms we have, but probably not later. In any event, it should cause too much harm as we do the same thing on several other platforms. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 insertions(+) dif

[Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2014-04-02 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/intel_display.c: In function 'intel_alloc_plane_obj': drivers/gpu/drm/i915/intel_display.c:2089:27: error: 'struct drm_crtc' has no member named 'fb' obj->stride = c

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm tree

2014-04-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in drivers/gpu/drm/i915/intel_display.c between commit f4510a2752b7 ("drm: Replace crtc fb with primary plane fb (v3)") from the drm tree and commit 262ca2b08fbd ("drm/i915: Rename similar plane functions to avoid confusion") fr

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Allow the module to load even if we fail to setup rings

2014-04-02 Thread Jesse Barnes
On Wed, 2 Apr 2014 16:36:09 +0100 Chris Wilson wrote: > Even without enabling the ringbuffers to allow command execution, we can > still control the display engines to enable modesetting. So make the > ringbuffer initialization failure soft, and mark the GPU as wedged > instead. > > v2: Only tr

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Preserve ring buffers objects across resume

2014-04-02 Thread Jesse Barnes
On Wed, 2 Apr 2014 16:36:08 +0100 Chris Wilson wrote: > +static void > +i915_gem_stop_ringbuffers(struct drm_device *dev) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + struct intel_ring_buffer *ring; > + int i; > + > + for_each_ring(ring, dev_priv, i) > +

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Move all ring resets before setting the HWS page

2014-04-02 Thread Jesse Barnes
On Wed, 2 Apr 2014 16:36:07 +0100 Chris Wilson wrote: > In commit a51435a3137ad8ae75c288c39bd2d8b2696bae8f > Author: Naresh Kumar Kachhi > Date: Wed Mar 12 16:39:40 2014 +0530 > > drm/i915: disable rings before HW status page setup > > we reordered stopping the rings to do so before we

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Replace hardcoded cacheline size with macro

2014-04-02 Thread Jesse Barnes
On Wed, 2 Apr 2014 16:36:06 +0100 Chris Wilson wrote: > For readibility and guess at the meaning behind the constants. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 29 - > 1 file changed, 16 insertions(+), 13 deletions(-) > > d

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Provide a bit more info when pipestat bits are wrong

2014-04-02 Thread Damien Lespiau
On Mon, Mar 31, 2014 at 06:21:28PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Print the enable_mask and status_mask from > __i915_{enable,disable}_pipestat() when the called has messed them up > somehow. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i

Re: [Intel-gfx] PROBLEM: i915 Haswell KMS wrong maximum resolution

2014-04-02 Thread Dave Airlie
On Mon, Mar 31, 2014 at 5:43 PM, Jani Nikula wrote: > On Sun, 30 Mar 2014, Kenneth de Mello wrote: >> What about dual-link DVI? I though the additional link addressed the >> pixel clock limitation. Has it only been using a single link this entire >> time, and it's only worked by ignoring the

Re: [Intel-gfx] PROBLEM: i915 Haswell KMS wrong maximum resolution

2014-04-02 Thread Kenneth de Mello
Jani, Thank you for explaining further. After checking the manual for my motherboard, I am mistaken. It specifies DVI-I and states the maximum resolution over DVI is 1920x1200@60Hz, so it appears all is well. The fact it worked before is a happy accident. I have since switched to use displa

Re: [Intel-gfx] [PATCH 0/4] Adding support for plane alpha/color blending through drm property

2014-04-02 Thread Ville Syrjälä
On Fri, Mar 21, 2014 at 07:23:31PM +, Damien Lespiau wrote: > On Fri, Mar 21, 2014 at 07:06:46PM +0530, Sagar Arun Kamble wrote: > > Hi Damien, > > > > On Thu, 2014-03-20 at 14:45 +, Damien Lespiau wrote: > > > On Thu, Mar 20, 2014 at 02:11:40PM +, Damien Lespiau wrote: > > > > (source

Re: [Intel-gfx] [PATCH] drm/i915: Gracefully handle obj not bound to GGTT in is_pin_display

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 07:21:01PM +0100, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > Otherwise, we do a NULL pointer dereference. Or we could just do was_pin_display = obj->pin_display; obj->pin_display = true; err_unpin_display: obj->pin_display = was_pin_display; And then we wouldn

[Intel-gfx] [PATCH] drm/i915: Gracefully handle obj not bound to GGTT in is_pin_display

2014-04-02 Thread oscar . mateo
From: Oscar Mateo Otherwise, we do a NULL pointer dereference. I've seen this happen while handling an error in i915_gem_object_pin_to_display_plane(): If i915_gem_object_set_cache_level() fails, we call is_pin_display() to handle the error. At this point, the object is still not pinned to GGTT

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix debugfs PDP register dump

2014-04-02 Thread Ben Widawsky
On Mon, Mar 31, 2014 at 06:17:16PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Iterate over all the PDP registers instead of just printing PDP0 four > times in gen8 PPGTT debugfs info. > > Signed-off-by: Ville Syrjälä Reviewed-by: Ben Widawsky > --- > drivers/gpu/d

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Fix framecount offset

2014-04-02 Thread Jesse Barnes
On Mon, 31 Mar 2014 18:21:29 +0300 ville.syrj...@linux.intel.com wrote: > From: Rafael Barbalho > > The framecount register was still using the old PIPE macro instead > of the new PIPE2 macro > > Signed-off-by: Rafael Barbalho > --- > drivers/gpu/drm/i915/i915_reg.h | 6 +++--- > 1 file chang

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Provide a bit more info when pipestat bits are wrong

2014-04-02 Thread Jesse Barnes
On Mon, 31 Mar 2014 18:21:28 +0300 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Print the enable_mask and status_mask from > __i915_{enable,disable}_pipestat() when the called has messed them up > somehow. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_ir

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Warn when DPIO read returns 0xffffffff

2014-04-02 Thread Jesse Barnes
On Mon, 31 Mar 2014 18:21:27 +0300 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > DPIO reads from groups/broadcast register offsets for PCS and > TX return all 1's. If that result gets used for something > we'll probably end up doing something wrong. So warn when that > happens.

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Move DP M/N setup from update_pll to mode_set for gmch platforms

2014-04-02 Thread Jesse Barnes
On Mon, 31 Mar 2014 18:21:25 +0300 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > There's no point in hiding the DP M/N setup in the update_pll functions. > Just move it to the mode_set function. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_display.c | 9

Re: [Intel-gfx] [PATCH 1/4] drm/i915/vlv: write the port field in the per-pipe DIP control reg

2014-04-02 Thread Jesse Barnes
These all have a Tested-by: "Joon Jung " too. -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/4] drm/i915/vlv: disable AVI infoframe emission when writing infoframes

2014-04-02 Thread Jesse Barnes
We also do a disable later when we write a specific infoframe, but here we do it to prevent sending a stale one before updating the infoframes. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_hdmi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 4/4] drm/i915: move infoframe setting to after port enable

2014-04-02 Thread Jesse Barnes
Needs to happen after clock is running or it doesn't behave correctly. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_hdmi.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index fb983

[Intel-gfx] [PATCH 3/4] drm/i915: enable HDMI mode on VLV when an HDMI sink is detected

2014-04-02 Thread Jesse Barnes
Allows sending of the null packets for conformance. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_hdmi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 3b804fc..fb9839b 100644 --

[Intel-gfx] [PATCH 1/4] drm/i915/vlv: write the port field in the per-pipe DIP control reg

2014-04-02 Thread Jesse Barnes
In case we end up bouncing these around between ports. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_hdmi.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index b0413e1..ee892a4 100644 --- a/

Re: [Intel-gfx] [PATCH 19/19] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+

2014-04-02 Thread Damien Lespiau
On Wed, Apr 02, 2014 at 04:28:06PM +0100, Chris Wilson wrote: > On Wed, Apr 02, 2014 at 11:14:58AM -0300, Paulo Zanoni wrote: > > 2014-04-02 8:27 GMT-03:00 Chris Wilson : > > > On Wed, Apr 02, 2014 at 12:23:51PM +0100, Chris Wilson wrote: > > >> On Wed, Apr 02, 2014 at 12:21:45PM +0100, Damien Lesp

Re: [Intel-gfx] 3.14 kills i810 with xf86-video-intel

2014-04-02 Thread Daniel Vetter
On Wed, Apr 2, 2014 at 4:15 PM, Tobias Powalowski wrote: > Am 02.04.2014 15:53, schrieb Daniel Vetter: >> On Wed, Apr 2, 2014 at 3:34 PM, Tobias Powalowski >> wrote: >>> Hi, >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b30324adaf8d2e5950a602bde63030d15a61826f >>>

[Intel-gfx] [PATCH 2/6] drm/i915: Move all ring resets before setting the HWS page

2014-04-02 Thread Chris Wilson
In commit a51435a3137ad8ae75c288c39bd2d8b2696bae8f Author: Naresh Kumar Kachhi Date: Wed Mar 12 16:39:40 2014 +0530 drm/i915: disable rings before HW status page setup we reordered stopping the rings to do so before we set the HWS register. However, there is an extra workaround for g45 to

[Intel-gfx] [PATCH 3/6] drm/i915: Preserve ring buffers objects across resume

2014-04-02 Thread Chris Wilson
Tearing down the ring buffers across resume is overkill, risks unnecessary failure and increases fragmentation. After failure, since the device is still active we may end up trying to write into the dangling iomapping and trigger an oops. Reported-by: Jae-hyeon Park Bugzilla: https://bugzilla.ke

[Intel-gfx] [PATCH 4/6] drm/i915: Allow the module to load even if we fail to setup rings

2014-04-02 Thread Chris Wilson
Even without enabling the ringbuffers to allow command execution, we can still control the display engines to enable modesetting. So make the ringbuffer initialization failure soft, and mark the GPU as wedged instead. v2: Only treat an EIO from ring initialisation as a soft failure, and abort modu

[Intel-gfx] [PATCH 6/6] drm/i915: Include a little more information about why ring init fails

2014-04-02 Thread Chris Wilson
If we include the expected values for the failing ring register checks, it makes it marginally easier to see which is the culprit. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/d

[Intel-gfx] [PATCH 1/6] drm/i915: Replace hardcoded cacheline size with macro

2014-04-02 Thread Chris Wilson
For readibility and guess at the meaning behind the constants. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 5/6] drm/i915: Mark device as wedged if we fail to resume

2014-04-02 Thread Chris Wilson
During module load, if we fail to initialise the rings, we abort the load reporting EIO. However during resume, even though we report EIO as we fail to reinitialize the ringbuffers, the resume continues and the device is restored - albeit in a non-functional state. As we cannot execute any commands

Re: [Intel-gfx] [PATCH 19/19] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 11:14:58AM -0300, Paulo Zanoni wrote: > 2014-04-02 8:27 GMT-03:00 Chris Wilson : > > On Wed, Apr 02, 2014 at 12:23:51PM +0100, Chris Wilson wrote: > >> On Wed, Apr 02, 2014 at 12:21:45PM +0100, Damien Lespiau wrote: > >> > On Tue, Apr 01, 2014 at 03:37:27PM -0300, Paulo Zano

Re: [Intel-gfx] [PATCH] Revert "drm/i915/vlv: fixup DDR freq detection per Punit spec"

2014-04-02 Thread Jesse Barnes
On Sun, 30 Mar 2014 12:30:56 +0530 deepa...@linux.intel.com wrote: > From: Deepak S > > This reverts commit f64a28a7c5ab2fc342326de9e126acf3cc0f91d6. > > As per the inputs provided by hardware team we still use DDR > Rates as 0,1=800, 2=1066, 3=1333. > With this change, Turbo freqs used on cur

Re: [Intel-gfx] [PATCH] drm/i915: fix command parser debug print format mismatches

2014-04-02 Thread Randy Dunlap
On 04/02/2014 01:24 AM, Jani Nikula wrote: > Drop the cast from the pointer diff to fix: > > drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format '%td' expects > argument of type 'ptrdiff_t', but argument 5 has type 'long unsigned int' > [-Wformat] > > While at it, use %u for u32. > > R

Re: [Intel-gfx] [PATCH 0/3] BDW runtime PM fixes

2014-04-02 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 07:39:46PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Hi > > I got a little surprised to see the BDW patches merged so fast, I thought I > was > going to have time to resend the last series with these last patches in. > > The first patch replaces a HSW-specific

Re: [Intel-gfx] [PATCH] drm/i915: Fix the computation of required fb size for pipe

2014-04-02 Thread Jesse Barnes
On Wed, 2 Apr 2014 09:10:44 +0200 Daniel Vetter wrote: > On Wed, Apr 02, 2014 at 07:58:18AM +0100, Chris Wilson wrote: > > On Thu, Mar 20, 2014 at 03:11:21PM +, Chris Wilson wrote: > > > The computation of required framebuffer size in > > > > > > commit d978ef14456a38034f6c0e94a794129501f892

Re: [Intel-gfx] [PATCH 19/19] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+

2014-04-02 Thread Paulo Zanoni
2014-04-02 8:27 GMT-03:00 Chris Wilson : > On Wed, Apr 02, 2014 at 12:23:51PM +0100, Chris Wilson wrote: >> On Wed, Apr 02, 2014 at 12:21:45PM +0100, Damien Lespiau wrote: >> > On Tue, Apr 01, 2014 at 03:37:27PM -0300, Paulo Zanoni wrote: >> > > From: Paulo Zanoni >> > > >> > > We should only enab

Re: [Intel-gfx] [linux-devel:devel-f2-cocci-201404022034 3/5] Warning(drivers/gpu/drm/drm_edid.c:1115): Excess function parameter 'adapter' description in 'drm_do_probe_ddc_edid'

2014-04-02 Thread Daniel Vetter
Hm, looks like Jani forgot to update the kerneldoc in commit 9dc4056026e0df30f6b29109e1e7a6958e7bea62 Author: Jani Nikula Date: Fri Mar 14 16:51:12 2014 +0200 drm/dp: let drivers specify the name of the I2C-over-AUX adapter The other stuff is kinda old or just kerneldoc being confused. Ja

Re: [Intel-gfx] 3.14 kills i810 with xf86-video-intel

2014-04-02 Thread Daniel Vetter
On Wed, Apr 2, 2014 at 3:34 PM, Tobias Powalowski wrote: > Hi, > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b30324adaf8d2e5950a602bde63030d15a61826f > kills my i810 card with 3.14 and Xorg. > Any solution for this? This driver doesn't bind agains an i810 card at al

Re: [Intel-gfx] [PATCH 39/49] drm/i915/bdw: Swap the PPGTT PDPs, LRC style

2014-04-02 Thread Damien Lespiau
On Thu, Mar 27, 2014 at 06:00:08PM +, oscar.ma...@intel.com wrote: > +static int gen8_write_pdp_ctx(struct i915_hw_context *ctx, > +struct i915_hw_ppgtt *ppgtt) > +{ > + struct page *page; > + uint32_t *reg_state; > + > + page = i915_gem_object_get_pa

Re: [Intel-gfx] [PATCH v2] drm/i915: move power domain init earlier during system resume

2014-04-02 Thread Takashi Iwai
At Tue, 1 Apr 2014 22:26:20 +0200, Daniel Vetter wrote: > > On Tue, Apr 01, 2014 at 09:50:43PM +0300, Imre Deak wrote: > > On Tue, 2014-04-01 at 19:48 +0200, Daniel Vetter wrote: > > > On Tue, Apr 01, 2014 at 07:55:22PM +0300, Imre Deak wrote: > > > > During resume the intel hda audio driver depen

Re: [Intel-gfx] [PATCH 41/49] drm/i915/bdw: LR context switch interrupts

2014-04-02 Thread Damien Lespiau
On Wed, Apr 02, 2014 at 01:49:38PM +0200, Daniel Vetter wrote: > On Wed, Apr 02, 2014 at 12:42:11PM +0100, Damien Lespiau wrote: > > On Thu, Mar 27, 2014 at 06:00:10PM +, oscar.ma...@intel.com wrote: > > > @@ -543,6 +545,9 @@ static int init_ring_common_lrc(struct intel_engine > > > *ring) > >

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Enabling the TLB invalidate bit in GFX Mode register

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 02:34:59PM +0300, Ville Syrjälä wrote: > On Mon, Mar 24, 2014 at 11:00:04PM +0530, sourab.gu...@intel.com wrote: > > From: Akash Goel > > > > This patch Enables the bit for TLB invalidate in GFX Mode register > > for Gen7. > > > > According to bspec, When enabled this bi

Re: [Intel-gfx] [PATCH i-g-t] tests: create files that list the available tests

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 11:41:43AM +0100, Thomas Wood wrote: > Add Makefile targets to create two text files containing the list of > available single and multi-test programs. This enables the tests to be > enumerated without requiring the build system. > > Signed-off-by: Thomas Wood Yay! Now on

Re: [Intel-gfx] [PATCH 41/49] drm/i915/bdw: LR context switch interrupts

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 12:42:11PM +0100, Damien Lespiau wrote: > On Thu, Mar 27, 2014 at 06:00:10PM +, oscar.ma...@intel.com wrote: > > @@ -543,6 +545,9 @@ static int init_ring_common_lrc(struct intel_engine > > *ring) > > ringbuf->space = ringbuf->size; > > ringbuf->last_retired_head

Re: [Intel-gfx] [PATCH 41/49] drm/i915/bdw: LR context switch interrupts

2014-04-02 Thread Damien Lespiau
On Thu, Mar 27, 2014 at 06:00:10PM +, oscar.ma...@intel.com wrote: > @@ -543,6 +545,9 @@ static int init_ring_common_lrc(struct intel_engine *ring) > ringbuf->space = ringbuf->size; > ringbuf->last_retired_head = -1; > > + I915_WRITE_IMR(ring, ~(ring->irq_enable_mask | ring->i

Re: [Intel-gfx] [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering

2014-04-02 Thread Ville Syrjälä
On Wed, Apr 02, 2014 at 02:27:40PM +0300, Antti Koskipää wrote: > On 04/02/2014 02:21 PM, Ville Syrjälä wrote: > > On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote: > > > >> @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_data) > >>do_test(test_data, left - (

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Enabling the TLB invalidate bit in GFX Mode register

2014-04-02 Thread Ville Syrjälä
On Mon, Mar 24, 2014 at 11:00:04PM +0530, sourab.gu...@intel.com wrote: > From: Akash Goel > > This patch Enables the bit for TLB invalidate in GFX Mode register > for Gen7. > > According to bspec, When enabled this bit limits the invalidation > of the TLB only to batch buffer boundaries, to pi

Re: [Intel-gfx] [PATCH 19/19] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 12:23:51PM +0100, Chris Wilson wrote: > On Wed, Apr 02, 2014 at 12:21:45PM +0100, Damien Lespiau wrote: > > On Tue, Apr 01, 2014 at 03:37:27PM -0300, Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > > > We should only enable interrupts at postinstall. > > > > > > And

Re: [Intel-gfx] [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering

2014-04-02 Thread Antti Koskipää
On 04/02/2014 02:21 PM, Ville Syrjälä wrote: > On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote: > >> @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_data) >> do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top >> , bottom

Re: [Intel-gfx] [PATCH 19/19] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 12:21:45PM +0100, Damien Lespiau wrote: > On Tue, Apr 01, 2014 at 03:37:27PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > We should only enable interrupts at postinstall. > > > > And now on ILK/SNB/IVB/HSW the irq_preinstall and irq_postinstall > > functions

Re: [Intel-gfx] [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering

2014-04-02 Thread Ville Syrjälä
On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote: > @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_data) > do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top > , bottom ); > do_test(test_data, left

Re: [Intel-gfx] [PATCH 19/19] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+

2014-04-02 Thread Damien Lespiau
On Tue, Apr 01, 2014 at 03:37:27PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > We should only enable interrupts at postinstall. > > And now on ILK/SNB/IVB/HSW the irq_preinstall and irq_postinstall > functions leave the hardware in the same state. > > Signed-off-by: Paulo Zanoni Ortho

[Intel-gfx] [PATCH i-g-t 3/7] kms_cursor_crc: Use a function pointer to call test

2014-04-02 Thread Antti Koskipaa
More tests are coming, and this allows us to not repeat the boilerplate code in run_test() for each subtest. Signed-off-by: Antti Koskipaa --- tests/kms_cursor_crc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc

[Intel-gfx] [PATCH i-g-t 1/7] kms_cursor_crc: Remove some test cases and change cursor to color

2014-04-02 Thread Antti Koskipaa
Currently this test is quite useless, since it only checks for valid CRCs when the correct output from a test is a completely black screen (invisible or visible but black cursor, or cursor is offscreen) and disables the check when anything visible is onscreen. This patch changes the cursor to a c

[Intel-gfx] [PATCH i-g-t 0/7] kms_cursor_crc enhancements

2014-04-02 Thread Antti Koskipaa
This patch series enhances the cursor test to actually be useful. The old "black transparent cursor on black background" tests are replaced with a visible cursor and the framework is changed to be more flexible and extendable. This way cursor rotation tests can be added with ease in the future. A

[Intel-gfx] [PATCH i-g-t 7/7] kms_cursor_crc: Add random cursor placement test

2014-04-02 Thread Antti Koskipaa
Signed-off-by: Antti Koskipaa --- tests/kms_cursor_crc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 1e1d348..d461d72 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -208,6 +208,18 @@ static void tes

[Intel-gfx] [PATCH i-g-t 4/7] kms_cursor_crc: Separate onscreen and offscreen tests

2014-04-02 Thread Antti Koskipaa
Also remove onscreen boolean from parameter list. All test-related data should be put into test_data from now. Signed-off-by: Antti Koskipaa --- tests/kms_cursor_crc.c | 99 +- 1 file changed, 50 insertions(+), 49 deletions(-) diff --git a/tests/k

[Intel-gfx] [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering

2014-04-02 Thread Antti Koskipaa
This patch first render the cursor with hardware rendering and then with software, acquiring the CRC in both cases so they can be properly compared. Say goodbye to crc_must_match variable. Signed-off-by: Antti Koskipaa --- tests/kms_cursor_crc.c | 27 +-- 1 file changed,

[Intel-gfx] [PATCH i-g-t 6/7] kms_cursor_crc: Add moving cursor test

2014-04-02 Thread Antti Koskipaa
Signed-off-by: Antti Koskipaa --- tests/kms_cursor_crc.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 021d58a..1e1d348 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -194,6 +194,20 @@ static void t

[Intel-gfx] [PATCH i-g-t 2/7] kms_cursor_crc: Move cursor enable and disable calls where they belong

2014-04-02 Thread Antti Koskipaa
We can't have the hw cursor enabled during software render tests. Signed-off-by: Antti Koskipaa --- tests/kms_cursor_crc.c | 54 -- 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c inde

[Intel-gfx] [PATCH i-g-t] tests: create files that list the available tests

2014-04-02 Thread Thomas Wood
Add Makefile targets to create two text files containing the list of available single and multi-test programs. This enables the tests to be enumerated without requiring the build system. Signed-off-by: Thomas Wood --- tests/.gitignore | 2 ++ tests/Makefile.am | 14 +- 2 files chan

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Track OACONTROL register enable/disable during parsing

2014-04-02 Thread Jani Nikula
On Fri, 28 Mar 2014, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > There is some thought that the data from the performance counters enabled > via OACONTROL should only be available to the process that enabled counting. > To limit snooping, require that any batch buffer which sets OACO

Re: [Intel-gfx] [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 12:11:37PM +0300, Jani Nikula wrote: > On Thu, 27 Mar 2014, bradley.d.vol...@intel.com wrote: > > From: Brad Volkin > > > > As suggested during review, this makes it much more obvious > > when the tables are not sorted. > > Let's look at the optimizations later. > > Revie

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Refactor cmd parser checks into a function

2014-04-02 Thread Jani Nikula
On Thu, 27 Mar 2014, Kenneth Graunke wrote: > On 03/27/2014 11:43 AM, bradley.d.vol...@intel.com wrote: >> From: Brad Volkin >> >> This brings the code a little more in line with kernel coding style. >> >> Signed-off-by: Brad Volkin >> --- >> drivers/gpu/drm/i915/i915_cmd_parser.c | 136 >> +

Re: [Intel-gfx] [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted

2014-04-02 Thread Jani Nikula
On Thu, 27 Mar 2014, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > As suggested during review, this makes it much more obvious > when the tables are not sorted. Let's look at the optimizations later. Reviewed-by: Jani Nikula > > Cc: Jani Nikula > Signed-off-by: Brad Volkin > ---

[Intel-gfx] [PATCH] drm/i915: fix command parser debug print format mismatches

2014-04-02 Thread Jani Nikula
Drop the cast from the pointer diff to fix: drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format '%td' expects argument of type 'ptrdiff_t', but argument 5 has type 'long unsigned int' [-Wformat] While at it, use %u for u32. Reported-by: Randy Dunlap Signed-off-by: Jani Nikula --- R

Re: [Intel-gfx] [PATCH 1/3] drm/i915: only check for irqs_disabled when disabling LCPLL

2014-04-02 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 07:39:47PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Because if we keep the current code, we'll get tons of WARNs on > Broadwell, since the code is Haswell-specific. > > We could have also added a Broadwell-specific code there, but it's not > really needed since

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Allow i915_pc8_status debug info on BDW

2014-04-02 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 10:04:15PM -0700, Ben Widawsky wrote: > On Tue, Apr 01, 2014 at 07:39:48PM -0300, Paulo Zanoni wrote: > > From: Zhenyu Wang > > > > Signed-off-by: Zhenyu Wang > > Reviewed-by: Ben Widawsky Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engin

Re: [Intel-gfx] [PATCH 3/3] drm/i915: fix infinite loop at gen6_update_ring_freq

2014-04-02 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 07:39:49PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > If I boot my Broadwell machine to X on a system with Mesa Gallium > llvmpipe instead of i965, then kill X and try to run pm_pc8.c, when we > disable PC8 and call gen6_update_ring_freq(), we will get stuck on an

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Expand FADD to 64bit

2014-04-02 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 04:31:07PM -0700, Ben Widawsky wrote: > For error state, like the recent modification to ACTHD, FADD also gets > an upper dword. This is useful for debug to make sure the fetch address > and head are similar. > > Signed-off-by: Ben Widawsky Queued for -next, thanks for th

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 01:35:22AM +0300, Imre Deak wrote: > On Wed, 2014-04-02 at 00:07 +0200, Daniel Vetter wrote: > > On Wed, Apr 02, 2014 at 12:42:50AM +0300, Imre Deak wrote: > > > On Wed, 2014-04-02 at 00:36 +0300, Imre Deak wrote: > > > > On Tue, 2014-04-01 at 18:04 -0300, Paulo Zanoni wrote

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Implement WaProgramMiArbOnOffAroundMiSetContext:bdw

2014-04-02 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 09:55:04PM -0700, Ben Widawsky wrote: > On Mon, Mar 31, 2014 at 06:17:18PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > BSpec seems to tell us we need the MI_ARB_ON_OFF w/a around > > MI_SET_CONTEXT on gen8. > > > > Signed-off-by: Ville Syrj

Re: [Intel-gfx] [PATCH] drm/i915: Fix the computation of required fb size for pipe

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 07:58:18AM +0100, Chris Wilson wrote: > On Thu, Mar 20, 2014 at 03:11:21PM +, Chris Wilson wrote: > > The computation of required framebuffer size in > > > > commit d978ef14456a38034f6c0e94a794129501f89200 > > Author: Jesse Barnes > > Date: Fri Mar 7 08:57:51 2014 -0